From patchwork Sat Aug 13 12:15:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anton Kochkov X-Patchwork-Id: 1666054 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=proton.me header.i=@proton.me header.a=rsa-sha256 header.s=k5kerzt4dnaormvktcrgzhgkru.protonmail header.b=a4RPBR16; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4M4fhG1p38z9sGQ for ; Sat, 13 Aug 2022 22:18:04 +1000 (AEST) Received: from localhost ([::1]:38834 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oMq5Y-0004xG-TU for incoming@patchwork.ozlabs.org; Sat, 13 Aug 2022 08:18:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52388) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oMq3Y-0004Hp-6h for qemu-devel@nongnu.org; Sat, 13 Aug 2022 08:15:56 -0400 Received: from mail-4316.protonmail.ch ([185.70.43.16]:29917) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oMq3U-0001Q8-Bz for qemu-devel@nongnu.org; Sat, 13 Aug 2022 08:15:55 -0400 Date: Sat, 13 Aug 2022 12:15:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=k5kerzt4dnaormvktcrgzhgkru.protonmail; t=1660392928; x=1660652128; bh=uVTMk+ZlNmRY9pdJknlwgHt1JlGkBCgdXXLcfD/noXM=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:Feedback-ID:From:To: Cc:Date:Subject:Reply-To:Feedback-ID:Message-ID; b=a4RPBR16wGxVKzA4B1JuiNcKDE4OBuFMJh8YOB5MX3Ooz7CjA+deZRurJPnkfrxPp OpYI+LtCFpMO9ooeUwLvAR4wAmI1c61mvWJtBWHLi4n+gTT/3F+6f2AJ9AVfd/ufRH HQ+KXIFny1/HiVmMk/E1I6MkphJyJyLJDyNAaUlmtrHZM5ErInhMRmx6GZpsJvEfIx m3Kxmh1lMbY9sBbKIW1NlzfWkIukUbevjVdW6TL17A+YKWrEd3kbea56JFTCyHOORm Ho9S6iBvwQN8PexO0cAYEnOBjXLS0ngNITdijBvW0J6AycwLP+gIzXarVQn+B97iYk eNtVbgNddGFNQ== To: qemu-devel@nongnu.org From: Anton Kochkov Cc: Anton Kochkov Subject: [PATCH] meson: be strict for boolean options Message-ID: <20220813121400.1995447-1-anton.kochkov@proton.me> Feedback-ID: 53490844:user:proton MIME-Version: 1.0 Received-SPF: pass client-ip=185.70.43.16; envelope-from=anton.kochkov@proton.me; helo=mail-4316.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Anton Kochkov Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" While Meson buildsystem accepts the 'false' as a value for boolean options, it's not covered by the specification and in general invalid. Some alternative Meson implementations, like Muon, do not accept 'false' or 'true' as a valid value for the boolean options. See https://mesonbuild.com/Build-options.html Signed-off-by: Anton Kochkov --- meson_options.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.37.1 diff --git a/meson_options.txt b/meson_options.txt index e58e158396..63f0725174 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -82,9 +82,9 @@ option('tcg', type: 'feature', value: 'enabled', description: 'TCG support') option('tcg_interpreter', type: 'boolean', value: false, description: 'TCG with bytecode interpreter (slow)') -option('cfi', type: 'boolean', value: 'false', +option('cfi', type: 'boolean', value: false, description: 'Control-Flow Integrity (CFI)') -option('cfi_debug', type: 'boolean', value: 'false', +option('cfi_debug', type: 'boolean', value: false, description: 'Verbose errors in case of CFI violation') option('multiprocess', type: 'feature', value: 'auto', description: 'Out of process device emulation support')