From patchwork Thu Mar 1 17:37:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Avery X-Patchwork-Id: 879962 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-tegra-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="D5OZcSG8"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zsfly3Qrqz9s2S for ; Fri, 2 Mar 2018 04:38:06 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1032900AbeCARiE (ORCPT ); Thu, 1 Mar 2018 12:38:04 -0500 Received: from mail-qt0-f193.google.com ([209.85.216.193]:44785 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1033490AbeCARiB (ORCPT ); Thu, 1 Mar 2018 12:38:01 -0500 Received: by mail-qt0-f193.google.com with SMTP id g60so8540504qtd.11 for ; Thu, 01 Mar 2018 09:38:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=/DR3XKxCElr+30tS2XKLLH6TZUb4NCKUXvFiEO9Fzrc=; b=D5OZcSG8IM5WezuqhJN2sCQf0hPwwDPAr8x35S8JXT+1SJyBe7kV8vS9r6sYXzkIp1 uFQbaEa+WUAzsOQaCAfsle407D8z3Emr46WVObpL6qlWNtaKVwgZ2Sq+uF1QQdVKQCxE HDriN7aF637Ac5H3k6s5SxufU2RqD3X7FBM6s7ZAjKxEj5BjugsiK0YWMqRSdh3dI77+ s6yZcKug6htm9+KgSYUm1oip+w07w90H1foF1Xbe63XARD4nxc6ak9+go7RWoJiH6qMA hxvYhiZl+vNmWixECWNdfQf0fEZO0lirjvALjOU6ZV2Q76NQ7ur5jApfv++GbOBpcp4f CQrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=/DR3XKxCElr+30tS2XKLLH6TZUb4NCKUXvFiEO9Fzrc=; b=tz1gmFiBVgOxLytRwNYpHC2J3oeRvz+8KRqQBM4KxCfB2mXejwWd6gE7k9/jpQK+MQ Tng7KKU64JYxh3b0g1lkhPMkZcccVFKxReZMxx6yN7dyETVzsT6UclvWTSMBYP+N2NTM doJOiOt44u+SrkAbMnxWxGlwnVgUSFp1m7S9ftHO+MEEWJyl1iKY+6qEokh5ufKGKoQG LyLig8j13DRuF6dEajVEdroJQeuqd1sz2qQ1rQzZWVnBzxKJPS7OZ59rdOxUYY0txYGD d46N1DCesFVB84N35ZRNfEJkz8Q+4q1jxS6ysOMocCxq+TLfYTYQ8mHCT5f4snWiPRGv LcjA== X-Gm-Message-State: AElRT7EZJWQEe8efMWu1F6/4ZU7/ClGcXDBsDUcKNFw3nQ5P5lIqoAPL bEn/+VRkluph3cUtxpEwoY3pfQ== X-Google-Smtp-Source: AG47ELstNWcowFzt8xcgp6c+3S+6Nz3Lv1TTzcAgaa4/G9gsSOu33EL1ZDN1lU6u2znipNBBAKLrkw== X-Received: by 10.200.35.120 with SMTP id b53mr4075764qtb.262.1519925879821; Thu, 01 Mar 2018 09:37:59 -0800 (PST) Received: from debian ([149.125.59.163]) by smtp.gmail.com with ESMTPSA id b125sm2955678qkc.47.2018.03.01.09.37.58 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 01 Mar 2018 09:37:58 -0800 (PST) Date: Thu, 1 Mar 2018 12:37:57 -0500 From: Thomas Avery To: marvin24@gmx.de Cc: gregkh@linuxfoundation.org, linux-tegra@vger.kernel.org Subject: [PATCH] staging: nvec: add error checking to nvec_event Message-ID: <20180301172613.wp5j6wytp2docnpf@debian> MIME-Version: 1.0 Content-Disposition: inline User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org This patch adds error checking to the nvec_power_poll function, which allows for easier debugging if the driver has issues. Signed-off-by: Thomas Avery --- drivers/staging/nvec/nvec_power.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/staging/nvec/nvec_power.c b/drivers/staging/nvec/nvec_power.c index 0e861c4bfcbf..c82679ae0563 100644 --- a/drivers/staging/nvec/nvec_power.c +++ b/drivers/staging/nvec/nvec_power.c @@ -347,6 +347,7 @@ static int const bat_iter[] = { static void nvec_power_poll(struct work_struct *work) { + int err; char buf[] = { NVEC_SYS, GET_SYSTEM_STATUS }; struct nvec_power *power = container_of(work, struct nvec_power, poller.work); @@ -355,7 +356,10 @@ static void nvec_power_poll(struct work_struct *work) counter = 0; /* AC status via sys req */ - nvec_write_async(power->nvec, buf, 2); + err = nvec_write_async(power->nvec, buf, 2); + if (err != 0) + return err; + msleep(100); /*