From patchwork Thu Jul 28 19:40:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ayoub Zaki X-Patchwork-Id: 1661821 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20210112 header.b=MTfSP+B/; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2a00:1450:4864:20::238; helo=mail-lj1-x238.google.com; envelope-from=swupdate+bncbdbktzhrzujrbt6mrolqmgqeyfwr4qq@googlegroups.com; receiver=) Received: from mail-lj1-x238.google.com (mail-lj1-x238.google.com [IPv6:2a00:1450:4864:20::238]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4Lv1Gs4qpCz9sGv for ; Fri, 29 Jul 2022 05:41:09 +1000 (AEST) Received: by mail-lj1-x238.google.com with SMTP id o16-20020a2e9450000000b0025e182ca7e1sf542254ljh.4 for ; Thu, 28 Jul 2022 12:41:09 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1659037264; cv=pass; d=google.com; s=arc-20160816; b=GM+hTZ6fdjWaPeESNjhRzemYNOEEthHy2SicJ/BzoxiUlpolEHSCo8Wr8lfvMLxKLF kpsCQ0vrNiQBzrV8oM+RLtze7iC9bDjpmIq/Zb5HDAyyDkwqip47Luaf0r0AzglUlWNA 6//jPFaPEjDOIjqIKy9Jk0vtFU+Sa4jnLbBzkdeQxVgT1pv4mUKKtZzQdgMHUCdUskbA Xh7+pORKqrXA/QoZ9s/GWX+I6KBae+RSlDQLs7PItUzmiFeMd2+URa3FtxOHLE4RPfzx 2XBO21HRkTtDwSoeQNf9n8Y2dxinluY6X8JWitVFm9d/YL0hoyG6vw2WH0/NWx4lL2lm ROiQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:message-id:date :subject:cc:to:from:sender:dkim-signature; bh=Zijoc3kWML4XGYhR0KUr7JjCj3rg1dVzJmDvR8VjmtU=; b=Mt7xbMIM/ijNJPypl+LHpNj5HVRQDjRfObJ7n/v0wu8PBzwL9PMKBwddQKjnmwgwsW Gw50izZP4mXpxLLUDTGpdBkze5GlVujzyOB4ygBqVVOn5/W7v/1QBncDX3pTSvYB0MVz jxu0Ml8oDUHVMTFIwUNa+Q51cA5+PTOz6RfOA56u07FlDgSYcLyQ5CjUFNN5thRkwBgz aljnxGkeQ/+FWC2CxnVYJJ2PhflbucX8spQfpF8O5WWWQrFdB/GE/+6RRlKCj0ir22Xv /XSldrORdbUJg+iwaTDqP4HTQWsIJzdctcegL9koq+Y/HBPZHuwGJMLBCryCWjy42rdQ omRQ== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@embexus.com header.s=rsa1 header.b=u10lOdVF; dkim=neutral (no key) header.i=@embexus.com; spf=neutral (google.com: 46.30.212.12 is neither permitted nor denied by best guess record for domain of ayoub.zaki@embexus.com) smtp.mailfrom=ayoub.zaki@embexus.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:mime-version :x-original-sender:x-original-authentication-results:precedence :mailing-list:list-id:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=Zijoc3kWML4XGYhR0KUr7JjCj3rg1dVzJmDvR8VjmtU=; b=MTfSP+B/M2RUStVp7muUXOlW/inzZHmBX/0DHe9/3UAY6tm6jRVsWG69EUNcAEaqQt qdW/QP51jH6Sv1nmSDgZikf2S+lPRaQADxgOlR3Vw8SjP3kFeSxxrX/4+6e6Jqm3m/rv 8QlpS3hbgKyFYmAhFiMEroL0lreDAUdPA+x9r3zoBFzhievKcH9VSG/Bhl8u+gIp8tVY FLegBr0yFNk4UlBykE9F0Rqfg9QrRBmpnUC3lqOMBW4MOo3hilcBtducQv0v4Yme5HNH HF96rXqrZQj7ZHchliZQIXs2voa4k2LT6T/N0yM9M76mQ5NHx1qc3DIcAqgo07zPy6JU iOEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=sender:x-gm-message-state:from:to:cc:subject:date:message-id :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:x-spam-checked-in-group:list-post :list-help:list-archive:list-subscribe:list-unsubscribe; bh=Zijoc3kWML4XGYhR0KUr7JjCj3rg1dVzJmDvR8VjmtU=; b=lWDCGvEsVoRtZWOAt3s8onuuv8ooa272gHL/5h21dhSH4Hg+owsiV6QnhvB4qvQJbe pd30kNvP9dnTaGPpt1X3aaXvoJ8aoMSSkQ3zw/oOcqAMjrVVjd9UDF+qGq/KZBKqpSSm YGFPcxKwY+U/D7FihI7wnNmV1ewP+565/gae8ouwYUWpH1+FTOQly9rhYZJ3P52xbiA7 MM9ZgQSmOTZO6lO1uX5747QbmofQnwkKGu9FJYbyhoNluUw2hHKVI77kdl4kzhPeEnJw c6uKngWayuHn8Pz1KQu2UqRn5sOCnGukwhR3onEO5/MlM3ZGF+iIjzkz5WHtTQzxUbBZ Q92Q== Sender: swupdate@googlegroups.com X-Gm-Message-State: AJIora8WzshZn2JvM5PzCL/wbUxOxi7fwbnze49bBBt3xhilpNlw+VES NmNl1JRNcEVrQiuuwzfu2uE= X-Google-Smtp-Source: AGRyM1sbzPGj7etoP5lNk5FykP9oiNRMF3a3PEE9ZEfGQICMdEZOf1mH2SxIc9KYQ/9aXcMFDTAdWg== X-Received: by 2002:ac2:4f0a:0:b0:48a:839c:2fe with SMTP id k10-20020ac24f0a000000b0048a839c02femr128024lfr.40.1659037263837; Thu, 28 Jul 2022 12:41:03 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com Received: by 2002:a05:6512:3695:b0:48a:833c:c687 with SMTP id d21-20020a056512369500b0048a833cc687ls627335lfs.0.-pod-prod-gmail; Thu, 28 Jul 2022 12:41:02 -0700 (PDT) X-Received: by 2002:a19:6408:0:b0:48a:139e:67b7 with SMTP id y8-20020a196408000000b0048a139e67b7mr114523lfb.203.1659037262175; Thu, 28 Jul 2022 12:41:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659037262; cv=none; d=google.com; s=arc-20160816; b=pMRHJH/uJDFU9KSa75GPxxNoQoaBe/VpYwpYVuibDX2z08XlFx95NX1IuxizTfL8SD m/QQcxNbjP6bGjUkJLR+mf03kd7MoH2XlWZmPVusua8RyHAYJ9cPDu0fgHvDKqldc87N +PED6cw9v/nQukSC32KsoP73MH1bA/QllMC5VcQ2tchv4IeZBcKJrV7QNd1ktr+tJc2E DqEwlXX67flBrXHKUAcsAAnQ3avCXV0iM/0PerPbV6oO5HJcPLDvp7VvpmavquPZeiVd kngnAa+7k0oHbTRtEBIUrg4lA2gRHUBeKrWsQ4pb9hYvoHZrIRVEpeyFr9uBqisRA5xS cbAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature:dkim-signature; bh=lVCv7SuM2o+caLWD/7I+2UrvKzZlT4xsk00p7MxxAg4=; b=IhGIdpffvFbFe6M1ZloQ0utGHvfZ/R5bq6C6Hz0hYs3KyO1wlK2Dekv98WXbhpfZBz Uyw18byzSVkjkoL+OESBn+/Ofez/b8e7TcxWCh2GW5wCOTbmKQJpIsobhj8KakWz8JMS RYOghj13cQgSg1QABvG2OPYqf4zgJbc53piEEBfU2dUizi7mMv7h1JXmefBB6rcHXRIo Hdtizjv0CVGSH04X6FCXqow3GUs1an2vPoUbfSpolaWCmmWzfOai0sTwpUJvypMIHS3c /piXrpc0bAxNCxN9G9lC/Q44R78XpLJRoCe8Solkv7vPB/1e/M+6+l3WjDG2RxoP+pPl hTBw== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@embexus.com header.s=rsa1 header.b=u10lOdVF; dkim=neutral (no key) header.i=@embexus.com; spf=neutral (google.com: 46.30.212.12 is neither permitted nor denied by best guess record for domain of ayoub.zaki@embexus.com) smtp.mailfrom=ayoub.zaki@embexus.com Received: from mailrelay3-3.pub.mailoutpod1-cph3.one.com (mailrelay3-3.pub.mailoutpod1-cph3.one.com. [46.30.212.12]) by gmr-mx.google.com with ESMTPS id k15-20020a2eb74f000000b0025e2b5ab5ffsi62609ljo.2.2022.07.28.12.41.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jul 2022 12:41:02 -0700 (PDT) Received-SPF: neutral (google.com: 46.30.212.12 is neither permitted nor denied by best guess record for domain of ayoub.zaki@embexus.com) client-ip=46.30.212.12; X-HalOne-Cookie: 34254fd5d93d3c242a0ac246307119d981fec5a3 X-HalOne-ID: 34aa1fbb-0ead-11ed-be80-d0431ea8bb03 Received: from xps13.gast.local (unknown [31.184.197.6]) by mailrelay3.pub.mailoutpod1-cph3.one.com (Halon) with ESMTPSA id 34aa1fbb-0ead-11ed-be80-d0431ea8bb03; Thu, 28 Jul 2022 19:41:01 +0000 (UTC) From: Ayoub Zaki To: swupdate@googlegroups.com Cc: Ayoub Zaki Subject: [swupdate] [PATCH V3] replace system("reboot") calls by native glibc call reboot() Date: Thu, 28 Jul 2022 21:40:58 +0200 Message-Id: <20220728194058.9622-1-ayoub.zaki@embexus.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Original-Sender: ayoub.zaki@embexus.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@embexus.com header.s=rsa1 header.b=u10lOdVF; dkim=neutral (no key) header.i=@embexus.com; spf=neutral (google.com: 46.30.212.12 is neither permitted nor denied by best guess record for domain of ayoub.zaki@embexus.com) smtp.mailfrom=ayoub.zaki@embexus.com Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Signed-off-by: Ayoub Zaki --- tools/swupdate-ipc.c | 6 ++++-- tools/swupdate-progress.c | 5 ++++- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/tools/swupdate-ipc.c b/tools/swupdate-ipc.c index ce8ec10..aa0afe5 100644 --- a/tools/swupdate-ipc.c +++ b/tools/swupdate-ipc.c @@ -23,6 +23,8 @@ #include #include #include +#include +#include #include #include #include @@ -571,8 +573,8 @@ static int sysrestart(cmd_t __attribute__((__unused__)) *cmd, int argc, char *a fprintf(stdout, "Ready to reboot !\n"); restart_system(ndevs); sleep(5); - - if (system("reboot") < 0) { /* It should never happen */ + sync(); + if (reboot(LINUX_REBOOT_CMD_RESTART) < 0) { /* It should never happen */ fprintf(stdout, "Please reset the board.\n"); } break; diff --git a/tools/swupdate-progress.c b/tools/swupdate-progress.c index 8910b5a..82a7881 100644 --- a/tools/swupdate-progress.c +++ b/tools/swupdate-progress.c @@ -18,6 +18,8 @@ #include #include #include +#include +#include #include #include #include @@ -380,7 +382,8 @@ int main(int argc, char **argv) psplash_ok = 0; if ((msg.status == SUCCESS) && (msg.cur_step > 0) && opt_r) { sleep(5); - if (system("reboot") < 0) { /* It should never happen */ + sync(); + if (reboot(LINUX_REBOOT_CMD_RESTART) < 0) { /* It should never happen */ fprintf(stdout, "Please reset the board.\n"); } }