From patchwork Tue Jul 26 10:39:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Deepti Panchal X-Patchwork-Id: 1660750 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=q35eUasX; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256 header.s=selector2 header.b=GbDtJtVF; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4LsYS54nF1z9s1l for ; Tue, 26 Jul 2022 20:44:05 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9JYoLr5u/zOjYABi/VjqWJjKOofV2MO3UBk11hIxWGE=; b=q35eUasXxLty/v V5rvAArYovoH6RD/usBFMAUHN6Vj8CUuTX/KUYFF/Xt/pnaDECUTjXr2WJzSMrNsGwU8/jnWVP0sw hA/RDSY1nY47n0mGZ1bkEF+/FFTT6v+6IEqYOw5fG3H40Mvqh75H9/aAQ1FHI+P3Z/flNCesnpWzt Nd4DNGL+E+DrAMufETsbVtTu5Aisd3vxqJi9A00PF8ZG2jrXM7MjmT69gD41RNScrjN0dUAbgrgpO EGNEJ43USEramoFPt7ZWF6BfOmgT3LjPs0vUn3xRBbUdkDjbC0wU0UbLiTnHUckRLzq/S3Sh3Hefi 1kWjaMBCEhcAauKnH+Sg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGI1W-00EAr2-SG; Tue, 26 Jul 2022 10:42:48 +0000 Received: from mail-am6eur05on2066.outbound.protection.outlook.com ([40.107.22.66] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGHxz-00E3z0-3O for hostap@lists.infradead.org; Tue, 26 Jul 2022 10:39:10 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RT5Ud50YxOBF55Hd41a6oFmPcs7SWaTKPpDnFgkC8rcVYyTJP7ViJdcEH0XIvzpE6eCGoUyYVzT3dkndkwJldSPuDMXOwZ5B/QHpFh80V+JS2iCNrLtoIuVa5pN7lb+y1hnNSfjJZoFMcZR+EPjqZK3FObbOzlSG8LEFglpzGRbUqjAULqC9PqjfG04PCw7CYahjRcqj4pEUPPKvBZKQ9tr4fiS0SoxRMP3RYS25P9UlTd5P62C1IanE6cuegkhIarW+OnwoaBgK4MgyXIljAZdXtwoRQ/HvogJ1uOotJA6FtlyEPh4f5B0Yip/LIQyEBEXYRqP4U3cY7IMvFmahMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9DHItiDu4WuZvA2xI2Rm9X6cvhx3ZBo4QztA6IQpG8U=; b=DycpdffbT4vKbj9c8anrSe3TXoJ2VpftIl3UTWR7i3zGdoiUbI/lFAjop7y7dYOeJrni/racrNidhBp67Am08u7/3lMQJDxlfDs7TZetUFvEkMB6SNj6AgGBfazOEfdzjJDlTqKJkBwUmpadRbAbdGcN0evhrBdDF86j3HZ0d9fMlxh19hBv1MXvI6nseRCqq7/6CIoeT+PD4SLSm5KHE/vmGi8tcEdJ4IxkfP8l1OBXfaPtSB+4HjWe+NFcQyPrN4AQ6ZZn3d1p3MCaZml1d8mecA1r4kDL/ZcP1VpTe77KlHhgOPZZAo9T2ZBvE8K8xojznZ56sfuxpqNBczFNjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9DHItiDu4WuZvA2xI2Rm9X6cvhx3ZBo4QztA6IQpG8U=; b=GbDtJtVFRRaxoPjFs50ZtA9I/dZWs/pWt5Zhlkc3rDTTZDHoxE6GfC7N4hTvf7WK0jhUBrfw571ZWmsOyQ+qcxxgSpAerFr4NeYDPu2Dft/pQTqbtj5hBgsQIQB+S3hHfy9WFwvbzowDVxmi6WNxhcJP6uqWAfZpL1C8s/yzjeI= Received: from VI1PR04MB5917.eurprd04.prod.outlook.com (2603:10a6:803:ec::29) by AS8PR04MB9010.eurprd04.prod.outlook.com (2603:10a6:20b:341::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Tue, 26 Jul 2022 10:39:03 +0000 Received: from VI1PR04MB5917.eurprd04.prod.outlook.com ([fe80::bc95:332:31a5:e837]) by VI1PR04MB5917.eurprd04.prod.outlook.com ([fe80::bc95:332:31a5:e837%6]) with mapi id 15.20.5458.018; Tue, 26 Jul 2022 10:39:03 +0000 From: Deepti Panchal To: "hostap@lists.infradead.org" Subject: [PATCH] Issue: Non-HE capable interface advertising HE Thread-Topic: [PATCH] Issue: Non-HE capable interface advertising HE Thread-Index: Adig20C31qhTxqqvQ0aEcSTEf3CwGgAAJRwQ Date: Tue, 26 Jul 2022 10:39:03 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6cd5dcdc-a02e-413a-d90a-08da6ef30ef9 x-ms-traffictypediagnostic: AS8PR04MB9010:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: r8kc4+x3oxAqAyAEA7hMpbVvNc8sDfy6ACub+D1dTx2xBUBKKmp971zw7QAqurpT7xQ1mNGX4d1K0hwnIep89/T00ZMWl/yPshkqyUDD3N+k7qkykoeFer8pUtJ7OCVV7KU0uDLDWMGdooJF+s/2LTo1O1cwS/G7NPmmgreqMgcEACuFWEoOOjk4WN+EJ3pyQKP4wDAvRApONOqmtCCXHIgxkr0qWix+Mx3F6IMUM14rZPDpoYpHRKjHqVklYBC0Pfd0hzpj3eqPdnFoZlzazDBT1UK7yGej6iYCjySzbGOMyKRNZKfvGUsd8ROrZ3TJw8o/Nk4aH92LB0/URBmBLmmt/tXBxWyAfvIQNVvb5FuPBA/H1DZ2EjemuHMxHMuAeyo2104SJTgutKl+z1pgWmPjFFy8ghBztmneHf/zf8uXCHLHt+aP3ZMFxug7nKnqV5SUaxMZDC4TfJfcAPS/pz16LVqbMLpgH3/m9dcL6xymo1VTQuQmGMo0c0a/oFZnW0g/5JbVQKzKqSE8Pxx837AVpmO3/QOQiKjYLC18PFTrxg9CVNU4rQbKjL96XnqgBtV2JoFonx1Iok47b12ZXFOe30j4yCCUoftGRFzERBVsuEJHYoIrxAkQcbPXb7IlQQp0oS0ffMEXGl/N8ORAU66xK6z7/0l4hD/PB2jkEYHbbXGgAJAdFhj0uPoRG9D3JpWjkwErg7cdEA+oJ5Eaeu2VGe/zNBE7TL50xbnKfpa99dNuH/LyxhqRz1SfMYBo2hMkHrefQNnZAOfOcuSCW93LRuajgipDZyuXUu9sqRfJh8jnr+osOB1BtTski2ce x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5917.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(396003)(366004)(346002)(136003)(39860400002)(52536014)(5660300002)(64756008)(8676002)(55016003)(66476007)(76116006)(66946007)(66556008)(8936002)(66446008)(2906002)(44832011)(122000001)(86362001)(83380400001)(38100700002)(33656002)(38070700005)(478600001)(71200400001)(26005)(316002)(6916009)(186003)(9686003)(41300700001)(6506007)(7696005)(2940100002)(55236004)(53546011);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: 0hgWZesGsC+15OouZtS2ll8peMDE5CWAc8AKG50NYti8aUtH75Yk2CfRWWL+G9mXnS8YSZcelRk0o/Zkmr7bDhR6kwuOpNk9Xlv1LlLuHsc2pmKJF+q7ya5Zr9ckZB8f/QLJ5liVkPI50/YKldVyh1MP8Z8qq2DhXdXUCcOPERXYvWAYn6Q1Yt997zXUpMJOw8cXu8FCkuy52/iqHLB0vKjOPTv7l77bXWGBK/66LDRvOQ5H+noUK/8xyUriQpvprQ4VTSgcv/xOQFOGp3qxe1whhCKJgwFDjyUUJ99alsA7EEq5DrptKLgIFQPTAiNHqNTmDFQQhd0uqLFbRzqeTwDZo68FSr+MaWbciZT701k6nwTIn/zmLljTbNX1qG2Du5p8fMNEUqRUX9WsAcb4VlvWgoeqrLpj4I2/VUWUNCI67ZQXRf0YJQmBrGpsuOsPBn0M6vUGRmCWRjAmhwCGY+hTs9jDD/6t7jzsNt0sjgucph1PeLx+Mslfm8YDcaNGudyCtGtseTIvq853sr7sZHSTMhnjl+9zaoBJe4szVxKpfxom/8sF0QghTUAODgMpujyi68nG9AgiqmLS/GQTQyNNqnFHk1chjAWzFbWlk/0pOytd2K6CJR0pK/raMQ7qIJFNovttB5TMD85kVfnfPvfZL6N4ejt6wTSIvr8We5WNKTZvuPO4nT3bOL3I/gi2lecPkwAS432x/lWZjSJWgA/NGsHibo1CqBH6dthL7RijYsUHQj7cp2IuW0UJqGJtBkEqeIqA+Mnqh8NfwtJCsIolTragXP8/FMiycGcY7U3b6iasvK5jUZbuKVWm6EbtTPe12e3CRnYLEsMDeRjqO7myl9dmhM9vJaofazfIK7QKO1Xkzd/3kph8qLgORdrfuTOfNwyE7MZ59wNAMRYB5aGk3ZYsS3AGWsuFpnu2IOaG5PijtHAW44s/TMzKbdbAShMVt0DIr7uk4yv3KE7WprSzv7XmyixXsyujAEDmtB5sI2/rz2RUSjhWtPZ90uSvMT0fLoi2iNIWw/+pTYJN7ND/+a51KFPQ6JtlXlb3BQC43tEOFZVaTi/yCw9YYzHJrDDjeW/4GtCg/wAVrL2WjkmWrGit9tw96EdL225ZRejYBsB20yOYSL27u24KQw3iImUsXrflokZ5yGx5ZtDp+aY9VIv4OcLYvwvi+ho+GDZPVn1vSpwXwxJB9K1ucXlqJRE5mt0jKi6P4ow8KXLExhqSBPI1ZJs2wnPpk3Ss1KhVwyp0boc5MD45STheBgK6H+Tbat2xD8/rBjz8Fn5IqwvNMnztSPf/dTKwkD2HqKphMkjYPSNnrsVPvRW4Jj6yaZGkpZBZO5+UwB32U0ewhTf+Px+lMqY2eyQ4s6Re3PXhB7AHEHv/WwHffHt5G2voWmEQfaiW+UfvrW3X6diM0jNNKCl81piBgTjIH7ieC4xiztAKmaoDsHgCWQxUxqD2AAJOgo+ygmJosfRPmlHs47MNhU0jqVMk0NF/+JaDjFs9O78pTV+l9uVUAKgM1E5RtqNNxnIlmS7RnoAs3opH6zWMAv/SEmaI/qf7q1HF9R6vT9Ipg91j1ftTaSszUsbF MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5917.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6cd5dcdc-a02e-413a-d90a-08da6ef30ef9 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jul 2022 10:39:03.3241 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QFqCp2SjnM7cGW7f+HAjTCLgUmSW8JicVZm6pIbbXU8qHhkPHE+dxmoWgCSFnZmr85mmpu1uITD+CpPsHh8leQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9010 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220726_033907_206523_0A31206F X-CRM114-Status: GOOD ( 16.51 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: This mail describes the purpose of the attached "hostapd" patch. The patch avoids issue when there is mismatch between user's 11ax config and DRV capability Behavior (without the patch): ========================== Non-HE capable interface advertising HE IEs/Capabilities in Beacon/Probe Response/Association Response frames if "ieee80211ax=1" configuration [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [40.107.22.66 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [40.107.22.66 listed in wl.mailspike.net] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org This mail describes the purpose of the attached "hostapd" patch. The patch avoids issue when there is mismatch between user's 11ax config and DRV capability Behavior (without the patch): ========================== Non-HE capable interface advertising HE IEs/Capabilities in Beacon/Probe Response/Association Response frames if "ieee80211ax=1" configuration is used Patch Description: ================ 1. The HE capability for an AP iface was read from the driver, but was not used to update the "drv_flags" for the interface 2. Change is now added to update the HE capability in the "drv_flags" of the interface 3. If the interface does not support HE capability, the "iface->conf->ieee80211ax" flag is set to 0 4. Now Beacons/Probe response/Association Response will advertise HE capabilities ONLY if the interface is HE capable Patch Verification: ================= 1. For Intel and NXP non-11ax/HE capable chip/interface, when "ieee80211ax=1" is used in the config file, NO HE IEs are added in the Beacon/Probe Response/Association Response frames 2. For NXP 11ax/HE capable chips, the HE IEs get added correctly to the required MGMT frames ==================================================================== From e19bf318ce2a27ccc03f72023b2fc7f1bf6cd496 Mon Sep 17 00:00:00 2001 From: Deepti Panchal Date: Mon, 18 Jul 2022 15:59:10 +0530 Subject: [PATCH] Issue: Non-HE capable interface advertising HE IEs/Capabilities in Beacon/Probe Response/Association Response frames if "ieee80211ax=1" configuration is used Change Description: 1. The HE capability for an AP iface was read from the driver, but was not used to update the "drv_flags" for the iface 2. Change is now added to update the HE capability in the "drv_flags" of the interface 3. If the interface does not support HE capability, the "iface->conf->ieee80211ax" flag is set to 0 4. Hence now Beacons/Probe response/Association Response will advertise HE capabilities ONLY if the interface is HE capable --- src/ap/hw_features.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) http://lists.infradead.org/mailman/listinfo/hostap diff --git a/src/ap/hw_features.c b/src/ap/hw_features.c index ed5ff41d3..87d7b52bd 100644 --- a/src/ap/hw_features.c +++ b/src/ap/hw_features.c @@ -679,7 +679,19 @@ static int ieee80211ac_supported_vht_capab(struct hostapd_iface *iface) #ifdef CONFIG_IEEE80211AX static int ieee80211ax_supported_he_capab(struct hostapd_iface *iface) { - return 1; + struct hostapd_hw_modes *mode = iface->current_mode; + struct he_capabilities *he_cap = + &(mode->he_capab[IEEE80211_MODE_AP]); + + /* Check iface HE capability, update drv_flags and HE config setting */ + if (he_cap && he_cap->he_supported) { + wpa_printf(MSG_DEBUG, "iface hw he_supported: %d", he_cap->he_supported); + iface->drv_flags |= WPA_DRIVER_FLAGS_HE_CAPABILITIES; + } else { + wpa_printf(MSG_DEBUG, "iface does not support HE capability"); + iface->conf->ieee80211ax = 0; + } + + return 1; } #endif /* CONFIG_IEEE80211AX */ _______________________________________________ Hostap mailing list Hostap@lists.infradead.org