From patchwork Wed Jul 13 10:03:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre-Marie de Rodat X-Patchwork-Id: 1655941 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=Gg5qaJkX; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4LjYDc6zJPz9s1l for ; Wed, 13 Jul 2022 20:06:24 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CF0BB3887F54 for ; Wed, 13 Jul 2022 10:06:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CF0BB3887F54 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1657706782; bh=ZZBGfnjEgjoqbU8vhCF+xtNaibTQ1QYdMi2VVM4us9g=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=Gg5qaJkXY+wjL02NZzWriASIIJyQONCPP+Jg2SdQ022tLPPtZboB+oDiatD91am+2 w1EPPaGxk/4ZnpGBNrOj+Mvq3OgnNLa947xiK/43pDfnj8tpRbhv6yFzu6rKPaRNLD GRquh0UbclbBzBzKLDG5UxYA2BgAPCaFgPyEqzK8= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by sourceware.org (Postfix) with ESMTPS id 6283B3850874 for ; Wed, 13 Jul 2022 10:03:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6283B3850874 Received: by mail-ed1-x52d.google.com with SMTP id eq6so13426288edb.6 for ; Wed, 13 Jul 2022 03:03:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=ZZBGfnjEgjoqbU8vhCF+xtNaibTQ1QYdMi2VVM4us9g=; b=77jv3zr9nBWv5EaDmflQMsASekSFkfss4HCBCAmkRxqeZZuXdgSycBshMpZ9EDdoGt PLofDNVvqBRmGTO/3imzcEzbbO5xAmOQPMx12inkAlZ14Uv1p9W8SchZzT20eOYS7apY c96/va6viv8Cn/1cHZDWCZyokLdvGN8LXR4eAuy+P1vjH4mfeMMtEMEZKsW9RYGszYR8 wLeA52GIPeBDEolrgPUnsNks/kVCLc7btRpeqIxjiEybMap0P+OIuMO/8D0q2E4tyiRi 8U5nGSbNIs76WqWVSggticWYnPtRHnGXLgIKbFYlONrPeLToyPcKOGqc/Rcj6o4b54Xx xJuQ== X-Gm-Message-State: AJIora/AC/gykbjXLegM2qyRpybV0Ljt+AdQvPpQTZLN4Xu+zIWEmJE7 3TClPvAFdmPj1fKatAeZ0D8lZUTb3Ht1jg== X-Google-Smtp-Source: AGRyM1vfOHPAF02L+8il2rZVzxvEkRC3KOnAl5ukNCYZ94Q7hMIUnqlaRt/YvawzL1/eIArRt0e07A== X-Received: by 2002:aa7:c2d1:0:b0:43a:997:c6d8 with SMTP id m17-20020aa7c2d1000000b0043a0997c6d8mr3589972edp.161.1657706583194; Wed, 13 Jul 2022 03:03:03 -0700 (PDT) Received: from adacore.com ([45.147.211.82]) by smtp.gmail.com with ESMTPSA id r24-20020a1709067fd800b006fe8b456672sm4809112ejs.3.2022.07.13.03.03.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jul 2022 03:03:02 -0700 (PDT) Date: Wed, 13 Jul 2022 10:03:02 +0000 To: gcc-patches@gcc.gnu.org Subject: [Ada] Fix internal error on comparison with access function parameter Message-ID: <20220713100302.GA994761@adacore.com> MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-13.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Pierre-Marie de Rodat via Gcc-patches From: Pierre-Marie de Rodat Reply-To: Pierre-Marie de Rodat Cc: Eric Botcazou Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" It comes from an overzealous assertion. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * gcc-interface/utils2.cc (build_binary_op) : Also accept pointer-to-function types that are not variant of each other. diff --git a/gcc/ada/gcc-interface/utils2.cc b/gcc/ada/gcc-interface/utils2.cc --- a/gcc/ada/gcc-interface/utils2.cc +++ b/gcc/ada/gcc-interface/utils2.cc @@ -1134,12 +1134,17 @@ build_binary_op (enum tree_code op_code, tree result_type, else if (POINTER_TYPE_P (left_base_type) && POINTER_TYPE_P (right_base_type)) { + tree left_ref_type = TREE_TYPE (left_base_type); + tree right_ref_type = TREE_TYPE (right_base_type); + /* Anonymous access types in Ada 2005 can point to different - members of a tagged type hierarchy. */ - gcc_assert (TYPE_MAIN_VARIANT (TREE_TYPE (left_base_type)) - == TYPE_MAIN_VARIANT (TREE_TYPE (right_base_type)) - || (TYPE_ALIGN_OK (TREE_TYPE (left_base_type)) - && TYPE_ALIGN_OK (TREE_TYPE (right_base_type)))); + members of a tagged hierarchy or different function types. */ + gcc_assert (TYPE_MAIN_VARIANT (left_ref_type) + == TYPE_MAIN_VARIANT (right_ref_type) + || (TYPE_ALIGN_OK (left_ref_type) + && TYPE_ALIGN_OK (right_ref_type)) + || (TREE_CODE (left_ref_type) == FUNCTION_TYPE + && TREE_CODE (right_ref_type) == FUNCTION_TYPE)); best_type = left_base_type; }