From patchwork Thu Jul 7 23:55:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Lance Taylor X-Patchwork-Id: 1653853 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=NKT6dFab; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4LfCwM2B4dz9s09 for ; Fri, 8 Jul 2022 09:55:45 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B9C31385020B for ; Thu, 7 Jul 2022 23:55:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B9C31385020B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1657238143; bh=T3/bE5BfrmSEu6y89rJJR8AONnxS3Dq8W3bqTUqmS8g=; h=Date:Subject:To:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=NKT6dFabe5aHR31YNbV2G/o1/KXkxjvakO76oY+lnUHV0+++yu4a3QVlmbbISssqf RB0CDyvYx7/fkhyoidgEQljSsUeSz/hd3a1fxgdF7l0SLhJF3hm+f+R/b4fQQ6Zq1T Z61qI33gaiVniKLYR6QB6BvgYsriawi76d9AXnGQ= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by sourceware.org (Postfix) with ESMTPS id 5A6953857B8F for ; Thu, 7 Jul 2022 23:55:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5A6953857B8F Received: by mail-pf1-x432.google.com with SMTP id a15so22104528pfv.13 for ; Thu, 07 Jul 2022 16:55:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=T3/bE5BfrmSEu6y89rJJR8AONnxS3Dq8W3bqTUqmS8g=; b=LurPmKWUBwVfhppW7PO1hPGNxEZrZHn1K7VJE8v9uv3Yk4IQt9Z39WYVVTT3BfN8q4 bvEh0x881jyT0nPtvyohmClufesph5/9/LnfIMfVkkcUYNnBPgJsGDGBwmLOE9FJhaZt xhAfOx8oPwbJEaPjZav2lUx3U+++MKe1V5T59O1muZb3vE03PKalC0VXnTxlx89zLk+o U56pGrn2trH6PbpvZ5v6PCAgR3OVVvaWmXl63cuKb4559RbLtM1rvdSWCvO2T/VrztsF noq1vq1IaE5pMxGOLT/AtbkqJ/a80NiAMzkwm65NqSU5nbjmD5IYqdLzYyZ4LspTtBwb vThQ== X-Gm-Message-State: AJIora+3NvlT1ca4g9siJLxX4EhMBDRyKPd1rDOSAHQ/t2FHloABtGq6 aCUf3R62jBDAi+FIiwBK7yEubw3YJc9G5Zz1LtuP/VI2F5A/Og== X-Google-Smtp-Source: AGRyM1vmw9HfikkPzX5EhZnU0Pk+oplCIu/WlH4bZgVd3yAPjDPtZvW7tRxNBwvMCDiebJ4xKatYHBBa4jkvjNbdEx0= X-Received: by 2002:a63:314a:0:b0:412:b42c:693d with SMTP id x71-20020a63314a000000b00412b42c693dmr618841pgx.20.1657238121736; Thu, 07 Jul 2022 16:55:21 -0700 (PDT) MIME-Version: 1.0 Date: Thu, 7 Jul 2022 16:55:10 -0700 Message-ID: Subject: libbacktrace patch committed: Don't exit Mach-O dyld loop on failure To: gcc-patches X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Ian Lance Taylor via Gcc-patches From: Ian Lance Taylor Reply-To: Ian Lance Taylor Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" This libbacktrace patch changes the loop over dynamic libraries on Mach-O to keep going if we fail to find the debug info for a particular library. We can still pick up debug info for other libraries even if one fails. Tested on x86_64-pc-linux-gnu which admittedly does little, but others have tested it on Mach-o. Committed to mainline. Ian * macho.c (backtrace_initialize) [HAVE_MACH_O_DYLD_H]: Don't exit loop if we can't find debug info for one shared library. d8ddf1fa098fa50929ea0a1569a8e38d80fadbaf diff --git a/libbacktrace/macho.c b/libbacktrace/macho.c index 3f40811719e..16f406507d2 100644 --- a/libbacktrace/macho.c +++ b/libbacktrace/macho.c @@ -1268,7 +1268,7 @@ backtrace_initialize (struct backtrace_state *state, const char *filename, mff = macho_nodebug; if (!macho_add (state, name, d, 0, NULL, base_address, 0, error_callback, data, &mff, &mfs)) - return 0; + continue; if (mff != macho_nodebug) macho_fileline_fn = mff;