From patchwork Tue May 10 12:22:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jian Hui Lee X-Patchwork-Id: 1629109 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=cig1u8qh; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4KyHJX2hjSz9sGJ for ; Tue, 10 May 2022 22:23:40 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1noOtp-00060m-QS; Tue, 10 May 2022 12:23:33 +0000 Received: from smtp-relay-internal-0.internal ([10.131.114.225] helo=smtp-relay-internal-0.canonical.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1noOtl-000604-Ro for kernel-team@lists.ubuntu.com; Tue, 10 May 2022 12:23:29 +0000 Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 843213F1A1 for ; Tue, 10 May 2022 12:23:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1652185409; bh=T32CCg2rLHhAdbyFt8Wz7+5jeSyhZx81O9fBwVUN4vg=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=cig1u8qhopC7Ez/gcbzaU9L0n5OUPHZ6U4DCyfAKQZC5szXrksCZgcK8lakJsW7qm +EmSKPZ4ul9QIes4JiJPc0VuVOBCO4KeiagxUFPsvNeZQlF1f3Vrr7SUDp3mS3nFLD Z75oFdiJbMFz/43w14ORrGypf1ayrq5JzZvwTWKyh7y/y459wBIsWqeCih7eDrlZ1R azjUc+p+G3BmBP3vJFJ7SkS43RHzeAyx7NSQ/pTHsrkcc2EMeve5BPsle6idKFSk7H wWKhLA2pOCDweKPq0CeV3bNjzyGhHnjiBkNwmklcEdX8wSYZLxdNm90RjW8m2/GDy/ zGuB9pt4PfVKw== Received: by mail-pj1-f72.google.com with SMTP id pt10-20020a17090b3d0a00b001dd200e709dso1214434pjb.9 for ; Tue, 10 May 2022 05:23:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=T32CCg2rLHhAdbyFt8Wz7+5jeSyhZx81O9fBwVUN4vg=; b=1iOSk9gfQK6emfao+AMIwO2xvadn+ormeXtVO9hY6ihCdYJaIbBeVUuurr4t9Jp0/3 r2AYqkHQzf8ewfh4vBP2b62tMEgzbXEYy2PIUZWfnIoV6sJxlcIIIZozKzXm2HBjp2zJ C1U7p2ecKfhXeLZFUgZgxuSCGyZbu1I1jU99l/kiagkG4uHjORRdS6CYRWQE+GgnpxMg GQGZ1X00d6c/vG62E0d3mcJn6P/Ri4ZbAHHmxeCu4E/9mMyVNr+ZrJ1NLExqWeZiTqr6 gxkl4bopbtrE79ozFuYS0Fm3fiXMQri8VEHVg32RGCfwBE6MYe0Xz3+QcB3AguJS1Jix qwJA== X-Gm-Message-State: AOAM530YJn9LJowMh18Xvxd9RG05vqdju142AXpIsqFSkpNY1MWfTZZ4 V5xUKMifaUB2ez8L0hOeSm4eqnLLYV3/2C2uEHjVCSxDTzRUmM1Eg+/C4lPhEvulMAmnQs3Y+sg ZpzWnIsZ0o2Z0UVGuncp80SPGkUEiJADS9t6eoVpaSQ== X-Received: by 2002:a65:4185:0:b0:399:4c59:e3b1 with SMTP id a5-20020a654185000000b003994c59e3b1mr16611438pgq.154.1652185408275; Tue, 10 May 2022 05:23:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyXjrb97q7YI7htw87ndzvzw9FSgp+VV2JK0lzDHbm4YJeufs/F7SY6kxQE+r55T8y54Z+g6w== X-Received: by 2002:a65:4185:0:b0:399:4c59:e3b1 with SMTP id a5-20020a654185000000b003994c59e3b1mr16611427pgq.154.1652185408000; Tue, 10 May 2022 05:23:28 -0700 (PDT) Received: from localhost.localdomain (36-230-106-94.dynamic-ip.hinet.net. [36.230.106.94]) by smtp.gmail.com with ESMTPSA id a11-20020a170902710b00b0015e8d4eb207sm1821522pll.81.2022.05.10.05.23.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 May 2022 05:23:27 -0700 (PDT) From: Jian Hui Lee To: kernel-team@lists.ubuntu.com Subject: [SRU][Jammy:linux-intel-iotg][PATCH v2 1/1] UBUNTU: SAUCE: EDAC/igen6: Add registration APIs for In-Band ECC error notification Date: Tue, 10 May 2022 20:22:43 +0800 Message-Id: <20220510122243.129426-2-jianhui.lee@canonical.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220510122243.129426-1-jianhui.lee@canonical.com> References: <20220510122243.129426-1-jianhui.lee@canonical.com> MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Qiuxu Zhuo BugLink: https://launchpad.net/bugs/1929901 The igen6_edac driver is the root to capture the In-Band ECC error event. There are some external modules which want to be notified about the In-Band ECC errors for specific error handling. So add the registration APIs for those external modules for the In-Band ECC errors. Signed-off-by: Qiuxu Zhuo Signed-off-by: Hsuan-Yu Lin Signed-off-by: Wen-chien Jesse Sung (cherry picked from commit a2d2ab315873d4c4f1db8b57f0281bad633b202f linux-intel-5.13) Signed-off-by: Jian Hui Lee --- drivers/edac/igen6_edac.c | 23 +++++++++++++++++++++++ drivers/edac/igen6_edac.h | 22 ++++++++++++++++++++++ 2 files changed, 45 insertions(+) create mode 100644 drivers/edac/igen6_edac.h diff --git a/drivers/edac/igen6_edac.c b/drivers/edac/igen6_edac.c index a07bbfd075d0..0cdb8f6745c7 100644 --- a/drivers/edac/igen6_edac.c +++ b/drivers/edac/igen6_edac.c @@ -26,6 +26,7 @@ #include "edac_mc.h" #include "edac_module.h" +#include "igen6_edac.h" #define IGEN6_REVISION "v2.5" @@ -428,6 +429,20 @@ static const struct pci_device_id igen6_pci_tbl[] = { }; MODULE_DEVICE_TABLE(pci, igen6_pci_tbl); +static BLOCKING_NOTIFIER_HEAD(ibecc_err_handler_chain); + +int ibecc_err_register_notifer(struct notifier_block *nb) +{ + return blocking_notifier_chain_register(&ibecc_err_handler_chain, nb); +} +EXPORT_SYMBOL_GPL(ibecc_err_register_notifer); + +int ibecc_err_unregister_notifer(struct notifier_block *nb) +{ + return blocking_notifier_chain_unregister(&ibecc_err_handler_chain, nb); +} +EXPORT_SYMBOL_GPL(ibecc_err_unregister_notifer); + static enum dev_type get_width(int dimm_l, u32 mad_dimm) { u32 w = dimm_l ? MAD_DIMM_CH_DLW(mad_dimm) : @@ -545,6 +560,7 @@ static void igen6_output_error(struct decoded_addr *res, enum hw_event_mc_err_type type = ecclog & ECC_ERROR_LOG_UE ? HW_EVENT_ERR_UNCORRECTED : HW_EVENT_ERR_CORRECTED; + struct ibecc_err_info e; edac_mc_handle_error(type, mci, 1, res->sys_addr >> PAGE_SHIFT, @@ -552,6 +568,13 @@ static void igen6_output_error(struct decoded_addr *res, ECC_ERROR_LOG_SYND(ecclog), res->channel_idx, res->sub_channel_idx, -1, "", ""); + + /* Notify other handlers for further IBECC error handling */ + memset(&e, 0, sizeof(e)); + e.type = type; + e.sys_addr = res->sys_addr; + e.ecc_log = ecclog; + blocking_notifier_call_chain(&ibecc_err_handler_chain, 0, &e); } static struct gen_pool *ecclog_gen_pool_create(void) diff --git a/drivers/edac/igen6_edac.h b/drivers/edac/igen6_edac.h new file mode 100644 index 000000000000..ca447593bdf8 --- /dev/null +++ b/drivers/edac/igen6_edac.h @@ -0,0 +1,22 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Registration for IBECC error notification + * Copyright (C) 2020 Intel Corporation + */ + +#ifndef _IGEN6_EDAC_H +#define _IGEN6_EDAC_H + +#include +#include + +struct ibecc_err_info { + enum hw_event_mc_err_type type; + u64 sys_addr; + u64 ecc_log; +}; + +int ibecc_err_register_notifer(struct notifier_block *nb); +int ibecc_err_unregister_notifer(struct notifier_block *nb); + +#endif /* _IGEN6_EDAC_H */