From patchwork Sun Apr 10 15:08:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 1615424 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=CDUYiuMq; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=CDUYiuMq; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=112.213.38.117; helo=lists.ozlabs.org; envelope-from=linux-aspeed-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org; receiver=) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4KbwPG2NJYz9sGG for ; Mon, 11 Apr 2022 01:09:05 +1000 (AEST) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4KbwP90b0Yz3bXq for ; Mon, 11 Apr 2022 01:09:01 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=CDUYiuMq; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=CDUYiuMq; dkim-atps=neutral X-Original-To: linux-aspeed@lists.ozlabs.org Delivered-To: linux-aspeed@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=170.10.133.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=trix@redhat.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=CDUYiuMq; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=CDUYiuMq; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4KbwP04bnCz2yJ9 for ; Mon, 11 Apr 2022 01:08:49 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649603324; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0fBEBq6RqOmAXN69Pg2n48BAzr3YZ3kkOQrunZvVvGw=; b=CDUYiuMqXbMeJHIMCo1JJZ2GvFbAZyQyFykaMKQz+jZox+z0lU9ltlVlbHyxSAgUu+AuAs S62NIFv78fzjwOp7IZCQUw/13cAebAeKy6QusJlYgoYU/QYdQ+bZpRHBM6FaSmyzNNwN3B AcWyVZGuznLqFbi/KXEVCLbV5UzCs4U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649603324; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0fBEBq6RqOmAXN69Pg2n48BAzr3YZ3kkOQrunZvVvGw=; b=CDUYiuMqXbMeJHIMCo1JJZ2GvFbAZyQyFykaMKQz+jZox+z0lU9ltlVlbHyxSAgUu+AuAs S62NIFv78fzjwOp7IZCQUw/13cAebAeKy6QusJlYgoYU/QYdQ+bZpRHBM6FaSmyzNNwN3B AcWyVZGuznLqFbi/KXEVCLbV5UzCs4U= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-642-MKg_JsTiOZiWxQy0CzIqAg-1; Sun, 10 Apr 2022 11:08:40 -0400 X-MC-Unique: MKg_JsTiOZiWxQy0CzIqAg-1 Received: by mail-qt1-f197.google.com with SMTP id c11-20020ac87dcb000000b002eba94b13c7so11161830qte.4 for ; Sun, 10 Apr 2022 08:08:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=0fBEBq6RqOmAXN69Pg2n48BAzr3YZ3kkOQrunZvVvGw=; b=5/qV4/AIS0FLxRIcyF0BcpHrMWShOjQ8hrs4GLkf7EO0LXlbdBDdWwW3vqws0qcav9 ss+gtuKT9F4Apgttyd8aKKm8eE28MPBU4Woo6gtEwii+RcPRoHpc4QibbEbLTKEk0ifu ee9aPczoyBhkTaTsGpk9eeA73Be1NLBGeyEsSni6zDLvxcMvEN2VuGTHWmSUdz9oDhEh uXySbrdLcioVZtuTEAZpYtgkBq8/hpAvpOC7VGLkXsZt4tbIbWO8d0o1u238zv4RR0Sj uxHqYYA7qzswlfz3zmmkhPrFEuCoYKVSKy8OHeUVd90OWwyBPULpln+UBchE/36YL2f7 BrhQ== X-Gm-Message-State: AOAM532s55yq8xz4mWZZnMc+ktiKBeqkpe/jUHtk4wEMtz9vLc0oCmrl hr5OW74fvumTFc0qio6efyAUyhasno2e80z6JiHxKPPfcc/iuNC9sm6YItUcG+OBKbX5SG5W5s/ fcyZqlP+0hpV+9UTy1IWyu7DoMw== X-Received: by 2002:a05:622a:1793:b0:2e1:ba41:ed2 with SMTP id s19-20020a05622a179300b002e1ba410ed2mr22788790qtk.238.1649603319936; Sun, 10 Apr 2022 08:08:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzKeGNEEMC9VIu0CY/yX+G5qpcMSSfbg6/dzIhH0M4SK2dAYg8MtigVjD0z4TpmKs/XK+8K7Q== X-Received: by 2002:a05:622a:1793:b0:2e1:ba41:ed2 with SMTP id s19-20020a05622a179300b002e1ba410ed2mr22788754qtk.238.1649603319616; Sun, 10 Apr 2022 08:08:39 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id p12-20020a05622a00cc00b002ebdd6ef303sm7685357qtw.43.2022.04.10.08.08.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Apr 2022 08:08:39 -0700 (PDT) From: Tom Rix To: balbi@kernel.org, gregkh@linuxfoundation.org, joel@jms.id.au, andrew@aj.id.au, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, claudiu.beznea@microchip.com, alcooperx@gmail.com, christophe.jaillet@wanadoo.fr, cai.huoqing@linux.dev, benh@kernel.crashing.org, neal_liu@aspeedtech.com, miles.chen@mediatek.com, balamanikandan.gunasundar@microchip.com, macpaul.lin@mediatek.com, s.shtylyov@omp.ru, jakobkoschel@gmail.com, stern@rowland.harvard.edu, andriy.shevchenko@linux.intel.com, quic_wcheng@quicinc.com, yashsri421@gmail.com, rdunlap@infradead.org Subject: [PATCH] usb: gadget: udc: clean up comments Date: Sun, 10 Apr 2022 11:08:28 -0400 Message-Id: <20220410150828.1891123-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: linux-aspeed@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux ASPEED SoC development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-aspeed@lists.ozlabs.org, Tom Rix , linux-usb@vger.kernel.org, linux-geode@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org Errors-To: linux-aspeed-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Linux-aspeed" SPDX *.h use /* */ style comments For double words, remove with, also Spelling replacements wayt to way wakup to wakeup Contrl to Control cheks to checks initiaization to initialization dyanmic to dynamic Signed-off-by: Tom Rix --- drivers/usb/gadget/udc/amd5536udc.h | 2 +- drivers/usb/gadget/udc/aspeed-vhub/core.c | 2 +- drivers/usb/gadget/udc/aspeed-vhub/ep0.c | 2 +- drivers/usb/gadget/udc/aspeed-vhub/hub.c | 2 +- drivers/usb/gadget/udc/aspeed-vhub/vhub.h | 4 ++-- drivers/usb/gadget/udc/at91_udc.c | 2 +- drivers/usb/gadget/udc/bdc/bdc_core.c | 4 ++-- drivers/usb/gadget/udc/core.c | 4 ++-- drivers/usb/gadget/udc/trace.h | 2 +- 9 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/usb/gadget/udc/amd5536udc.h b/drivers/usb/gadget/udc/amd5536udc.h index 055436016503..e670d251e16f 100644 --- a/drivers/usb/gadget/udc/amd5536udc.h +++ b/drivers/usb/gadget/udc/amd5536udc.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * amd5536.h -- header for AMD 5536 UDC high/full speed USB device controller * diff --git a/drivers/usb/gadget/udc/aspeed-vhub/core.c b/drivers/usb/gadget/udc/aspeed-vhub/core.c index 7a635c499777..8eba6d744090 100644 --- a/drivers/usb/gadget/udc/aspeed-vhub/core.c +++ b/drivers/usb/gadget/udc/aspeed-vhub/core.c @@ -180,7 +180,7 @@ void ast_vhub_init_hw(struct ast_vhub *vhub) * We do *NOT* set the VHUB_CTRL_CLK_STOP_SUSPEND bit * to stop the logic clock during suspend because * it causes the registers to become inaccessible and - * we haven't yet figured out a good wayt to bring the + * we haven't yet figured out a good way to bring the * controller back into life to issue a wakeup. */ diff --git a/drivers/usb/gadget/udc/aspeed-vhub/ep0.c b/drivers/usb/gadget/udc/aspeed-vhub/ep0.c index b4cf46249fea..3c64c00546ec 100644 --- a/drivers/usb/gadget/udc/aspeed-vhub/ep0.c +++ b/drivers/usb/gadget/udc/aspeed-vhub/ep0.c @@ -366,7 +366,7 @@ static int ast_vhub_ep0_queue(struct usb_ep* u_ep, struct usb_request *u_req, struct device *dev = &vhub->pdev->dev; unsigned long flags; - /* Paranoid cheks */ + /* Paranoid checks */ if (!u_req || (!u_req->complete && !req->internal)) { dev_warn(dev, "Bogus EP0 request ! u_req=%p\n", u_req); if (u_req) { diff --git a/drivers/usb/gadget/udc/aspeed-vhub/hub.c b/drivers/usb/gadget/udc/aspeed-vhub/hub.c index 65cd4e46f031..70001decf8c0 100644 --- a/drivers/usb/gadget/udc/aspeed-vhub/hub.c +++ b/drivers/usb/gadget/udc/aspeed-vhub/hub.c @@ -551,7 +551,7 @@ void ast_vhub_device_connect(struct ast_vhub *vhub, 0, true); /* - * If the hub is set to wakup the host on connection events + * If the hub is set to wakeup the host on connection events * then send a wakeup. */ if (vhub->wakeup_en) diff --git a/drivers/usb/gadget/udc/aspeed-vhub/vhub.h b/drivers/usb/gadget/udc/aspeed-vhub/vhub.h index 6b9dfa6e10eb..81b92d683c35 100644 --- a/drivers/usb/gadget/udc/aspeed-vhub/vhub.h +++ b/drivers/usb/gadget/udc/aspeed-vhub/vhub.h @@ -23,9 +23,9 @@ #define AST_VHUB_USBSTS 0x24 /* USB Status Register */ #define AST_VHUB_EP_TOGGLE 0x28 /* Programmable Endpoint Pool Data Toggle Value Set */ #define AST_VHUB_ISO_FAIL_ACC 0x2C /* Isochronous Transaction Fail Accumulator */ -#define AST_VHUB_EP0_CTRL 0x30 /* Endpoint 0 Contrl/Status Register */ +#define AST_VHUB_EP0_CTRL 0x30 /* Endpoint 0 Control/Status Register */ #define AST_VHUB_EP0_DATA 0x34 /* Base Address of Endpoint 0 In/OUT Data Buffer Register */ -#define AST_VHUB_EP1_CTRL 0x38 /* Endpoint 1 Contrl/Status Register */ +#define AST_VHUB_EP1_CTRL 0x38 /* Endpoint 1 Control/Status Register */ #define AST_VHUB_EP1_STS_CHG 0x3C /* Endpoint 1 Status Change Bitmap Data */ #define AST_VHUB_SETUP0 0x80 /* Root Device Setup Data Buffer0 */ #define AST_VHUB_SETUP1 0x84 /* Root Device Setup Data Buffer1 */ diff --git a/drivers/usb/gadget/udc/at91_udc.c b/drivers/usb/gadget/udc/at91_udc.c index 728987280373..c80d0902bb30 100644 --- a/drivers/usb/gadget/udc/at91_udc.c +++ b/drivers/usb/gadget/udc/at91_udc.c @@ -994,7 +994,7 @@ static const struct usb_gadget_ops at91_udc_ops = { .udc_stop = at91_stop, /* - * VBUS-powered devices may also also want to support bigger + * VBUS-powered devices may also want to support bigger * power budgets after an appropriate SET_CONFIGURATION. */ /* .vbus_power = at91_vbus_power, */ diff --git a/drivers/usb/gadget/udc/bdc/bdc_core.c b/drivers/usb/gadget/udc/bdc/bdc_core.c index 9849e0c86e23..223e08e53f94 100644 --- a/drivers/usb/gadget/udc/bdc/bdc_core.c +++ b/drivers/usb/gadget/udc/bdc/bdc_core.c @@ -296,7 +296,7 @@ static void bdc_mem_init(struct bdc *bdc, bool reinit) for (i = 1; i < bdc->num_eps; ++i) bdc->bdc_ep_array[i]->flags = 0; } else { - /* One time initiaization only */ + /* One time initialization only */ /* Enable status report function pointers */ bdc->sr_handler[0] = bdc_sr_xsf; bdc->sr_handler[1] = bdc_sr_uspc; @@ -361,7 +361,7 @@ int bdc_reinit(struct bdc *bdc) return ret; } -/* Allocate all the dyanmic memory */ +/* Allocate all the dynamic memory */ static int bdc_mem_alloc(struct bdc *bdc) { u32 page_size; diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c index 85b194011a16..bf472478239b 100644 --- a/drivers/usb/gadget/udc/core.c +++ b/drivers/usb/gadget/udc/core.c @@ -162,7 +162,7 @@ EXPORT_SYMBOL_GPL(usb_ep_disable); /** * usb_ep_alloc_request - allocate a request object to use with this endpoint - * @ep:the endpoint to be used with with the request + * @ep:the endpoint to be used with the request * @gfp_flags:GFP_* flags to use * * Request objects must be allocated with this call, since they normally @@ -897,7 +897,7 @@ EXPORT_SYMBOL_GPL(usb_gadget_unmap_request); /** * usb_gadget_giveback_request - give the request back to the gadget layer - * @ep: the endpoint to be used with with the request + * @ep: the endpoint to be used with the request * @req: the request being given back * * This is called by device controller drivers in order to return the diff --git a/drivers/usb/gadget/udc/trace.h b/drivers/usb/gadget/udc/trace.h index 98584f6b6c66..75987cae2a15 100644 --- a/drivers/usb/gadget/udc/trace.h +++ b/drivers/usb/gadget/udc/trace.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0 +/* SPDX-License-Identifier: GPL-2.0 */ /* * udc.c - Core UDC Framework *