From patchwork Wed Mar 23 18:26:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Anderson X-Patchwork-Id: 1608776 X-Patchwork-Delegate: jh80.chung@samsung.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=j80nw4i5; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4KNxdN5Zpwz9s5V for ; Thu, 24 Mar 2022 05:26:32 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D9CE883F88; Wed, 23 Mar 2022 19:26:27 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="j80nw4i5"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B47A283F55; Wed, 23 Mar 2022 19:26:25 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 69A1983F89 for ; Wed, 23 Mar 2022 19:26:22 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qv1-xf32.google.com with SMTP id jo24so1909285qvb.5 for ; Wed, 23 Mar 2022 11:26:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=lnLVSBdANxSOIsXwrQNlSuRb2re1LsZISLUN+E86bKM=; b=j80nw4i58gCTJjT9i4NbwmCd5x/C3MUe+GHJuWd8+EPW10uDdCxP4KnOQIWf2BPHg6 pbf+ywgbgyak13gy1XzhlwOXGkPPklpAZJw5+qjVpxtxOyz9Dasesah36FfwRRs5RFNJ ZdRZ8yNEDELYnnlMc+LuhpVz6C3hxLoc/2lVMbrX6yoxQW1NOxvZtcfHflBiRAArGdFR sxr5k8tX/6p/UTj+VifGuDcBSPJwpj056mQyAzC0kkjo/IrUB0j8wAOPKoHdtGvXU0Ut yo1g6clsI90DyHAW0VDWgwSCw4+i7Ndo12RhRM76Yf3QZIOaueIFhmWLRPuTulntgi/W 5sng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=lnLVSBdANxSOIsXwrQNlSuRb2re1LsZISLUN+E86bKM=; b=whkBSYK667AIrVPXYVy47ppvNsCSOcfEALv6l3X7UouJAZcKtx1BX4C+KwpEJhlA6y OF1hZgEL2jdpgnfj3DoeJMGHH64M5JaJ2qfs/uNdKG20RaS+4dgKJqteT4xlbylw0j83 vVjoeLQAhlNfHleUsR0A+uESnpKCEZR64CeiCmM66830gbF+/npYp5HYAhegGmPRGs97 nzz5BLyOPqbMt4Z00+PMgBTRAoanH+e5x2ykqhdDCZwp34i4gJmDGalVTSsSbfmvl38J lKs+jKpj/1vytALW032v7GqG3BaN4DciLoewa29BlItrDin960z4PSvdhIbmlxzR1AcR FtOQ== X-Gm-Message-State: AOAM530qt9o490z3PI01eyhRow93OfhAdtwJevlR3fzjByxYKGm3Oxu3 3fDAtJ/WbDFTlJ1Hm1StcKZaOIPj080= X-Google-Smtp-Source: ABdhPJxUmsttTTSFWf7kdZoKJlrPeRsn3WJlzSv9En2qNIa3+hCaj5U5LoRftHwlj+Az0d1J8xOS+g== X-Received: by 2002:a05:6214:23c5:b0:435:3700:d65 with SMTP id hr5-20020a05621423c500b0043537000d65mr940975qvb.65.1648059980764; Wed, 23 Mar 2022 11:26:20 -0700 (PDT) Received: from godwin.fios-router.home (pool-108-18-137-133.washdc.fios.verizon.net. [108.18.137.133]) by smtp.gmail.com with ESMTPSA id v9-20020a05620a0a8900b0067db9cc46a9sm337472qkg.62.2022.03.23.11.26.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Mar 2022 11:26:20 -0700 (PDT) From: Sean Anderson To: u-boot@lists.denx.de, Tom Rini Cc: Patrick Delaunay , Simon Glass , Lokesh Vutla , Anatolij Gustschin , Sean Anderson , Jaehoon Chung Subject: [PATCH] power-domain: Fix use of uninitialized value in dev_power_domain_ctrl Date: Wed, 23 Mar 2022 14:26:09 -0400 Message-Id: <20220323182609.58136-1-seanga2@gmail.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean If dev_count_phandle_with_args returns 0 or another error, then pd will never have been initialized by power_domain_get_by_index. Avoid comparing against pd.dev in this situation. Fixes: 3e4fcfa4bc ("power-domain: fix hang in endless loop on i.MX8") Signed-off-by: Sean Anderson Reviewed-by: Simon Glass Reviewed-by: Jaehoon Chung --- drivers/power/domain/power-domain-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/domain/power-domain-uclass.c b/drivers/power/domain/power-domain-uclass.c index 33f9206bd0..1a317a00aa 100644 --- a/drivers/power/domain/power-domain-uclass.c +++ b/drivers/power/domain/power-domain-uclass.c @@ -137,7 +137,7 @@ static int dev_power_domain_ctrl(struct udevice *dev, bool on) * off their power-domain parent. So we will get here again and * again and will be stuck in an endless loop. */ - if (!on && dev_get_parent(dev) == pd.dev && + if (count > 0 && !on && dev_get_parent(dev) == pd.dev && device_get_uclass_id(dev) == UCLASS_POWER_DOMAIN) return ret;