From patchwork Thu Feb 15 20:27:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joe Moriarty X-Patchwork-Id: 874113 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=oracle.com header.i=@oracle.com header.b="nq5iPXXq"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zj79d64Czz9t3M for ; Fri, 16 Feb 2018 07:27:17 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755639AbeBOU1L (ORCPT ); Thu, 15 Feb 2018 15:27:11 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:57834 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755630AbeBOU1J (ORCPT ); Thu, 15 Feb 2018 15:27:09 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w1FKLmhB031785; Thu, 15 Feb 2018 20:27:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=corp-2017-10-26; bh=avNPbrkyOjX66iRwNNCev+9lD5C6LD1G06Ft46sQiro=; b=nq5iPXXqgIF4Dx3r7CafZx1tL0S6SPb6BaON1DSZyRtA6aiAg60aopYilbC6ARvbFGmH udyN+pHQavpnAmn0xCFs+RAUTXXdb+3bwDNNmSjr49ZXb8lQETc8P2A/6O5UKF2tfmpV pBzhMgT1CjSZn8vXFl8zcWMk7wWO3nKCX1nAo9iF+5GGM4XZxpoXT/w+EZz/yDgkhcdF MxvfCQPRalTsr+lNB2OIsV2zC+QaiiDI3vWDgxQzssIcd8ovy3KAUr3woB2sjdqD4/2O 9lFh/QRB8C/VGKwWVwU9NYVf+FpUBejds0WMKLUAgAtznZKj+0I4agxqYwev8lOvwLCq 9g== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp2120.oracle.com with ESMTP id 2g5gbgg9e7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 15 Feb 2018 20:27:07 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w1FKR6ka024635 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 15 Feb 2018 20:27:06 GMT Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w1FKR6sP017519; Thu, 15 Feb 2018 20:27:06 GMT Received: from localhost.us.oracle.com (/10.153.52.84) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 15 Feb 2018 12:27:05 -0800 From: Joe Moriarty To: davem@davemloft.net Cc: netdev@vger.kernel.org Subject: [PATCH v1 1/1] drivers: isdn: NULL pointer dereference [null-pointer-deref] (CWE 476) problem Date: Thu, 15 Feb 2018 15:27:00 -0500 Message-Id: <20180215202700.48177-2-joe.moriarty@oracle.com> X-Mailer: git-send-email 2.15.0 In-Reply-To: <20180215202700.48177-1-joe.moriarty@oracle.com> References: <20180215202700.48177-1-joe.moriarty@oracle.com> X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8806 signatures=668672 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=391 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1802150245 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The Parfait (version 2.1.0) static code analysis tool found the following NULL pointer dereference problem. - drivers/isdn/mISDN/core.c function channelmap_show() does not check the returned mdev variable from dev_to_mISDN() for NULL. Added the check for NULL, which results in a value of 0 being returned. Signed-off-by: Joe Moriarty Reviewed-by: Jonathan Helman --- drivers/isdn/mISDN/core.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/isdn/mISDN/core.c b/drivers/isdn/mISDN/core.c index faf505462a4f..aec7e2706109 100644 --- a/drivers/isdn/mISDN/core.c +++ b/drivers/isdn/mISDN/core.c @@ -129,8 +129,10 @@ static ssize_t channelmap_show(struct device *dev, char *bp = buf; int i; - for (i = 0; i <= mdev->nrbchan; i++) - *bp++ = test_channelmap(i, mdev->channelmap) ? '1' : '0'; + if (mdev) + for (i = 0; i <= mdev->nrbchan; i++) + *bp++ = test_channelmap(i, mdev->channelmap) ? + '1' : '0'; return bp - buf; }