From patchwork Wed Feb 9 15:35:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 1590457 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=ai10ow/M; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4Jv3qz2PwYz9sCD for ; Thu, 10 Feb 2022 02:35:59 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 52C343858426 for ; Wed, 9 Feb 2022 15:35:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 52C343858426 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1644420956; bh=/RBOaF7c5R4Mk/p6g0OIpZd9TUDSBVXHEUt4Llldrfo=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=ai10ow/MWxuIc+9hCWrVbWyLe5ISlrt9m4XWnilottu1LyY0dEt1dcwFnAalKzszM JWNKHPbA1b78yI7IjWf86LKPjZ7NuIy8n7mlC54joAn6pZW4bqOanz5dydtelIRicG XEKrJC0qazR1JnjBZyhtowCP7thDBFEWpcOlGM+k= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by sourceware.org (Postfix) with ESMTPS id C69B23858D28 for ; Wed, 9 Feb 2022 15:35:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C69B23858D28 Received: by mail-pf1-x434.google.com with SMTP id z35so4956010pfw.2 for ; Wed, 09 Feb 2022 07:35:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=/RBOaF7c5R4Mk/p6g0OIpZd9TUDSBVXHEUt4Llldrfo=; b=pHGKSFHtTikHfec2jhER2qay9St12KcnB0rDWfe5ZbHxC0hQI8J9gn1ZYyCcKzRsEk Xy2eUlezpL6IsDtFz0Ufxm8bBUVGee8iYdSquW5Z+ygdSeYRKHV+AXgT5xQNR9DlMNDr bmPSXAq3t5d0R+p1J3aL3h/TwEWWdOGpgq9JSbPU2dRZSte3MeFANIFZ0Owx94xrwd+h YOW1QZonU+LiB+Ix6y9Tj+R97TsFBuOvrIFa/fcdkOHUvP2LVUeQzXyc8lFumvo29KxK 9S8VqFcqQR1SdXuVUMo051Sb99KlM+mFhfD/KPvEO37qmXWXdiTBDOzW8noXENAMZ5Wd QnEg== X-Gm-Message-State: AOAM531tmcxIhXQFEXNYPnQA4dgVYpr55Pb77d8VL3mbZp/doiWyLFeW /Vtlufdhvpf5DA1bka5IqbuT2S8mHk8= X-Google-Smtp-Source: ABdhPJz9TBOLioWiGmSWzL49w2sgE48wxc9QeieUEAKwujtmhYGPMci5S3lYYh5ilpxIl5yhAZid1w== X-Received: by 2002:a05:6a00:1691:: with SMTP id k17mr2846782pfc.54.1644420939602; Wed, 09 Feb 2022 07:35:39 -0800 (PST) Received: from gnu-tgl-3.localdomain ([172.58.38.240]) by smtp.gmail.com with ESMTPSA id h17sm20494639pfv.198.2022.02.09.07.35.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Feb 2022 07:35:39 -0800 (PST) Received: from gnu-tgl-3.. (localhost [IPv6:::1]) by gnu-tgl-3.localdomain (Postfix) with ESMTP id 39F76C00C2; Wed, 9 Feb 2022 07:35:38 -0800 (PST) To: libc-alpha@sourceware.org Subject: [PATCH] benchtests: Add benches for zeroing memset Date: Wed, 9 Feb 2022 07:35:38 -0800 Message-Id: <20220209153538.66931-1-hjl.tools@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-3029.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: "H.J. Lu via Libc-alpha" From: "H.J. Lu" Reply-To: "H.J. Lu" Errors-To: libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org Sender: "Libc-alpha" memset with zero as the value to set is by far the majority value (99%+ for Python3 and GCC). Add bench-memset-zero-large.c, bench-memset-zero-walk.c and bench-memset-zero.c to measure memset functions for zeroing. Reviewed-by: Sunil K Pandey --- benchtests/Makefile | 3 +++ benchtests/bench-bzero-large.c | 29 ++++++++++++++++++++++++++- benchtests/bench-bzero-walk.c | 30 +++++++++++++++++++++++++++- benchtests/bench-bzero.c | 30 +++++++++++++++++++++++++++- benchtests/bench-memset-zero-large.c | 20 +++++++++++++++++++ benchtests/bench-memset-zero-walk.c | 20 +++++++++++++++++++ benchtests/bench-memset-zero.c | 20 +++++++++++++++++++ 7 files changed, 149 insertions(+), 3 deletions(-) create mode 100644 benchtests/bench-memset-zero-large.c create mode 100644 benchtests/bench-memset-zero-walk.c create mode 100644 benchtests/bench-memset-zero.c diff --git a/benchtests/Makefile b/benchtests/Makefile index 6f718fac35..9b8df3b3f5 100644 --- a/benchtests/Makefile +++ b/benchtests/Makefile @@ -139,6 +139,9 @@ string-benchset := \ memset \ memset-large \ memset-walk \ + memset-zero \ + memset-zero-large \ + memset-zero-walk \ rawmemchr \ stpcpy \ stpcpy_chk \ diff --git a/benchtests/bench-bzero-large.c b/benchtests/bench-bzero-large.c index f2e2e981b7..cfc7b81cdf 100644 --- a/benchtests/bench-bzero-large.c +++ b/benchtests/bench-bzero-large.c @@ -17,7 +17,11 @@ . */ #define TEST_MAIN -#define TEST_NAME "bzero" +#ifdef DO_MEMSET +# define TEST_NAME "memset" +#else +# define TEST_NAME "bzero" +#endif #define START_SIZE (128 * 1024) #define MIN_PAGE_SIZE (getpagesize () + 64 * 1024 * 1024) #define TIMEOUT (20 * 60) @@ -25,6 +29,14 @@ #include "json-lib.h" +#ifdef DO_MEMSET +void *generic_memset (void *, int, size_t); + +typedef void *(*proto_t) (void *, int, size_t); + +IMPL (memset, 1) +IMPL (generic_memset, 0) +#else static void memset_zero (void * s, size_t len) { @@ -35,6 +47,7 @@ typedef void (*proto_t) (void *, size_t); IMPL (bzero, 1) IMPL (memset_zero, 0) +#endif static void do_one_test (json_ctx_t *json_ctx, impl_t *impl, CHAR *s, size_t n) @@ -45,7 +58,11 @@ do_one_test (json_ctx_t *json_ctx, impl_t *impl, CHAR *s, size_t n) TIMING_NOW (start); for (i = 0; i < iters; ++i) { +#ifdef DO_MEMSET + CALL (impl, s, 0, n); +#else CALL (impl, s, n); +#endif } TIMING_NOW (stop); @@ -115,3 +132,13 @@ test_main (void) } #include + +#ifdef DO_MEMSET +# define libc_hidden_builtin_def(X) +# define libc_hidden_def(X) +# define libc_hidden_weak(X) +# define weak_alias(X,Y) +# undef MEMSET +# define MEMSET generic_memset +# include +#endif diff --git a/benchtests/bench-bzero-walk.c b/benchtests/bench-bzero-walk.c index b65d12a6a2..00226f80b8 100644 --- a/benchtests/bench-bzero-walk.c +++ b/benchtests/bench-bzero-walk.c @@ -17,7 +17,11 @@ . */ #define TEST_MAIN -#define TEST_NAME "bzero" +#ifdef DO_MEMSET +# define TEST_NAME "memset" +#else +# define TEST_NAME "bzero" +#endif #define START_SIZE 128 #define MIN_PAGE_SIZE (getpagesize () + 32 * 1024 * 1024) #define TIMEOUT (20 * 60) @@ -25,6 +29,15 @@ #include "json-lib.h" +#ifdef DO_MEMSET +void *generic_memset (void *, int, size_t); + +typedef void *(*proto_t) (void *, int, size_t); + +IMPL (memset, 1) +IMPL (generic_memset, 0) + +#else static void memset_zero (void * s, size_t len) { @@ -35,6 +48,7 @@ typedef void (*proto_t) (void *, size_t); IMPL (bzero, 1) IMPL (memset_zero, 0) +#endif static void do_one_test (json_ctx_t *json_ctx, impl_t *impl, CHAR *s, CHAR *s_end, @@ -45,7 +59,11 @@ do_one_test (json_ctx_t *json_ctx, impl_t *impl, CHAR *s, CHAR *s_end, TIMING_NOW (start); for (i = 0; i < iters && s <= s_end; s_end -= n, i++) +#ifdef DO_MEMSET + CALL (impl, s, 0, n); +#else CALL (impl, s, n); +#endif TIMING_NOW (stop); TIMING_DIFF (cur, start, stop); @@ -116,3 +134,13 @@ test_main (void) } #include + +#ifdef DO_MEMSET +# define libc_hidden_builtin_def(X) +# define libc_hidden_def(X) +# define libc_hidden_weak(X) +# define weak_alias(X,Y) +# undef MEMSET +# define MEMSET generic_memset +# include +#endif diff --git a/benchtests/bench-bzero.c b/benchtests/bench-bzero.c index 93ec521725..500b7eba96 100644 --- a/benchtests/bench-bzero.c +++ b/benchtests/bench-bzero.c @@ -17,12 +17,25 @@ . */ #define TEST_MAIN -#define TEST_NAME "bzero" +#ifdef DO_MEMSET +# define TEST_NAME "memset" +#else +# define TEST_NAME "bzero" +#endif #define MIN_PAGE_SIZE 131072 #include "bench-string.h" #include "json-lib.h" +#ifdef DO_MEMSET +void *generic_memset (void *, int, size_t); + +typedef void *(*proto_t) (void *, int, size_t); + +IMPL (memset, 1) +IMPL (generic_memset, 0) + +#else static void memset_zero (void * s, size_t len) { @@ -33,6 +46,7 @@ typedef void (*proto_t) (void *, size_t); IMPL (bzero, 1) IMPL (memset_zero, 0) +#endif static void do_one_test (json_ctx_t *json_ctx, impl_t *impl, CHAR *s, size_t n) @@ -43,7 +57,11 @@ do_one_test (json_ctx_t *json_ctx, impl_t *impl, CHAR *s, size_t n) TIMING_NOW (start); for (i = 0; i < iters; ++i) { +#ifdef DO_MEMSET + CALL (impl, s, 0, n); +#else CALL (impl, s, n); +#endif } TIMING_NOW (stop); @@ -132,3 +150,13 @@ test_main (void) } #include + +#ifdef DO_MEMSET +# define libc_hidden_builtin_def(X) +# define libc_hidden_def(X) +# define libc_hidden_weak(X) +# define weak_alias(X,Y) +# undef MEMSET +# define MEMSET generic_memset +# include +#endif diff --git a/benchtests/bench-memset-zero-large.c b/benchtests/bench-memset-zero-large.c new file mode 100644 index 0000000000..bc938cdfff --- /dev/null +++ b/benchtests/bench-memset-zero-large.c @@ -0,0 +1,20 @@ +/* Measure memset functions for zeroing with large data sizes. + Copyright (C) 2022 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#define DO_MEMSET 1 +#include "bench-bzero-large.c" diff --git a/benchtests/bench-memset-zero-walk.c b/benchtests/bench-memset-zero-walk.c new file mode 100644 index 0000000000..dce4b43e06 --- /dev/null +++ b/benchtests/bench-memset-zero-walk.c @@ -0,0 +1,20 @@ +/* Measure memset functions for zeroing throughput with large data sizes. + Copyright (C) 2022 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#define DO_MEMSET 1 +#include "bench-bzero-walk.c" diff --git a/benchtests/bench-memset-zero.c b/benchtests/bench-memset-zero.c new file mode 100644 index 0000000000..535005f0e6 --- /dev/null +++ b/benchtests/bench-memset-zero.c @@ -0,0 +1,20 @@ +/* Measure memset functions for zeroing. + Copyright (C) 2022 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#define DO_MEMSET 1 +#include "bench-bzero.c"