From patchwork Mon Feb 12 21:07:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Rossak X-Patchwork-Id: 872407 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-rtc-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="iMxD06Sc"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zgJCN6mSgz9sNw for ; Tue, 13 Feb 2018 08:07:28 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753977AbeBLVH2 (ORCPT ); Mon, 12 Feb 2018 16:07:28 -0500 Received: from mail-wr0-f194.google.com ([209.85.128.194]:34283 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753908AbeBLVH1 (ORCPT ); Mon, 12 Feb 2018 16:07:27 -0500 Received: by mail-wr0-f194.google.com with SMTP id m5so4545443wrg.1; Mon, 12 Feb 2018 13:07:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=dBdRQJgymmtqhjx45Bpi4ujMQKyEDofN9fB3kXdkqUY=; b=iMxD06ScMrbgn/UwMhC2iC38WF1Ql3MtNwVs94/FauGTfrUexVs8jDQakjVHYRLbwB 8zKlR9ESYpUNvmmFWhmdVY/q8tRZdxHRHXNtO1mrybmZx4CPglqTNino0sxFsA4EE/JH OOY0BIUuZlVipJTQD40pq8w2ai5nOjFcB+c3MP/jLgB2EuZjD2lTzT3vWWgbYyDr2iyY 7ShZKuoKy8nEFC/ytbGwtzTkz+W0KjUR7o8ZgM1gbMAkBfXG0Znko8V/0yxBGp3lWmra mFwCcCx+t46aH+tHE7lhBlhok0pRerH91R4IJw9W0Tz2/9VxqM0ZZ9krwsJ3bacX5jy7 KiAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=dBdRQJgymmtqhjx45Bpi4ujMQKyEDofN9fB3kXdkqUY=; b=ILaDY3QVgKkT4B+JdP+VLfVwS/85sax+EPF7Wq7G24u5v5cQV0LlgtcAu10u179+ca 1y6lrWSIHCIsM+51d/UlYw6AdKMYlDVd9SdMflpyN9xFsKI8rpCxM5bcvO+7Rb9e0Yvj /6Iw1ByGtI+7tFEFbQZyzhdTfQWTUgan0xNGA41+kLN+unKPSuMk0qm/1HYk8zAY+sbu 9lFEA2BSxX7F/LufiN59yTOk/qLB2suvNrUFQpWxIdHWJRrOk3RW6RPJ1+VDY+NgO1+y PWwoncQQ/iJCTuL4i2tll4vo+rl9WvzVgMbFRPtrFD+/Klb/NvGn8He3Y7TJPMtbENvZ JTZA== X-Gm-Message-State: APf1xPAWI6CLd2JN5igtqqt5dhveWHJe9FwhZ/6pbQH5E2TO5RpntJwD kps4eN3xDnp0lVaJZnqiI2o= X-Google-Smtp-Source: AH8x2279mvkysQSVDFJu1hRnz3XUHLjO+tn9VRPPCtW6iKFw1dVgrVTxzL1XjezLMeTZzgtMLDp+wA== X-Received: by 10.223.134.20 with SMTP id 20mr10381588wrv.280.1518469645664; Mon, 12 Feb 2018 13:07:25 -0800 (PST) Received: from debian-laptop.fritz.box (p578F04D2.dip0.t-ipconnect.de. [87.143.4.210]) by smtp.gmail.com with ESMTPSA id k36sm9590711wre.39.2018.02.12.13.07.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Feb 2018 13:07:25 -0800 (PST) From: Philipp Rossak To: wens@csie.org, a.zummo@towertech.it, alexandre.belloni@free-electrons.com Cc: linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, linux-rtc@vger.kernel.org Subject: [PATCH] rtc: ac100: Fix ac100 determine rate bug Date: Mon, 12 Feb 2018 22:07:23 +0100 Message-Id: <20180212210723.20919-1-embed3d@gmail.com> X-Mailer: git-send-email 2.11.0 Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org This patch fixes a bug, that prevents the Allwinner A83T and the A80 from a successful boot. You can find the shortend trace below: Unable to handle kernel NULL pointer dereference at virtual address 00000000 pgd = (ptrval) [00000000] *pgd=00000000 Internal error: Oops: 5 [#1] SMP ARM Modules linked in: CPU: 0 PID: 49 Comm: kworker/0:1 Not tainted 4.15.0-10190-gb89e32ccd1be #2 Hardware name: Allwinner sun8i Family Workqueue: events deferred_probe_work_func PC is at clk_hw_get_rate+0x0/0x34 LR is at ac100_clkout_determine_rate+0x48/0x19c [ ... ] (clk_hw_get_rate) from (ac100_clkout_determine_rate+0x48/0x19c) (ac100_clkout_determine_rate) from (clk_core_set_rate_nolock+0x3c/0x1a0) (clk_core_set_rate_nolock) from (clk_set_rate+0x30/0x88) (clk_set_rate) from (of_clk_set_defaults+0x200/0x364) (of_clk_set_defaults) from (platform_drv_probe+0x18/0xb0) To fix that bug, we first check if the return of the clk_hw_get_parent_by_index is non zero. If it is zero we skip that clock parent. The BUG report could be found here: https://lkml.org/lkml/2018/2/10/198 Signed-off-by: Philipp Rossak --- drivers/rtc/rtc-ac100.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-ac100.c b/drivers/rtc/rtc-ac100.c index 8ff9dc3fe5bf..820ce6fb9d34 100644 --- a/drivers/rtc/rtc-ac100.c +++ b/drivers/rtc/rtc-ac100.c @@ -183,7 +183,12 @@ static int ac100_clkout_determine_rate(struct clk_hw *hw, for (i = 0; i < num_parents; i++) { struct clk_hw *parent = clk_hw_get_parent_by_index(hw, i); - unsigned long tmp, prate = clk_hw_get_rate(parent); + unsigned long tmp, prate; + + if (!parent) + continue; + + prate = clk_hw_get_rate(parent); tmp = ac100_clkout_round_rate(hw, req->rate, prate);