From patchwork Mon Feb 12 21:02:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Martincoski X-Patchwork-Id: 872398 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.133; helo=hemlock.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="qhDHxw4/"; dkim-atps=neutral Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zgJ7B13Kvz9sRm for ; Tue, 13 Feb 2018 08:03:50 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 72BA888DB9; Mon, 12 Feb 2018 21:03:48 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8rw9WnRO3inV; Mon, 12 Feb 2018 21:03:47 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 82CA688DA4; Mon, 12 Feb 2018 21:03:47 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 32D5B1C0AE2 for ; Mon, 12 Feb 2018 21:03:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 2CA5C88DB1 for ; Mon, 12 Feb 2018 21:03:43 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Q+PObOWJcJvk for ; Mon, 12 Feb 2018 21:03:42 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-qk0-f193.google.com (mail-qk0-f193.google.com [209.85.220.193]) by hemlock.osuosl.org (Postfix) with ESMTPS id DDB8888D8D for ; Mon, 12 Feb 2018 21:03:41 +0000 (UTC) Received: by mail-qk0-f193.google.com with SMTP id 15so20032889qkl.3 for ; Mon, 12 Feb 2018 13:03:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=KTKblZ9Mko36DhQJNq4jp3GFjFX3biXmtLTF58osCAQ=; b=qhDHxw4/MK3hKSP7ad4x/+mcrLLHl3TAFnLvCstoZTWR2vdU0mLtic8U5iIIn14dNT 8+4dESHFsZi/RSJ4D9V9C9wq5vu/zbKBHRtxgsdBY3ZClp40NSviwLzfcapuhUsNP76f sKQkhIA5M6MQYLdIFbTUxPHjedUA7rY7flo3IzyRbegXdUaPo5Bp4KBCaNsbE1SxGmjz WBKOG8LhRBixydaoD7NPKDop8iBgIhv+5JCd/UZQrp8jDEPDjs+1s0JGeI3Vc5zJNnS7 WpoHtQErKAuQzGtQ6v1WWNjU3SVu6ueHpNO9cIdpiaxUZBmQg/7V6cWgc/3UdxIApesm vnZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=KTKblZ9Mko36DhQJNq4jp3GFjFX3biXmtLTF58osCAQ=; b=D/Dtue9W3VW/21ya5lDGPxkB3h2/QGh2dm/j3ymb/WwsOwyL800qN1trnEIoGz+GIb hi1bwsDRGWxFpfKO3HOQDbPRnnIK+3aUgUhZH+biqqTS59MQS4LxPR+bz5NE+GaaxRwn 5OinI7zxojIbsuBAv6ujLy0hkJ1xi/NoOAEguCifWVXScGr6W08AIEcIl2i7SmKfNZ44 Vq4BOAw/QpCvEb0dET02YLvfJUWOV7s93T6N4850IjD8M82YsdSys9Wdcm14H+SlHkqS tkcVSWPFZlbNPNOqsYcU5qN9ZJRFyHv0F+hfj1R/QbmaoyVjvXe3/4DP9IAN35GPDbrn 4twQ== X-Gm-Message-State: APf1xPCLlodwnfUQHDD1AMGaijMBOvWLzt6+p2qCSFNfsMv5srX3bX1j VM/Qj65+HiDkq7Izv28tDTprDaJQ X-Google-Smtp-Source: AH8x227NC3zRaptQJklJRK+niPUJnKCQDNwjZP0Pmkr2rgqssk7a1eHnjJT560kLFK9NSG7EGvFzQA== X-Received: by 10.55.139.132 with SMTP id n126mr19423496qkd.299.1518469420770; Mon, 12 Feb 2018 13:03:40 -0800 (PST) Received: from ultri3.home (189.27.186.248.dynamic.adsl.gvt.net.br. [189.27.186.248]) by smtp.gmail.com with ESMTPSA id y188sm6575515qke.55.2018.02.12.13.03.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 12 Feb 2018 13:03:40 -0800 (PST) From: Ricardo Martincoski To: buildroot@buildroot.org Date: Mon, 12 Feb 2018 19:02:08 -0200 Message-Id: <1518469328-5895-1-git-send-email-ricardo.martincoski@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <20180212090725.323e5a6c@windsurf.lan> References: <20180212090725.323e5a6c@windsurf.lan> Subject: [Buildroot] [PATCH] support/testing: fix job check-gitlab-ci.yml X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.24 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eric Le Bihan , Thomas Petazzoni , "Yann E . MORIN" , Ricardo Martincoski MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Currently 'run-tests -l' is broken. It breaks 'make .gitlab-ci.yml' that in turn breaks the job in GitLab. TestRustBase is not a test case by itself, so it can't have a method with the name starting with "test_" otherwise nose2 assumes it is a test case. Move the test_run method from the base class to the derived classes. While at it, update .gitlab-ci.yml with the new test cases. Fixes: https://gitlab.com/buildroot.org/buildroot/-/jobs/52000035 Reported-by: Yegor Yefremov Signed-off-by: Ricardo Martincoski Cc: Eric Le Bihan Cc: Thomas Petazzoni Cc: Yann E. MORIN Cc: Yegor Yefremov Reviewed-by: Yegor Yefremov --- check-gitlab-ci.yml after the fix: https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/52092002 which is part of a full run: https://gitlab.com/RicardoMartincoski/buildroot/pipelines/17391318 --- .gitlab-ci.yml | 2 ++ support/testing/tests/package/test_rust.py | 18 ++++++++++++------ 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 30a4399..f76e53b 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -282,6 +282,8 @@ tests.package.test_ipython.TestIPythonPy2: *runtime_test tests.package.test_ipython.TestIPythonPy3: *runtime_test tests.package.test_python.TestPython2: *runtime_test tests.package.test_python.TestPython3: *runtime_test +tests.package.test_rust.TestRust: *runtime_test +tests.package.test_rust.TestRustBin: *runtime_test tests.toolchain.test_external.TestExternalToolchainBuildrootMusl: *runtime_test tests.toolchain.test_external.TestExternalToolchainBuildrootuClibc: *runtime_test tests.toolchain.test_external.TestExternalToolchainCCache: *runtime_test diff --git a/support/testing/tests/package/test_rust.py b/support/testing/tests/package/test_rust.py index 8035f8b..e6c0de2 100644 --- a/support/testing/tests/package/test_rust.py +++ b/support/testing/tests/package/test_rust.py @@ -53,12 +53,6 @@ class TestRustBase(infra.basetest.BRTest): self.b.build() shutil.rmtree(workdir) - def test_run(self): - self.build_test_prog() - self.login() - _, exit_code = self.emulator.run(self.crate) - self.assertEqual(exit_code, 0) - class TestRustBin(TestRustBase): config = \ @@ -82,6 +76,12 @@ class TestRustBin(TestRustBase): BR2_PACKAGE_HOST_RUSTC=y """ + def test_run(self): + self.build_test_prog() + self.login() + _, exit_code = self.emulator.run(self.crate) + self.assertEqual(exit_code, 0) + class TestRust(TestRustBase): config = \ @@ -105,3 +105,9 @@ class TestRust(TestRustBase): BR2_PACKAGE_HOST_RUSTC=y BR2_PACKAGE_HOST_RUST=y """ + + def test_run(self): + self.build_test_prog() + self.login() + _, exit_code = self.emulator.run(self.crate) + self.assertEqual(exit_code, 0)