From patchwork Sat Jan 15 22:24:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Anderson X-Patchwork-Id: 1580413 X-Patchwork-Delegate: seanga2@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=ot6LcubQ; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4Jbt6M2tDYz9sP7 for ; Sun, 16 Jan 2022 09:25:47 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 63A33834B5; Sat, 15 Jan 2022 23:25:29 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ot6LcubQ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B746183520; Sat, 15 Jan 2022 23:25:23 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 40F4383518 for ; Sat, 15 Jan 2022 23:25:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qt1-x833.google.com with SMTP id q14so14631403qtx.10 for ; Sat, 15 Jan 2022 14:25:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qeAWQwPHJYMg1gJSe2iE4KryNVX0uE0y/rrr1LDznz8=; b=ot6LcubQLLQOdv5OcKtHF3g54gRxojuITYbm2jfpVBKEkNhO2t3uPw2/cccUC+GM+Z i1h5yhpV/PTZKKLPqIeLw90kUML1GKY6FpRUIIoM4pVGjo8ZY2gqSxy2/uR3lyxXtN+N aR4Va6b4OeraEVM81lpnPXFvF0EYG2+YMt7nStC8lHk33Ji5MEXYtPKt1HnsOZbzmaN3 suGuAX5wwSJSTcjTa9RUq8IqYpDXTFCO3JxeeO70iY5xAi7brPJaoBU6Xqmjw3WOhc09 n7kJNpKTQqWYt9kN96qCgvUMLlS2X1NmFX/aF8nNjextJDz7wk1dhnM74sL3mNuUVczf 8qZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qeAWQwPHJYMg1gJSe2iE4KryNVX0uE0y/rrr1LDznz8=; b=ZTk2aYCQL7RvgP6GCwhkfmKHVQWN/SSphex3J4QwjKlRRKT+44RDJFDoTioYl3Dw8r CxVtNtnZcuHlmftWhszbujk91FXf9pdj2Te7KdmTvfxfnkbXBhZGZmn96RIRaE2IBCv5 Pgt5K6SC1FIcSCOzu4pUxQMGexApW6BiOYHjRQ+RyoU91sCt8VWSGXxZrEYtQ+C026M3 F14iuDLSxPF1PvDCy2oGtqnv2Zn60sMkL3l+63u41CoUCvKpT7UFHG+35+uOsUVg6X/t /1KodNZOhtpOtx9XCJpKIpxhI4lZPylt6goLq/LMsrZEIWetrDrp+PPKMcLZKLRT3h2N uUJg== X-Gm-Message-State: AOAM531mW1sohayJisi+g6/4fdhM4Vt/R0arUXb/twQ6qnagakdjNw4K 0Jgqm82DXgyZ/9A0C64oQw/pHqsn3gs= X-Google-Smtp-Source: ABdhPJxENi7XTjciV9oX+/yPmh/tfVV4oyqGoyK1zx+zdB04Y9gd8oGyeEZtk1QvepgSXl50zBTHFw== X-Received: by 2002:a05:622a:1894:: with SMTP id v20mr2752747qtc.148.1642285514794; Sat, 15 Jan 2022 14:25:14 -0800 (PST) Received: from godwin.fios-router.home (pool-108-18-137-133.washdc.fios.verizon.net. [108.18.137.133]) by smtp.gmail.com with ESMTPSA id ay15sm5991017qkb.63.2022.01.15.14.25.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Jan 2022 14:25:14 -0800 (PST) From: Sean Anderson To: u-boot@lists.denx.de Cc: Simon Glass , Lukasz Majewski , Sean Anderson Subject: [PATCH 1/7] clk: Make rfree return void Date: Sat, 15 Jan 2022 17:24:58 -0500 Message-Id: <20220115222504.617013-2-seanga2@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220115222504.617013-1-seanga2@gmail.com> References: <20220115222504.617013-1-seanga2@gmail.com> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean When freeing a clock there is not much we can do if there is an error, and most callers do not actually check the return value. Even e.g. checking to make sure that clk->id is valid should have been done in request() in the first place (unless someone is messing with the driver behind our back). Just return void and don't bother returning an error. Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- drivers/clk/clk-uclass.c | 7 +++---- drivers/clk/clk_sandbox.c | 6 +++--- include/clk-uclass.h | 8 +++----- 3 files changed, 9 insertions(+), 12 deletions(-) diff --git a/drivers/clk/clk-uclass.c b/drivers/clk/clk-uclass.c index fca4b8321a..61f977b661 100644 --- a/drivers/clk/clk-uclass.c +++ b/drivers/clk/clk-uclass.c @@ -481,10 +481,9 @@ int clk_free(struct clk *clk) return 0; ops = clk_dev_ops(clk->dev); - if (!ops->rfree) - return 0; - - return ops->rfree(clk); + if (ops->rfree) + ops->rfree(clk); + return 0; } ulong clk_get_rate(struct clk *clk) diff --git a/drivers/clk/clk_sandbox.c b/drivers/clk/clk_sandbox.c index 57acf7d855..636914db8c 100644 --- a/drivers/clk/clk_sandbox.c +++ b/drivers/clk/clk_sandbox.c @@ -101,15 +101,15 @@ static int sandbox_clk_request(struct clk *clk) return 0; } -static int sandbox_clk_free(struct clk *clk) +static void sandbox_clk_free(struct clk *clk) { struct sandbox_clk_priv *priv = dev_get_priv(clk->dev); if (clk->id >= SANDBOX_CLK_ID_COUNT) - return -EINVAL; + return; priv->requested[clk->id] = false; - return 0; + return; } static struct clk_ops sandbox_clk_ops = { diff --git a/include/clk-uclass.h b/include/clk-uclass.h index e44f1caf51..65ebff9ed2 100644 --- a/include/clk-uclass.h +++ b/include/clk-uclass.h @@ -32,7 +32,7 @@ struct clk_ops { int (*of_xlate)(struct clk *clock, struct ofnode_phandle_args *args); int (*request)(struct clk *clock); - int (*rfree)(struct clk *clock); + void (*rfree)(struct clk *clock); ulong (*round_rate)(struct clk *clk, ulong rate); ulong (*get_rate)(struct clk *clk); ulong (*set_rate)(struct clk *clk, ulong rate); @@ -81,11 +81,9 @@ int request(struct clk *clock); * rfree() - Free a previously requested clock. * @clock: The clock to free. * - * This is the implementation of the client clk_free() API. - * - * Return: 0 if OK, or a negative error code. + * Free any resources allocated in request(). */ -int rfree(struct clk *clock); +void rfree(struct clk *clock); /** * round_rate() - Adjust a rate to the exact rate a clock can provide. From patchwork Sat Jan 15 22:24:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Anderson X-Patchwork-Id: 1580412 X-Patchwork-Delegate: seanga2@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=Rmue0+7I; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4Jbt6B0cPhz9t6h for ; Sun, 16 Jan 2022 09:25:37 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6959C8351A; Sat, 15 Jan 2022 23:25:25 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Rmue0+7I"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id EEE07835BA; Sat, 15 Jan 2022 23:25:21 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-qv1-xf2e.google.com (mail-qv1-xf2e.google.com [IPv6:2607:f8b0:4864:20::f2e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E33A383531 for ; Sat, 15 Jan 2022 23:25:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qv1-xf2e.google.com with SMTP id fo11so13866818qvb.4 for ; Sat, 15 Jan 2022 14:25:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YU6tPtuROSfNLWCZ1wUhUIXSjoajZcGgFOyLRMLWe5g=; b=Rmue0+7ImY9hOHklL/PHHr4p59twKfcraPfEMlYx2OS1zi0c3vy/Kb6N/TKICmispB Labzw1VzGd700jlc+vSPRuxcCFtZrLaHiR2K4FRiGdTrNYtkEJDfTZlUntt3s9WyCxZ0 HYAucHKGeZ4f81goMj2lIGitqaZ8pEykq3Io37N95OjdEqrdFi7CiEP4KzTr7RQwDmF3 7CUEJyCUnZrLtdUuU788vPwd5jJUfwccCEftCLSuG4B/nZkSbeXyf8yeZ/m1Wj3aWGpU ikWnflKXjpjpHSm7p65SIQi9/Zia75rO9++RZmULdzTyL7l2HOqBugAiDOIiKNKTxWbh 5mNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YU6tPtuROSfNLWCZ1wUhUIXSjoajZcGgFOyLRMLWe5g=; b=fpbBXQpn3hMATN19x9CHbaFWHmNnCfBrC2IQAOD1ZtREBVaxy104HlrYOkgsfymEUV zVEvXkK+P2793mO9t850juOkDh5kuNlOa/AwC0tgvZzGMs57tH+Wp4BpYwuCTxyjDC5j v67n7MIZYYUPUgXACcWtj9xQQaZeV77uTcEeHXxhbAnB+jWn/1vusC0WSJbUJQ79Whqt AEN2hBj0zGn7DDJv13AH53L4Cz1Ba8avjSiX/UwoeOalFKSF/cXmgl85d2XTXy4PJH+S goTmEuKvZTysBnIsa7Si7y3OXK+906R85MLKERUDHc/HGQKLwHi01SfYi3L46d8QUkps 6bqw== X-Gm-Message-State: AOAM531WBo+79v9rVy0zQQoKuB+/2kUMOVX77CVEoxrtbLW4eA0nrKVU rViXxy7KV+PIB112OkrziubGXMU29aA= X-Google-Smtp-Source: ABdhPJwPBOWYH7zX8u4BBoA7Xx9iSauUFPSYZ5/7pSIiHRHbhhCo1JLhxpgphmkNdge95qC9AlubDg== X-Received: by 2002:a05:6214:761:: with SMTP id f1mr13599824qvz.51.1642285515662; Sat, 15 Jan 2022 14:25:15 -0800 (PST) Received: from godwin.fios-router.home (pool-108-18-137-133.washdc.fios.verizon.net. [108.18.137.133]) by smtp.gmail.com with ESMTPSA id ay15sm5991017qkb.63.2022.01.15.14.25.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Jan 2022 14:25:15 -0800 (PST) From: Sean Anderson To: u-boot@lists.denx.de Cc: Simon Glass , Lukasz Majewski , Sean Anderson , Daniel Schwierzeck , =?utf-8?q?=C3=81lvaro_Fe?= =?utf-8?q?rn=C3=A1ndez_Rojas?= Subject: [PATCH 2/7] dma: bcm6348: Don't check clk_free Date: Sat, 15 Jan 2022 17:24:59 -0500 Message-Id: <20220115222504.617013-3-seanga2@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220115222504.617013-1-seanga2@gmail.com> References: <20220115222504.617013-1-seanga2@gmail.com> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean This function always succeeds, so don't check its return value. Signed-off-by: Sean Anderson --- drivers/dma/bcm6348-iudma.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/dma/bcm6348-iudma.c b/drivers/dma/bcm6348-iudma.c index c04aa55cb4..4fc650272d 100644 --- a/drivers/dma/bcm6348-iudma.c +++ b/drivers/dma/bcm6348-iudma.c @@ -596,11 +596,7 @@ static int bcm6348_iudma_probe(struct udevice *dev) return ret; } - ret = clk_free(&clk); - if (ret < 0) { - pr_err("error freeing clock %d\n", i); - return ret; - } + clk_free(&clk); } /* try to perform resets */ From patchwork Sat Jan 15 22:25:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Anderson X-Patchwork-Id: 1580414 X-Patchwork-Delegate: seanga2@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=F9lB3dSV; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4Jbt6W62F4z9sP7 for ; Sun, 16 Jan 2022 09:25:55 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1222F83504; Sat, 15 Jan 2022 23:25:32 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="F9lB3dSV"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2218D8350D; Sat, 15 Jan 2022 23:25:25 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DE1FF8355E for ; Sat, 15 Jan 2022 23:25:17 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qt1-x82a.google.com with SMTP id w6so6217368qtk.4 for ; Sat, 15 Jan 2022 14:25:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZN9kedHBG6nDcFISYdhA1+e3+TWqSWmcg9j3UX4/xiw=; b=F9lB3dSVNZdugd60gs+bFourFZYik7zyz18ldXJiXN61hpMWc10Pi5iajohwBZyYUT YCOjPT48EIVDX0S5V6rKwmxNBmaKPjXMllqBzRBqVHx7xALcqhPUYKcZaoTOCIsD4euZ PkeahA7qt2u2LvnZYjpd5LtPaA9kPc/HyP++OJeKOSFuh4fdffDH2Er3YYP1WW62/Gmf 8hl1OLJCXcvxfWpjpG9NmhVl+2jyo7oYaohkacDTZexZEZm0rdHv8862jwzKzMUj8G4J I3uMEsyLzh8GC41iMWdBYjnsIudpK8Mla1davN6vIIxMMEMqWWgienFBEt2ACEP21nm6 tsiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZN9kedHBG6nDcFISYdhA1+e3+TWqSWmcg9j3UX4/xiw=; b=1aZPTCgVkUnFnZbLcQy21HSR8wmsnY71XDJb/EsF8vNauZmdnI1IexTeGGGqdazEcB lexzutH/Zpv3kQHzYGCkf6X6Ip36LkdWO4T3EjzvFrhqsMUyz2UpTyseosq1nF6/1yGF ylVOghMusaB/XM9nCfiqats8/FnbNTO4MWy8sN5dFKdeL/huBlH0telXEGbzVaY9KH1l 3Z8+rEx/LZn+6+CCSa4/aSy+AaLZVSccfh14CWo/d02+9ldYVxIGrHZ3zjZWNCu40oDQ tfXXxugeqmDysGdSzIskHJ8GjtFSGb/12gM4OjjScRJ0ciT8KMYtgsQ1FAyoS7GGbJ/s yLSg== X-Gm-Message-State: AOAM531Dfxk2erZWfZuOkJjGDDNFhgxCsqT/ofAshtNk4Q7GgypC95iK RRLTz11MxTM0P0KRELlF0q8/7H2UTRs= X-Google-Smtp-Source: ABdhPJwulGv2num6IVOUHIBlYOszNAfEDiVQSeo1j17HNzeaqiuuGAE2/5FyGf5OP4BgJH7OdjjsDg== X-Received: by 2002:ac8:7f8d:: with SMTP id z13mr12414992qtj.351.1642285516652; Sat, 15 Jan 2022 14:25:16 -0800 (PST) Received: from godwin.fios-router.home (pool-108-18-137-133.washdc.fios.verizon.net. [108.18.137.133]) by smtp.gmail.com with ESMTPSA id ay15sm5991017qkb.63.2022.01.15.14.25.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Jan 2022 14:25:16 -0800 (PST) From: Sean Anderson To: u-boot@lists.denx.de Cc: Simon Glass , Lukasz Majewski , Sean Anderson , Daniel Schwierzeck , Joe Hershberger , Ramon Fried , =?utf-8?q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= Subject: [PATCH 3/7] net: bcm63xx: Don't check clk_free Date: Sat, 15 Jan 2022 17:25:00 -0500 Message-Id: <20220115222504.617013-4-seanga2@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220115222504.617013-1-seanga2@gmail.com> References: <20220115222504.617013-1-seanga2@gmail.com> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean This function always succeeds, so don't check its return value. Signed-off-by: Sean Anderson --- drivers/net/bcm6348-eth.c | 6 +----- drivers/net/bcm6368-eth.c | 6 +----- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/net/bcm6348-eth.c b/drivers/net/bcm6348-eth.c index aad7b61213..06e0dd74a5 100644 --- a/drivers/net/bcm6348-eth.c +++ b/drivers/net/bcm6348-eth.c @@ -461,11 +461,7 @@ static int bcm6348_eth_probe(struct udevice *dev) return ret; } - ret = clk_free(&clk); - if (ret < 0) { - pr_err("%s: error freeing clock %d\n", __func__, i); - return ret; - } + clk_free(&clk); } /* try to perform resets */ diff --git a/drivers/net/bcm6368-eth.c b/drivers/net/bcm6368-eth.c index 29abe7fc96..c2a8b9f057 100644 --- a/drivers/net/bcm6368-eth.c +++ b/drivers/net/bcm6368-eth.c @@ -546,11 +546,7 @@ static int bcm6368_eth_probe(struct udevice *dev) return ret; } - ret = clk_free(&clk); - if (ret < 0) { - pr_err("%s: error freeing clock %d\n", __func__, i); - return ret; - } + clk_free(&clk); } /* try to perform resets */ From patchwork Sat Jan 15 22:25:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Anderson X-Patchwork-Id: 1580416 X-Patchwork-Delegate: seanga2@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=dQiT6ZHz; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4Jbt6t4WWcz9sP7 for ; Sun, 16 Jan 2022 09:26:14 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 40B698359C; Sat, 15 Jan 2022 23:25:38 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="dQiT6ZHz"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D73AE83504; Sat, 15 Jan 2022 23:25:28 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 Received: from mail-qv1-xf35.google.com (mail-qv1-xf35.google.com [IPv6:2607:f8b0:4864:20::f35]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9234C83458 for ; Sat, 15 Jan 2022 23:25:18 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qv1-xf35.google.com with SMTP id ee17so2720675qvb.6 for ; Sat, 15 Jan 2022 14:25:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pWkbp7o0G8PrA1XI1ZTir8J0c+VRkfue1FL4QAg9C1w=; b=dQiT6ZHzOtUXNp9fIaInXtjgMgDM6z33Mf9rEUX+lw3mzoJzpoAekd3TPrY4wn85Ca rciyAT19fE1ZP46A0vuuE95ORxweKuTTwkTPQjVkPJE6BKqCVpA3IBwTzaxn52tNUxfc jMDEaHdJXVMrFCdZa44XIbq3BAbI2Co3ZjOCik/gZ0RTiHtb0f2AJ+afJsZbiDW1Hi+2 YxZ0ZoToMZ8qKhlEerKTSgMsB/AoTFgJAKURxfiBwPU0a1IrFOYavD4PxvZ59BENn2vG emMth+ZpwAqcf4X5fJ86/x2acNqrW/HFuhkajGzjRXFGqSFva5AUSDEi2U+X3wpOlxH3 7bnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pWkbp7o0G8PrA1XI1ZTir8J0c+VRkfue1FL4QAg9C1w=; b=nOtiGTMlWQYG8y92FZSJRUUPp8RQcE2py/QiUqQQBWX5Nj7i4Auhj1hz8WLKKUUzy1 5o1AJRrW7WaD4nH8XUo8Gl+Z+xCg0gAyKK5n/I+piz80bZE9BrqbgJ830RoywQBlrwgC H2cFlsSuRvG+H69ZLWMii4fe774Aelqv6Xm3e+kBiaw/F065+EJ6u0Ty7cnBWcuJVqcJ wWr8ucFoCqqYAtmcAXTKb65xCzbZ58B65ERC2N00f7vdRuHvc+wYtJj5ltdPixCT7K/w viLc56NW87GBr2cqXB7DIRTK3A0gszNmmZRBeQTv02Gm4QXeOcx1W+8p2U9qS5g5Seh8 0s0A== X-Gm-Message-State: AOAM532Jtar3JEnWfopp97UWM0txJf8m48D9YMCphcAtP1k1kTqfRslE +Mw+z2AqPX38gUTAWMvnF3gsQxJDVpk= X-Google-Smtp-Source: ABdhPJyjpF8WyQJ/eOJpcaI2HG2UPdpQw6aIK1HE+wwxQX5dHos9g6+A/5A37sf6zlgGtASWxCUQFg== X-Received: by 2002:a05:6214:d08:: with SMTP id 8mr7441957qvh.127.1642285517389; Sat, 15 Jan 2022 14:25:17 -0800 (PST) Received: from godwin.fios-router.home (pool-108-18-137-133.washdc.fios.verizon.net. [108.18.137.133]) by smtp.gmail.com with ESMTPSA id ay15sm5991017qkb.63.2022.01.15.14.25.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Jan 2022 14:25:17 -0800 (PST) From: Sean Anderson To: u-boot@lists.denx.de Cc: Simon Glass , Lukasz Majewski , Sean Anderson , Daniel Schwierzeck , Joe Hershberger , =?utf-8?q?=C3=81lvaro_Fern=C3=A1n?= =?utf-8?q?dez_Rojas?= Subject: [PATCH 4/7] phy: bcm63xx: Don't check clk_free Date: Sat, 15 Jan 2022 17:25:01 -0500 Message-Id: <20220115222504.617013-5-seanga2@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220115222504.617013-1-seanga2@gmail.com> References: <20220115222504.617013-1-seanga2@gmail.com> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean This function always succeeds, so don't check its return value. Signed-off-by: Sean Anderson --- drivers/phy/bcm6318-usbh-phy.c | 4 +--- drivers/phy/bcm6348-usbh-phy.c | 4 +--- drivers/phy/bcm6368-usbh-phy.c | 8 ++------ 3 files changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/phy/bcm6318-usbh-phy.c b/drivers/phy/bcm6318-usbh-phy.c index 60608a55bc..1c10853940 100644 --- a/drivers/phy/bcm6318-usbh-phy.c +++ b/drivers/phy/bcm6318-usbh-phy.c @@ -98,9 +98,7 @@ static int bcm6318_usbh_probe(struct udevice *dev) if (ret < 0) return ret; - ret = clk_free(&clk); - if (ret < 0) - return ret; + clk_free(&clk); /* enable power domain */ ret = power_domain_get(dev, &pwr_dom); diff --git a/drivers/phy/bcm6348-usbh-phy.c b/drivers/phy/bcm6348-usbh-phy.c index 1b6b5ad177..ce6be3d7da 100644 --- a/drivers/phy/bcm6348-usbh-phy.c +++ b/drivers/phy/bcm6348-usbh-phy.c @@ -62,9 +62,7 @@ static int bcm6348_usbh_probe(struct udevice *dev) if (ret < 0) return ret; - ret = clk_free(&clk); - if (ret < 0) - return ret; + clk_free(&clk); /* perform reset */ ret = reset_get_by_index(dev, 0, &rst_ctl); diff --git a/drivers/phy/bcm6368-usbh-phy.c b/drivers/phy/bcm6368-usbh-phy.c index 4d3a63faad..d057f1f52e 100644 --- a/drivers/phy/bcm6368-usbh-phy.c +++ b/drivers/phy/bcm6368-usbh-phy.c @@ -137,9 +137,7 @@ static int bcm6368_usbh_probe(struct udevice *dev) if (ret < 0) return ret; - ret = clk_free(&clk); - if (ret < 0) - return ret; + clk_free(&clk); #if defined(CONFIG_POWER_DOMAIN) /* enable power domain */ @@ -176,9 +174,7 @@ static int bcm6368_usbh_probe(struct udevice *dev) if (ret < 0) return ret; - ret = clk_free(&clk); - if (ret < 0) - return ret; + clk_free(&clk); } mdelay(100); From patchwork Sat Jan 15 22:25:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Anderson X-Patchwork-Id: 1580415 X-Patchwork-Delegate: seanga2@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=SGO2nXq4; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4Jbt6h6lyZz9sP7 for ; Sun, 16 Jan 2022 09:26:04 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2C1828356F; Sat, 15 Jan 2022 23:25:36 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="SGO2nXq4"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D510783504; Sat, 15 Jan 2022 23:25:27 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 Received: from mail-qv1-xf30.google.com (mail-qv1-xf30.google.com [IPv6:2607:f8b0:4864:20::f30]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4FE4883564 for ; Sat, 15 Jan 2022 23:25:19 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qv1-xf30.google.com with SMTP id t7so13968112qvj.0 for ; Sat, 15 Jan 2022 14:25:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EvKt41oD+UOqApaguNRummFBw/pYoh8kauZ4klaPngU=; b=SGO2nXq4kkSh5guO+zqFDXHJonK9DXqbIcTXRxM0aeh/SwUGg+kgxB+so5Wah8G49W IpeRdo+H1hTAdm2hTV6rdEVt1eMTsHVM9LXmykqbcKexFCJE5icrQnrmI4jP1z56HCMo SuV22AEb7VnnG0DH2C5sv/gytnTPMtiBsaZQZO2OwCxc3zo4a1o/n4j5VozFqPhMG8Yh lcolS+ehwVKrGv/PtkdqW0tP+IjIvpI9SQhoYSonYjFNClTQqXCx7FskyHWD9MhXWfWc WmHIcFauOXEZ/IT0yVvV2J6dY6IW2Ok1U9Ad/84prWpM337hGYuFj/ZD7XqXgBoxpbuY Mcnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EvKt41oD+UOqApaguNRummFBw/pYoh8kauZ4klaPngU=; b=3zS23MENLix3G0j7MJ5xMTuK0oWwkfD4bF8ZLNH3r6tejWNdGmZdDDDKZ8BBvHQpBm FnHKYsYnGBroTH4W2epMednG0Y+IXOFHM17uD4+9ViWrHP0hZVfjme4fdyXuoDh978+F L6HEdy/sShjh32iMd+0tbGmFasWMs8dGlc65VCLUvvA1nwWZTWnj6SLybpezaD8yF85U ADWUhlp2DExKsJv8p1VMBo0i/eGNzqmydZDiBwmicx2qLEB170zqawQv5pJavkqSiU7P M33yM1dk9elhm1ElV12c/4+0SHm+L/h/T/Iwe2kA/orgMZAW6nY6N9sf6oiUVEFl86SQ ZSNg== X-Gm-Message-State: AOAM533v+IL3C2GysF/qFXFG/C8YAO6D6uILtu0IIPS6TPO6aeYCv1Ow u3630wFWLGMiqQU2kX/V1/1DfyHSiow= X-Google-Smtp-Source: ABdhPJwPjSctPEtvxHlCt3ORLVRBmRkHFSM4a7Nq1BOTOYGObTgy6oYQn8yYnwd5SMBcxLX1OYv7Rg== X-Received: by 2002:a05:6214:c85:: with SMTP id r5mr12611050qvr.90.1642285518031; Sat, 15 Jan 2022 14:25:18 -0800 (PST) Received: from godwin.fios-router.home (pool-108-18-137-133.washdc.fios.verizon.net. [108.18.137.133]) by smtp.gmail.com with ESMTPSA id ay15sm5991017qkb.63.2022.01.15.14.25.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Jan 2022 14:25:17 -0800 (PST) From: Sean Anderson To: u-boot@lists.denx.de Cc: Simon Glass , Lukasz Majewski , Sean Anderson , Daniel Schwierzeck , Jagan Teki , =?utf-8?q?=C3=81lvaro_Fern=C3=A1nd?= =?utf-8?q?ez_Rojas?= Subject: [PATCH 5/7] spi: bcm63xx: Don't check clk_free Date: Sat, 15 Jan 2022 17:25:02 -0500 Message-Id: <20220115222504.617013-6-seanga2@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220115222504.617013-1-seanga2@gmail.com> References: <20220115222504.617013-1-seanga2@gmail.com> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean This function always succeeds, so don't check its return value. Signed-off-by: Sean Anderson --- drivers/spi/bcm63xx_hsspi.c | 8 ++------ drivers/spi/bcm63xx_spi.c | 4 +--- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/spi/bcm63xx_hsspi.c b/drivers/spi/bcm63xx_hsspi.c index 85108df565..47002f8b56 100644 --- a/drivers/spi/bcm63xx_hsspi.c +++ b/drivers/spi/bcm63xx_hsspi.c @@ -355,9 +355,7 @@ static int bcm63xx_hsspi_probe(struct udevice *dev) if (ret < 0 && ret != -ENOSYS) return ret; - ret = clk_free(&clk); - if (ret < 0 && ret != -ENOSYS) - return ret; + clk_free(&clk); /* get clock rate */ ret = clk_get_by_name(dev, "pll", &clk); @@ -366,9 +364,7 @@ static int bcm63xx_hsspi_probe(struct udevice *dev) priv->clk_rate = clk_get_rate(&clk); - ret = clk_free(&clk); - if (ret < 0 && ret != -ENOSYS) - return ret; + clk_free(&clk); /* perform reset */ ret = reset_get_by_index(dev, 0, &rst_ctl); diff --git a/drivers/spi/bcm63xx_spi.c b/drivers/spi/bcm63xx_spi.c index dd5e62b2fe..0600d56c69 100644 --- a/drivers/spi/bcm63xx_spi.c +++ b/drivers/spi/bcm63xx_spi.c @@ -391,9 +391,7 @@ static int bcm63xx_spi_probe(struct udevice *dev) if (ret < 0) return ret; - ret = clk_free(&clk); - if (ret < 0) - return ret; + clk_free(&clk); /* perform reset */ ret = reset_get_by_index(dev, 0, &rst_ctl); From patchwork Sat Jan 15 22:25:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Anderson X-Patchwork-Id: 1580418 X-Patchwork-Delegate: seanga2@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=m8HJn3E3; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4Jbt745yZwz9sP7 for ; Sun, 16 Jan 2022 09:26:24 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 547CF835D4; Sat, 15 Jan 2022 23:25:42 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="m8HJn3E3"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D837483504; Sat, 15 Jan 2022 23:25:30 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 Received: from mail-qt1-x82b.google.com (mail-qt1-x82b.google.com [IPv6:2607:f8b0:4864:20::82b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4617083595 for ; Sat, 15 Jan 2022 23:25:20 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qt1-x82b.google.com with SMTP id l17so14658231qtk.7 for ; Sat, 15 Jan 2022 14:25:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Pxp16qAP4ZJw+1Sf7eF8zWV9Jc9Gn34IWBDRsWwJgU4=; b=m8HJn3E3iVfvA0HS1p696GhzKQf5ATLoJD4r8eFKI82z95P0urxZ/wb4WS5UXDfQTK HdSmee4ihnw67QEf/Ib3E6utmZ8zpuPlbhHpWlBUhjhg6dBfCuX5+iVYRzj/CUxoGHZR xlCrP0i8Qn+H/3wr86GD0Xi2Yp1eLcHMpbFr7jnacBMQgt+HohD/Ghtijzf94NBC6rYP IyipD2+SMVRAsjsXd6i4n3a+fM7dm8rXWh2AEl/5J3KXMrNqy739MWrU1LkrgGvsf8il PSKAxjS3QYJELnx4bQaqPcLL6tfCUDOB4jPVuwQtbdlxiTl1/Yn/ktSlW9fyQD1pO4kd RUjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Pxp16qAP4ZJw+1Sf7eF8zWV9Jc9Gn34IWBDRsWwJgU4=; b=guq3hI/KEp+JfqP5RcIbh3tFqdOJqb7aQeHb5GrxjRpB4iOpO7xFAzkTQ25MKbWgX3 BjxOB1ihCjLI+it2ZjbdWDqMYTpEu065FsNLqhZXIgHj2n4FVJfdkRXvsjiPgyi2i1iK EwMxzuggtvetQ4uWSFCXkl1FryGxT2xUWd3HI0HmN+oDo/nPWNtg/xSz/Z2PT8wC7PHD 4ubZDiHh2/k/kNtEf1zeB4ZELunopNoLIYRDH+0HJ2xjQ/Uy6BlPITceeHDeK6ecdcIr hFgYBTHczEhu6qvP2BdkkHcWrb6QsfHa8D+y0RQl6WWscsx8eziP1LdLYFgm7N/yW3OY Ti0w== X-Gm-Message-State: AOAM531k9gifi7Q0HOOZfnqoODs4mmEkG/0anUQVS3dHKGQzTYEGnLOk CPKA29icNhu9LJIfzTELnAZLtHoMYbE= X-Google-Smtp-Source: ABdhPJyf837Kola+bYu7Cg6YIMKcuVw+bw8+fHaxHRadvUijFiJ+TeYZWkwf7Y1yBeLN5r5Ko8QH9w== X-Received: by 2002:ac8:5dca:: with SMTP id e10mr12411821qtx.558.1642285518927; Sat, 15 Jan 2022 14:25:18 -0800 (PST) Received: from godwin.fios-router.home (pool-108-18-137-133.washdc.fios.verizon.net. [108.18.137.133]) by smtp.gmail.com with ESMTPSA id ay15sm5991017qkb.63.2022.01.15.14.25.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Jan 2022 14:25:18 -0800 (PST) From: Sean Anderson To: u-boot@lists.denx.de Cc: Simon Glass , Lukasz Majewski , Sean Anderson , Jagan Teki Subject: [PATCH 6/7] spi: dw: Don't check clk_free Date: Sat, 15 Jan 2022 17:25:03 -0500 Message-Id: <20220115222504.617013-7-seanga2@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220115222504.617013-1-seanga2@gmail.com> References: <20220115222504.617013-1-seanga2@gmail.com> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean This function always succeeds, so don't check its return value. Signed-off-by: Sean Anderson --- drivers/spi/designware_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/designware_spi.c b/drivers/spi/designware_spi.c index 742121140d..9b9933b439 100644 --- a/drivers/spi/designware_spi.c +++ b/drivers/spi/designware_spi.c @@ -718,7 +718,7 @@ static int dw_spi_remove(struct udevice *bus) if (ret) return ret; - ret = clk_free(&priv->clk); + clk_free(&priv->clk); if (ret) return ret; #endif From patchwork Sat Jan 15 22:25:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Anderson X-Patchwork-Id: 1580419 X-Patchwork-Delegate: seanga2@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=jTwkel9k; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4Jbt7G41dhz9sP7 for ; Sun, 16 Jan 2022 09:26:34 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6CEFA835FB; Sat, 15 Jan 2022 23:25:44 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="jTwkel9k"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7284E8354B; Sat, 15 Jan 2022 23:25:31 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 Received: from mail-qv1-xf34.google.com (mail-qv1-xf34.google.com [IPv6:2607:f8b0:4864:20::f34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 04EA5835B3 for ; Sat, 15 Jan 2022 23:25:21 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qv1-xf34.google.com with SMTP id hu2so13887663qvb.8 for ; Sat, 15 Jan 2022 14:25:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4rnLRW6e+Sj+T5YPqx+0BK27nAtfvfliGz6EtIE/Vto=; b=jTwkel9keM4OBhxhhdFOdskNgcQcyohqlDGbCcdZsYhuKFsrRerdCCV6FnWsSoAXBf Lrwn2qQ8dDKVs+brHvnvqNEAWCDiNmFzddyD3LeskB0VvAAlTAXKPhPATYvubhMRkqKh jzeGHNPOzGdpMIlb/qI23VYGpL1GXevIsmlHwTyysj2U+LTGiKKBk7b2s9UFqETb8Dyu Q5L9qtmkgxc6iDdLBKl7PqHrpiYKoKIOuV/UPiq49DK1njaIQZJbJ9M/l8e0xIYH5mNT WS0T7dASbZvVAsvycUrqaJ61FkLuKCotF4Dx0FU4c4yQIMjj1EI2YjOjP45X7kWH3WI0 YBSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4rnLRW6e+Sj+T5YPqx+0BK27nAtfvfliGz6EtIE/Vto=; b=3NEVEel/TALjixA+7TqjuKsSkNNh4toHn0uuQSqRnOcOt6eWSit3r2+W9LuTc/M8cq we4w+s0l74CG/OGFDTf5cZXo3FB3dY1XW5EuhqsOSB186uPAzzAxgxmYgwYnn1z2FV/w 1klvZpwUmxd+XjqKDfQG6dAnP5ZtE47s9+Qn2bNyQHWgiu/xGxjEUphNjQ2K6kqFDVMr JPE30kk94OE3xnntyvZptGIefsXMAol3pgFH7cG3Zvv+qPc4/d2IzGsmRji0MNVDz9qm R/tKQqgj25sYwgo/eEVvQaXhxLkZ0jxtI10tCcHMHUmDRjVAyn9rzk9K/TPrZv/SnTUX zTxw== X-Gm-Message-State: AOAM532Q5xE0HVWLAyXWuHob53gxbla2eThNY7zKbz29TFtFYdoHQtvA 05Nvss2yblsp9d8FNBQqLRznx9a7qS0= X-Google-Smtp-Source: ABdhPJwJ2KVH809Fq67oDAscjds5FDPUa9bbEa+MSMxoGbX2t4Cmlc91i1Q0ffpoMzM5r/yrXCykmA== X-Received: by 2002:ad4:5b8e:: with SMTP id 14mr12994732qvp.95.1642285519658; Sat, 15 Jan 2022 14:25:19 -0800 (PST) Received: from godwin.fios-router.home (pool-108-18-137-133.washdc.fios.verizon.net. [108.18.137.133]) by smtp.gmail.com with ESMTPSA id ay15sm5991017qkb.63.2022.01.15.14.25.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Jan 2022 14:25:19 -0800 (PST) From: Sean Anderson To: u-boot@lists.denx.de Cc: Simon Glass , Lukasz Majewski , Sean Anderson Subject: [PATCH 7/7] clk: Make clk_free return void Date: Sat, 15 Jan 2022 17:25:04 -0500 Message-Id: <20220115222504.617013-8-seanga2@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220115222504.617013-1-seanga2@gmail.com> References: <20220115222504.617013-1-seanga2@gmail.com> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Most callers of this function do not check the return value, and it is unclear what action they should take if it fails. If a function is freeing multiple clocks, it should not stop just because the first one failed. Since the callbacks can no longer fail, just convert the return type to void. Signed-off-by: Sean Anderson --- drivers/clk/clk-uclass.c | 10 ++++------ drivers/clk/clk_sandbox_test.c | 9 +++------ include/clk.h | 8 ++++---- 3 files changed, 11 insertions(+), 16 deletions(-) diff --git a/drivers/clk/clk-uclass.c b/drivers/clk/clk-uclass.c index 61f977b661..5641709244 100644 --- a/drivers/clk/clk-uclass.c +++ b/drivers/clk/clk-uclass.c @@ -447,9 +447,7 @@ int clk_release_all(struct clk *clk, int count) if (ret && ret != -ENOSYS) return ret; - ret = clk_free(&clk[i]); - if (ret && ret != -ENOSYS) - return ret; + clk_free(&clk[i]); } return 0; @@ -472,18 +470,18 @@ int clk_request(struct udevice *dev, struct clk *clk) return ops->request(clk); } -int clk_free(struct clk *clk) +void clk_free(struct clk *clk) { const struct clk_ops *ops; debug("%s(clk=%p)\n", __func__, clk); if (!clk_valid(clk)) - return 0; + return; ops = clk_dev_ops(clk->dev); if (ops->rfree) ops->rfree(clk); - return 0; + return; } ulong clk_get_rate(struct clk *clk) diff --git a/drivers/clk/clk_sandbox_test.c b/drivers/clk/clk_sandbox_test.c index f665fd3cc4..5807a454f3 100644 --- a/drivers/clk/clk_sandbox_test.c +++ b/drivers/clk/clk_sandbox_test.c @@ -137,14 +137,11 @@ int sandbox_clk_test_disable_bulk(struct udevice *dev) int sandbox_clk_test_free(struct udevice *dev) { struct sandbox_clk_test *sbct = dev_get_priv(dev); - int i, ret; + int i; devm_clk_put(dev, sbct->clkps[SANDBOX_CLK_TEST_ID_DEVM1]); - for (i = 0; i < SANDBOX_CLK_TEST_NON_DEVM_COUNT; i++) { - ret = clk_free(&sbct->clks[i]); - if (ret) - return ret; - } + for (i = 0; i < SANDBOX_CLK_TEST_NON_DEVM_COUNT; i++) + clk_free(&sbct->clks[i]); return 0; } diff --git a/include/clk.h b/include/clk.h index 33f448eb89..79e7a9551f 100644 --- a/include/clk.h +++ b/include/clk.h @@ -396,9 +396,9 @@ int clk_request(struct udevice *dev, struct clk *clk); * @clk: A clock struct that was previously successfully requested by * clk_request/get_by_*(). * - * Return: 0 if OK, or a negative error code. + * Free resources allocated by clk_request() (or any clk_get_* function). */ -int clk_free(struct clk *clk); +void clk_free(struct clk *clk); /** * clk_get_rate() - Get current clock rate. @@ -545,9 +545,9 @@ static inline int clk_request(struct udevice *dev, struct clk *clk) return -ENOSYS; } -static inline int clk_free(struct clk *clk) +static inline void clk_free(struct clk *clk) { - return 0; + return; } static inline ulong clk_get_rate(struct clk *clk)