From patchwork Tue Jan 11 07:47:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cosmin Tanislav X-Patchwork-Id: 1578292 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=XTwGvD53; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by bilbo.ozlabs.org (Postfix) with ESMTP id 4JY2qL6g9yz9s1l for ; Tue, 11 Jan 2022 18:47:58 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348623AbiAKHr4 (ORCPT ); Tue, 11 Jan 2022 02:47:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348620AbiAKHr4 (ORCPT ); Tue, 11 Jan 2022 02:47:56 -0500 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80855C06173F; Mon, 10 Jan 2022 23:47:55 -0800 (PST) Received: by mail-ed1-x532.google.com with SMTP id o6so63659861edc.4; Mon, 10 Jan 2022 23:47:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=nM/uwZwpqJW2H4ac2VQWs6cOpPGqITY+VBtnGv3nTiE=; b=XTwGvD53MBV256bvS8LuVW3PvGGeLrJslg/rc7qaD1PF+hfb5208xwdDXBGQPyO1Bb F1HtEoCrMfXLunOM3Hl78wR+K1oJsls1InG8qWY0FPZZ7oRpbWQX+DRxyFzOkUKh3plb oLIaZZ4JT9aW1R6Q/FdjelU+PdmxzPkXOz8lvrojeck6WOjumPjrqpNc5rzmgXfhB2xT amINwuXgXUbtQf5PMT13LhXqqUsZAAjfGZm9LW3y0fPSQRlwIQslAS1AySysIz1hF/Nz SYtolXo85W9yNm3s4wUKFLNydeVJYc9McjwC+XOUdqTcXE0s681x7WvGmlSqAoLr1fc7 fbvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=nM/uwZwpqJW2H4ac2VQWs6cOpPGqITY+VBtnGv3nTiE=; b=SdsZUJFlWlmIkdxfXPiWE6TP4OqBEY9NJD1oUbjM2kCTfbmjEd4ukdG+e2zY4sm50g KpAicHvV/iBffhUSIP2X6Z9NpTQWUzeeCXBx5pSn9mXvPIr4jIby5SDcU81zUv8YMe6X oO3N/Sy1ZzOSTaRriZktB4CsVf6jVoLZ/in2sSG7MdAVSxiHC0U6mKZim7gLNrgVQkdt TFmcooNANvaxtucIVp4hyekqGRbEU/J81AZWBrdV5sA+/U6DCKkQnMbCPwFV3FvXP9Go 2g8SrolWjRXzZPhNczQRIv49ogjgQ1lMuXQWRWejIhBSl31mosm9aV3gF7cdH4tF147S KqEw== X-Gm-Message-State: AOAM533Pj/AT2+LGqdNI5W5Jm0n2rXexArrKPqcLalX+RtNRx1rrWCOJ dAj6Ch2Hdii7XDAZ0wffhgXe2IFaEs6WjQ== X-Google-Smtp-Source: ABdhPJzjyMLOpWeTbx1gSQaL8x3d5JjLlwmJarPjnmSW/CfZug1OrOzJuN39Hg9sgFVh+CqQjMRqNQ== X-Received: by 2002:a17:906:16d5:: with SMTP id t21mr2724958ejd.547.1641887274130; Mon, 10 Jan 2022 23:47:54 -0800 (PST) Received: from demon-pc.localdomain ([79.119.107.253]) by smtp.gmail.com with ESMTPSA id ga10sm3318827ejc.12.2022.01.10.23.47.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jan 2022 23:47:53 -0800 (PST) From: Cosmin Tanislav X-Google-Original-From: Cosmin Tanislav To: andy.shevchenko@gmail.com Cc: cosmin.tanislav@analog.com, demonsingur@gmail.com, Lars-Peter Clausen , Michael Hennerich , Rob Herring , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org Subject: [PATCH v3 1/3] iio: addac: ad74413r: use ngpio size when iterating over mask Date: Tue, 11 Jan 2022 09:47:01 +0200 Message-Id: <20220111074703.3677392-1-cosmin.tanislav@analog.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org ngpio is the actual number of GPIOs handled by the GPIO chip, as opposed to the max number of GPIOs. Fixes: fea251b6a5db ("iio: addac: add AD74413R driver") Signed-off-by: Cosmin Tanislav Reviewed-by: Andy Shevchenko --- V1 -> V2 * add Fixes tag --- drivers/iio/addac/ad74413r.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/addac/ad74413r.c b/drivers/iio/addac/ad74413r.c index 5271073bb74e..6ea3cd933d05 100644 --- a/drivers/iio/addac/ad74413r.c +++ b/drivers/iio/addac/ad74413r.c @@ -288,7 +288,7 @@ static void ad74413r_gpio_set_multiple(struct gpio_chip *chip, unsigned int offset = 0; int ret; - for_each_set_bit_from(offset, mask, AD74413R_CHANNEL_MAX) { + for_each_set_bit_from(offset, mask, chip->ngpio) { unsigned int real_offset = st->gpo_gpio_offsets[offset]; ret = ad74413r_set_gpo_config(st, real_offset, @@ -334,7 +334,7 @@ static int ad74413r_gpio_get_multiple(struct gpio_chip *chip, if (ret) return ret; - for_each_set_bit_from(offset, mask, AD74413R_CHANNEL_MAX) { + for_each_set_bit_from(offset, mask, chip->ngpio) { unsigned int real_offset = st->comp_gpio_offsets[offset]; if (val & BIT(real_offset)) From patchwork Tue Jan 11 07:47:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cosmin Tanislav X-Patchwork-Id: 1578293 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=J1tfV/JI; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by bilbo.ozlabs.org (Postfix) with ESMTP id 4JY2qM6Rxxz9ssD for ; Tue, 11 Jan 2022 18:47:59 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348633AbiAKHr6 (ORCPT ); Tue, 11 Jan 2022 02:47:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348628AbiAKHr5 (ORCPT ); Tue, 11 Jan 2022 02:47:57 -0500 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 049C2C06173F; Mon, 10 Jan 2022 23:47:57 -0800 (PST) Received: by mail-ed1-x535.google.com with SMTP id c71so52075358edf.6; Mon, 10 Jan 2022 23:47:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9J4sXRF843dXBbYU89Qr1DSQHRtG4M472WmhcYlGSGM=; b=J1tfV/JI+HdcNH6RWUPg5V1WifYMdHWLsC8qTwMWwnKVQMlgJSuEKx66S/J8MTg7ml zXfcLTj8oFqpnRqlsdkUGBzzHF5dZArs+d3kQ9L/xBSMCxgyF6k3gjcRG1WAun7kXlLy /dEiaXZ5DLBr8bbx3ep66yP5rZn9qJ0rQVDqqQAPHIkIXsNQIs4wM/hGDZmVCO/IumEo rHENzVaQZOEq4/lyV6893rRTfvWNQ8jKFmkWoGhQQn/p6zsvYrb6wOBIB2ZVZLw3JOyD CsHvlZCWig4G2FVp8qrqaJzQI58qyjRgZuceWj92f0AMRvFBWklpHX8chA/S4/YcZhKA 19OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9J4sXRF843dXBbYU89Qr1DSQHRtG4M472WmhcYlGSGM=; b=OqmifdAEK30vOzRnCv82SvOQNy6yxRK9xUwS8CqrJZgmUGhMAoWPIz5GktIaixz+oR wpWo1e1Nq8phfWabRk0347xiCCF75pDkNH9OIfoojEiszGGl8Xp7foeIXQmTt57MGk5z Fyp+kIyC93N3WdpiX4hEuVrTfoJSAapcguZqHAdnjCAPUiLTAW7Ix/qtNcA2JITxL6nU Y0kkvdhh6G9ZgMwapJCE39kvILj97KRiJmHjdSZ81iKWNz5Wd//TF8HtwMF4w0vY882T CgGITSeNg//fR/BWg4Z/eeP4ph6Xqu/dnHAToItbD7iGxeDlkCOqR0wqKbe2mkBGlB0k OhEQ== X-Gm-Message-State: AOAM5339IcO2KvEbgrb8rzDzgprHoYTLDHf+eGCZo4nx6OeX8AVXmEqq 1kJlEVCg6UB+jCSpejmMBms= X-Google-Smtp-Source: ABdhPJyfuZs06WNtGUKGD/3UN0ppEPrhdEdfmGcxNbE8H0N/t3JqTNZScA6E4D/quOR0LGJYXCyBuQ== X-Received: by 2002:a05:6402:5112:: with SMTP id m18mr3184969edd.45.1641887275676; Mon, 10 Jan 2022 23:47:55 -0800 (PST) Received: from demon-pc.localdomain ([79.119.107.253]) by smtp.gmail.com with ESMTPSA id ga10sm3318827ejc.12.2022.01.10.23.47.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jan 2022 23:47:55 -0800 (PST) From: Cosmin Tanislav X-Google-Original-From: Cosmin Tanislav To: andy.shevchenko@gmail.com Cc: cosmin.tanislav@analog.com, demonsingur@gmail.com, Lars-Peter Clausen , Michael Hennerich , Rob Herring , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org Subject: [PATCH v3 2/3] iio: addac: ad74413r: correct comparator gpio getters mask usage Date: Tue, 11 Jan 2022 09:47:02 +0200 Message-Id: <20220111074703.3677392-2-cosmin.tanislav@analog.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220111074703.3677392-1-cosmin.tanislav@analog.com> References: <20220111074703.3677392-1-cosmin.tanislav@analog.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org The value of the GPIOs is currently altered using offsets rather than masks. Make use of __assign_bit and the BIT macro to turn the offsets into masks. Fixes: fea251b6a5db ("iio: addac: add AD74413R driver") Signed-off-by: Cosmin Tanislav Reviewed-by: Andy Shevchenko --- V1 -> V2 * add Fixes tag * use __assign_bit * remove bitmap_zero V2 -> V3 * add back line between real_offset declaration and __assign_bit call * move before patch 2 --- drivers/iio/addac/ad74413r.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/iio/addac/ad74413r.c b/drivers/iio/addac/ad74413r.c index 6ea3cd933d05..b13cd5407df3 100644 --- a/drivers/iio/addac/ad74413r.c +++ b/drivers/iio/addac/ad74413r.c @@ -134,7 +134,6 @@ struct ad74413r_state { #define AD74413R_CH_EN_MASK(x) BIT(x) #define AD74413R_REG_DIN_COMP_OUT 0x25 -#define AD74413R_DIN_COMP_OUT_SHIFT_X(x) x #define AD74413R_REG_ADC_RESULT_X(x) (0x26 + (x)) #define AD74413R_ADC_RESULT_MAX GENMASK(15, 0) @@ -316,7 +315,7 @@ static int ad74413r_gpio_get(struct gpio_chip *chip, unsigned int offset) if (ret) return ret; - status &= AD74413R_DIN_COMP_OUT_SHIFT_X(real_offset); + status &= BIT(real_offset); return status ? 1 : 0; } @@ -337,8 +336,7 @@ static int ad74413r_gpio_get_multiple(struct gpio_chip *chip, for_each_set_bit_from(offset, mask, chip->ngpio) { unsigned int real_offset = st->comp_gpio_offsets[offset]; - if (val & BIT(real_offset)) - *bits |= offset; + __assign_bit(offset, bits, val & BIT(real_offset)); } return ret; From patchwork Tue Jan 11 07:47:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cosmin Tanislav X-Patchwork-Id: 1578294 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=gvKTnYl7; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by bilbo.ozlabs.org (Postfix) with ESMTP id 4JY2qQ4Mdmz9s1l for ; Tue, 11 Jan 2022 18:48:02 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348645AbiAKHsA (ORCPT ); Tue, 11 Jan 2022 02:48:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348638AbiAKHr6 (ORCPT ); Tue, 11 Jan 2022 02:47:58 -0500 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23025C06173F; Mon, 10 Jan 2022 23:47:58 -0800 (PST) Received: by mail-ed1-x52e.google.com with SMTP id b13so10273677edn.0; Mon, 10 Jan 2022 23:47:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZdPX8GIQceGUqvgcepNMikuMFPrZwyFE5c5d7j8AF5Y=; b=gvKTnYl7a/N9XVB0BiYT2wk3ZZHDbbFrIHKX8HV0j2PNt2Ugk4/vuu12iWJPaV7mI/ MHHWlCFuiup7JXdSqQKarHqDcyaIBcdQ5P19QbtVHr8BYe6WnUBg7hl9SFwb7Cne+JRQ 83z0koopBy6RkhcD/6IALDqebRHMJcRWJ+imLykdBNmROpIWXkazB9Td5Vut0dBAJlRV wNV9MU0dzS3s5YygksRYcntJ1R+DhT8JUUT1DhVyjiVllbB/QccbpbbUwwJh0QRJ06Wj jwUKZLXP+jqH11demWQQKe94kzkeXCbwfWRgQ13G+5AMDBQ12oE78SEOF0wK0XfjrxOR HKFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZdPX8GIQceGUqvgcepNMikuMFPrZwyFE5c5d7j8AF5Y=; b=NaaPyowkm73FcDaYjb9T60hGppEOzNJggPYZaOkb1k72McGJT1Q4qsUecEnY++GvRj cxsdTMPtHLUKuRXO0ETg5iIRyWHXuyYT36z4l/UmnlIAv3Ti9eX3AtGsw+ldSfuZUoby VUyhaIR6f9NfxCJTdXd+7LnLp18AHtjdjb4r+69jWgit7OItAeejCPTmCSOjplfNxhBj oj5HJt7xvGUbDP/fHV723Djrk9eIOZctOkJp+kcSN2KEfHR4LPfZjWM3PkXaLnV0U2oY fo7SIcfMrcMn9iyZj6tn/KHGCcQKMvT9+3DAm0xMxGMLQ81/aTmsyt7d8FucXJixZepf qI5Q== X-Gm-Message-State: AOAM532p8sDIPgsf3NtdE8B8SV8cEAwE/TZzYIXwwFQEoWESGL4FBffG /yb1cnuF9im6d707yEIwRJU= X-Google-Smtp-Source: ABdhPJyvTVJNxXsmi2pRMWNUGq62FF0tyDI+KiHJMeUkAxV+gQbBDafpo6q/kvMv7/tJCSg6ZDgGiA== X-Received: by 2002:a05:6402:274e:: with SMTP id z14mr3155708edd.242.1641887276816; Mon, 10 Jan 2022 23:47:56 -0800 (PST) Received: from demon-pc.localdomain ([79.119.107.253]) by smtp.gmail.com with ESMTPSA id ga10sm3318827ejc.12.2022.01.10.23.47.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jan 2022 23:47:56 -0800 (PST) From: Cosmin Tanislav X-Google-Original-From: Cosmin Tanislav To: andy.shevchenko@gmail.com Cc: cosmin.tanislav@analog.com, demonsingur@gmail.com, Lars-Peter Clausen , Michael Hennerich , Rob Herring , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org Subject: [PATCH v3 3/3] iio: addac: ad74413r: for_each_set_bit_from -> for_each_set_bit Date: Tue, 11 Jan 2022 09:47:03 +0200 Message-Id: <20220111074703.3677392-3-cosmin.tanislav@analog.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220111074703.3677392-1-cosmin.tanislav@analog.com> References: <20220111074703.3677392-1-cosmin.tanislav@analog.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org The starting bit is always zero, it doesn't make much sense to use for_each_set_bit_from. Replace it with for_each_set_bit which doesn't start from a particular bit. Signed-off-by: Cosmin Tanislav Reviewed-by: Andy Shevchenko --- V2 -> V3 * move after patch 3 --- drivers/iio/addac/ad74413r.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/iio/addac/ad74413r.c b/drivers/iio/addac/ad74413r.c index b13cd5407df3..cf58ee19f912 100644 --- a/drivers/iio/addac/ad74413r.c +++ b/drivers/iio/addac/ad74413r.c @@ -284,10 +284,10 @@ static void ad74413r_gpio_set_multiple(struct gpio_chip *chip, struct ad74413r_state *st = gpiochip_get_data(chip); unsigned long real_mask = 0; unsigned long real_bits = 0; - unsigned int offset = 0; + unsigned int offset; int ret; - for_each_set_bit_from(offset, mask, chip->ngpio) { + for_each_set_bit(offset, mask, chip->ngpio) { unsigned int real_offset = st->gpo_gpio_offsets[offset]; ret = ad74413r_set_gpo_config(st, real_offset, @@ -325,7 +325,7 @@ static int ad74413r_gpio_get_multiple(struct gpio_chip *chip, unsigned long *bits) { struct ad74413r_state *st = gpiochip_get_data(chip); - unsigned int offset = 0; + unsigned int offset; unsigned int val; int ret; @@ -333,7 +333,7 @@ static int ad74413r_gpio_get_multiple(struct gpio_chip *chip, if (ret) return ret; - for_each_set_bit_from(offset, mask, chip->ngpio) { + for_each_set_bit(offset, mask, chip->ngpio) { unsigned int real_offset = st->comp_gpio_offsets[offset]; __assign_bit(offset, bits, val & BIT(real_offset));