From patchwork Mon Jan 10 09:41:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre-Marie de Rodat X-Patchwork-Id: 1577838 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=ENibd/hy; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4JXTVn0S9bz9s9c for ; Mon, 10 Jan 2022 20:46:41 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D858E3891C08 for ; Mon, 10 Jan 2022 09:46:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D858E3891C08 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1641807998; bh=oHuZchbsiy1hTdOt8ZAJ2R92iCNhaBzK2CnioFvbMJE=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=ENibd/hyypl63OaR++z5CbOhLE23BHlPn1unT7SkXpmLaNVjCQvVZJY4E2rUISvbd mQNSDxUSR5gayn7Cw5pFigHHhQgp0ehTuJZ7nR91TZaSpQhc1vQFFLLpda4cSvpgTk bDfko19hC3KfR5N/eFX28C/FM8cpFM2WwiJRHCyU= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by sourceware.org (Postfix) with ESMTPS id F0374389043B for ; Mon, 10 Jan 2022 09:41:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F0374389043B Received: by mail-wr1-x430.google.com with SMTP id o3so25531088wrh.10 for ; Mon, 10 Jan 2022 01:41:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=oHuZchbsiy1hTdOt8ZAJ2R92iCNhaBzK2CnioFvbMJE=; b=ky9zV3MzhFdy2dGBGtALmJypkEkBPe9RUi+ZOHaoQ5WlM/JAM8rlBtUOUvQ6qPNCZh iPQv0Ubcu34vYABCkCrPVUYfKe9BULZ9aKYSvFxqzpXG3oCMWTy/kun8/wxqDB1IYzpv ziH0UYnctiG5TyQiot0kIP8fabykgnLcHuHSs0wp97pJhYKytZxycJDp9+n3jVFWYEPO SLiZrVSXvlYpEvxA7Zr3kZV30nNW+8Bzd2uymUvC8Fk2OrHvkKKB6qyidLXsYy5zQa8k RseEuhBLMbZS0bumv6J4EhCHQ1jHA3veBwhQ0V8hOagwQDiOf1viFnHcW0EnW9ROhXss 5a3Q== X-Gm-Message-State: AOAM532WTi+Uea2nV/7/EgTRHiVUCIcssOZcXnEFJVtE0maGJgCYq2KX owISwNSRsK0sj4b0RQSKKwC5o/mNIPZxlQ== X-Google-Smtp-Source: ABdhPJxrLDzEcecQFk7q4/jPYyWFZR3QydCpaPLE5pu+1KfKcxY7hLyGPtbdC0hFwWrJW/evZc3dOw== X-Received: by 2002:adf:ce87:: with SMTP id r7mr5816490wrn.259.1641807698059; Mon, 10 Jan 2022 01:41:38 -0800 (PST) Received: from adacore.com ([45.147.211.82]) by smtp.gmail.com with ESMTPSA id a8sm1826214wrx.57.2022.01.10.01.41.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jan 2022 01:41:37 -0800 (PST) Date: Mon, 10 Jan 2022 09:41:37 +0000 To: gcc-patches@gcc.gnu.org Subject: [Ada] Remove CodePeer annotations for pragma Loop_Variant Message-ID: <20220110094137.GA586124@adacore.com> MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Pierre-Marie de Rodat via Gcc-patches From: Pierre-Marie de Rodat Reply-To: Pierre-Marie de Rodat Cc: Piotr Trojanek Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" Pragma Loop_Variant is now expanded into a null statement in CodePeer mode. Remove annotations related to false positives in runtime units. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * libgnat/s-exponn.adb, libgnat/s-expont.adb, libgnat/s-exponu.adb, libgnat/s-widthi.adb, libgnat/s-widthu.adb: Remove CodePeer annotations for pragma Loop_Variant. diff --git a/gcc/ada/libgnat/s-exponn.adb b/gcc/ada/libgnat/s-exponn.adb --- a/gcc/ada/libgnat/s-exponn.adb +++ b/gcc/ada/libgnat/s-exponn.adb @@ -130,9 +130,6 @@ is pragma Loop_Invariant (Big (Result) * Big (Factor) ** Exp = Big (Left) ** Right); pragma Loop_Variant (Decreases => Exp); - pragma Annotate - (CodePeer, False_Positive, - "validity check", "confusion on generated code"); if Exp rem 2 /= 0 then declare diff --git a/gcc/ada/libgnat/s-expont.adb b/gcc/ada/libgnat/s-expont.adb --- a/gcc/ada/libgnat/s-expont.adb +++ b/gcc/ada/libgnat/s-expont.adb @@ -130,9 +130,6 @@ is pragma Loop_Invariant (Big (Result) * Big (Factor) ** Exp = Big (Left) ** Right); pragma Loop_Variant (Decreases => Exp); - pragma Annotate - (CodePeer, False_Positive, - "validity check", "confusion on generated code"); if Exp rem 2 /= 0 then declare diff --git a/gcc/ada/libgnat/s-exponu.adb b/gcc/ada/libgnat/s-exponu.adb --- a/gcc/ada/libgnat/s-exponu.adb +++ b/gcc/ada/libgnat/s-exponu.adb @@ -64,9 +64,6 @@ begin pragma Loop_Invariant (Exp > 0); pragma Loop_Invariant (Result * Factor ** Exp = Left ** Right); pragma Loop_Variant (Decreases => Exp); - pragma Annotate - (CodePeer, False_Positive, - "validity check", "confusion on generated code"); if Exp rem 2 /= 0 then pragma Assert diff --git a/gcc/ada/libgnat/s-widthi.adb b/gcc/ada/libgnat/s-widthi.adb --- a/gcc/ada/libgnat/s-widthi.adb +++ b/gcc/ada/libgnat/s-widthi.adb @@ -163,9 +163,6 @@ begin pragma Loop_Invariant (Pow = Big_10 ** (W - 2)); pragma Loop_Invariant (Big (T) = Big (T_Init) / Pow); pragma Loop_Variant (Decreases => T); - pragma Annotate - (CodePeer, False_Positive, - "validity check", "confusion on generated code"); end loop; declare diff --git a/gcc/ada/libgnat/s-widthu.adb b/gcc/ada/libgnat/s-widthu.adb --- a/gcc/ada/libgnat/s-widthu.adb +++ b/gcc/ada/libgnat/s-widthu.adb @@ -156,9 +156,6 @@ begin pragma Loop_Invariant (Pow = Big_10 ** (W - 2)); pragma Loop_Invariant (Big (T) = Big (T_Init) / Pow); pragma Loop_Variant (Decreases => T); - pragma Annotate - (CodePeer, False_Positive, - "validity check", "confusion on generated code"); end loop; declare