From patchwork Sat Jan 8 00:09:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Malcolm X-Patchwork-Id: 1577014 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=fBed0998; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4JW0pt5FKmz9sXM for ; Sat, 8 Jan 2022 11:10:30 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8FF883857C53 for ; Sat, 8 Jan 2022 00:10:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8FF883857C53 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1641600628; bh=iTIsCfzk5scVjo3vsQZ8TNveBGzyZW84WLf/lTgcLA4=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=fBed0998UHQ2hK87LdV/qgVZEMWiSEZxV36jzVxv1/To2SXKIt4csTkA8mKnyItDT LImM5gnk3M4+NBnHn3oP257Rn46eOrY/ja+EksmhL8VffmSESKDm6DfGgYvp0X3iJh ehsF2sfbWKO13y6Yy0Yfl5bWzXJlhXtVWMApGtfE= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 84ACC3857C53 for ; Sat, 8 Jan 2022 00:09:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 84ACC3857C53 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-49-GlNd59X3O1qB3IjRvf847Q-1; Fri, 07 Jan 2022 19:09:10 -0500 X-MC-Unique: GlNd59X3O1qB3IjRvf847Q-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AA5C88042E1 for ; Sat, 8 Jan 2022 00:09:09 +0000 (UTC) Received: from t14s.localdomain.com (unknown [10.2.16.212]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4B28D6E209; Sat, 8 Jan 2022 00:09:05 +0000 (UTC) To: gcc-patches@gcc.gnu.org Subject: [committed] analyzer: add logging of aliasing Date: Fri, 7 Jan 2022 19:09:04 -0500 Message-Id: <20220108000904.1076388-1-dmalcolm@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: David Malcolm via Gcc-patches From: David Malcolm Reply-To: David Malcolm Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to trunk as 11a2ff8d981110e1562caf7d98e41c1ff2e76056. gcc/analyzer/ChangeLog: * engine.cc (impl_run_checkers): Pass logger to engine ctor. * region-model-manager.cc (region_model_manager::region_model_manager): Add logger param and use it to initialize m_logger. * region-model.cc (engine::engine): New. * region-model.h (region_model_manager::region_model_manager): Add logger param. (region_model_manager::get_logger): New. (region_model_manager::m_logger): New field. (engine::engine): New. * store.cc (store_manager::get_logger): New. (store::set_value): Log scope. Log when marking a cluster as unknown due to possible aliasing. * store.h (store_manager::get_logger): New decl. --- gcc/analyzer/engine.cc | 2 +- gcc/analyzer/region-model-manager.cc | 5 +++-- gcc/analyzer/region-model.cc | 7 +++++++ gcc/analyzer/region-model.h | 7 ++++++- gcc/analyzer/store.cc | 21 +++++++++++++++++++++ gcc/analyzer/store.h | 2 ++ 6 files changed, 40 insertions(+), 4 deletions(-) diff --git a/gcc/analyzer/engine.cc b/gcc/analyzer/engine.cc index 0d456a14639..346b65973b2 100644 --- a/gcc/analyzer/engine.cc +++ b/gcc/analyzer/engine.cc @@ -5329,7 +5329,7 @@ impl_run_checkers (logger *logger) FOR_EACH_FUNCTION_WITH_GIMPLE_BODY (node) node->get_untransformed_body (); - engine eng; + engine eng (logger); /* Create the supergraph. */ supergraph sg (logger); diff --git a/gcc/analyzer/region-model-manager.cc b/gcc/analyzer/region-model-manager.cc index 19e1a93b89e..998bbe7858c 100644 --- a/gcc/analyzer/region-model-manager.cc +++ b/gcc/analyzer/region-model-manager.cc @@ -66,8 +66,9 @@ namespace ana { /* region_model_manager's ctor. */ -region_model_manager::region_model_manager () -: m_next_region_id (0), +region_model_manager::region_model_manager (logger *logger) +: m_logger (logger), + m_next_region_id (0), m_root_region (alloc_region_id ()), m_stack_region (alloc_region_id (), &m_root_region), m_heap_region (alloc_region_id (), &m_root_region), diff --git a/gcc/analyzer/region-model.cc b/gcc/analyzer/region-model.cc index cb86d79c99d..8708a91551d 100644 --- a/gcc/analyzer/region-model.cc +++ b/gcc/analyzer/region-model.cc @@ -3965,6 +3965,13 @@ rejected_ranges_constraint::dump_to_pp (pretty_printer *pp) const /* class engine. */ +/* engine's ctor. */ + +engine::engine (logger *logger) +: m_mgr (logger) +{ +} + /* Dump the managed objects by class to LOGGER, and the per-class totals. */ void diff --git a/gcc/analyzer/region-model.h b/gcc/analyzer/region-model.h index 669f1c748ce..b1fa4fc82af 100644 --- a/gcc/analyzer/region-model.h +++ b/gcc/analyzer/region-model.h @@ -240,7 +240,7 @@ namespace ana { class region_model_manager { public: - region_model_manager (); + region_model_manager (logger *logger = NULL); ~region_model_manager (); /* svalue consolidation. */ @@ -335,6 +335,8 @@ public: void enable_complexity_check (void) { m_check_complexity = true; } void disable_complexity_check (void) { m_check_complexity = false; } + logger *get_logger () const { return m_logger; } + private: bool too_complex_p (const complexity &c) const; bool reject_if_too_complex (svalue *sval); @@ -358,6 +360,8 @@ private: const svalue *maybe_fold_asm_output_svalue (tree type, const vec &inputs); + logger *m_logger; + unsigned m_next_region_id; root_region m_root_region; stack_region m_stack_region; @@ -1080,6 +1084,7 @@ private: class engine { public: + engine (logger *logger = NULL); region_model_manager *get_model_manager () { return &m_mgr; } void log_stats (logger *logger) const; diff --git a/gcc/analyzer/store.cc b/gcc/analyzer/store.cc index 3f91b6107a9..ade6dec624d 100644 --- a/gcc/analyzer/store.cc +++ b/gcc/analyzer/store.cc @@ -1987,6 +1987,12 @@ binding_cluster::maybe_get_simple_value (store_manager *mgr) const /* class store_manager. */ +logger * +store_manager::get_logger () const +{ + return m_mgr->get_logger (); +} + /* binding consolidation. */ const concrete_binding * @@ -2353,6 +2359,9 @@ store::set_value (store_manager *mgr, const region *lhs_reg, const svalue *rhs_sval, uncertainty_t *uncertainty) { + logger *logger = mgr->get_logger (); + LOG_SCOPE (logger); + remove_overlapping_bindings (mgr, lhs_reg); rhs_sval = simplify_for_binding (rhs_sval); @@ -2405,6 +2414,18 @@ store::set_value (store_manager *mgr, const region *lhs_reg, gcc_unreachable (); case tristate::TS_UNKNOWN: + if (logger) + { + pretty_printer *pp = logger->get_printer (); + logger->start_log_line (); + logger->log_partial ("possible aliasing of "); + iter_base_reg->dump_to_pp (pp, true); + logger->log_partial (" when writing SVAL: "); + rhs_sval->dump_to_pp (pp, true); + logger->log_partial (" to LHS_REG: "); + lhs_reg->dump_to_pp (pp, true); + logger->end_log_line (); + } iter_cluster->mark_region_as_unknown (mgr, iter_base_reg, uncertainty); break; diff --git a/gcc/analyzer/store.h b/gcc/analyzer/store.h index f30b6bc8b2e..ee084dd81f3 100644 --- a/gcc/analyzer/store.h +++ b/gcc/analyzer/store.h @@ -787,6 +787,8 @@ class store_manager public: store_manager (region_model_manager *mgr) : m_mgr (mgr) {} + logger *get_logger () const; + /* binding consolidation. */ const concrete_binding * get_concrete_binding (bit_offset_t start_bit_offset,