From patchwork Sun Feb 11 20:07:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexey Neyman X-Patchwork-Id: 871794 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=uclibc-ng.org (client-ip=2a00:1828:2000:679::23; helo=helium.openadk.org; envelope-from=devel-bounces@uclibc-ng.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=att.net header.i=@att.net header.b="TFEOLxYz"; dkim-atps=neutral Received: from helium.openadk.org (helium.openadk.org [IPv6:2a00:1828:2000:679::23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zffx35VP5z9t3m for ; Mon, 12 Feb 2018 07:07:49 +1100 (AEDT) Received: from helium.openadk.org (localhost [IPv6:::1]) by helium.openadk.org (Postfix) with ESMTP id 6A45C10049; Sun, 11 Feb 2018 21:07:33 +0100 (CET) X-Original-To: devel@uclibc-ng.org Delivered-To: devel@helium.openadk.org Received: from sonic310-17.consmr.mail.bf2.yahoo.com (sonic310.consmr.mail.bf2.yahoo.com [74.6.135.253]) by helium.openadk.org (Postfix) with ESMTPS id 16C3910065 for ; Sun, 11 Feb 2018 21:07:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=att.net; s=s1024; t=1518379657; bh=9ixXASbtgcej29yuDRHAIuhd1M6bGj+yOm4Jn1gM9mI=; h=To:From:Subject:Date:From:Subject; b=TFEOLxYzj67wUF+njxxG8s4WEEmlB/QGbhm1FAoPvgKRh97lj/4Pk8aoksElJdpoe+NmCBbGS0GqUmnNX2i5LVYl9u5okZ7Sb4U+E69txLyMsOgSQeF6RmeabQW9NAchc2Ao8ctVEpkzTr3bUtE31C/7TK2Y6IN87AndhKOCVSw= X-YMail-OSG: 7HFnnLYVM1mYNqgzibNCp3hIMJrWBYReDNKkaTDNBgXfssHExxJBHFXov7lUN3j N8DudwpoX2IsDev0FObxGdc.a5cH0HDo6JP3JNgL48.AHKVxyd.SSMFOsVhloggbIc.CYPtGCLKH nQX2zVhBGKdcrzcgSedAKpijYzPnsJWr.I6wqLGRch.Gw8ETMcOjiMmvkATb2j5cU2nLO8pLA7by ryr_4.HxPX53GjojXXLuu8e6opbGC2gxrQU2SZ3CRTeq4oUNyL01yMYhgNyHGvuM7O2w0lM_RsWK 7CLlbA6bfoalDbojQ7876vC14OV5Qa6mMaeNhIqX_yx7aIvtNGn2Le8VW3WyRaMFnf6vRGdKcvQM MyhzoyMMDWGRItqbSN_5u9.t6acG3axtAV0bJQjLKSNF4ot8ancrZBii6Defpf4fiDic8mgx7k8m QIpPjBspviOPQphE.rH8oERCi8oWIXt1rmYvBe08U2iL3otz4kAO8r0lzOOVJwje9rTEMBEjrqmX vYRegeLzbdxQNH_dCtaIk7r4AkkLL1PzfYLo4 Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.bf2.yahoo.com with HTTP; Sun, 11 Feb 2018 20:07:37 +0000 Received: from smtp102.sbc.mail.bf1.yahoo.com (EHLO [192.168.0.33]) ([98.139.230.211]) by smtp416.mail.bf1.yahoo.com (JAMES SMTP Server ) with ESMTPA ID 9eb2359600ad3806882716ed735dba3f; Sun, 11 Feb 2018 20:07:35 +0000 (UTC) To: Waldemar Brodkorb , devel@uclibc-ng.org From: Alexey Neyman Message-ID: <29705dc1-6465-e49d-993d-6fe583c3cf24@att.net> Date: Sun, 11 Feb 2018 12:07:33 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 Content-Language: en-US Subject: [uclibc-ng-devel] Undefined reference to name_to_handle_at while building eudev X-BeenThere: devel@uclibc-ng.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: uClibc-ng Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devel-bounces@uclibc-ng.org Sender: "devel" Hi, I noticed a failure while compiling eudev against uClibc-ng 1.0.28 on aarch64: it detected name_to_handle_at being declared in the header but then failed to link because it is not implemented in uClibc-ng. Patch attached. Regards, Alexey. From 319583d37ce649221ca4ff48a0b194bdbbf2ace1 Mon Sep 17 00:00:00 2001 From: Alexey Neyman Date: Sun, 11 Feb 2018 11:59:22 -0800 Subject: [PATCH] uClibc-ng does not implement name_to_handle_at ... so don't declare it. Otherwise, eudev finds it declared and tries to link with it - and fails. Signed-off-by: Alexey Neyman --- libc/sysdeps/linux/aarch64/bits/fcntl.h | 21 --------------------- 1 file changed, 21 deletions(-) diff --git a/libc/sysdeps/linux/aarch64/bits/fcntl.h b/libc/sysdeps/linux/aarch64/bits/fcntl.h index 042ea947f..80657c008 100644 --- a/libc/sysdeps/linux/aarch64/bits/fcntl.h +++ b/libc/sysdeps/linux/aarch64/bits/fcntl.h @@ -242,15 +242,6 @@ struct f_owner_ex file to zeros. */ -/* File handle structure. */ -struct file_handle -{ - unsigned int handle_bytes; - int handle_type; - /* File identifier. */ - unsigned char f_handle[0]; -}; - /* Maximum handle size (for now). */ # define MAX_HANDLE_SZ 128 #endif @@ -315,18 +306,6 @@ extern int fallocate64 (int __fd, int __mode, __off64_t __offset, # endif -/* Map file name to file handle. */ -extern int name_to_handle_at (int __dfd, const char *__name, - struct file_handle *__handle, int *__mnt_id, - int __flags) __THROW; - -/* Open file using the file handle. - - This function is a possible cancellation point and therefore not - marked with __THROW. */ -extern int open_by_handle_at (int __mountdirfd, struct file_handle *__handle, - int __flags); - #endif /* use GNU */ __END_DECLS -- 2.14.1