From patchwork Sat Feb 10 21:07:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 871702 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zf4JJ07jCz9t2l for ; Sun, 11 Feb 2018 08:07:28 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752100AbeBJVH0 (ORCPT ); Sat, 10 Feb 2018 16:07:26 -0500 Received: from mout.web.de ([212.227.15.14]:33739 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751145AbeBJVHZ (ORCPT ); Sat, 10 Feb 2018 16:07:25 -0500 Received: from [192.168.1.2] ([78.53.150.195]) by smtp.web.de (mrweb001 [213.165.67.108]) with ESMTPSA (Nemesis) id 0LjaR6-1fHkGE1LPk-00baz8; Sat, 10 Feb 2018 22:07:18 +0100 Subject: [PATCH 1/2] gpio: omap: Delete an error message for a failed memory allocation in omap_gpio_probe() From: SF Markus Elfring To: linux-gpio@vger.kernel.org, linux-omap@vger.kernel.org, Grygorii Strashko , Kevin Hilman , Linus Walleij , Santosh Shilimkar Cc: LKML , kernel-janitors@vger.kernel.org References: <8ec31664-badc-5454-b759-ae9132833589@users.sourceforge.net> Message-ID: <86570340-688b-34ec-2d99-ff728ccbe4a9@users.sourceforge.net> Date: Sat, 10 Feb 2018 22:07:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <8ec31664-badc-5454-b759-ae9132833589@users.sourceforge.net> Content-Language: en-US X-Provags-ID: V03:K0:x912BX3jlKZbXPyyaQ3EU1+Ve5d4kFxS1YDzp8N/lgFfWMQNHhM qBdeGtliz9OYAsMEB0Curlk/YsDgFun3G+3lKaBhcAYGCk6H4HsxrPTjdg+wOEJLTQ3LFZy IjlPL73NMc6GClBHHY3iMu2p7bzva6IksQWpzxgTHvtAQlApl2ue6F2tXmvxdXeUppvUP6p pIaflihpFKz4jDDYYNeRg== X-UI-Out-Filterresults: notjunk:1; V01:K0:PHkCKHu3ZZc=:IcuwKM24hjbb2Sbh1+MTUn TW5zR3i5q8MtV1cl0Od5/EayGZRml7fc38JvyVA51T+mrMliMYh9oVrREsTkpj9f/gVR0Leph Bmgol1zrRzDHfPcsqC1hl1aL51qxl+oBK8SDbsT9YCO/mE4cson2Rwcnxii+tUNABUFratge2 cNpArIZFfzHW6L5F1yxMGQ8pjUHAuQh9H8YdmM/npNGfJkN8tRaUADsuVxkjo6J2qVhCEnM+v TpZaf4WrYpXsxppTOyPpAJwuLL+bhdkd74X3lfILJDZlBmwHGwSSNKmLCh4uKbyGgS9dh68LN r5tNnMUNqolGMQzxYHMXd1dOZPMljaoSaTGoCYtPxoQNxe+RQR0ONSENAc4f8cUqVgy7A04R/ A/XnMsYN8eXoPxINbP9n1bBkoCI5SadybOuoCQwYyGzv7LmRwDTQ65UB0JlZ9RgMqRqjExMWn yBZco3OLOc7btp15lokVAp7BtwrHKwZN5PLXUb05CqY/JIxc+RK/ft9Ig8csZ/xDq9NPCYdKt w6slzdMOxe3k4zBecTefoJm80Gg/nSAg/MpCKGhFxMBfS8MvTWGUNcVjkUKhlXbzBIQxyI8y9 hgV46pTWgZzKxCDNP0Gg8z6hw5iI2wO3UuNt5TFDmaQwgqMnA4fiTR+9aUkjSg130dd3eGHb1 gf2D9Dg/7h0blZNXcUFMxGBBwccALDt1UYTpq9IVlyuYVwaMEE9na28IAiwOkcvOktOs/eBps l4hudl4M/RjrJFH4a4Nchd9mcoCTg4aXTHGKoghG2kB5f8GTjNoXOctyo+OT5yOAg46yMyf/0 U541Lcj4Zkky/J9SCUt0+drA3qKRjO+5z6UjLFh4pwWicyAEe8= Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org From: Markus Elfring Date: Sat, 10 Feb 2018 21:46:30 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/gpio/gpio-omap.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c index ab5035b96886..4db6f13fa133 100644 --- a/drivers/gpio/gpio-omap.c +++ b/drivers/gpio/gpio-omap.c @@ -1158,10 +1158,8 @@ static int omap_gpio_probe(struct platform_device *pdev) return -EINVAL; bank = devm_kzalloc(dev, sizeof(struct gpio_bank), GFP_KERNEL); - if (!bank) { - dev_err(dev, "Memory alloc failed\n"); + if (!bank) return -ENOMEM; - } irqc = devm_kzalloc(dev, sizeof(*irqc), GFP_KERNEL); if (!irqc) From patchwork Sat Feb 10 21:08:28 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 871703 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zf4Kx1dbfz9t2l for ; Sun, 11 Feb 2018 08:08:53 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752519AbeBJVIh (ORCPT ); Sat, 10 Feb 2018 16:08:37 -0500 Received: from mout.web.de ([212.227.15.14]:44563 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752498AbeBJVIg (ORCPT ); Sat, 10 Feb 2018 16:08:36 -0500 Received: from [192.168.1.2] ([78.53.150.195]) by smtp.web.de (mrweb001 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MVtmK-1eDYmL2OXg-00X5fo; Sat, 10 Feb 2018 22:08:29 +0100 Subject: [PATCH 2/2] gpio: omap: Improve a size determination in omap_gpio_probe() From: SF Markus Elfring To: linux-gpio@vger.kernel.org, linux-omap@vger.kernel.org, Grygorii Strashko , Kevin Hilman , Linus Walleij , Santosh Shilimkar Cc: LKML , kernel-janitors@vger.kernel.org References: <8ec31664-badc-5454-b759-ae9132833589@users.sourceforge.net> Message-ID: <422a4c63-5ffc-2b40-4d9a-cf947d4af2fd@users.sourceforge.net> Date: Sat, 10 Feb 2018 22:08:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <8ec31664-badc-5454-b759-ae9132833589@users.sourceforge.net> Content-Language: en-US X-Provags-ID: V03:K0:ax4hthMaPQTzzjdJou8ZCtM1v1qqVKmYBRdn7poY8ecLVn4oXwE RzJDt3eGB0/TbHZpYlC6ICoo2V1pwJfQqvOBCHOOF88jpnSYuqA3GW8p0h0w6EIDPj+2cR5 qO3oDJGT91ahF3kf/mC5kGzrZmBs1pC34I4qxgl92VPqUZTt+nTKcF2smJO4nQ8jFTBNIzf ZpvS8zP5ctY3WQK6rip5A== X-UI-Out-Filterresults: notjunk:1; V01:K0:isfcWtWLal4=:mJcD+M+uo9B21pe0i3empd yu4Di+vgnxwDrc8fiy0rpkRkQsmiYl1PU6xOs5FZE5BIy7yxtXfoaSzsNaQlNuaLlS4WhBjxg elJgx9WP/+7/AnPnF4qAX710l1/n2Qv2yrpAWxo48W2Ug1z0iyvU2iscKOqQfserMPw8OJ0pb q6ASarIjK7uB7nM8LccrcQrCl7EEMOi6zee7t6a/pSkqljJ1XEpGF5pVtNPoD84jmCmOCZHZ0 8ZpKkhDKBsh4dN5rVMrSFBgGzh0fh3KRZIHAopkPIKmo3qwhiBD6c3Y3bs3eQgk91NGyHQZq7 d7NWZLG9RxBd+yxtm4Qp5CSMkW+lecmPBs2DLItSvQGX/5D0fvBbnAMudKaydP7B1GJGrst4Y J4hmfO5IhCMMMYvI53gpr9W2HYeAZQnvTeCsbyhC7tH8vl+Et9urhV0rZKThivK3lk3Ssqfe0 LG9JutDa5RHQf+3w58ykGsk+2fsaNViDdFOI3M/x6vy0jYToEQIROU7CgTwDQVd7RLnAY1OBJ IzXk3+8Ju7TVlqULSKdNMQdf/xlFrcuU1IP6ljUsiI71fcE8JYA3ArBaYGh6TT/QhbqAgE6c4 8zfWw+HKSeo8vLI2mlBAWJQhgYMbJtLOWVD5CI7O2QtziJ48CNc0cEYB/tQxeDsuY5cyHXDc3 w/BWQDdDj9H/WfKM+JSJVTKhFlOZybVjb1lO25pqllKjd9MDu/eeMgYe0wuT8NotTXZWrr1AW h5ut5sBr9tX+jWV6QkkttwC0pj3mw1ZLn+CowtPNQx+EJi3StVLLuwD2tUyZZhCSD4SH7DscW 7CQDSve+bG1DY2TSa8tr+KlA4AP+QKeDny5ezEuoZOFJjgc/jY= Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org From: Markus Elfring Date: Sat, 10 Feb 2018 21:49:22 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/gpio/gpio-omap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c index 4db6f13fa133..35971a341c40 100644 --- a/drivers/gpio/gpio-omap.c +++ b/drivers/gpio/gpio-omap.c @@ -1157,7 +1157,7 @@ static int omap_gpio_probe(struct platform_device *pdev) if (!pdata) return -EINVAL; - bank = devm_kzalloc(dev, sizeof(struct gpio_bank), GFP_KERNEL); + bank = devm_kzalloc(dev, sizeof(*bank), GFP_KERNEL); if (!bank) return -ENOMEM;