From patchwork Fri Feb 9 12:21:42 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Agner X-Patchwork-Id: 871375 X-Patchwork-Delegate: boris.brezillon@free-electrons.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nEr+0XX2"; dkim=fail reason="signature verification failed" (1024-bit key; secure) header.d=agner.ch header.i=@agner.ch header.b="TH7/6A3C"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zdDhh0n6Tz9s1h for ; Fri, 9 Feb 2018 23:22:12 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=g5rOEdgLyXH/oXyobRXnsy0DIv4UUDVu5lZCEzj+CJY=; b=nEr +0XX2FN9IqzqkmyQNwiU9HO86Yeb/7gfa/EqQMtIek1V1Lcvaj7Nd7LftLLK+G7/wLYO8m7PyXph/ V+isN/UWa8gixfzJVqHOjbg/rUez3VpywmfGEusOCacYICCG2vKfxtj+pYzo0kkT/9JpWTo0xb05X WaSurUet+XcIAXPt4qOG8otVbXc02fmhHS9rCHlig2gNftWyATDF8mxxAA/+hrhPQTGqW77v+FwdQ VQurLoJsNrE0qMV+0JjEd/rWic/i/pfWVdHAW1LeD8kkNvlzjH/UTWByQqHvOQEP49+L/zz9Ga6N7 +8p5jYA9Rrc5V1T0CJ9lqhzxA1RZqrw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1ek7gt-0005mA-1q; Fri, 09 Feb 2018 12:22:07 +0000 Received: from mail.kmu-office.ch ([2a02:418:6a02::a2]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1ek7gp-0005lc-JG for linux-mtd@lists.infradead.org; Fri, 09 Feb 2018 12:22:05 +0000 Received: from trochilidae.toradex.int (unknown [46.140.72.82]) by mail.kmu-office.ch (Postfix) with ESMTPSA id 5E84C5C0790; Fri, 9 Feb 2018 13:14:25 +0100 (CET) From: Stefan Agner To: boris.brezillon@free-electrons.com Subject: [PATCH] mtd: nand: vf610: set correct ooblayout Date: Fri, 9 Feb 2018 13:21:42 +0100 Message-Id: <20180209122142.13272-1-stefan@agner.ch> X-Mailer: git-send-email 2.16.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=agner.ch; s=dkim; t=1518178465; bh=R5gXdGzERSl/v3CrTCzKn31DENhWLelcT5QkE6gNIjY=; h=From:To:Cc:Subject:Date:Message-Id; b=TH7/6A3CK/z8AdnPO863PsuE0do8BzXklBzgbr+SLkFT0Ycu377WKBnHzmbABMkXfhkx1c4+fdVmLYctu0GKBshaNsSqyBOZ3QzBy6qyu/x71opyESLG/cSpH1PKQ6/wCOgNKFEVyqQ4KA8dr/Tm+vGsvqkxURIH61Wwna2e5VI= X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.0 (--) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-2.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: richard@nod.at, stefan@agner.ch, marek.vasut@gmail.com, linux-mtd@lists.infradead.org, stable@vger.kernel.org, cyrille.pitchen@wedev4u.fr, computersforpeace@gmail.com, dwmw2@infradead.org MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org With commit 3cf32d180227 ("mtd: nand: vf610: switch to mtd_ooblayout_ops") the driver started to use the NAND cores default large page ooblayout. However, shortly after commit 6a623e076944 ("mtd: nand: add ooblayout for old hamming layout") changed the default layout to the old hamming layout, which is not what vf610_nfc is using. Specify the default large page layout explicitly. Fixes: 6a623e076944 ("mtd: nand: add ooblayout for old hamming layout") Cc: # v4.12+ Signed-off-by: Stefan Agner --- drivers/mtd/nand/vf610_nfc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/vf610_nfc.c b/drivers/mtd/nand/vf610_nfc.c index 80d31a58e558..f367144f3c6f 100644 --- a/drivers/mtd/nand/vf610_nfc.c +++ b/drivers/mtd/nand/vf610_nfc.c @@ -752,10 +752,8 @@ static int vf610_nfc_probe(struct platform_device *pdev) if (mtd->oobsize > 64) mtd->oobsize = 64; - /* - * mtd->ecclayout is not specified here because we're using the - * default large page ECC layout defined in NAND core. - */ + /* Use default large page ECC layout defined in NAND core */ + mtd_set_ooblayout(mtd, &nand_ooblayout_lp_ops); if (chip->ecc.strength == 32) { nfc->ecc_mode = ECC_60_BYTE; chip->ecc.bytes = 60;