From patchwork Thu Oct 28 11:39:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefano Babic X-Patchwork-Id: 1547438 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20210112 header.b=H9dr2r2B; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2a00:1450:4864:20::23f; helo=mail-lj1-x23f.google.com; envelope-from=swupdate+bncbcxploxj6ikrbcey5kfqmgqe4d54s3i@googlegroups.com; receiver=) Received: from mail-lj1-x23f.google.com (mail-lj1-x23f.google.com [IPv6:2a00:1450:4864:20::23f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4Hg3Wd4xj8z9sRN for ; Thu, 28 Oct 2021 22:39:56 +1100 (AEDT) Received: by mail-lj1-x23f.google.com with SMTP id h5-20020a2e9005000000b00210d01099b3sf1513513ljg.17 for ; Thu, 28 Oct 2021 04:39:55 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1635421193; cv=pass; d=google.com; s=arc-20160816; b=vUhMvyct1aTnmYyVnyzUBmVQvG+QcTb4IKwPaCOHdGKGyUUGTKOWTOlc+kIP7fFFq/ HRy81mW3HIl/CISk5qeCHRMj62NrSS5Ne5z0TgqhqeGMwC+suupguSM12yyD/ZqFL9bK GOgP5E+9ehvxSYDcxqRxptfXp/powXfeY/vl+pci7v4mZ2bUZFX+ghO+O0BFOu2/Y+uB sbYcNZiYGMfcJ8QnbGpxZQscX0T8JMfDRjaRwpI0Ffei8XzU2s43E9bSjIEt8IiSGrY8 TPMo5GMwBBFo1R55iGe4IoC0kmjDsHbkSsf6lnRMFA23LaEs2pXg1DD4wqG9JWkz30LT nlEg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:message-id:date :subject:cc:to:from:sender:dkim-signature; bh=VS0/G2Su+sOF7MDf9xEmsjy7JLjORMCNFPQ+mdmozYA=; b=cH1vfq7o+7k2XxG3HWWj0jBOmQIVI1REMiDW31zqaHbDVdvkO96XxXXWVwX5X1HTg2 3Fbs6IH4p9kKIGjQPlpMcKUxV5yFgPoFRCWEsdHsas0OrAqEtxJrcseRhoz0TSGG1d5h 0kPXtPgGUVrCPf+FEcd/dPhSxedIeKe+e+rZoABbn/IfMFYdH6E9jx91la+AmdMKJAqx TS60m8YuQvs6KCC6rJedyvqIeLnWioJQ2LgJJh7IaGDicVVEFEM/0j3v5e7fC/TMlDkp LVZsQXYQMifQbrVFfIKd+j9BZm7Ok4VVQqrjdIzWcdM5hrfcS+R/cNEby1DsqD1FmXLb 9dWg== ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:mime-version :x-original-sender:x-original-authentication-results:precedence :mailing-list:list-id:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=VS0/G2Su+sOF7MDf9xEmsjy7JLjORMCNFPQ+mdmozYA=; b=H9dr2r2BihnA/8dmLIEAhzIvLLV6bx/VHoJRwpX8EpXerl4cB32CDuvSG8nOGyJwZ1 avgJAuJPpyYpiLFMv9HDrtUMMZfY7exSiJlowNcmMZbCO86XluX5JblDEihqEoV1uwxi P6ewnW5XwXvK1HPg9A/tCKO4u3ps1++tuRo9GyfW7ONoM2CEwMtp73P+8mGqx/iwPl0N IQc9Iefz3srGdUSxBB9zuvknqKz6YvBOGLwS60nnyxmohLopD9qbg4ko6r2uOJYfotFC kCxV17yfwgFxkcL695kJRcl020frbkXGhee3lZsIKRd0q6xjVeSpgaXl+SCHFribr/iI S8cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=sender:x-gm-message-state:from:to:cc:subject:date:message-id :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:x-spam-checked-in-group:list-post :list-help:list-archive:list-subscribe:list-unsubscribe; bh=VS0/G2Su+sOF7MDf9xEmsjy7JLjORMCNFPQ+mdmozYA=; b=QopILxxW/ZMOPWMvUEZBH3BQIbWi8r56TGbNmYUeKShRISVuFlBeUc9QXeIQgA06vl LGjaXiAZFNTXzVZJySAtortRXvAiDOAndbb5o/EkkBaCHdWFcuhzYgBOuI/Hm4ZBGKOo sNALRgS3cOAj9Wc5RZk+A3Z831A1zU4HLyuuGxN9K0FNUIKl9UJRRbUltFr4+wVr7whK EwBJMUuRdUJjsnXItcw0C+KUK+RYdmQaAj7ZyHvoyzDfIabnqY9H0lUlbseewiG84j+l ooyWj+Zp3ubknFixkBd+pXQvCl4AhfzEKhZ34hV5CrYdbyAd7n87qtR32d+WhUNADiWD yC/Q== Sender: swupdate@googlegroups.com X-Gm-Message-State: AOAM532CrqHTkMyKLKQ0bOHoM2qs/mMAp7jw0MRVmRkyahixRyAP7Flx j2moOEvt/hSqBqOqs3jr7ho= X-Google-Smtp-Source: ABdhPJx6HL0uvqeqf2ZIqrhhzqj6K4v3rtRzABnSJfNZlRMrnum6aaG0AJv1wzb5LroPTPeJ7oPHVA== X-Received: by 2002:a05:6512:3144:: with SMTP id s4mr3664957lfi.108.1635421192914; Thu, 28 Oct 2021 04:39:52 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com Received: by 2002:a05:651c:b1e:: with SMTP id b30ls559961ljr.9.gmail; Thu, 28 Oct 2021 04:39:52 -0700 (PDT) X-Received: by 2002:a2e:891a:: with SMTP id d26mr4211560lji.91.1635421191880; Thu, 28 Oct 2021 04:39:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635421191; cv=none; d=google.com; s=arc-20160816; b=YsNijoXv6okU7uTVaI444D/wPAj7xYsXxgDeQVCVnD1T90MY5qOZGb/I/5no+VSfHW UjpVsU3fNKkMqSsLPBnYrUKps2GNYiD6FH6BDV9JUwTciTxoNYFPWqF9QqO82h9Chl4n 02JdEyo10D/qQBBy1m1qPlm82t2ArgvrIbOdJuDlB+pAuTuAkMWnV3DjeIncrDdAfUBA k7j09YzpLUXCWfZnRy0cxc9zVzfjbE61MGt+55EKujjawwJXpJM9EPzDoonfaQoBpKOc uCD0nhs8i8N3GwtWlIvkGvqiB/2g6TaDYCIPFpJtOwtonito3WhYTaG8RtxQEhw9JOLn ei7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from; bh=HyiFqv82Kr056D7dijx+Mt5xrKEdEEJ73vo75OHH/y4=; b=P6iA3aNmHTACn8kzZ3qIF+gLX3JB5pcffG7sas3MNwJwu0EKu3Miqq1tLQenJLSukz KZN7n0806yMTwlyc8Visu5KAJXXJz9DojCwousYcd1wKaK4rGaxVRBlwIghA9WGbpSOP z1s6rvlibkaUG4IfUNiIAm6kUONKNExx/ehrfvRnXrUCp74qNI78FQPbIrpHuTXcm+qR rI72zXSPlrRYr6VsundWt5B/N31+eKHJ4+bQQvD6obFm5R6pHwL7lwhKRzzqB28j1/SU E5xe0EjyiyZjiN0aR/V/zyoZetZfpEMAsXwxto+uqhMl5SqBtkl0kIszPZ7G1dmD/Xd/ YzDw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de Received: from mail-out.m-online.net (mail-out.m-online.net. [2001:a60:0:28:0:1:25:1]) by gmr-mx.google.com with ESMTPS id v25si171538lfr.1.2021.10.28.04.39.51 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Oct 2021 04:39:51 -0700 (PDT) Received-SPF: neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by domain of sbabic@denx.de) client-ip=2001:a60:0:28:0:1:25:1; Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4Hg3WW1Kvjz1sDRD; Thu, 28 Oct 2021 13:39:51 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4Hg3WW0Qm1z1qqkB; Thu, 28 Oct 2021 13:39:51 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id C-u3pc0b7vX1; Thu, 28 Oct 2021 13:39:49 +0200 (CEST) Received: from babic.homelinux.org (host-88-217-136-221.customer.m-online.net [88.217.136.221]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS; Thu, 28 Oct 2021 13:39:49 +0200 (CEST) Received: from localhost (mail.babic.homelinux.org [127.0.0.1]) by babic.homelinux.org (Postfix) with ESMTP id 0560945412FF; Thu, 28 Oct 2021 13:39:49 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at babic.homelinux.org Received: from babic.homelinux.org ([IPv6:::1]) by localhost (mail.babic.homelinux.org [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id Z3URZQeT6ZPa; Thu, 28 Oct 2021 13:39:46 +0200 (CEST) Received: from paperino.fritz.box (paperino.fritz.box [192.168.178.48]) by babic.homelinux.org (Postfix) with ESMTP id 122F145412F1; Thu, 28 Oct 2021 13:39:45 +0200 (CEST) From: Stefano Babic To: swupdate@googlegroups.com Cc: Stefano Babic Subject: [swupdate] [PATCH] ucfw: drop support for old libgpiod Date: Thu, 28 Oct 2021 13:39:45 +0200 Message-Id: <20211028113945.2983998-1-sbabic@denx.de> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Original-Sender: sbabic@denx.de X-Original-Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , This is now obsolete and it makes no sense to support build with very old libgpiod. Signed-off-by: Stefano Babic --- handlers/Config.in | 12 ------------ handlers/ucfw_handler.c | 8 -------- 2 files changed, 20 deletions(-) diff --git a/handlers/Config.in b/handlers/Config.in index 14f8af9c..0dd899ad 100644 --- a/handlers/Config.in +++ b/handlers/Config.in @@ -304,16 +304,4 @@ config UCFWHANDLER comment "Microcontroller handler depends on libgpiod" depends on !HAVE_LIBGPIOD -config UCFW_OLD_LIBGPIOD - bool "Support older libgpiod version" - depends on HAVE_LIBGPIOD - depends on UCFWHANDLER - default n - help - The libgpiod library changed the api gpiod_line_request_output. - The old function was replaced by gpiod_line_request_flags_output - while the new one dropped "flags" from the list of parameters. - Rather there is no way to get this changes from the library - at build time. - endmenu diff --git a/handlers/ucfw_handler.c b/handlers/ucfw_handler.c index ea94486b..c4f31991 100644 --- a/handlers/ucfw_handler.c +++ b/handlers/ucfw_handler.c @@ -139,21 +139,13 @@ static int switch_mode(char *devreset, int resoffset, char *devprog, int progoff goto freegpios; } -#ifdef CONFIG_UCFW_OLD_LIBGPIOD - status = gpiod_line_request_output(linereset, RESET_CONSUMER, false, 0); -#else status = gpiod_line_request_output(linereset, RESET_CONSUMER, 0); -#endif if (status) { ret =-ENODEV; ERROR("Cannot request reset line"); goto freegpios; } -#ifdef CONFIG_UCFW_OLD_LIBGPIOD - status = gpiod_line_request_output(lineprog, PROG_CONSUMER, false, mode); -#else status = gpiod_line_request_output(lineprog, PROG_CONSUMER, mode); -#endif if (status) { ret =-ENODEV; ERROR("Cannot request prog line");