From patchwork Wed Oct 27 12:32:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Maciej W. Rozycki" X-Patchwork-Id: 1546906 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=embecosm.com header.i=@embecosm.com header.a=rsa-sha256 header.s=google header.b=PQIcPgrq; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4HfSl00WXKz9sXS for ; Wed, 27 Oct 2021 23:32:43 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1ED873857C59 for ; Wed, 27 Oct 2021 12:32:40 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by sourceware.org (Postfix) with ESMTPS id 51AE2385840D for ; Wed, 27 Oct 2021 12:32:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 51AE2385840D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-wm1-x32e.google.com with SMTP id 82-20020a1c0055000000b0032ccc3ad5c1so4187190wma.2 for ; Wed, 27 Oct 2021 05:32:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=zD+aToEPP54Zl7UlT7xBVl4WmShP50nVfplaeQrbnso=; b=PQIcPgrqpUJZ2vowBqn7tK/RPbAXJFmTJFpcU0xedbBwjfJaCfMpk5kS0NnL8W51+0 qdwZ8QKRUP6i0jnnQXXuGHK+upLl8iLPV5O2z6w5TERmRwvA6xbA+uIstaa0ed08aCQC cnDzVkc4EMW2wqebp1cvAJLnGtPXYazWd/iEhaM5VczcblZsbtg+92SECYbEJLuVYc9s Yq1N+gVOelSwB7mBl4CrphVMPGuy9Iq10SHGXGOCvt6Oa0KHpSQYTqGo7cqu7+PwdGme j4lvobMDrBH2yryRsFD7OueSQMq5rYQkIBIrksPnHdNQORq+0ifLGMksZfMF6GkVUEjP YBEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=zD+aToEPP54Zl7UlT7xBVl4WmShP50nVfplaeQrbnso=; b=3gWAEgKXtfdqlcRSpgC5kQuNYdNbafMnthVJ1PFiuW9m1gdfhiqyzTHcesGCzKv/1/ Xd0DYQQp/WAhMQ+OlO7GP8geu7SEC2Z7BxF/0CtwqjOnFg8POgia4FWwtkevbNp/EwqN r4yoxfXqJX5kDnYAqhdq+wx0cT+YdhVM5HLb1FCThgYkRRTV11mCWPjuyPMdXYsyYmIL /zz+MpY1OMP0d1cIQYshWSgwn7iT058Sp+z/UalDTvxVmYtslXvHKdxREH/Vkly2+rUD l90Fg0loyHBTv28z/WU/6TCKg5NQOh2OS7qCva8wznXp0RsktcH5bq+DWfoQc+1GjEot /1vA== X-Gm-Message-State: AOAM5302DKNYwsBqUufRqPh2xUGVODOTxudq8F0EIs0LjW1CYVjEjVxg Ik66L1qxKwSdpDUnBbnEMXeg6A== X-Google-Smtp-Source: ABdhPJwp0uUXdwuEEgFDZuHj7WsdT1nWPVlWwdEmxhrPUhJeMbNbFIUBcbuJiWEFxXx6AdYJoIN58g== X-Received: by 2002:a1c:6a06:: with SMTP id f6mr5544341wmc.153.1635337935325; Wed, 27 Oct 2021 05:32:15 -0700 (PDT) Received: from tpp.orcam.me.uk (tpp.orcam.me.uk. [2001:8b0:154:0:ea6a:64ff:fe24:f2fc]) by smtp.gmail.com with ESMTPSA id 6sm3530317wma.48.2021.10.27.05.32.14 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Oct 2021 05:32:14 -0700 (PDT) Date: Wed, 27 Oct 2021 13:32:13 +0100 (BST) From: "Maciej W. Rozycki" To: Jeff Law Subject: [PATCH] MAINTAINERS: Clarify the policy WRT the Write After Approval list In-Reply-To: <06b4937d-c1a6-1432-841c-8bb143a02b81@gmail.com> Message-ID: References: <6ffab241-1236-1fba-dea4-fb6643ad2d1b@suse.cz> <20211026190632.GB304296@tucnak> <06b4937d-c1a6-1432-841c-8bb143a02b81@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jakub Jelinek , gcc-patches@gcc.gnu.org Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" * MAINTAINERS: Clarify the policy WRT the Write After Approval list. --- On Tue, 26 Oct 2021, Jeff Law wrote: > > > It seems like there's been hardly any discussion about this matter > > > around > > > the time this stuff was added with commit bddcac9d1c32 ("[contrib] Add > > > contrib/maintainers-verify.sh"). What was the actual motivation behind > > > that change? > > That was only addition of a script and testcase to verify what has been done > > in MAINTAINERS since forever. > > Just look at all the commits to remove redundant entries from Write After > > Approval, e.g. > > https://gcc.gnu.org/legacy-ml/gcc-patches/2003-05/msg00366.html > > All maintainers or reviewers (global or specific) have write after approval > > rights for areas they don't maintain. > I went ahead and fixed Maciej's entries in the obvious way. Thanks. It did not occur to me that we had such a policy in place even before said commit, and now that I can see it is the case it seems to me like it has been a recurring problem with people not being aware of it, and I can hardly imagine anyone running the test suite for a MAINTAINERS file update. So while I maintain my concerns about the policy itself, how about this change, so that at least it's written down somewhere other than mailing list archives only? Maciej --- MAINTAINERS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index fe56b2f647e..1471f53d30b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -15,6 +15,9 @@ To report problems in GCC, please visit: http://gcc.gnu.org/bugs/ +Note: when adding someone to a more specific section please remove any +corresponding entry from the Write After Approval list. + Maintainers ===========