From patchwork Fri Feb 2 14:21:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 868592 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-i2c-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zXzgk0j5rz9sDB for ; Sat, 3 Feb 2018 01:21:38 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751708AbeBBOVg (ORCPT ); Fri, 2 Feb 2018 09:21:36 -0500 Received: from mout.web.de ([212.227.15.4]:50051 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751469AbeBBOVf (ORCPT ); Fri, 2 Feb 2018 09:21:35 -0500 Received: from [192.168.1.2] ([92.228.169.238]) by smtp.web.de (mrweb004 [213.165.67.108]) with ESMTPSA (Nemesis) id 0LzmLr-1emqxa2PyN-014yPH; Fri, 02 Feb 2018 15:21:33 +0100 Subject: [PATCH 1/2] i2c-sh7760: Delete an error message for a failed memory allocation in sh7760_i2c_probe() From: SF Markus Elfring To: linux-i2c@vger.kernel.org, Wolfram Sang Cc: LKML , kernel-janitors@vger.kernel.org References: <3f4a9053-5518-61ab-2cdf-e400f6b35ce3@users.sourceforge.net> Message-ID: <737fe7c8-9ae3-7e19-100a-f2f3d9f2b83a@users.sourceforge.net> Date: Fri, 2 Feb 2018 15:21:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <3f4a9053-5518-61ab-2cdf-e400f6b35ce3@users.sourceforge.net> Content-Language: en-US X-Provags-ID: V03:K0:68yC4l39mQkeA2y6/6WsFbkh8AIJiQvI6PXgx2Xzawn1d0JZpID n91t1i8sUfC37orngnOc8xIv6rzOKVDXx5HuKKw7/K1rHZNFqZhLkBZPIjniZsHs84STdxX QXUcPoH0d41P2CzgFFN7OSgFtD2DKowLfgLfuIqIDGlZ8jTrk5/7po8hp1YRUNYpPWRXYqU s8jqhwq2RBMZeGyZQNZiw== X-UI-Out-Filterresults: notjunk:1; V01:K0:rjdhrFLoA9I=:cMlJGV0j540GRk8VEWjNyU vnTs35hgC/reEgXAoPv6H8cWVLB4+TMeVwH4Tn04JVtYyQPp1PcXq3rDG7mjk/bjh7nCM16ba 2fjhyN+D/xyYgeFdUimcODXrU25Lf2g6Xuqub7NYbci88ePFE+5jPzrkTqGGH6SX+WmKrGOwW /pjuPtvC+mnK2ad9RYQ0+q7b80pW2HKOBTXNgO0cMOpd5gavOHCera0R3NOcWhSNFuc4TEslV GOjeFrVbJ69xdBU3UCy1kV2+vfEMwX48sXbtMPD4Yo0Eez/IQeIIo6arYYgYRYECfCEcpX02H Mw1TLOxAJXysjD7g2gqGwSAfCrYsiR/8qNdwWmG0y9pFVj054yNWROCes8F0j5ZMuiKLf4Y9X bfHQPsl28eZHGMrobZNNA1mlz5dZEGjG6QTxQOfn2V3Ub5slRhBtfkriTWo8YRcn/XrQArdpa Kxx/XiHQUbxWKfwoF1ZeW7HRPjSei7Gc+fe9bhpGjTHcpmUXASf3YFT0l5mWbvLRyGlustiSA s9shW1Gq6A+InFuDMQLH5icCypcwqsh2/MaXB/4UMI+pWEBHcizxrwSflVgBINrVQ9wZ6VskZ a9WRLF2gPyYr3BdGX8NfdBHDj4PiUHY8g/21WeaJZUYt/4DW0389sqtrUseYC0hvwQfP7qbiO QMn4eDoudTfAznvpqRQY8wnRziA24boE6RFBx7bnC1ubrZIe7awtwzVGs7nk5RFe9/5RR7CcV uvIrBV5vYkz6rjOtzo4fcWbxMl/hdXv+NVxHdW5zYTvb8OIVpIhojZGbCHFpYZzqCD4esxUZn 96hRSRMsr118ueCmVuAl7sIcZF4weJaSs54yJ8Y4IbPnccefko= Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org From: Markus Elfring Date: Fri, 2 Feb 2018 11:46:02 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/i2c/busses/i2c-sh7760.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-sh7760.c b/drivers/i2c/busses/i2c-sh7760.c index c2005c789d2b..4d2e4d10600b 100644 --- a/drivers/i2c/busses/i2c-sh7760.c +++ b/drivers/i2c/busses/i2c-sh7760.c @@ -445,7 +445,6 @@ static int sh7760_i2c_probe(struct platform_device *pdev) id = kzalloc(sizeof(struct cami2c), GFP_KERNEL); if (!id) { - dev_err(&pdev->dev, "no mem for private data\n"); ret = -ENOMEM; goto out0; } From patchwork Fri Feb 2 14:22:21 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 868594 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-i2c-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zXzjb4MqZz9sDB for ; Sat, 3 Feb 2018 01:23:15 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752229AbeBBOW1 (ORCPT ); Fri, 2 Feb 2018 09:22:27 -0500 Received: from mout.web.de ([212.227.15.4]:54640 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752191AbeBBOWY (ORCPT ); Fri, 2 Feb 2018 09:22:24 -0500 Received: from [192.168.1.2] ([92.228.169.238]) by smtp.web.de (mrweb004 [213.165.67.108]) with ESMTPSA (Nemesis) id 0M6xc5-1eu2TT0KAP-00wkhI; Fri, 02 Feb 2018 15:22:22 +0100 Subject: [PATCH 2/2] i2c-sh7760: Improve a size determination in sh7760_i2c_probe() From: SF Markus Elfring To: linux-i2c@vger.kernel.org, Wolfram Sang Cc: LKML , kernel-janitors@vger.kernel.org References: <3f4a9053-5518-61ab-2cdf-e400f6b35ce3@users.sourceforge.net> Message-ID: <51f963df-4ad0-22a9-5d27-67facfac7a27@users.sourceforge.net> Date: Fri, 2 Feb 2018 15:22:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <3f4a9053-5518-61ab-2cdf-e400f6b35ce3@users.sourceforge.net> Content-Language: en-US X-Provags-ID: V03:K0:kcDwTQnplwXRSwYbjjyNgYb687Tea6AXpSIgUAsNG9OEA2FIplr fjqaGh4x+9MIj/Ul4ij6Co2yJBgQnYw7+BKXozQSTtlAS2hvcr+MaCbdcQ11QCyS8LAc/yn DSiHpvCC65untEJacteunDR7tZ1821XzovJtaPiWYaeioYMkurAYL5N1CIN7FlTG7/0F2no vgD5Ru94HP257SuncXVmw== X-UI-Out-Filterresults: notjunk:1; V01:K0:i2Cj4pgUHqg=:Euxlk7N6xmF/KgIsL2kRCd MEkbGHOHTF4aJ7qHlxHxO6/NdPQD4r5mrCOZjNMTVDaJeMfQVa84Bk67sWvU471s1N6H7167f T4ST4SVw8QqFe3ILcjythUlFGZOuYmGLYuSonvHBSMzXKdKyuBvlI5Q8tF4Yre1pdHtVf4Cfs CSGz5tyUrf2/0aH6vfXF1BLoi3G0FOXEXEWmz5C0cCUseaFcn03ZnXhkbX8wOFpu0wCB9SsaF Gm4kcEAhxsB5ztLy47KXp8DLqmK3Fyh7AmRIiLxEW5VvIBqCuVNbTm7JsUhH7+BJBDjNPmy8b 2KI0P8LOVWvpCenbzw385Pbdl9XF/JanV9rpe/sZdXFIn9MH2/G79+VF++SX+tnBrr6mPAekf drE5O+/B8GtThgDK1reQXm12FbzmsCAGPUS7t+5mXJZ3+A7lhCE9IjSziYT8eYPoKLSy/0/pR /geDoWwjjtWojBEd0bIxBOZCv31kXapSvtHyrdu9BTaNcQZhy3oML+24o93k5T8wJezQGV77q Ov1W0R1tL6/vvr6E8nHP8rtLMnZhGcxvPGDrY+6j5Uce/rvxmuGthAne5Ya1uwto9Enz7xStE tk8qK7YTuwqvrmmVxgYlofOCEeip16VboMMOJ0BcMj7KBX5zxkySgBfZ+4I7ogO5rshfHx/Kq PxH+KR/iCMgc/lt/2Ey980tmx2K+GUuGAZqKSQKnyD+gqriUVUCPFZFBYY22YpajHdHdJAs4E sb6zdjs6PFPlOTKIqEZHUC8ZITXFge26nEuF20274GVpB1F4iZYp6aI9Q1pJtEbCVnHn9acpz Gx59ay3Jylk9//L/1EuPP2D5LiKKIEdmIL+sV2Cb37IFr56ks4= Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org From: Markus Elfring Date: Fri, 2 Feb 2018 14:50:09 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/i2c/busses/i2c-sh7760.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-sh7760.c b/drivers/i2c/busses/i2c-sh7760.c index 4d2e4d10600b..62bc23b9acbb 100644 --- a/drivers/i2c/busses/i2c-sh7760.c +++ b/drivers/i2c/busses/i2c-sh7760.c @@ -443,7 +443,7 @@ static int sh7760_i2c_probe(struct platform_device *pdev) goto out0; } - id = kzalloc(sizeof(struct cami2c), GFP_KERNEL); + id = kzalloc(sizeof(*id), GFP_KERNEL); if (!id) { ret = -ENOMEM; goto out0;