From patchwork Fri Feb 2 06:52:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rosen Penev X-Patchwork-Id: 868521 X-Patchwork-Delegate: blogic@openwrt.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PO6cHezH"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="VQgtQ0l8"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zXnjN28pLz9sRV for ; Fri, 2 Feb 2018 17:52:24 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:Message-Id: Date:To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=xYXWDeWDRJGjwP/tpb08iHkadsi1vaNkOLKodViRGCY=; b=PO6cHezH5ja+IZ vFBMPZUIVBqAvCPyqQNfyf1md+yEQ1FoIiRUbBlMdOUBTtp4VHwP9u0DjBo90NDL+Rin9VcnsrHon L8c4OK2XXxCOCONxllq622j3ga9gulFheEhjf4mcaQtFv/pJH/dn38CQ2b+WQQjO5sIGyWor/u1vn tlBish6hGIzIs9s3aoFADzVos77Xmr8gwhWPqCBVzuOJuABpYLvbbU/zNhuWjBsOA1poUfSxC0SgI MheMHkQ/iv/DvEfBpg0WaKf52aVObBApSLkVx8/CduxKo5MrEYFV5I45LSvVwQhQzD9tGO79o/l8S PclsF4BtBUJxGWSg6KSg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1ehVCr-0005dV-O5; Fri, 02 Feb 2018 06:52:17 +0000 Received: from mail-pf0-x243.google.com ([2607:f8b0:400e:c00::243]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1ehVCo-0005ck-RL for lede-dev@lists.infradead.org; Fri, 02 Feb 2018 06:52:16 +0000 Received: by mail-pf0-x243.google.com with SMTP id g17so2594515pfh.1 for ; Thu, 01 Feb 2018 22:52:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=vleNi/dont309qas27cz2dQNACddZyCOE17UU2ctUOE=; b=VQgtQ0l8fs4XyuIcp6kzkHQYCKcLvRCV5sf79KoKVZyWjcByZMRBz1HzHWOJ1T622c xlwG4uE/zOauvghdoV5wlrcZU2kZ7xA19g0jgMy5/wuGgabKEMIb+BgyTgS0Gc1inqlJ HGsEvr8TshBmCA/Xwkdh7qcnJZLrn17acXr0ZsVrUal3xhhGuzeoVb3jsxzdIgazT1Vs RYW95Ka0PMQ9qjFEfg8i+81iB/Pn90uXJ2oZP1rIXajG+RK0vMwrwvsXW/Yeluw8qa7C 78hXlqMS39gV6ivpXv9/S6uayVbueg3YDcwIMCcWH/Bo9hUT8HD//ju2/xvEu+2bTs0A TsGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=vleNi/dont309qas27cz2dQNACddZyCOE17UU2ctUOE=; b=iP+ViDZk6QZW4Y/IO22MYhYIzkJhvJoM7Zj6nMk/LnAfLKqa5d6mTDgMEPZPU4d014 UnjV1bTZHd/GmHAPqpSbYPFgrcKvKfafK4gOOZa9Cj18LwLs8np/6X1KhP+PWoZDAnS1 Q1rqxZxi6nbocr+coNuZ5MSFksueOi1NfMhIUobtPeuesa0lR+eor3pyACGKohINCRx4 N1NTb4nUifIDhg9naRCbVfjpgtYUqBrg9f83mHLWi+2PJ9Hfx+7cREZK3htSlN53OzkV gtXAxIR1S8fRSXy6GQzgO+qVCgI482MOPk953I61/vg4aUDeOw0q+Fz7pfE2duNaztFu LgBw== X-Gm-Message-State: AKwxytfJWdH77NXH2JW2kBcatf5a5T+uKIOuEt8PUFgX78ce6mi0WAxZ aa9WVsgKcllY5yzzoyqHD7JOeVr3 X-Google-Smtp-Source: AH8x22512FC89di7RH+nAsBGaGaIfPPEaSYFTnkQ55fmhADX86QMNGexG5uI+rcKM5NU9mPiOM7YGg== X-Received: by 10.98.54.71 with SMTP id d68mr38968808pfa.173.1517554323509; Thu, 01 Feb 2018 22:52:03 -0800 (PST) Received: from DESKTOP-CEH0M93.lan ([2001:470:1f05:c3e:96a:11bb:b21e:8a77]) by smtp.gmail.com with ESMTPSA id o82sm1421635pfj.73.2018.02.01.22.52.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 01 Feb 2018 22:52:02 -0800 (PST) From: Rosen Penev To: lede-dev@lists.infradead.org Date: Thu, 1 Feb 2018 22:52:11 -0800 Message-Id: <1517554332-15236-1-git-send-email-rosenp@gmail.com> X-Mailer: git-send-email 2.7.4 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.0 (--) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-2.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:400e:c00:0:0:0:243 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rosenp[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain Subject: [LEDE-DEV] [PATCH 1/2] libubox: Don't warn about sign comparisons. X-BeenThere: lede-dev@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rosen Penev MIME-Version: 1.0 Sender: "Lede-dev" Errors-To: lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org -Wsign-compare was breaking my builds when i disabled MIPS16 on ramips (mt7621). Since this will probably not get fixed, disable it. Signed-off-by: Rosen Penev --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 57804cf..0449a59 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -3,7 +3,7 @@ INCLUDE(CheckLibraryExists) INCLUDE(CheckFunctionExists) PROJECT(ubox C) -ADD_DEFINITIONS(-Os -Wall -Werror --std=gnu99 -g3 -Wmissing-declarations) +ADD_DEFINITIONS(-Os -Wall -Werror --std=gnu99 -g3 -Wmissing-declarations -Wno-sign-compare) OPTION(BUILD_LUA "build Lua plugin" ON) OPTION(BUILD_EXAMPLES "build examples" ON) From patchwork Fri Feb 2 06:52:12 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rosen Penev X-Patchwork-Id: 868522 X-Patchwork-Delegate: blogic@openwrt.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PvGmzcyO"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="schTX+Oc"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zXnjT4PpQz9sDB for ; Fri, 2 Feb 2018 17:52:29 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:References: In-Reply-To:Message-Id:Date:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WQj0LeyYBAtFncZdYtaapuynq0IlubgPsXeRe9hRNrk=; b=PvGmzcyO0O9317 UNIlIJosMhqj3J46k8Key2q1UlrS5G5mlCgFF2HmmViaWt2kjaw66Pt3x2RVil2cwG11y4jMrHF9l GY8Q0naMfFwqOvagcETjMYIuJxJia7w7UwzUEEmlQ7ZvNcDg08AzYe5md/QZitM1NU5bMsN82B1rQ 5VrBq5nQYlH5BW51+wi8gtgb4OVw8zxpnQCMLuN6ecTE6/RcmoZNVKRUbrIPqkoBcDIUKEo9sh3hU rdgSQWV8nhb4GhChafOg8jEhl/eZA1okZF8H7bpI4X+e6BhzsYZIGerYeA518epPrWiSoGbETpFdr su4LhefjBUJukYB/WfYw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1ehVCz-0005kV-0r; Fri, 02 Feb 2018 06:52:25 +0000 Received: from mail-pl0-x242.google.com ([2607:f8b0:400e:c01::242]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1ehVCq-0005cl-AB for lede-dev@lists.infradead.org; Fri, 02 Feb 2018 06:52:17 +0000 Received: by mail-pl0-x242.google.com with SMTP id f4so5476360plr.10 for ; Thu, 01 Feb 2018 22:52:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=euPrDIzmNRfaUSwUCTDCxx2sk3FuwHox2ime48+g9Ps=; b=schTX+OcNAtL9wfvxBxufM1sve6yDcdP9KWsNtuBmMzh7XARWwPaIKzMivKFba08od RqgWwIJY2+u90EBr4Jq06cFHbQYl/i+Lj9bpYQGzAuHOVHPssRzXQgPK9Vp04FZ1n6E4 LQOwZUDCLnAhWyi9eMZQJPnfxwIciSU/FRm1S38iU2tq5Tk6fNGUhCgPrJAY3qjWWoe2 /yscLdHj15pvtBZjHystKKkDgsnbYaXJOwcHtEVKsClLF0PbqDtZr+6FRLxkOwmP9iX2 3iUneHXa9wykNpSHMeshHilmlhbi6g79TLMw0udv34qu4j9LIF9NO90/ifVWuDZa+wIC /d8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=euPrDIzmNRfaUSwUCTDCxx2sk3FuwHox2ime48+g9Ps=; b=W3XjRpKhKVoU7qBcyYMeE+2gPo9mBWhIaGFuKw+T9ROJFQVVOKny3XK7QVbudWvYtF vgHDEWhSbdvexbEFRRHzSaXRvl2XUESqQ2oGeBr3924MuQd4JD5HlRQiTqtHNny5Uq6q YPyVbQaaUPO3s2im7qpeQHHsiIhmbb38RE5CN0BcML5QWyhRJeMSUQAnfpNmZhUJthIA bgHLPsnDUeo7bJRsk5C4tTzMpujJAkO1PIUCEpcGJNRCNbL5twR9xwJNx7wq8YQsEvGx toc9d+0Cj6vh0cMOHyOodeVyq7PZg2+SQX5LhDUtUc5aXevawWBAf/x84Iiis/QMhey9 55KA== X-Gm-Message-State: AKwxytfCDu6MGbueNZJ8Nxg6gwFr1RTV3WSq1IKEEw+K4JqtDOItLErX 8JFDqj1UozwQL8sIyc6sVhTh08/D X-Google-Smtp-Source: AH8x227m4/+VfFk0+ZRUsMx7AwZp+Tt+C0JtHA0jjvSfU8KWgrRDnBkVBnBxvVVzmULuUhoYtyOkjA== X-Received: by 2002:a17:902:15a8:: with SMTP id m37-v6mr10119498pla.186.1517554325025; Thu, 01 Feb 2018 22:52:05 -0800 (PST) Received: from DESKTOP-CEH0M93.lan ([2001:470:1f05:c3e:96a:11bb:b21e:8a77]) by smtp.gmail.com with ESMTPSA id o82sm1421635pfj.73.2018.02.01.22.52.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 01 Feb 2018 22:52:04 -0800 (PST) From: Rosen Penev To: lede-dev@lists.infradead.org Date: Thu, 1 Feb 2018 22:52:12 -0800 Message-Id: <1517554332-15236-2-git-send-email-rosenp@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1517554332-15236-1-git-send-email-rosenp@gmail.com> References: <1517554332-15236-1-git-send-email-rosenp@gmail.com> X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.0 (--) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-2.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:400e:c01:0:0:0:242 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rosenp[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain Subject: [LEDE-DEV] [PATCH 2/2] libubox: Plug a small memory leak. X-BeenThere: lede-dev@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rosen Penev MIME-Version: 1.0 Sender: "Lede-dev" Errors-To: lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org va_end was not called if calloc fails. Signed-off-by: Rosen Penev --- utils.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/utils.c b/utils.c index 765dd8b..c22250d 100644 --- a/utils.c +++ b/utils.c @@ -47,8 +47,11 @@ void *__calloc_a(size_t len, ...) va_end(ap1); ptr = calloc(1, alloc_len); - if (!ptr) + if (!ptr) { + va_end(ap); return NULL; + } + alloc_len = 0; foreach_arg(ap, cur_addr, cur_len, &ret, len) { *cur_addr = &ptr[alloc_len];