From patchwork Wed Oct 6 14:11:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Storm, Christian" X-Patchwork-Id: 1537168 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20210112 header.b=neqCBkPb; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2a00:1450:4864:20::53c; helo=mail-ed1-x53c.google.com; envelope-from=swupdate+bncbdd6bwv65qpbbzo462famgqed266f3q@googlegroups.com; receiver=) Received: from mail-ed1-x53c.google.com (mail-ed1-x53c.google.com [IPv6:2a00:1450:4864:20::53c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4HPbvw3j7Cz9sP7 for ; Thu, 7 Oct 2021 01:10:52 +1100 (AEDT) Received: by mail-ed1-x53c.google.com with SMTP id d11-20020a50cd4b000000b003da63711a8asf2721884edj.20 for ; Wed, 06 Oct 2021 07:10:52 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1633529446; cv=pass; d=google.com; s=arc-20160816; b=Ut3b1AgrHwmid2jBTcI5k9Pe4V3uDKZcvADsZ2avCEU2EH/udOm85wgOsv8SsHjPyh yFJ962XyvvzEbyJYIz4Kddg8M/Gd8f+GZqVMH3WQH2bXKqnAlpS9AiacZTCC6dqs0vMl e/dHdXoyVYIsh5NoqAY7PO5htjSa0ouy1mwyE8fjdnERcHsZLgDWKSFHvvkCltMpqXZ6 3KesBVLqjx36/RjHCLcMiEmTIkwb2hcwbXBZcc40Z+zQcqQeV84ScJ+hopdlaxGuVjXa 8Wz41cqUE5sGGlRGJFh9KqpIP3+ZfFV/s0xAj+KnGAZw6Vv4DSrmFxo6LpF8bQW8ovmy XKqA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:message-id:date :subject:cc:to:from:sender:dkim-signature; bh=w6jS+WEEM4Z8JZ+V6FJrOwNB8Z1SZYXa3U+NDwVmSjg=; b=YtsYeDDMoZKwbEltTrIGVZ3QFsTqzSBYiqplCtmyObKeU5+FoxU+dX6RFeL8LRZVFL nxTphbr10dVhwyTQLQdrrdxvfqorv/KEobMpXJ7GefIVUugrH3ok0DMMnTe/EeJjR6+I 03cka267fhSppoH64K3Y3R32JpgCY9QRzXPeR1RNIgFsnDDHEES2TK30H7lx0sfwV3ii IbhFYIxPyyQihL7CvNCCYvurZE7quLhxSVjaJ6BPycsPFyRdwHhWapyUztFmyktzPndA 1PtmEXHG9O+G3Bun5XPQHK8EF1ohQ5bjk4AeIyGYk70jPe7x1v1kRC4fg/M6WnyOUrlA BkJA== ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of christian.storm@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=christian.storm@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:mime-version :x-original-sender:x-original-authentication-results:precedence :mailing-list:list-id:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=w6jS+WEEM4Z8JZ+V6FJrOwNB8Z1SZYXa3U+NDwVmSjg=; b=neqCBkPb9VMwNcdtmRXXldqte/+3ir/0MLTqGqrnHygvztYRPFhtVHpPynCistRIVN QOZ1BwWqsyNXINFaRw9pG0uYSFZ+0QlSVpSMV6+rV+Hgy19dMYY6Y+CsnexTpKOTprkS DhRZoMsdYnVJT6yGQJ3+QSyM55HkPvfqR7+A3bIDwazX116iuRcvbZDMbPHlTpnbGTJn WKyxr4WQq9KxZlBwcywaWfGsCpLe7GDYGL054MHcqepWFdJ7C1OS3ofCGC6hdpiKiFPg BD52ieyyXuT2giuST+W4/ncCpIzs9AR3VPMMng/Y0R2D4dM2kABtL1yQVfktC+lcQt+C Xo9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=sender:x-gm-message-state:from:to:cc:subject:date:message-id :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:x-spam-checked-in-group:list-post :list-help:list-archive:list-subscribe:list-unsubscribe; bh=w6jS+WEEM4Z8JZ+V6FJrOwNB8Z1SZYXa3U+NDwVmSjg=; b=utprTdbDURLThksMlybUVWHrXl4FZHqzvm/nx5Ey+b1jW7/LRWrOg1KOPMsdnFwb69 1gLW1dJOgX5Z1LFdIdrqogro8ej1Pr03Iaf/oI291ObXh7gG7WHt28It1U4gR2KhuAxL MFDEtpmgsD8/1QH/gXd1nkx53J8MlAAIganFxtH0h61ihyfEK/lu/+1682NJb5jbhz7i IVWvhf2xtNmZF9oiV3Woo/alZmaiwnkCsRkLkutE28fL43uuKohqaWqsvDQEL372Kdgu y23iUR0YRfqfnrRMnHyAxnNr55ErMhNrjnbHMy2AZU8c8nrmwOQsiUft/o4IKImKKLf6 Ph+A== Sender: swupdate@googlegroups.com X-Gm-Message-State: AOAM532MV3YGKnmFlhNe3PCdmDzcXxnh+AnmKuteMuptV/cy/ll99AUy LwEaUcJAHEPQuLGMQvfKXrs= X-Google-Smtp-Source: ABdhPJwb5ZQw/2285dy5JFb6/nm945eVquMFHxZ0ojAW/NLX/YHtgJGhn6qHzVaTHEvFzBaGuVAu5g== X-Received: by 2002:a05:6402:40d0:: with SMTP id z16mr6482620edb.220.1633529446037; Wed, 06 Oct 2021 07:10:46 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com Received: by 2002:aa7:c944:: with SMTP id h4ls104674edt.1.gmail; Wed, 06 Oct 2021 07:10:45 -0700 (PDT) X-Received: by 2002:aa7:dd90:: with SMTP id g16mr31988777edv.199.1633529445231; Wed, 06 Oct 2021 07:10:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633529445; cv=none; d=google.com; s=arc-20160816; b=oZ/gR2Loy8IlxbMHkxrl509/XlUDIYBd1SC/hah3RQnIz1PJBDOXMzBJpa/j788yVl sYPnXJe299uju5AJ/05k0N/jCAOdS3JIq6M2MQbVU9fVe3uAyWRdu6cOO3mAPXqnmSvo Z7ln/pCplx0fVUcKVYzcxJ/INryji4ZsuCebWNIMoLYgH3m/oH0GxMriUcIvGL1/0zjr zZD8pifpQKDr8rPMTeZjLdBaBdc9p9t8VpaCjdPZXTiYDAxEC67NL60jGnbyjCkQfN11 A2zQmo6iA6Q9kVUm9lc/uEQwCsv5bgrv1uWrLCE00XWApfv4gaVPpSmzTx1mqMwZj7IK CL+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from; bh=BDdhMNB6yO9UEr0J68GZdFYjNy4Pna9sRhpsh4SJaHc=; b=bajU4zFDi0ka3SG3L7YsCPCXWuiNm3LgtW41uNRKKk0XZGM1+8gbzF/enBpkWT2WlQ Mbhw8kvXv18u85jdWOI0AuzyYe6oB8+f9wszgnii4pBQV+kUho53Mv4AEv4Mt0Cv2dXF AO/5Jvc5+PVQ1jl3I2IW/euV9N+f2Vy9qXqA2JLRsFjrnCSodJrOW7g1tNgb9OxighAs KT2lolnMahsh3oJGJlMGfoU8iTePGqdk5bL2jyfHsmv6Z+LW+68uVPR6u+MMYjy1w5lc DEYTS5mGsqJk3fiRbqQvheVHk8Pxt3rNL9vqUL0LKgl8xZNQdeh3g9kfjJQe5+5o1acj I50w== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of christian.storm@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=christian.storm@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id zh8si1500919ejb.0.2021.10.06.07.10.45 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Oct 2021 07:10:45 -0700 (PDT) Received-SPF: pass (google.com: domain of christian.storm@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Received: from mail2.siemens.de (mail2.siemens.de [139.25.208.11]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id 196EAilU012065 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 6 Oct 2021 16:10:44 +0200 Received: from MD1ZFJVC.ad001.siemens.net ([167.87.33.85]) by mail2.siemens.de (8.15.2/8.15.2) with ESMTP id 196EAi4L031124; Wed, 6 Oct 2021 16:10:44 +0200 From: Christian Storm To: swupdate@googlegroups.com Cc: Christian Storm Subject: [swupdate] [PATCH] channel_curl: Remove leftover comment after 859be4a Date: Wed, 6 Oct 2021 16:11:44 +0200 Message-Id: <20211006141144.114905-1-christian.storm@siemens.com> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 X-Original-Sender: christian.storm@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of christian.storm@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=christian.storm@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Commit 859be4a "channel_curl: Add ability to define a set of custom HTTP headers" splits header handling for sent and received headers. This comment was only meaningful prior to this change, so remove it. Signed-off-by: Christian Storm --- corelib/channel_curl.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/corelib/channel_curl.c b/corelib/channel_curl.c index 91e8d56..c3ea3f7 100644 --- a/corelib/channel_curl.c +++ b/corelib/channel_curl.c @@ -600,12 +600,6 @@ channel_op_res_t channel_set_options(channel_t *this, channel_data_t *channel_da } if (channel_data->received_headers) { - /* - * Setup supply request and receive reply HTTP headers. - * A LIST_INIT()'d dictionary is expected at channel_data->headers. - * The dictionary is modified in-place with the received headers, - * if any, by channel_callback_headers(). - */ if ((curl_easy_setopt(channel_curl->handle, CURLOPT_HEADERFUNCTION, channel_callback_headers) != CURLE_OK) ||