From patchwork Tue Sep 12 10:16:27 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnaud Charlet X-Patchwork-Id: 812755 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-461902-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="F66a3VEM"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xs11B2rFCz9s0Z for ; Tue, 12 Sep 2017 20:16:46 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; q=dns; s=default; b=FwYx5shjagpQrdjVfZxW6E2bMWnYG+Nnz3p616IKDQaFKw2H8/ v+cGVBHDPW76Xf6zffOymNK2eyM2t4CdqU1phBq3pIb+wcFdrTc+JVcZgQA0KKxK L1gBRFr+BNRQgK2ShHxdnXA+DcuPymr3eS3yyzCfiZL6PAGDzg6uW53Zc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; s= default; bh=ynfpkty3b/qzIrwSlQ1NaT3+ZMo=; b=F66a3VEM3s+GtNSj3f6h L2WG18wkO71erLxeC7p+Jqw+bE7kjMrcLqHxoGdvGMSCph+RPU/xqTQJvHHAHGtb vMWHGXx8ZNzsbhGdz1DaIQOUswwwYpQNbN+5dPf78fzLR2B5n1vUlWmP7pp+nSXl B/+DObH9i2IO/acvrz/W+SM= Received: (qmail 18443 invoked by alias); 12 Sep 2017 10:16:30 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 18347 invoked by uid 89); 12 Sep 2017 10:16:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 12 Sep 2017 10:16:28 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 5AA1756169; Tue, 12 Sep 2017 06:16:27 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Pz2JhzlWCk93; Tue, 12 Sep 2017 06:16:27 -0400 (EDT) Received: from tron.gnat.com (tron.gnat.com [IPv6:2620:20:4000:0:46a8:42ff:fe0e:e294]) by rock.gnat.com (Postfix) with ESMTP id 4A4F656106; Tue, 12 Sep 2017 06:16:27 -0400 (EDT) Received: by tron.gnat.com (Postfix, from userid 4192) id 49614521; Tue, 12 Sep 2017 06:16:27 -0400 (EDT) Date: Tue, 12 Sep 2017 06:16:27 -0400 From: Arnaud Charlet To: gcc-patches@gcc.gnu.org Cc: Javier Miranda Subject: [Ada] Enforce check on wrong usage names in aspect definitions Message-ID: <20170912101627.GA9726@adacore.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) The frontend does not report an error on aspect clases defined in the public part of a nested package that reference names defined in the private part. After this patch the error is reported on the following sources: pragma Ada_2012; with Ada.Text_IO; use Ada.Text_IO; procedure Small is package Pack is type T is tagged private with Constant_Indexing => F; -- Error private function F (Obj : T; S : String; Pos : Positive) return Character; type T is tagged null record; end Pack; package body Pack is function F (Obj : T; S : String; Pos : Positive) return Character is begin return S (Pos); end F; end Pack; use Pack; V : T; begin Put (V ("abcd", 1)); Put (V ("abcd", 2)); New_Line; end; Command: gcc -c small.adb Output: small.adb:7:14: aspect must be fully defined before "T" is frozen small.adb:7:35: "F" is undefined Tested on x86_64-pc-linux-gnu, committed on trunk 2017-09-12 Javier Miranda * sem_ch3.adb (Analyze_Declarations): In nested package declarations that have a private part enable missing check of the RM rule 13.1.1(11/3): usage names in aspect definitions are resolved at the end of the immediately enclosing declaration list. Index: sem_ch3.adb =================================================================== --- sem_ch3.adb (revision 251998) +++ sem_ch3.adb (working copy) @@ -2676,14 +2676,11 @@ and then not Is_Child_Unit (Current_Scope) and then No (Generic_Parent (Parent (L))) then - -- This is needed in all cases to catch visibility errors in - -- aspect expressions, but several large user tests are now - -- rejected. Pending notification we restrict this call to - -- ASIS mode. + -- ARM rule 13.1.1(11/3): usage names in aspect definitions are + -- resolved at the end of the immediately enclosing declaration + -- list (AI05-0183-1). - if ASIS_Mode then - Resolve_Aspects; - end if; + Resolve_Aspects; elsif L /= Visible_Declarations (Parent (L)) or else No (Private_Declarations (Parent (L)))