From patchwork Wed Jan 31 23:02:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cong Wang X-Patchwork-Id: 868094 X-Patchwork-Delegate: pablo@netfilter.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netfilter-devel-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="OMX3JM1P"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zWzLn5bcLz9sR8 for ; Thu, 1 Feb 2018 10:03:29 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753979AbeAaXD0 (ORCPT ); Wed, 31 Jan 2018 18:03:26 -0500 Received: from mail-pf0-f196.google.com ([209.85.192.196]:46783 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753778AbeAaXDQ (ORCPT ); Wed, 31 Jan 2018 18:03:16 -0500 Received: by mail-pf0-f196.google.com with SMTP id w69so724784pfd.13; Wed, 31 Jan 2018 15:03:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=6e7zPxb0bdBNiLLITAV6LnzdWYPxrMxtZ3OVAl44dsg=; b=OMX3JM1PzalKbUBz1YpeE9wOOVe329nbYGVj/I3UNJIGV5nIie1JscjCzfU9UJlTnB YacbvgcIQbW91fZwK7dcspj1G+nWH2b9b7XelnFy3ZJFE2+DiOx09xPbJQGIcp9xHK4I UjXei4Q807ZKwCnUAfaFQEzS4lSNnANizwXLLgUbdYifaK4JclCJa35WvyGW66BE3zLF ZGXxxDdgXgPNWRkl2e+mIk5c9R5hvp8+kMyI+3tS5pAtdHLtK+kfRDCXInTZxIG2ICLL cZCrl7Za4vq9abcz0NcVVCo+0NskXzeQ4BQ4z8lBlIbS72xENaOr20UAfM9XRrVQnZ4h GtoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=6e7zPxb0bdBNiLLITAV6LnzdWYPxrMxtZ3OVAl44dsg=; b=BrNjHYv+FcYklmqIkOO7xtMpxKdz2D9/hm5CAvrkvDVQdy0Fei0F8QSIoaVmUC5CAZ 5btKfs90VE3dJLNRnwU2QoyremDwZk4UWweRxh4RqxjvGdODDCrGCGVa9xJ5megxKQ7b lYPT+cOqwVss8e2RV0zzy3TSHTnxb7kksW/mYc5UG4CEubB7mv5H28DBTMHgZg6wtruK Dc3qu3rNSByvkYY9DL2nPKWL0t5p7iZHCVIBucIGbt5HyVzrrQo4uhtMx+vlVUOFcG1j tK7fIhOobrltUhyXYoQqtVMpsp7iFqdj2AAR7HPYV15kocsAYIZIZxH9ft7JeZ6rAVi3 QfPw== X-Gm-Message-State: AKwxytfPq9LcWa5LRmHNmTwuyPqvLDFP/dpx1vVXwJLPVk8rDMNtT4Rn lTZ3zBevqLKOqLWqz3LPQ4zojYN/ X-Google-Smtp-Source: AH8x226vI0XiW1nTITxbzqT8qA+UIBmOrJoOtJTrgyXucttTe3d1tcbEscIYAuTAnnfzcF2UODE65g== X-Received: by 10.98.7.207 with SMTP id 76mr34335529pfh.130.1517439796049; Wed, 31 Jan 2018 15:03:16 -0800 (PST) Received: from tw-172-25-30-113.office.twttr.net ([8.25.197.25]) by smtp.gmail.com with ESMTPSA id u26sm46166903pfk.126.2018.01.31.15.03.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 31 Jan 2018 15:03:15 -0800 (PST) From: Cong Wang To: netdev@vger.kernel.org Cc: netfilter-devel@vger.kernel.org, Cong Wang , Pablo Neira Ayuso Subject: [Patch net] xt_cgroup: initialize info->priv in cgroup_mt_check_v1() Date: Wed, 31 Jan 2018 15:02:47 -0800 Message-Id: <20180131230247.1417-1-xiyou.wangcong@gmail.com> X-Mailer: git-send-email 2.9.4 Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org xt_cgroup_info_v1->priv is an internal pointer only used for kernel, we should not trust what user-space provides. Reported-by: Fixes: c38c4597e4bf ("netfilter: implement xt_cgroup cgroup2 path match") Cc: Pablo Neira Ayuso Signed-off-by: Cong Wang --- net/netfilter/xt_cgroup.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/netfilter/xt_cgroup.c b/net/netfilter/xt_cgroup.c index 1db1ce59079f..891f4e7e8ea7 100644 --- a/net/netfilter/xt_cgroup.c +++ b/net/netfilter/xt_cgroup.c @@ -52,6 +52,7 @@ static int cgroup_mt_check_v1(const struct xt_mtchk_param *par) return -EINVAL; } + info->priv = NULL; if (info->has_path) { cgrp = cgroup_get_from_path(info->path); if (IS_ERR(cgrp)) {