From patchwork Wed Aug 25 09:34:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Burke X-Patchwork-Id: 1520583 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2a00:1450:4864:20::53e; helo=mail-ed1-x53e.google.com; envelope-from=swupdate+bncbcvlvqx7qegbbqe5tceqmgqeznfeolq@googlegroups.com; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20210112 header.b=MtFcl3pL; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=f58598qu; dkim-atps=neutral Received: from mail-ed1-x53e.google.com (mail-ed1-x53e.google.com [IPv6:2a00:1450:4864:20::53e]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Gvgn15vqTz9sSs for ; Wed, 25 Aug 2021 19:35:00 +1000 (AEST) Received: by mail-ed1-x53e.google.com with SMTP id b8-20020a056402350800b003c5e3d4e2a7sf1029776edd.2 for ; Wed, 25 Aug 2021 02:35:00 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1629884096; cv=pass; d=google.com; s=arc-20160816; b=FOYbow2MxiWGN3fDWRi8ZyVXuYk8ls1uQIRtuJHO+skns/effbKvrsaYah2/6hPJvw V5xvcp+Dm+4DSHmS8h3ncABXjF6bb+fxPxFFFaYAlHIMVxorLxo2iOo7mzN+Kmz0IVBH 6GDRaid8bgvPGEwVTTBI9+WWz90A8dJIMjdNSHDynJPpy8/pTCJyAhiKrA3dC5Xe5yGa ztAd3xJZqQpHbAmZ/yXtZsTfi+KC+9GhiQFo6dp855eZ+AMwh+V/kGG4JvyAHAkBcJod piRXlFrwuvvR63fxiOvkMvU51V4sSOmSsNj+Q4Gyvn86rwSBRo7EGsY8mEwBDJsVA/I1 Jn/Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:message-id:date:subject:cc:to:from :mime-version:sender:dkim-signature:dkim-signature; bh=09IrJkrUKpFt4/tLrFWJNyCSWATXc0psvs47ZAGvsO8=; b=nw4k4f72sw7DWPQDXc7jyLCVONnEUMBj9J2axitZg+2Vsuo5ewPxXyn5WFiXS1kAgs QS1qEDA9ud1RNVV7h/jxKacNAIOgRRO0kkd+jA7Up3GJeYCxOtk0FfF3s2fJ66js+tTZ qtnuGwvrQVBbVi7nxBm7YVeJwN5FH5bhqZpA2dLOZjE4CHpiT1hvnAECGGP4ZivSHgcr 9JrN0e4wbmJc70AmnoF8dwWxkVcQ49IyW697cLOKMqSIEEiV9SNtmtoenX8t1sx0eX1J 2SUlYc8yd4h8bk/t9AHdn7n7qcS+k5Sz++BLGStiys+J/Fs5e5taBqJCqzZKO2+SkeM7 mQ6Q== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Njrj+FQI; spf=pass (google.com: domain of rich.g.burke@gmail.com designates 2a00:1450:4864:20::42c as permitted sender) smtp.mailfrom=rich.g.burke@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20210112; h=sender:mime-version:from:to:cc:subject:date:message-id :x-original-sender:x-original-authentication-results:precedence :mailing-list:list-id:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=09IrJkrUKpFt4/tLrFWJNyCSWATXc0psvs47ZAGvsO8=; b=MtFcl3pLovYxXfCIc6exQjGh0UwrynAWq8Op64igwQerWrLIyfXvYs8WgJFFw72lRh k4FwGRtpbM4tR6TFxMCJ8exhEHKjEgQSsSvv2P1i6vMWMJxMJaHcBSxmnUcG6ej6HzqS PJuXzElEiFO0Ys+fe43AiY9kyX1mC0ivfPMc2eLRaQZIBj+GAgTjBe/AacaNVCEw/QYc E05uV98ws8g0UNzkDjWLdRxWcMLCbDwOaKn43/W/X2LEcdwj+RWubh1rlX+5hHGz6Nxg +75svxI0RDriguR1EjeUKlj0EUZoeBH6Wyo0FF9t4HtjSSNgLuhXTMAyAZqy8b1UoKX1 YhgA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:to:cc:subject:date:message-id:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-subscribe:list-unsubscribe; bh=09IrJkrUKpFt4/tLrFWJNyCSWATXc0psvs47ZAGvsO8=; b=f58598qu8TMzw+SJe5aigcVVnenXSJaf9vn3+GMSqGOV8r1hpMQ5lQcq0c0ksmjncd NDUHz4XOFIvRWhOSMNbsxj+yDKFGS5zVtxljKNRmBMWT4sly6aYfoYVEVgGw4cI86SRK UxvZznMIWrz+Goo6brCF4t7NkGvSQdHFYDw4XnFW/BJ53Pisrh9QM3DVnLxX1U4K3Cft VH1umNgzPXiG3/cXd/8/dD9L/+bDWpKJ7jBMF23Y9kauczQOdyb1Y8LOUaVvPtd4lF3J TAIEFhhb8uY6aGbuLwr8VEwTcE4xCFBEckwKPLKkhyNQsmZlDpRjkdnLGDADzx/IZcMc M37Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=sender:x-gm-message-state:mime-version:from:to:cc:subject:date :message-id:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:x-spam-checked-in-group:list-post :list-help:list-archive:list-subscribe:list-unsubscribe; bh=09IrJkrUKpFt4/tLrFWJNyCSWATXc0psvs47ZAGvsO8=; b=QHbdvzrF0N5yOf1XxdcgFWMrvbSyUbxagC9TJzgKZN6tN9v7U6awJ0R83LQ7kJ0ALS j5HwcHVUUJpm4W4zic+I8A5rfXqcQDYELVoKvcf6D/g+hC4N+mcN39i2SxqdYw5AGdqq 3rrLxzj8qPvS7FpG2B9FiHuQAUB8+fX8rlz+wOeboHXEBauE2Rn1Hu+KFgFv2UwZfKqH ELHlaYtTzfPnAWf2fDKERsrFLtFG7uITgzQdSN1bG5/48zjYdX2Yy/w0IgKx6IkxAefc xkwOxyq66rEJ1ML2xKqk5aMUGib2CqL+fNMy4OlCBqmcQjypq6ncOXpV4WgJebBCxRMK iHxQ== Sender: swupdate@googlegroups.com X-Gm-Message-State: AOAM531eYx46bD3d1dN6lorrR2vowTjp6wZ/F4oFRUjWOd6VRwdgBZ1H +HAYJ0Z+w0IeDNfUP9GZPo0= X-Google-Smtp-Source: ABdhPJw9sNPuUCeLQgsRzGMpzShHTB7s6TX+dCnaFM4LN6bJKJnssOEkLZMw/5fTfDYS9vLMW8zAaA== X-Received: by 2002:aa7:cfcb:: with SMTP id r11mr19874002edy.14.1629884096679; Wed, 25 Aug 2021 02:34:56 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: swupdate@googlegroups.com Received: by 2002:a17:906:35c9:: with SMTP id p9ls823827ejb.0.gmail; Wed, 25 Aug 2021 02:34:55 -0700 (PDT) X-Received: by 2002:a17:907:2721:: with SMTP id d1mr2646847ejl.24.1629884095656; Wed, 25 Aug 2021 02:34:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629884095; cv=none; d=google.com; s=arc-20160816; b=XON2ZYu/28MOU/Jlofo4GlCzwPc7MlY7/U1a8WwCbf5gqVe8fG2UqoMh3nsUeHEYxx EnC402E9PoQK4NsdWqo4Kl/bcLkx6uIkQ66Bp+WEVPkmp4Qv8Ge8lNmhV44/+2MHERdD GX+CMb5VeohOikLJOC4FawYH+hFj2zFFKWAC3Snou/C/NVC5do2NCMcpT/1OvBOBUVv5 yy/8icwHlfRtUtX05wVvh1Eg17pz/Pm5RV84rJl983Kdabc+16iL0hpy71cLTtUJx6pR Ypz95LFzGjRIGTuEwmrlpqbJyGDi15HjYcoLQsEmuKC1js9SLQpE82oCZ+AijJ8b/WN7 W3lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:cc:to:from:dkim-signature; bh=BDTRW2L29xV23LbxTznfPrd8IGobSCn2taPUutQJzHM=; b=ZSLgY4rtNgZ1KoNDfcqjYw1LnnUQlaCyIYuJdZFCxZl/CJK3kyOyUzD7kwbVNxxlxV YhrTDxM67mNK2S5X5blrXpfdSaMFnzZM3Z6pPCfxbQ8dKl8ZzTj8mCIQkkQYXz6YU0Hb nq3mfaM5B5+ehEA0ST+aQtDFR/A7YejffCTfvrsW9M7aPqEkbqyahTZHT21J1QfqFMEL PnKW9s4xGPwIxKxf8ctMjf/yPcmHY6I6vjjyQPVJvF7wpM4Ew9aObV4M65HsQUP1Tos7 3BHM6Q0FY2Rao5V9Kqc5TqqihQdQC4Xh0wJ+/JvrCq8lsREW33PeV9kqRBgZTHX47uhE g9SQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Njrj+FQI; spf=pass (google.com: domain of rich.g.burke@gmail.com designates 2a00:1450:4864:20::42c as permitted sender) smtp.mailfrom=rich.g.burke@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com. [2a00:1450:4864:20::42c]) by gmr-mx.google.com with ESMTPS id 24si1382291edv.4.2021.08.25.02.34.55 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Aug 2021 02:34:55 -0700 (PDT) Received-SPF: pass (google.com: domain of rich.g.burke@gmail.com designates 2a00:1450:4864:20::42c as permitted sender) client-ip=2a00:1450:4864:20::42c; Received: by mail-wr1-x42c.google.com with SMTP id d26so15059693wrc.0 for ; Wed, 25 Aug 2021 02:34:55 -0700 (PDT) X-Received: by 2002:a5d:58c8:: with SMTP id o8mr14008897wrf.361.1629884095290; Wed, 25 Aug 2021 02:34:55 -0700 (PDT) Received: from ip-172-31-9-123.eu-west-1.compute.internal (ec2-54-78-17-143.eu-west-1.compute.amazonaws.com. [54.78.17.143]) by smtp.gmail.com with ESMTPSA id v5sm20997100wru.37.2021.08.25.02.34.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Aug 2021 02:34:54 -0700 (PDT) From: Richard Burke To: swupdate@googlegroups.com Cc: Richard Burke Subject: [swupdate] [PATCH] fw_printenv: return non-zero status when uboot env doesn't exist Date: Wed, 25 Aug 2021 09:34:51 +0000 Message-Id: <20210825093451.6286-1-richard.burke@hivehome.com> X-Mailer: git-send-email 2.17.1 X-Original-Sender: rich.g.burke@gmail.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Njrj+FQI; spf=pass (google.com: domain of rich.g.burke@gmail.com designates 2a00:1450:4864:20::42c as permitted sender) smtp.mailfrom=rich.g.burke@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Match the behaviour of uboot fw_printenv by returning a non-zero exit code when a specified env variable doesn't exist. Signed-off-by: Richard Burke --- src/fw_printenv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/fw_printenv.c b/src/fw_printenv.c index c457b30..5534a2e 100644 --- a/src/fw_printenv.c +++ b/src/fw_printenv.c @@ -146,6 +146,7 @@ int main (int argc, char **argv) { } else { for (i = 0; i < argc; i++) { value = libuboot_get_env(ctx, argv[i]); + ret |= (value == NULL); if (noheader) fprintf(stdout, "%s\n", value ? value : ""); else