From patchwork Tue Aug 17 02:01:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Osipenko X-Patchwork-Id: 1517481 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-tegra-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=erVnpZgP; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4GpZ6K5tpPz9sSs for ; Tue, 17 Aug 2021 12:02:17 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233438AbhHQCCr (ORCPT ); Mon, 16 Aug 2021 22:02:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233394AbhHQCCr (ORCPT ); Mon, 16 Aug 2021 22:02:47 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EAB46C0613C1 for ; Mon, 16 Aug 2021 19:02:14 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id i28so11589171lfl.2 for ; Mon, 16 Aug 2021 19:02:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LeDUZerYgs0/VRyn6Vbc3mu8D8SEh6Gle5d+UtLhMUo=; b=erVnpZgPdz0Cy7RoxFgipeGYgGcmWFIZirHU2Yk4K7PY6mna1YszI5U80zIgc98RLd vC8K0TfqnJvLWnvy8Soo0VFS6/9k0e8F6tA9qHxnGXUG2ZzQyW7Daag1X1nMMcxudKuF NRoEdf5nrRKOrErz1duotOlt5J6nhWtiHU/+Ps6bQcjhpNMkrlBPnM/Qws7WNzxEWerv xbXemK9jxt+gLLgRdCn3gG0hXFqEj22GSuUXkwnBj/9GdaIgUSz4Mbpl5b+ejDZMFtsX h6kD2adhiS9WizUTw1PkgQT2hFheMzDPjdpQGh8JvWtzpCmWqx4GEBkv9gWC4rajAInn Sp0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LeDUZerYgs0/VRyn6Vbc3mu8D8SEh6Gle5d+UtLhMUo=; b=rplafQ3Qd6kqbVDNO/epTW9zdNyxivNm4Mpup+4jcxNZYV1fapLiYCnhb5Oc5DP9fR 6hvF6Ijsk8ojH/eLhl07Dp9Xgq3qJdOnA+Qi5rnsppdm2jBUIBTIiHxLQNsJ+0FrA8Xb FsY2m+NOysFjtq6VdaahlN69KCaTv4fexbFZl7bQMYEjghxKnzf9QQzUp6NmznXDwEbM QsEAc5ij45WvpxMkiu/jo4d64BUmGM7MvN8tjCzHopwtWUqyLqM7PSP0S8+KQcRlcb/D mjYST/WLYW9+TUGqPdRvGTTf9A8P9HZSkiFI7CxsMi9asiYx/kO77XJLnEg9TIXiRxUG HyGw== X-Gm-Message-State: AOAM530f6tk4wU84boYiMxjwswom0KsBy09KS0208TMgZbVV5IVjn/yU 11/MKklmrRfSoKwiI9828BQ= X-Google-Smtp-Source: ABdhPJzYaXnJVVykD6dXfLHQucjLE9tpup4cVMAKU8bG+LamEsyXCVKCBt2Z/pt9EtUeqkJuA+IC/A== X-Received: by 2002:a05:6512:ea4:: with SMTP id bi36mr562765lfb.414.1629165733349; Mon, 16 Aug 2021 19:02:13 -0700 (PDT) Received: from localhost.localdomain (46-138-85-91.dynamic.spd-mgts.ru. [46.138.85.91]) by smtp.gmail.com with ESMTPSA id i24sm51729lfc.293.2021.08.16.19.02.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Aug 2021 19:02:13 -0700 (PDT) From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Mikko Perttunen Cc: dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org Subject: [PATCH v1 1/3] drm/tegra: dc: Remove unused variables Date: Tue, 17 Aug 2021 05:01:51 +0300 Message-Id: <20210817020153.25378-2-digetx@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210817020153.25378-1-digetx@gmail.com> References: <20210817020153.25378-1-digetx@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org Remove unused variables from tegra_crtc_update_memory_bandwidth(). Fixes: 04d5d5df9df7 ("drm/tegra: dc: Support memory bandwidth management") Reported-by: kernel test robot Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/dc.c | 3 --- drivers/gpu/drm/tegra/dc.h | 6 ------ 2 files changed, 9 deletions(-) diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c index 16c7aabb94d3..a29d64f87563 100644 --- a/drivers/gpu/drm/tegra/dc.c +++ b/drivers/gpu/drm/tegra/dc.c @@ -1845,7 +1845,6 @@ tegra_crtc_update_memory_bandwidth(struct drm_crtc *crtc, bool prepare_bandwidth_transition) { const struct tegra_plane_state *old_tegra_state, *new_tegra_state; - const struct tegra_dc_state *old_dc_state, *new_dc_state; u32 i, new_avg_bw, old_avg_bw, new_peak_bw, old_peak_bw; const struct drm_plane_state *old_plane_state; const struct drm_crtc_state *old_crtc_state; @@ -1858,8 +1857,6 @@ tegra_crtc_update_memory_bandwidth(struct drm_crtc *crtc, return; old_crtc_state = drm_atomic_get_old_crtc_state(state, crtc); - old_dc_state = to_const_dc_state(old_crtc_state); - new_dc_state = to_const_dc_state(crtc->state); if (!crtc->state->active) { if (!old_crtc_state->active) diff --git a/drivers/gpu/drm/tegra/dc.h b/drivers/gpu/drm/tegra/dc.h index f0cb691852a1..40378308d527 100644 --- a/drivers/gpu/drm/tegra/dc.h +++ b/drivers/gpu/drm/tegra/dc.h @@ -35,12 +35,6 @@ static inline struct tegra_dc_state *to_dc_state(struct drm_crtc_state *state) return NULL; } -static inline const struct tegra_dc_state * -to_const_dc_state(const struct drm_crtc_state *state) -{ - return to_dc_state((struct drm_crtc_state *)state); -} - struct tegra_dc_stats { unsigned long frames; unsigned long vblank; From patchwork Tue Aug 17 02:01:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Osipenko X-Patchwork-Id: 1517482 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-tegra-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=do/TU6ch; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4GpZ6L1gxvz9sSn for ; Tue, 17 Aug 2021 12:02:18 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233394AbhHQCCt (ORCPT ); Mon, 16 Aug 2021 22:02:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233470AbhHQCCr (ORCPT ); Mon, 16 Aug 2021 22:02:47 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F6D2C061764 for ; Mon, 16 Aug 2021 19:02:15 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id d4so38224081lfk.9 for ; Mon, 16 Aug 2021 19:02:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=epNIxrUppPqeTZ7mqYHZ01PA0yMU2Orit2VrfzLmV54=; b=do/TU6chvs8vMTkbDooRR2le11a6dh31qQVCxAc7wOduy19pmJbPiDhCLSTW07+CiQ lX1UHH+momYHwEekQWF3+aDYU1DQ0RDhN/1yb57l3/MoXLQ4etTEOP8O8ae2lW4AL+Za /Ig741ScZy8GeVujaRJFJl1byQr4c0qhzuTIcVYJXj3ZIUlMMV33AdJGfFaVp/35T9Z3 tLafaUFFsxgE8Ulj2u3UGa1E0VsRWGioUkpZb2KmZTpyjp593sml9+CxDqgkcDkHz7PF kqXCCJ2qSOebx4BN7sn/BIN967CvGzUVYuiVUzk063GET/0akxTM9iiSpfRNlLzKhfcU OYqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=epNIxrUppPqeTZ7mqYHZ01PA0yMU2Orit2VrfzLmV54=; b=tvquA1aHZiaN9mdSFzgMhZGpiafQeKv8oJiRX5sIUCc0cqgewNSsW46KljZh83Yxy9 oLlR8m+sG75Dya6t7ESHXi+nObbPGA2SWYBleB7F2sfDG0b7DpsOxC3AEXYLcfTvRaxA wW6m1/uC33A70qyYTbc/7Wtte3OhqPdyJeN3ZzPfW7SeI2+FIjCqBT6GOMASNkev6eym G3X1yXBrLBzLByDJTMJUVFD8YBQNjx59IryJfUsXCvPmCEFOOIzd0gUrDBExHl6ODrKS jAAsIh4lDAJ25YknhGA5NWbl/RhhjCt6qbT68K4T46g7EIflx3aapCgi51I3QQgMarng CDdw== X-Gm-Message-State: AOAM533LWTTFzUMISZQeUe++oX/+9KHnkEUBgu5BkX0ErcyUkeg7FPLX Q8VrMDHY9Q5B0Mpyagyz7tY= X-Google-Smtp-Source: ABdhPJwkJ2gDPVNWO4IqYvAkxmWMhu2XsrbQEMpDkRgki8Oh4US6ZUSIQkq7gq/j1HoSU2SPC5P74Q== X-Received: by 2002:a19:760b:: with SMTP id c11mr577972lff.224.1629165733949; Mon, 16 Aug 2021 19:02:13 -0700 (PDT) Received: from localhost.localdomain (46-138-85-91.dynamic.spd-mgts.ru. [46.138.85.91]) by smtp.gmail.com with ESMTPSA id i24sm51729lfc.293.2021.08.16.19.02.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Aug 2021 19:02:13 -0700 (PDT) From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Mikko Perttunen Cc: dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org Subject: [PATCH v1 2/3] drm/tegra: uapi: Fix wrong mapping end address in case of disabled IOMMU Date: Tue, 17 Aug 2021 05:01:52 +0300 Message-Id: <20210817020153.25378-3-digetx@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210817020153.25378-1-digetx@gmail.com> References: <20210817020153.25378-1-digetx@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org All jobs are failing on Tegra20 because it doesn't use IOMMU and mapping function uses size of mapping that is zero instead of BO size, fix it. Fixes: d7c591bc1a3f ("drm/tegra: Implement new UAPI") Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/uapi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tegra/uapi.c b/drivers/gpu/drm/tegra/uapi.c index dc16a24f4dbe..690a339c52ec 100644 --- a/drivers/gpu/drm/tegra/uapi.c +++ b/drivers/gpu/drm/tegra/uapi.c @@ -222,7 +222,7 @@ int tegra_drm_ioctl_channel_map(struct drm_device *drm, void *data, struct drm_f mapping->iova = sg_dma_address(mapping->sgt->sgl); } - mapping->iova_end = mapping->iova + host1x_to_tegra_bo(mapping->bo)->size; + mapping->iova_end = mapping->iova + host1x_to_tegra_bo(mapping->bo)->gem.size; err = xa_alloc(&context->mappings, &args->mapping, mapping, XA_LIMIT(1, U32_MAX), GFP_KERNEL); From patchwork Tue Aug 17 02:01:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Osipenko X-Patchwork-Id: 1517483 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-tegra-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=fs4uFuIA; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4GpZ6L3zTxz9sSs for ; Tue, 17 Aug 2021 12:02:18 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233470AbhHQCCu (ORCPT ); Mon, 16 Aug 2021 22:02:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233523AbhHQCCs (ORCPT ); Mon, 16 Aug 2021 22:02:48 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16A14C0613C1 for ; Mon, 16 Aug 2021 19:02:16 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id c24so38236200lfi.11 for ; Mon, 16 Aug 2021 19:02:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EHlZUQ8HgfGWcfinu2oIDpWpJRbCk6Twh3QjNslqYr8=; b=fs4uFuIARdGUUvUr5JtczJnktriIqQUMwKz1TctsMb3X59FdX2FyyqpMPnbxuG9mU8 CCic+poj7/DHmq8geyAiaUFaJRNrJNX5wmCdWAlsNbmWKQt7noAgNMhzbkfU6aDXHret EL13+/Q00KfmL9OpSOmMIjDOrxKLBx6PuuRA5Hl+K4d1UxSlcI2grgK71XdRkw8vToo4 nl11MBwRuReJh8LoGJ2MPD+GEfGoqRFyYEVDTCdNH4W7V85uGjWRaqYEoiYJ3IlNH0q3 Mo9YaSS+PkOsUzpKG6UAlpVr7j6Vzj/VGJmLheXFj99c4bPyTAqizk//I0eYcHX+MpC2 CVGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EHlZUQ8HgfGWcfinu2oIDpWpJRbCk6Twh3QjNslqYr8=; b=s++w73Ux7KoQN0LXyGtaXMwojYiEpnhGILB3rWE+dLjVJZzRSJ0GaIBfXEdyi2WVAp qnEROPu1kzlmrgGkREOmxGW/KfgyBRWm0rBCdhyuWbuvwXOVtS7oCvrlN+6CW08Nh0c3 dDcxJi05sR+h1eMlGCbmUWoyxYR95ugPc1V67nJuTlF2ppU2RK+GH1VScvWROxQEtSZR i28yLvsNEzS/ApZU7hH9RzlS2jCmP+wshruMC18AHJIj9NjtiiFoViqdnJZlJY8jXzfw 6c/jK5UvTt13akybEqgotRBpUd3mJiiWnPshzAfREcE4/13hdbJgs8dPPPP4J7lE4Jrm CE3g== X-Gm-Message-State: AOAM533/3EUrQqbjt0wxLLMKOu+IMfjDkBfS4lgWN362kyl6VoQClatK i9+Fy1Z1qTi65wfgoD+HMdE= X-Google-Smtp-Source: ABdhPJzVZANJW5iSs1X4gKiIvuAT2ZlwwoV9fug2MkAnjpXJYzhlQGYByLpQ6vPcTb80NGpOsNFyzg== X-Received: by 2002:a19:e00a:: with SMTP id x10mr615907lfg.536.1629165734488; Mon, 16 Aug 2021 19:02:14 -0700 (PDT) Received: from localhost.localdomain (46-138-85-91.dynamic.spd-mgts.ru. [46.138.85.91]) by smtp.gmail.com with ESMTPSA id i24sm51729lfc.293.2021.08.16.19.02.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Aug 2021 19:02:14 -0700 (PDT) From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Mikko Perttunen Cc: dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org Subject: [PATCH v1 3/3] gpu/host1x: fence: Make spinlock static Date: Tue, 17 Aug 2021 05:01:53 +0300 Message-Id: <20210817020153.25378-4-digetx@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210817020153.25378-1-digetx@gmail.com> References: <20210817020153.25378-1-digetx@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org The DEFINE_SPINLOCK macro creates a global spinlock symbol that is visible to the whole kernel. This is unintended in the code, fix it. Fixes: 687db2207b1b ("gpu: host1x: Add DMA fence implementation") Signed-off-by: Dmitry Osipenko --- drivers/gpu/host1x/fence.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/host1x/fence.c b/drivers/gpu/host1x/fence.c index 6941add95d0f..e49083b0b09e 100644 --- a/drivers/gpu/host1x/fence.c +++ b/drivers/gpu/host1x/fence.c @@ -15,7 +15,7 @@ #include "intr.h" #include "syncpt.h" -DEFINE_SPINLOCK(lock); +static DEFINE_SPINLOCK(lock); struct host1x_syncpt_fence { struct dma_fence base;