From patchwork Thu Jan 25 15:43:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 865930 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-i2c-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=codeaurora.org header.i=@codeaurora.org header.b="HbRpHwgY"; dkim=pass (1024-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="SjTVClyd"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zS5tK1rnMz9sNV for ; Fri, 26 Jan 2018 02:43:53 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751247AbeAYPni (ORCPT ); Thu, 25 Jan 2018 10:43:38 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:38026 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751176AbeAYPnh (ORCPT ); Thu, 25 Jan 2018 10:43:37 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id ED978608CB; Thu, 25 Jan 2018 15:43:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1516895017; bh=e8YfBmm6TIM7WLXsrVCQ6AZQ1lmcyrm5BW+Mw2KU2Bc=; h=From:To:Cc:Subject:Date:From; b=HbRpHwgYo4kW1NMngw/rdKgiQ5W2PP+NPLSBBnelxKTyd8yQsk9Cg6bGyupgd58wx GFiqY0FtW62U1SUtUyJp9NR+wB8koDElIM0K/B1ZsdusKeWjDOKOzpm1XSoOxd7Zjx aGZqgaPZkjIeYMCImUyxlWLi5Ark0WzUS0mvtQWY= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED, T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 8921360590; Thu, 25 Jan 2018 15:43:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1516895016; bh=e8YfBmm6TIM7WLXsrVCQ6AZQ1lmcyrm5BW+Mw2KU2Bc=; h=From:To:Cc:Subject:Date:From; b=SjTVClyd/vvFlVzdxoB6MCot+2adnQnDUEQrmBHjgkrQ76AkuFxXImnT6yHwzQJ+h VzzuXoELm+IXllRu0irdPGZ8Tev/WpvXx8K8nGK4wGdvgvF2I2F5DdBtSGf+HERkv3 Zsc9PLyNcCBe+3LxwO0uRTXLpkjtXFGDGAZsHxbg= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 8921360590 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org From: Sinan Kaya To: linux-acpi@vger.kernel.org, timur@codeaurora.org Cc: eric.auger@redhat.com, hdegoede@redhat.com, mika.westerberg@linux.intel.com, wsa@the-dreams.de, linux-i2c@vger.kernel.org, rjw@rjwysocki.net, Sinan Kaya , Len Brown , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v3] ACPI: Force I2C to be selected as a built-in module Date: Thu, 25 Jan 2018 10:43:31 -0500 Message-Id: <1516895011-17588-1-git-send-email-okaya@codeaurora.org> X-Mailer: git-send-email 1.9.1 Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org From: Auger Eric If I2C is built as a module, ACPI_I2C_OPREGION cannot be set and any ACPI opregion calls targeting I2C fail with no opregion found. Commit da3c6647ee08 ("I2C/ACPI: Clean up I2C ACPI code and Add CONFIG_I2C_ACPI config") says following: "Current there is a race between removing I2C ACPI operation region and ACPI AML code accessing." This patch forces core I2C support to be compiled as a built-in module if ACPI is selected as code is not ready for dynamic module removal. Signed-off-by: Eric Auger Signed-off-by: Sinan Kaya --- drivers/acpi/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig index 4650539..5b48098 100644 --- a/drivers/acpi/Kconfig +++ b/drivers/acpi/Kconfig @@ -9,6 +9,8 @@ menuconfig ACPI depends on IA64 || X86 || ARM64 depends on PCI select PNP + # force building I2C in on ACPI systems, for opregion availability + imply I2C default y if (IA64 || X86) help Advanced Configuration and Power Interface (ACPI) support for