From patchwork Thu Jan 25 15:33:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Lance Taylor X-Patchwork-Id: 865927 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-472023-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="od9pTM0n"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zS5fn5DBrz9sNV for ; Fri, 26 Jan 2018 02:33:53 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:from:date:message-id:subject:to:content-type; q= dns; s=default; b=vwHO2+agywBCB+TcOwJYvT8xcHegT5HlxLrF1G8yGtM8YQ Ij76qQx95kYtDF42swLG52VjHosEugCxylY59FUCsknqfk/vHiiejc2z63qGjwjO tD10QcbksdL7qxB8iztpfCH7j3crwPAIpHugC5si8gE0OqPPaczKxzosPvIbc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:from:date:message-id:subject:to:content-type; s= default; bh=s4OEMiU0y7K7lNgFA0eij+sPgi8=; b=od9pTM0ntMUyzXtThrI8 8kMxc3ClD74enSJDuNy1v5Fg/KcA+dCbXRA+w1PlSYnZ2JjuiqeNTdakk1qIYHkm 2jRSzCiezb6J5BezgpCc2aLzxQK2k7qdU75DlUNYcaTUKPfQgpH4caiV7UVbpiJS 6nNTy4qLewA8U1LfJxcqMhM= Received: (qmail 38096 invoked by alias); 25 Jan 2018 15:33:43 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 37977 invoked by uid 89); 25 Jan 2018 15:33:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.7 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-wm0-f45.google.com Received: from mail-wm0-f45.google.com (HELO mail-wm0-f45.google.com) (74.125.82.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 25 Jan 2018 15:33:40 +0000 Received: by mail-wm0-f45.google.com with SMTP id v123so15677161wmd.5 for ; Thu, 25 Jan 2018 07:33:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=EomXspVrMl4Su5HLjgaYQbw8ClQvQSgLxz4/7B/mEDQ=; b=GnETs4xLDXqDUgCYQt42u4vv9pXVMfAlHCKJSJ+gp8Tvn8+8gxpNL+U+Fdlwsdkp1O CYO9o9aP/tVsyi7sQ/cdal3for3X8c0YpfAFGMPlJVNPVZeDwLaiA9WGft0I0tZDKEUs JoKu8JVebGcCbjYKje6mkAYVlng+jswPbYBhB22E/ML+BXhW+1VwkTkOUk7Go82Lwwyu GHe0ceSBQJlK1LncMjTcSKW5ixesRXGKyRgS/nYBLge3ZzGI6bErR2jIrO/3kc2eYK0F 5dtcKJ6V5g9h7EZnRyhtIBzyqp40VtvGW6s+LkC6krhK9NQG433BAJmrYDFgJlRD+NQ+ x8nQ== X-Gm-Message-State: AKwxytfSwO2pSlbuQjCdnfviI/XfOVuSnJNeaTlhRrXgBww1rPd/NWqh yhbq/BRMG73FWKSXNK7oJcB5mPrPGTfWhGfL1QaHcpKK X-Google-Smtp-Source: AH8x2245m8mPKaDYHswsmbK8ra2eu8LSznL0qUV9SNgnbuxh2rz4EA+bdaUvDaP/4/rhAaoHvAnru83NcINfisdNpGY= X-Received: by 10.80.174.245 with SMTP id f50mr29521209edd.28.1516894418185; Thu, 25 Jan 2018 07:33:38 -0800 (PST) MIME-Version: 1.0 Received: by 10.80.134.56 with HTTP; Thu, 25 Jan 2018 07:33:37 -0800 (PST) From: Ian Lance Taylor Date: Thu, 25 Jan 2018 07:33:37 -0800 Message-ID: Subject: libbacktrace patch committed: Another memcpy -> coff_read4 fix To: gcc-patches This libbacktrace patch fixes another cases where memcpy was used in a way that would leave some bytes uninitialized on a 64-bit system. Committed to mainline. Ian 2018-01-25 Ian Lance Taylor * pecoff.c (coff_add): Another memcpy -> coff_read4 fix. Index: pecoff.c =================================================================== --- pecoff.c (revision 257040) +++ pecoff.c (working copy) @@ -631,10 +631,10 @@ coff_add (struct backtrace_state *state, goto fail; { - const char *vptr = (const char *)fhdr_view.data; + const unsigned char *vptr = fhdr_view.data; if (vptr[0] == 'M' && vptr[1] == 'Z') - memcpy (&fhdr_off, vptr + 0x3c, 4); + fhdr_off = coff_read4 (vptr + 0x3c); else fhdr_off = 0; }