From patchwork Wed Jul 14 09:36:18 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 1505081 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=ZidOLPwq; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GPsqc5dD7z9sCD for ; Wed, 14 Jul 2021 19:37:48 +1000 (AEST) Received: from localhost ([::1]:46622 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m3bKr-0001te-Ab for incoming@patchwork.ozlabs.org; Wed, 14 Jul 2021 05:37:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34812) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3bJs-0001rj-Ci for qemu-devel@nongnu.org; Wed, 14 Jul 2021 05:36:44 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]:51872) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m3bJq-0004E4-O3 for qemu-devel@nongnu.org; Wed, 14 Jul 2021 05:36:44 -0400 Received: by mail-wm1-x329.google.com with SMTP id n4so1166302wms.1 for ; Wed, 14 Jul 2021 02:36:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=07qbnshrUSR72AAoluEeIei2r45399bnXGyWSV2iqis=; b=ZidOLPwqKqepQQhdE9AgMozraI0lrF5BN+ZHsaMix6XKjVU5ecEGdSL8os8NLlz9Wz zbhK15qWDl+n8hW+lNvCUJqvHb8XbO45AqzWdwY/nvBY1/H/JtwofRnjZF363a3dWBlx qiyRyxdRF5mu1vbGpe3HD9Dx3motCy5SxIgPgKiDqlw4nsZVHaB+piFTpnyBBkLjF/ea vvucJVAM+qHVlpqgbbBcI1bCO7FWORLQlu1IEiLqgq4migetyU0RWNoeLsHCaCOKaLyj RRka0VVcYldnlUaJRfrgV0ZF5zLYrcfQ96IJPVyE4JII5ka7GwCro7TH50wDWorqWCII fhYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=07qbnshrUSR72AAoluEeIei2r45399bnXGyWSV2iqis=; b=kITzN+C3YG8oNbdjwWI2VgwQWiSDAMthdfL0ogZpQGtZDfmQhYF/OOqv2i1y9Njt3N IrRNuEMDfhYQb5lgIDKJrsWnFPpXZ3u8gzzczEvAVbdojTysIcrBlali31IocEyqOQPc vyxo3iAIKDpCL++PuYRc1W7ASsTs/tlf1S8rm2u43qJ6BKTPX+rKRw6tdd21Dy6nv+J6 jaRdpiyjHBAc8WDfm2uGLMhseL5I0jH4oBPjSvlY8EQvXhYsizXCE/9lq0cPv07COAj3 819OoTwqRfJNXe5K5q5jJGrjQijQzDs3YDp24mTIfqlpls8OrkYx+ZQDW7Imsx3bFE6B +3xw== X-Gm-Message-State: AOAM530CYZsEOMW3ZFRj/qKSPI/xkdfkBUemCMY1369SYF/O4XhxgcTo jxMUcjzlcJiTmOfwOCpIAlnF5Q== X-Google-Smtp-Source: ABdhPJzfvLhIJh4FDssAVMSsqISatK9QI5wdLSTGIuDpY731O0Gmjh9MAaW5oPb6xFaQZphNNlwamA== X-Received: by 2002:a05:600c:1c86:: with SMTP id k6mr10313710wms.147.1626255400405; Wed, 14 Jul 2021 02:36:40 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id x1sm5644168wmc.0.2021.07.14.02.36.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jul 2021 02:36:39 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id F30DE1FF87; Wed, 14 Jul 2021 10:36:38 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v1 01/21] gitignore: Update with some filetypes Date: Wed, 14 Jul 2021 10:36:18 +0100 Message-Id: <20210714093638.21077-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210714093638.21077-1-alex.bennee@linaro.org> References: <20210714093638.21077-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Viresh Kumar , =?utf-8?q?Alex_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Viresh Kumar Update .gitignore to ignore .swp and .patch files. Signed-off-by: Viresh Kumar Reviewed-by: Alex Bennée Message-Id: <79262dbe1f7888eb02e1911501eebafa6f2f6400.1616583806.git.viresh.kumar@linaro.org> Signed-off-by: Alex Bennée --- .gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index 75a4be0724..eb2553026c 100644 --- a/.gitignore +++ b/.gitignore @@ -13,3 +13,5 @@ GTAGS *~ *.ast_raw *.depend_raw +*.swp +*.patch From patchwork Wed Jul 14 09:37:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 1505094 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=Q0PXoyCm; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GPt1C48vtz9sCD for ; Wed, 14 Jul 2021 19:46:07 +1000 (AEST) Received: from localhost ([::1]:44234 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m3bSv-0002OL-7L for incoming@patchwork.ozlabs.org; Wed, 14 Jul 2021 05:46:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35188) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3bKY-00032c-TJ for qemu-devel@nongnu.org; Wed, 14 Jul 2021 05:37:27 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]:45982) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m3bKW-0004fJ-PC for qemu-devel@nongnu.org; Wed, 14 Jul 2021 05:37:26 -0400 Received: by mail-wr1-x434.google.com with SMTP id t5so2352656wrw.12 for ; Wed, 14 Jul 2021 02:37:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=O7eiCiiOA1Sqqm1FgUzdGWyHxXgBgMmn6hDxRrW6WnA=; b=Q0PXoyCmfli6eyNXCgsXg6XIhFVCc4JSYP1WDikxi0o/oYzJpNl/XgdMXgzs0XVNdG HWKeRhfznVP6btbB2CK9fz6txkaKp3vkZ+CXgbeHCYgUmO24I8tN9/wdzzgpdlnk87PH T5nyg11OEIfwHcbJuy0akugM6IrjXeLR5h1yeYA4NcpGOnbyLxg9WXhUjbfjTyrf0hmU 2Bq7LRAbIc05anxvFPzKb+y/FwrS+4IW/kkXwsBMMY9EVzLHNiiywfZSs281NWbeDyHS kVbMMa+DgHX0zTy8nVmKR2U2UGN+1dsYHYYEv7yQ9B6C1xUdvjk0rWrEuEcq5nfp/0FC 4SdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=O7eiCiiOA1Sqqm1FgUzdGWyHxXgBgMmn6hDxRrW6WnA=; b=JQBDdOn8NC7+DFU9HncJeoqJIUoJ7vFR5ca+AXgjVEXPsd1zChMYa3/3Vb6va20prz MZH1KdEoVxmgt9YLrSdxMkhE4FFNQYkMqeCPWTbL5yveD6Fncq4zPVboeG3jJ6yL1IR8 JXbfdVPKo0wBQzrbruusYg2HbI9nVOMEDSAlbI88Izb+0QF4+9dTTxA+GztnIBGAy4OO sxwnr0w5h9xVq3SQr5P5P2LV8FwPj+ZKPd52UM58OcUQ9W0K/Ohi5GpAzSsVqjuk6Ahx zOowuomyz3/G2i6hj+hV8FU6dJaEZ1ffm0UK9b42fSMjVkt8e2Z7jDszRXUCIT+Ogu4q lBEA== X-Gm-Message-State: AOAM531ATOr7jQNNL8/pe6bfTxxfTo2P4gSmwA9g5CtkUYqsP9VcT8BL u1fw0T9Bh3aW9EtO7jsc/MQ6WQ== X-Google-Smtp-Source: ABdhPJxm/rC/dln0RQtpBWqRUrMR+uXwef0QlVi+fTrlobtmT87gg8Almj4UK9tIWyiorH3OZgye8w== X-Received: by 2002:a05:6000:11c5:: with SMTP id i5mr11951135wrx.268.1626255443564; Wed, 14 Jul 2021 02:37:23 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id d8sm1854280wrv.20.2021.07.14.02.37.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jul 2021 02:37:20 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id CCC1D1FF93; Wed, 14 Jul 2021 10:37:19 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v1 02/21] docs: collect the disparate device emulation docs into one section Date: Wed, 14 Jul 2021 10:37:00 +0100 Message-Id: <20210714093719.21429-3-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210714093719.21429-1-alex.bennee@linaro.org> References: <20210714093719.21429-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x434.google.com X-Spam_score_int: -1 X-Spam_score: -0.2 X-Spam_bar: / X-Spam_report: (-0.2 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" While we are at it add a brief preamble that explains some of the common concepts in QEMU's device emulation which will hopefully lead to less confusing about our dizzying command line options. Signed-off-by: Alex Bennée --- docs/system/device-emulation.rst | 78 +++++++++++++++++++++++ docs/system/{ => devices}/ivshmem.rst | 0 docs/system/{ => devices}/net.rst | 0 docs/system/{ => devices}/nvme.rst | 0 docs/system/{ => devices}/usb.rst | 0 docs/system/{ => devices}/virtio-pmem.rst | 0 docs/system/index.rst | 6 +- 7 files changed, 79 insertions(+), 5 deletions(-) create mode 100644 docs/system/device-emulation.rst rename docs/system/{ => devices}/ivshmem.rst (100%) rename docs/system/{ => devices}/net.rst (100%) rename docs/system/{ => devices}/nvme.rst (100%) rename docs/system/{ => devices}/usb.rst (100%) rename docs/system/{ => devices}/virtio-pmem.rst (100%) diff --git a/docs/system/device-emulation.rst b/docs/system/device-emulation.rst new file mode 100644 index 0000000000..a0f00bc340 --- /dev/null +++ b/docs/system/device-emulation.rst @@ -0,0 +1,78 @@ +.. _device-emulation: + +Device Emulation +---------------- + +QEMU supports the emulation of a large number of devices from +peripherals such network cards and USB devices to integrated systems +on a chip (SoCs). Configuration of these is often a source of +confusion so it helps to have an understanding of some of the terms +used to describes devices within QEMU. + +Common Terms +~~~~~~~~~~~~ + +Device Front End +================ + +A device front end is how a device is presented to the guest. The type +of device presented should match the hardware that the guest operating +system is expecting to see. All devices can be specified with the +``--device`` command line option. Running QEMU with the command line +options ``--device help`` will list all devices it is aware of. Using +the command line ``--device foo,help`` will list the additional +configuration options available for that device. + +A front end is often paired with a back end, which describes how the +host's resources are used in the emulation. + +Device Buses +============ + +All devices exist on a BUS. Depending on the machine model you choose +(``-M foo``) a number of buses will have been automatically created. +In most cases the BUS a device is attached to can be inferred, for +example PCI devices are generally automatically allocated to the next +free slot of the PCI bus. However in complicated configurations you +can explicitly specify what bus a device is attached to and its +address. Some devices, for example a PCI SCSI host controller, will +add an additional bus to the system that other devices can be attached +to. + +Device Back End +=============== + +The back end describes how the data from the emulated device will be +processed by QEMU. The configuration of the back end is usually +specific to the class of device being emulated. For example serial +devices will be backed by a ``--chardev`` which can redirect the data +to a file or socket or some other system. Storage devices are handled +by ``--blockdev`` which will specify how blocks are handled, for +example being stored in a qcow2 file or accessing a raw host disk +partition. Back ends can sometimes be stacked to implement features +like snapshots. + +While the choice of back end is generally transparent to the guest +there are cases where features will not be reported to the guest if +the back end is unable to support it. + +Device Pass Through +=================== + +Device pass through is where the device is actually given access to +the underlying hardware. This can be as simple as exposing a single +USB device on the host system to the guest or dedicating a video card +in a PCI slot to the exclusive use of the guest. + + +Emulated Devices +~~~~~~~~~~~~~~~~ + +.. toctree:: + :maxdepth: 1 + + devices/ivshmem.rst + devices/net.rst + devices/nvme.rst + devices/usb.rst + devices/virtio-pmem.rst diff --git a/docs/system/ivshmem.rst b/docs/system/devices/ivshmem.rst similarity index 100% rename from docs/system/ivshmem.rst rename to docs/system/devices/ivshmem.rst diff --git a/docs/system/net.rst b/docs/system/devices/net.rst similarity index 100% rename from docs/system/net.rst rename to docs/system/devices/net.rst diff --git a/docs/system/nvme.rst b/docs/system/devices/nvme.rst similarity index 100% rename from docs/system/nvme.rst rename to docs/system/devices/nvme.rst diff --git a/docs/system/usb.rst b/docs/system/devices/usb.rst similarity index 100% rename from docs/system/usb.rst rename to docs/system/devices/usb.rst diff --git a/docs/system/virtio-pmem.rst b/docs/system/devices/virtio-pmem.rst similarity index 100% rename from docs/system/virtio-pmem.rst rename to docs/system/devices/virtio-pmem.rst diff --git a/docs/system/index.rst b/docs/system/index.rst index 6092eb2d91..641d243ba4 100644 --- a/docs/system/index.rst +++ b/docs/system/index.rst @@ -16,15 +16,12 @@ Contents: quickstart invocation + device-emulation keys mux-chardev monitor images - net virtio-net-failover - usb - nvme - ivshmem linuxboot generic-loader guest-loader @@ -35,7 +32,6 @@ Contents: gdb managed-startup cpu-hotplug - virtio-pmem pr-manager targets security From patchwork Wed Jul 14 09:37:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 1505092 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=UqNGForL; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GPsyx1Bh6z9sX3 for ; Wed, 14 Jul 2021 19:44:09 +1000 (AEST) Received: from localhost ([::1]:36082 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m3bR0-0005PC-T5 for incoming@patchwork.ozlabs.org; Wed, 14 Jul 2021 05:44:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35190) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3bKY-00032d-VQ for qemu-devel@nongnu.org; Wed, 14 Jul 2021 05:37:27 -0400 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]:37503) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m3bKX-0004fv-JL for qemu-devel@nongnu.org; Wed, 14 Jul 2021 05:37:26 -0400 Received: by mail-wr1-x432.google.com with SMTP id i94so2395939wri.4 for ; Wed, 14 Jul 2021 02:37:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1YFfcNF4LkvFeRrj0McNGwJ95momCe8V6bBvEw7Hvfw=; b=UqNGForLMMp19Lw5UIA4gWcyAfFmTBl643TKoPa029Kd5J43mWkJS7CJ55wO+QRRzq Tw0pWMug8PAkkes9lWu1i/tI5Gwmygb1SPx8Sq+Eq26p3vi+q3U6tEkFuVto3KtLLSfl bDM9gHY8laqQMVmWOlEMtKvbT6h0/WnuI99fsBIipH6tefFKUKNvGXh5HLULHNPbIdMU Zese1ScBX/YURUO29cS34UUAyzL+STHIpXns0nJSOBo4b8XuxIS92XgpjOl6u0nquH7o 0lVGLy+j4SitxshAil3a2sBFNh8M/BO9sWq5kE0xBMLthFtlP/XuSzWcaB97R6i9fD5r lBNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1YFfcNF4LkvFeRrj0McNGwJ95momCe8V6bBvEw7Hvfw=; b=b2cHY1xOun3jaiFJX6YJf7eQ2cQdDXBtsqEcnzVqSvLGytdeXFrN7iQ678J2F0iHdK Smp5ZLobsqTL0qmBKMkpCy/TNM5MWjGoy5ec2uEic5hxyXCRkr/qMnPjpbaO0J91VtsS WUyYAbuKGUYFmx0YsR/ldn+qgCztsS8AgFL7kFbCzdqLALwQlpjJ6bQOUP+c8r73Obhd Y8QFtTeE4DOamFFYSIFRBzaFK1lGA15xF1JJ3UqrZ8+QAOAl1qGEIyR+jkLODRQ8RuWu hupuxqZGBac/yqaRqd1KbDTLMmGkLnPUS+j2aMoQU80cvQOaYVFMyLO7Q3plCZPw1YQ6 HjVg== X-Gm-Message-State: AOAM531Qu2tMTRT45FDo+I4y61pQB22gzosmuF3Ve2BK6IL5GIu5W/Vp MBhDDqbLiVjwUieWHH4uN/Zw/Q== X-Google-Smtp-Source: ABdhPJzWliUH+Ig0zMgvqWsw9so4wEKh08v8twphwmGtOk07vo4f5kO5h9cAjT4BjxSfAGNdEPW0Dg== X-Received: by 2002:a5d:4a44:: with SMTP id v4mr11451804wrs.219.1626255444287; Wed, 14 Jul 2021 02:37:24 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id p9sm1837495wrx.59.2021.07.14.02.37.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jul 2021 02:37:20 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 0782E1FF98; Wed, 14 Jul 2021 10:37:20 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v1 04/21] configure: remove needless if leg Date: Wed, 14 Jul 2021 10:37:02 +0100 Message-Id: <20210714093719.21429-5-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210714093719.21429-1-alex.bennee@linaro.org> References: <20210714093719.21429-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::432; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x432.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" It was pointed out in review of the previous patch that the if leg isn't needed as the for loop will not enter on an empty $device_archs. Fixes: d1d5e9eefd ("configure: allow the selection of alternate config in the build") Signed-off-by: Alex Bennée --- configure | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/configure b/configure index 4d0a2bfdd8..013f327f4a 100755 --- a/configure +++ b/configure @@ -5083,12 +5083,10 @@ if test "$skip_meson" = no; then echo "[properties]" >> $cross # unroll any custom device configs - if test -n "$device_archs"; then - for a in $device_archs; do - eval "c=\$devices_${a}" - echo "${a}-softmmu = '$c'" >> $cross - done - fi + for a in $device_archs; do + eval "c=\$devices_${a}" + echo "${a}-softmmu = '$c'" >> $cross + done test -z "$cxx" && echo "link_language = 'c'" >> $cross echo "[built-in options]" >> $cross