From patchwork Mon Jun 21 19:50:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 1495296 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=WxHlqStE; dkim=fail reason="signature verification failed" (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=XMN1VhEn; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4G80WD0mVKz9s5R for ; Tue, 22 Jun 2021 05:50:31 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=6VlDZdJ611thUZpd1kqaftO0g5LecZZP/8TsUhip/Bk=; b=WxHlqStEUAU7J1 xEiWntG0Nh+ncNhCIIdWUJEr2277Bl6YOojkgCDGzJpTAk75xn+0yDXHqJdg02oPxCYzk98GL+ssa ZcXd4vjwTCatW9s+z6o/MhS9IzHw+9lAsogEsTU1CxP/iwxwp0eojdH39gUsnugjY1vM0ZDh5vJ/M N6ngQDfkcTylMLANNecKlVlTVI8zy3xmGirx2V8h3NReCCksoM7knR1JJ5Ri4inP1NozNmUp3j0NW SNFmL+pTVJ5bVgRAuqGb+Qo02ZtYRSRrliyWroEViDtpKTaxDYAY6kBHy4Ak3OAhtovtio4NpM5U3 56v6pqnWqn5cQVK7q8xQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvPwB-004kHP-0w; Mon, 21 Jun 2021 19:50:27 +0000 Received: from mout.gmx.net ([212.227.15.18]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvPw8-004kGr-1g for opensbi@lists.infradead.org; Mon, 21 Jun 2021 19:50:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1624305017; bh=BQjGri7cqY7ZzNdT/JuEPI+Xuewd8ZlRRApHDBnafyc=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=XMN1VhEn/+0NG/WPSfOTCrOts0N5Xm0gP6QB+lTgkvBSZDr9wrWxX1o0ahGZM7rIX TGlUNQn7ZuAyTG8rFZu2/x2Euw/1S1jsADn0dAgh7ihOixcqzwqx4agjhRCODTkCR4 WAJjg9ONJFlXohKw4XjysQ4YhdxG6BnxcDmr6Cxw= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from LT02.fritz.box ([88.152.144.157]) by mail.gmx.net (mrgmx004 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MtwUw-1l7hYr1KZA-00uGPA; Mon, 21 Jun 2021 21:50:17 +0200 From: Heinrich Schuchardt To: opensbi@lists.infradead.org Cc: Anup Patel , Atish Patra , Heinrich Schuchardt Subject: [PATCH 1/1] lib: sign conflict in sbi_tlb_entry_process() Date: Mon, 21 Jun 2021 21:50:10 +0200 Message-Id: <20210621195010.33557-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Provags-ID: V03:K1:0de1w3YyxdwIr25WLmj7AH6ToXVsz/2b+vwgIf1qKgZtPRP4qQr UH90oqpd2HVWJbqJJEDGnaW+aTTvp9Oi4K3yus3jC96yX9ualQYmpQCTaaLvDoApyOuUuGi t5FalLqKjyEPAc19kA4TtLZAx2ggrM2kLxXsybhJ6bjFctHsfej+n63bqT6To6avH4YUXNr 8yr8gCUz2/w4trGkcDimg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:X/kYXq4bte8=:U6eLyxaMS0piqLvSCvZkM4 7wWxi3emacvw24QdDkS3WzlqJo3BRGhVhWMsUhUczo9eCCB+d0n+FCe6I7sYy7FuRnxybNQ8p 1iK6HoN7u2HSQcQmzm+CYjg9lq94B0pw9OiipgBOgHStTSuK+I33Lxu0UASyl9y6hpk7Mo8Yu XmKvauuWj9H2v91sLiMFD8AjpbrZwcmEL97iR3iGmxAKAJwcEfhebW9hTvZcBJ1Dz8Sb6lByS vgeHjnA9RWEZk6RG9G/VkcVlzTalxzpzuqCvpcEL4/BLpbbvTWBdt0MVo1OprAUurVJ9Iicd0 hryBGtFi1jI/RM8lxGkzjhfsPThEFSUVVuAI01OnzMmzkAeCF1ONFFPZKrFWyu5lxbjHKQ9Hw 6QpWZ9/pH6lJjbgBnnLj5zE75DwJ0e327M7hnQMZkaW1H8q0YYVavAAWWMiMssRqd49EH00BE 60mXb1eyyP83fFimQxaN7A8FBSpx2p/KPZI0sR3/25lCC+mLs++dO66E4ZV3+n4AdSNtUUiqp YcQ2HVHSddbJGo40DPUfHDefcRUAXqXafQhzmqDWf7pLXj8QtZ1oapTm3zHVV4XyEARbupzjv s3u3aQG8ET4T1DigNunBbCwQBJ0EWzhuuN52Ll4m00eXuWVU3CpwogGAcZu2mmmRzdASR7ZFa 4ehJvLrRBBUVZ2ITQLNwh1DHGPLQk/Ab7lUXhcjwaVx1yDF+8Mvcx88a1pnsWFX29UVoFzGX9 MS/6RGxo/Wve0mbFep70QmLlLU6IpcjzW8xgpEtDCKib9awusJSrlvCNbE2wYh8o8wzAPo6Tn DhWFLlSU6CSgtwHyWN+L/Sq+cQHWmieeSlVFYEqhEI3SWulGZv5HCAB3cY/IqEqSNoyMIyBfW kVoU0VLg93P6OQI9ml9L5UMTUlFZ2c3IH49uZA2qc12XWtyd5AFdXDZC4wsKRDKk0P1BXldk2 Wzo/M7/vGb5FeXGSe1dOft4ItyHPbJic9vLltgTzhGA/6L1tdZOjeTrw62y9K7cSN5jqYcQFC IzYx1fs/kzVyRNWGVQiaw1MMNLuDKiML42lDG9JGp4GDbkykS0HcAw6VS/C2ew43nAzhP442f 3sgzDYRMUhMEmw5TyoBWl8/Z/2FC02oTLAo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210621_125024_426374_FC53777D X-CRM114-Status: UNSURE ( 9.40 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.7 (/) X-Spam-Report: =?unknown-8bit?q?Spam_detection_software=2C_running_on_the_sy?= =?unknown-8bit?q?stem_=22bombadil=2Einfradead=2Eorg=22=2C?= =?unknown-8bit?q?_has_NOT_identified_this_incoming_email_as_spam=2E__The_ori?= =?unknown-8bit?q?ginal?= =?unknown-8bit?q?_message_has_been_attached_to_this_so_you_can_view_it_or_la?= =?unknown-8bit?q?bel?= =?unknown-8bit?q?_similar_future_email=2E__If_you_have_any_questions=2C_see?= =?unknown-8bit?q?_the_administrator_of_that_system_for_details=2E?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_Content_preview=3A__Compiling_sbi=5Ftlb=5Fentry=5Fprocess?= =?unknown-8bit?q?=28=29_with_GCC_11_and_-Wextra?= =?unknown-8bit?b?IHlpZWxkczogbGliL3NiaS9zYmlfdGxiLmM6IEluIGZ1bmN0aW9uIOKA?= =?unknown-8bit?b?mHNiaV90bGJfcHJvY2Vzc19jb3VudOKAmTogbGliL3NiaS9zYmlfdGxi?= =?unknown-8bit?b?LmM6MjA2OjMxOg==?= =?unknown-8bit?q?_error=3A_comparison_of_integer_expressions_of_different_si?= =?unknown-8bit?q?gnedness=3A_=E2=80=98u32=E2=80=99?= =?unknown-8bit?b?IHtha2Eg4oCYdW5zaWduZWQgaW504oCZfSBhbmQg4oCYaW504oCZIFsu?= =?unknown-8bit?b?Li5dIA==?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_Content_analysis_details=3A___=28-0=2E7_points=2C_5=2E0_re?= =?unknown-8bit?q?quired=29?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_pts_rule_name______________description?= =?unknown-8bit?q?_----_----------------------_------------------------------?= =?unknown-8bit?q?--------------------?= =?unknown-8bit?q?_-0=2E0_SPF=5FPASS_______________SPF=3A_sender_matches_SPF_?= =?unknown-8bit?q?record?= =?unknown-8bit?q?_0=2E0_SPF=5FHELO=5FNONE__________SPF=3A_HELO_does_not_publ?= =?unknown-8bit?q?ish_an_SPF_Record?= =?unknown-8bit?q?_-0=2E7_RCVD=5FIN=5FDNSWL=5FLOW______RBL=3A_Sender_listed_a?= =?unknown-8bit?q?t_https=3A//www=2Ednswl=2Eorg/=2C?= =?unknown-8bit?q?_low_trust?= =?unknown-8bit?q?_=5B212=2E227=2E15=2E18_listed_in_list=2Ednswl=2Eorg=5D?= =?unknown-8bit?q?_-0=2E0_RCVD=5FIN=5FMSPIKE=5FH2______RBL=3A_Average_reputat?= =?unknown-8bit?q?ion_=28+2=29?= =?unknown-8bit?q?_=5B212=2E227=2E15=2E18_listed_in_wl=2Emailspike=2Enet=5D?= =?unknown-8bit?q?_0=2E0_FREEMAIL=5FFROM__________Sender_email_is_commonly_ab?= =?unknown-8bit?q?used_enduser_mail?= =?unknown-8bit?q?_provider?= =?unknown-8bit?b?IFt4eXByb24uZ2xwa1thdF1nbXguZGVd?= =?unknown-8bit?q?_-0=2E1_DKIM=5FVALID_____________Message_has_at_least_one_v?= =?unknown-8bit?q?alid_DKIM_or_DK_signature?= =?unknown-8bit?q?_0=2E1_DKIM=5FSIGNED____________Message_has_a_DKIM_or_DK_si?= =?unknown-8bit?q?gnature=2C_not_necessarily?= =?unknown-8bit?q?_valid?= X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Compiling sbi_tlb_entry_process() with GCC 11 and -Wextra yields: lib/sbi/sbi_tlb.c: In function ‘sbi_tlb_process_count’: lib/sbi/sbi_tlb.c:206:31: error: comparison of integer expressions of different signedness: ‘u32’ {aka ‘unsigned int’} and ‘int’ [-Werror=sign-compare] 206 | if (deq_count > count) Signed-off-by: Heinrich Schuchardt Reviewed-by: Atish Patra Reviewed-by: Xiang W --- lib/sbi/sbi_tlb.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- 2.30.2 diff --git a/lib/sbi/sbi_tlb.c b/lib/sbi/sbi_tlb.c index 2ba1b7b..8bbe92b 100644 --- a/lib/sbi/sbi_tlb.c +++ b/lib/sbi/sbi_tlb.c @@ -193,10 +193,11 @@ static void sbi_tlb_entry_process(struct sbi_tlb_info *tinfo) } } -static void sbi_tlb_process_count(struct sbi_scratch *scratch, int count) +static void sbi_tlb_process_count(struct sbi_scratch *scratch, + unsigned int count) { struct sbi_tlb_info tinfo; - u32 deq_count = 0; + unsigned int deq_count = 0; struct sbi_fifo *tlb_fifo = sbi_scratch_offset_ptr(scratch, tlb_fifo_off);