From patchwork Thu Jun 17 09:14:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Norbert Lange X-Patchwork-Id: 1493281 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=oW3gR19J; dkim-atps=neutral Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4G5Gd62dlVz9s1l for ; Thu, 17 Jun 2021 19:16:10 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id B5EFB60864; Thu, 17 Jun 2021 09:16:03 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WzaRGofijP78; Thu, 17 Jun 2021 09:16:03 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 2E5BA60761; Thu, 17 Jun 2021 09:16:02 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id E4BE61BF30F for ; Thu, 17 Jun 2021 09:15:13 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id D459660761 for ; Thu, 17 Jun 2021 09:15:13 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6aHcGpSVvtVA for ; Thu, 17 Jun 2021 09:15:13 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by smtp3.osuosl.org (Postfix) with ESMTPS id 2C9F360670 for ; Thu, 17 Jun 2021 09:15:13 +0000 (UTC) Received: by mail-wr1-x435.google.com with SMTP id n7so5911932wri.3 for ; Thu, 17 Jun 2021 02:15:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=o+zVtQxgqqGqcqoxqC3d5a7iTGD9MKZqB0om22PuA9Q=; b=oW3gR19JyZAwtBJTJKKqRKc/X9a5ezYBsVDnlBpTT46iIFnYk6euuujeJfcjaaQkqa 9mCr4JhFtAlv3Hmz/rwgjbJS+mM6YvVF/8pDOJFWYgFVc02K5szsdzb6ZxqwogDYiC06 Qt3p9f/OvOj9AtaZ83kqkN2oSXK6SS0Sgciw/HEqmPKHz+8xXBfbhWBAHcImUBGp3Dju do3Oxus44lthXH2mZbJdKXKvpLNsxc4rd2LMpMrtEalDKhJGlsQQvOJaPDbK2ALeiJM+ j1eBvGWMyhbQuvwSapccAWGmWY/ZCcR16z4VIYMr22wXoxjDybDubqViJwdYRn6wSTrN u2MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=o+zVtQxgqqGqcqoxqC3d5a7iTGD9MKZqB0om22PuA9Q=; b=kA/kx02sxRg8zfBc43vZsM8N8XsAjUG9bNH4SDu4gokKexEoUVYZ+uvk0Cccfwq9WM xxPbWmL/0pGcJnDJCB//YUYD8Zj1wBCT/lpV9/jXeA+CiSH1gtoeHk7t8ApIDZ5pPkVf /4ZECteCxTHCui6BM2LHBmU3ZHlylVVAUPDZA4mV+a/lYeoT/lco+9YYMaEvqpQEF1kc CaITmLz9Ez6mGUEC2EaL4XBzx5OuIeP50SprRWPNQhwdraGD8BjMOGMByv9odTzfkC8S 7jAXatduq7BL8jPH9jvARPrfWyplnDlfjQJhjX1gLQsSBrZoKqMYPgv7D4ag7gYlugDs pvIA== X-Gm-Message-State: AOAM532ehtog/jF8dLwsXCfgBnR4znhk7i02deF377zBSVuVnlEl6cm9 KGkKFt4bupu4r5QqvsSeDty1El/pUfVvtA== X-Google-Smtp-Source: ABdhPJz9qamg0CTUnaIMrWgcVMbe8FadCau5JFbdQY4BFTg/2f1LRm6PSyidrvkcX8TnEDbSov0cuw== X-Received: by 2002:adf:f346:: with SMTP id e6mr4310556wrp.179.1623921311439; Thu, 17 Jun 2021 02:15:11 -0700 (PDT) Received: from debian-noppl.. (84-114-45-16.cable.dynamic.surfer.at. [84.114.45.16]) by smtp.gmail.com with ESMTPSA id r6sm4752767wrt.21.2021.06.17.02.15.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Jun 2021 02:15:10 -0700 (PDT) From: Norbert Lange To: buildroot@buildroot.org Date: Thu, 17 Jun 2021 11:14:54 +0200 Message-Id: <20210617091456.272611-5-nolange79@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210617091456.272611-1-nolange79@gmail.com> References: <20210617091456.272611-1-nolange79@gmail.com> MIME-Version: 1.0 Subject: [Buildroot] [PATCH v4 2/3] package/zstd: Change Build options X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Smirnov , Norbert Lange Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Disable the legacy format, these are just needed for decompressing files created with pre-release version. Use Buildroot's setting for optimization, zstd's build system overrides CFLAGS, but MOREFLAGS can override again. Quick tests show that using -O2 (like buildroot) is actually a little faster than -O3 on x86_64 Atoms. Signed-off-by: Norbert Lange --- v2->v3: * Remove ZSTD_OPTS_MOREFLAGS variable --- package/zstd/zstd.mk | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/package/zstd/zstd.mk b/package/zstd/zstd.mk index 5674e85bfe..58b0d0099e 100644 --- a/package/zstd/zstd.mk +++ b/package/zstd/zstd.mk @@ -13,6 +13,7 @@ ZSTD_CPE_ID_VENDOR = facebook ZSTD_CPE_ID_PRODUCT = zstandard ZSTD_OPTS += PREFIX=/usr +ZSTD_OPTS += ZSTD_LEGACY_SUPPORT=0 ifeq ($(BR2_PACKAGE_ZLIB),y) ZSTD_DEPENDENCIES += zlib @@ -35,6 +36,9 @@ else ZSTD_OPTS += HAVE_LZ4=0 endif +# zstd will append -O3 after $(CFLAGS), use MOREFLAGS to override again +ZSTD_OPTS += MOREFLAGS="$(TARGET_OPTIMIZATION)" + ZSTD_BUILD_PROG_TARGET = zstd-release ifeq ($(BR2_STATIC_LIBS)$(BR2_SHARED_STATIC_LIBS),y)