From patchwork Tue Jun 15 11:54:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Gray X-Patchwork-Id: 1492155 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.133; helo=smtp2.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=SExLWETH; dkim-atps=neutral Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4G46F504GTz9sW4 for ; Tue, 15 Jun 2021 21:54:48 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id DAF254039C; Tue, 15 Jun 2021 11:54:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Soqcv3iCXEu4; Tue, 15 Jun 2021 11:54:46 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp2.osuosl.org (Postfix) with ESMTPS id 2459C402E1; Tue, 15 Jun 2021 11:54:45 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 62B70C0027; Tue, 15 Jun 2021 11:54:43 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 5B625C000B for ; Tue, 15 Jun 2021 11:54:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id A67EA607A9 for ; Tue, 15 Jun 2021 11:54:41 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lcyPgYZ9H4QK for ; Tue, 15 Jun 2021 11:54:41 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp3.osuosl.org (Postfix) with ESMTPS id 18D1E607E4 for ; Tue, 15 Jun 2021 11:54:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623758080; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2GlxTQrf1Y+I9cMi27Jv/UZ90ys52cfZ2jNIpbo88QM=; b=SExLWETH31gMq+Z1qQ0M7XmAr5A3ysW2K1vJcE13wkTgGLGpk+Us7R+1v8cG+gH6RuEyNM SMCQ3pNZcMD/qJrLu5OWmWykkO3B8vb7HgAZrktgUBkO4EOwm9ezNF9HN/M/vdOan6nLsd k0Mtpa9J6ATwY6DpdLzNAcEaJjQSwLQ= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-2-q2Ro_XqTMLGwGcKlbWPN7A-1; Tue, 15 Jun 2021 07:54:38 -0400 X-MC-Unique: q2Ro_XqTMLGwGcKlbWPN7A-1 Received: by mail-qt1-f198.google.com with SMTP id h24-20020ac856980000b0290243c83a3ddcso9231650qta.1 for ; Tue, 15 Jun 2021 04:54:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2GlxTQrf1Y+I9cMi27Jv/UZ90ys52cfZ2jNIpbo88QM=; b=ARljZ4TB/yOY1oPKamclyeudfXx2bjM1m1CZDcBEHAWpokFddcplH95FkAUaVVNWzI yNtrofR4gkeQH7hIOpPuaYD7EATwZ4/jHxWP9a4UFEvSftUfblhVTVBhv5AYzHlo6Jvf wmCVCbxj2Emk8C4EGCAqzgjZ33q17//q51gu9u6KgCz9Pys7dX+wPVVuToorwecZgFwR E9K305FJ/GKy/O8bJVZV06htQGIq3ETy0ibzm2ojo++fhgK3Z0vTXLeW4jHZLIEH8NXm nuo0vuW0HuRmkvUZ926wfG9J+DGUdjN935MrPiee7SHpB3RmRave45cZiE3BcMa+Fpe7 TS7Q== X-Gm-Message-State: AOAM5310QXKO70UtK/nzgq2tSRPFIFyd9dmMrG3CPMmceZs1TqbV8GUB NFcWcLSYDGfBl6/BPw+uWT8LiooMjqvsBPJM+9+gAmROXifgvag+Mds2mHRuR6PrDb1E1+hS4yM T1seGtJlqJraC7y587mJgunAmvo0Me7kq39ueTaYaiaAHvG7a+2hN91rWaG1EjCtyZow3 X-Received: by 2002:a05:622a:48:: with SMTP id y8mr13851546qtw.353.1623758077984; Tue, 15 Jun 2021 04:54:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyfrBrSNpCDwFK3rTOieZqIBdA7U082sCPxoHMvLe4TNNHy6fbS/jaF6Mddeks4yoBC5uGrIg== X-Received: by 2002:a05:622a:48:: with SMTP id y8mr13851531qtw.353.1623758077761; Tue, 15 Jun 2021 04:54:37 -0700 (PDT) Received: from wsfd-netdev91.ntdv.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id f4sm2735366qte.28.2021.06.15.04.54.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jun 2021 04:54:37 -0700 (PDT) From: Mark Gray To: dev@openvswitch.org Date: Tue, 15 Jun 2021 07:54:33 -0400 Message-Id: <20210615115435.2461498-2-mark.d.gray@redhat.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210615115435.2461498-1-mark.d.gray@redhat.com> References: <20210615115435.2461498-1-mark.d.gray@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mark.d.gray@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [ovs-dev] [PATCH ovn 1/3] ovn-macros.at: fix typo X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" Signed-off-by: Mark Gray --- tests/ovn-macros.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/ovn-macros.at b/tests/ovn-macros.at index cd02b6986cc2..c92c07720112 100644 --- a/tests/ovn-macros.at +++ b/tests/ovn-macros.at @@ -184,7 +184,7 @@ ovn_start_northd() { # ovn-sbctl and ovn-nbctl use them by default, and starts ovn-northd running # against them. # -# Normally this starts an active northd and a backup norhtd. The following +# Normally this starts an active northd and a backup northd. The following # options are accepted to adjust that: # --backup-northd=none Don't start a backup northd. # --backup-northd=paused Start the backup northd in the paused state. From patchwork Tue Jun 15 11:54:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Gray X-Patchwork-Id: 1492156 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.136; helo=smtp3.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=QKQfbLH3; dkim-atps=neutral Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4G46F70Fs9z9sW4 for ; Tue, 15 Jun 2021 21:54:51 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id B85F260851; Tue, 15 Jun 2021 11:54:48 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MOVTHgtuc2tG; Tue, 15 Jun 2021 11:54:47 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id 84E5E6082F; Tue, 15 Jun 2021 11:54:46 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 2E692C0022; Tue, 15 Jun 2021 11:54:46 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 833ADC0029 for ; Tue, 15 Jun 2021 11:54:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 6588D6082A for ; Tue, 15 Jun 2021 11:54:43 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6Cd1nXbFbQi5 for ; Tue, 15 Jun 2021 11:54:42 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp3.osuosl.org (Postfix) with ESMTPS id 24166607E4 for ; Tue, 15 Jun 2021 11:54:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623758081; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/zzpM0uHejg0gMG9CjYapBiPLUutctpuSDUqVZ+2Q4E=; b=QKQfbLH3P8TbJa7K9tm/S2G6nn5u/jgrBoBDkGEvEJ8B24MbWNUdo45EoJSWflFO7YKrtv Es2m7ytI4LuRYy/hXIiDnxhxI4JtThdZl7GITmlnSvt5MktE+5vPNvu/7iKO2qdKMd2siS ouWwVKVyNh9MGfwCOwNavQHS+6zOTIU= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-6-O4QHS0DXNIe2LgghRpUGMw-1; Tue, 15 Jun 2021 07:54:40 -0400 X-MC-Unique: O4QHS0DXNIe2LgghRpUGMw-1 Received: by mail-qt1-f200.google.com with SMTP id d7-20020ac811870000b02901e65f85117bso9210440qtj.18 for ; Tue, 15 Jun 2021 04:54:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/zzpM0uHejg0gMG9CjYapBiPLUutctpuSDUqVZ+2Q4E=; b=Ta/VlRfrssi+qKszLFQTFi73CMVu2rubRbzLBTdQbgsQqtRD30FOw6c6eQKANcrwRa tVPFASK5gA3ZIuvvfAN/LIAk9eprCOblI0vIjPGFyD6+Be3KP1FPKwOQC7kYDAGLxaTZ o49UJvMQo1ZxZ6W3JAFb82QI9hXLpkqvkOb4NGEz9PtMR4kHTAnsvPYM2X+PsTvHuRqP IzqtALPhQae3Curies2hDHk/4DQa4dwbVNRvQZBx5fEroHJBD8qAGm1Vo1AKDXxXOkxS yD6NUezqAvttc046Wv6D/BrtBfBxljwS4p1dsrMFRHLD0h1V09i9xPn434DGRyT5GWa7 7aZw== X-Gm-Message-State: AOAM5312JWYG0fPZ7xRJM4hcm405FVJiTTNfpU87R1mqXzMqpb+nfdXv aMZ02Y0xl5wawV/1sKLFGGij1/oWjAgtibgcg5jSc/3MpCREf9AGuVgKDV3B0xz1fUbz1rkaHUM oJxQGwMuyh0t4vSCMzGsZeIakP/qztb6n0YnAOgexGWT7hKwCdvVWscTdolcYKS/vLRUZ X-Received: by 2002:ad4:51cf:: with SMTP id p15mr2329483qvq.5.1623758079232; Tue, 15 Jun 2021 04:54:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzfuwkGMB6PyAemglrORyyDyg/9/eFL57vPTSQZ6M0BM4KfL0SjWNB9AP2hG/Q7fG2uYNEUNg== X-Received: by 2002:ad4:51cf:: with SMTP id p15mr2329466qvq.5.1623758079060; Tue, 15 Jun 2021 04:54:39 -0700 (PDT) Received: from wsfd-netdev91.ntdv.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id f4sm2735366qte.28.2021.06.15.04.54.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jun 2021 04:54:38 -0700 (PDT) From: Mark Gray To: dev@openvswitch.org Date: Tue, 15 Jun 2021 07:54:34 -0400 Message-Id: <20210615115435.2461498-3-mark.d.gray@redhat.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210615115435.2461498-1-mark.d.gray@redhat.com> References: <20210615115435.2461498-1-mark.d.gray@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mark.d.gray@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [ovs-dev] [PATCH ovn 2/3] ovn-northd: Add useful stopwatches X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" For performance measurement, it is useful to understand the length of time required to complete a number of key code paths in ovn-northd.c. Add stopwatches to measure these timings. Signed-off-by: Mark Gray --- northd/ovn-northd-ddlog.c | 15 +++++++++++++++ northd/ovn-northd.c | 20 ++++++++++++++++++++ 2 files changed, 35 insertions(+) diff --git a/northd/ovn-northd-ddlog.c b/northd/ovn-northd-ddlog.c index a4f2960bdcb8..7c552d516550 100644 --- a/northd/ovn-northd-ddlog.c +++ b/northd/ovn-northd-ddlog.c @@ -37,6 +37,7 @@ #include "ovsdb-parser.h" #include "ovsdb-types.h" #include "simap.h" +#include "stopwatch.h" #include "stream-ssl.h" #include "stream.h" #include "unixctl.h" @@ -50,6 +51,10 @@ VLOG_DEFINE_THIS_MODULE(ovn_northd); #include "northd/ovn-northd-ddlog-nb.inc" #include "northd/ovn-northd-ddlog-sb.inc" +#define NORTHD_LOOP_STOPWATCH_NAME "ovn-northd-loop" +#define OVNNB_DB_RUN_STOPWATCH_NAME "ovnnb_db_run" +#define OVNSB_DB_RUN_STOPWATCH_NAME "ovnsb_db_run" + struct northd_status { bool locked; bool pause; @@ -1259,6 +1264,10 @@ main(int argc, char *argv[]) daemonize_complete(); + stopwatch_create(NORTHD_LOOP_STOPWATCH_NAME, SW_MS); + stopwatch_create(OVNNB_DB_RUN_STOPWATCH_NAME, SW_MS); + stopwatch_create(OVNSB_DB_RUN_STOPWATCH_NAME, SW_MS); + /* Main loop. */ exiting = false; while (!exiting) { @@ -1285,8 +1294,12 @@ main(int argc, char *argv[]) status.locked = has_lock; status.pause = sb_ctx->paused; + stopwatch_start(OVNNB_DB_RUN_STOPWATCH_NAME, time_msec()); northd_run(nb_ctx); + stopwatch_stop(OVNNB_DB_RUN_STOPWATCH_NAME, time_msec()); + stopwatch_start(OVNSB_DB_RUN_STOPWATCH_NAME, time_msec()); northd_run(sb_ctx); + stopwatch_stop(OVNSB_DB_RUN_STOPWATCH_NAME, time_msec()); northd_update_probe_interval(nb_ctx, sb_ctx); if (ovsdb_cs_has_lock(sb_ctx->cs) && sb_ctx->state == S_UPDATE && @@ -1297,6 +1310,8 @@ main(int argc, char *argv[]) northd_send_deltas(sb_ctx); } + stopwatch_stop(NORTHD_LOOP_STOPWATCH_NAME, time_msec()); + stopwatch_start(NORTHD_LOOP_STOPWATCH_NAME, time_msec()); unixctl_server_run(unixctl); northd_wait(nb_ctx); diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c index d872f6a3cc1d..bffa18de5c2d 100644 --- a/northd/ovn-northd.c +++ b/northd/ovn-northd.c @@ -49,6 +49,7 @@ #include "smap.h" #include "sset.h" #include "svec.h" +#include "stopwatch.h" #include "stream.h" #include "stream-ssl.h" #include "timeval.h" @@ -59,6 +60,10 @@ VLOG_DEFINE_THIS_MODULE(ovn_northd); +#define NORTHD_LOOP_STOPWATCH_NAME "ovn-northd-loop" +#define OVNNB_DB_RUN_STOPWATCH_NAME "ovnnb_db_run" +#define OVNSB_DB_RUN_STOPWATCH_NAME "ovnsb_db_run" + static unixctl_cb_func ovn_northd_exit; static unixctl_cb_func ovn_northd_pause; static unixctl_cb_func ovn_northd_resume; @@ -13238,6 +13243,9 @@ ovnnb_db_run(struct northd_context *ctx, if (!ctx->ovnsb_txn || !ctx->ovnnb_txn) { return; } + + stopwatch_start(OVNNB_DB_RUN_STOPWATCH_NAME, time_msec()); + struct hmap port_groups; struct hmap mcast_groups; struct hmap igmp_groups; @@ -13379,6 +13387,8 @@ ovnnb_db_run(struct northd_context *ctx, * as well. */ cleanup_macam(); + + stopwatch_stop(OVNNB_DB_RUN_STOPWATCH_NAME, time_msec()); } /* Stores the list of chassis which references an ha_chassis_group. @@ -13970,6 +13980,8 @@ ovnsb_db_run(struct northd_context *ctx, return; } + stopwatch_start(OVNSB_DB_RUN_STOPWATCH_NAME, time_msec()); + struct shash ha_ref_chassis_map = SHASH_INITIALIZER(&ha_ref_chassis_map); handle_port_binding_changes(ctx, ports, &ha_ref_chassis_map); update_northbound_cfg(ctx, sb_loop, loop_start_time); @@ -13977,6 +13989,8 @@ ovnsb_db_run(struct northd_context *ctx, update_sb_ha_group_ref_chassis(&ha_ref_chassis_map); } shash_destroy(&ha_ref_chassis_map); + + stopwatch_stop(OVNSB_DB_RUN_STOPWATCH_NAME, time_msec()); } static void @@ -14425,6 +14439,10 @@ main(int argc, char *argv[]) char *ovn_internal_version = ovn_get_internal_version(); VLOG_INFO("OVN internal version is : [%s]", ovn_internal_version); + stopwatch_create(NORTHD_LOOP_STOPWATCH_NAME, SW_MS); + stopwatch_create(OVNNB_DB_RUN_STOPWATCH_NAME, SW_MS); + stopwatch_create(OVNSB_DB_RUN_STOPWATCH_NAME, SW_MS); + /* Main loop. */ exiting = false; @@ -14508,6 +14526,8 @@ main(int argc, char *argv[]) ovsdb_idl_wait(ovnsb_idl_loop.idl); } + stopwatch_stop(NORTHD_LOOP_STOPWATCH_NAME, time_msec()); + stopwatch_start(NORTHD_LOOP_STOPWATCH_NAME, time_msec()); unixctl_server_run(unixctl); unixctl_server_wait(unixctl); memory_wait(); From patchwork Tue Jun 15 11:54:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Mark Gray X-Patchwork-Id: 1492157 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.133; helo=smtp2.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Re/IWwVW; dkim-atps=neutral Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4G46Fl0jl0z9sTD for ; Tue, 15 Jun 2021 21:55:23 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 5EA53404BB; Tue, 15 Jun 2021 11:55:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nBZ7PlZ_V5zk; Tue, 15 Jun 2021 11:55:20 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp2.osuosl.org (Postfix) with ESMTPS id 3C193402E8; Tue, 15 Jun 2021 11:55:19 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id F3EAEC0011; Tue, 15 Jun 2021 11:55:18 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id EA6C9C000B for ; Tue, 15 Jun 2021 11:55:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id D7EF7405C0 for ; Tue, 15 Jun 2021 11:54:57 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=fail (1024-bit key) reason="fail (body has been altered)" header.d=redhat.com Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ApVxhCYrEKUl for ; Tue, 15 Jun 2021 11:54:51 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp4.osuosl.org (Postfix) with ESMTPS id 53E49405E0 for ; Tue, 15 Jun 2021 11:54:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623758090; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KSgz29QWVTRhamOJbkBPEk5kd+nXx1kTZorBPn5rxIQ=; b=Re/IWwVWFutj0w5kO91lgljMAnhgl82atvK3PbAF6budz4ZJxEGpyt+km6ttRtPKTrKWIW WIEL6wXiOHscLOH2B64Garvl74Wuanjg21uf5lllePdjrcrjMvSNmi3sTqXDU1+E59ALDp Pqsve+CG6Q71NcRnxRE5BxCoSYbOUk8= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-24-DmLZTiXINKWA11cfVWyCUg-1; Tue, 15 Jun 2021 07:54:41 -0400 X-MC-Unique: DmLZTiXINKWA11cfVWyCUg-1 Received: by mail-qt1-f198.google.com with SMTP id d12-20020ac8668c0000b0290246e35b30f8so9159032qtp.21 for ; Tue, 15 Jun 2021 04:54:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tMw4iXeextrBr1teXDUA+xcoozyxDyxDeKjqaGU5sTM=; b=pFoweUu8jHBjz02lUxm03stfsHOgvHmki5ppZLdt5hODhdhLpNk/M197QHdGYjR1nK +dD07W8OXbpNPN+OrPV7LwB2fRi2L2w76G6RW1O5/O5QoX0JaH3dkVwwtX6bO5ue5Iwe q/HFtuax7yWBAbCHw2zQvuGOtF+xuhyGd4IC321KUOSIxY53RmKcgn7k344n7LVsfqYm 0VtVh2yEuJ6oyMV9r0kBBNBtE9vLgRX7zE3jrNTSlGRZPgKc5hJGND2Q+TesmqxNpNpT VRk3P97CW+eZbJrrg7piaWRkn4tAlSr/sOqH84HWVI3xDAwRwnzOOUmYmlRZ1SnCGi6y cLVw== X-Gm-Message-State: AOAM533CWfQ/rmL243oeDJcqqbuwKy6wJsSQdSVZPf4dvOeKJvFLg9cy G1/C/aiiXLsJ6A1u0gXgjmZvTD/9pROGVMfQ/3QPyPqMKClrOvWoH0dvSuVFEJQu2WK/seZEbdh DOROjeh7lDOslz/h8/0H+SEN4YDBSJZR6NRp9NsFoVlkQKXCHx6HVVaV8aWRgcRbSQxZ8 X-Received: by 2002:ac8:7c99:: with SMTP id y25mr4057556qtv.239.1623758080655; Tue, 15 Jun 2021 04:54:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxBL7SJ2hPRXo9SlRdnTGyv/E5UAWSUm69d6LwvwuPiupTDTLsJsSvzho1ROWHW3Blm9B+N5Q== X-Received: by 2002:ac8:7c99:: with SMTP id y25mr4057527qtv.239.1623758080284; Tue, 15 Jun 2021 04:54:40 -0700 (PDT) Received: from wsfd-netdev91.ntdv.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id f4sm2735366qte.28.2021.06.15.04.54.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jun 2021 04:54:39 -0700 (PDT) From: Mark Gray To: dev@openvswitch.org Date: Tue, 15 Jun 2021 07:54:35 -0400 Message-Id: <20210615115435.2461498-4-mark.d.gray@redhat.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210615115435.2461498-1-mark.d.gray@redhat.com> References: <20210615115435.2461498-1-mark.d.gray@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mark.d.gray@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [ovs-dev] [PATCH ovn 3/3] tests: Add check-perf target X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" Add a suite of micro-benchmarks to aid a developer in understanding the performance impact of any changes that they are making. They can be used to help to understand the relative performance between two test runs on the same test machine, but are not intended to give the absolute performance of OVN. To invoke the performance testsuite, run: $ make check-perf This will run all available performance tests. Additional metrics (e.g. memory, coverage, perf counters) may be added in the future. Additional tests (e.g. additional topologies, ovn-controller tests) may be added in the future. Signed-off-by: Mark Gray --- Documentation/topics/testing.rst | 49 ++++++++ tests/.gitignore | 3 + tests/automake.mk | 26 ++++ tests/perf-northd.at | 207 +++++++++++++++++++++++++++++++ tests/perf-testsuite.at | 26 ++++ 5 files changed, 311 insertions(+) create mode 100644 tests/perf-northd.at create mode 100644 tests/perf-testsuite.at diff --git a/Documentation/topics/testing.rst b/Documentation/topics/testing.rst index be9e7c57331c..ccd3278437b1 100644 --- a/Documentation/topics/testing.rst +++ b/Documentation/topics/testing.rst @@ -256,3 +256,52 @@ the following:: All the features documented under `Unit Tests`_ are available for the datapath testsuites, except that the datapath testsuites do not support running tests in parallel. + +Performance testing +~~~~~~~~~~~~~~~~~~~ + +OVN includes a suite of micro-benchmarks to aid a developer in understanding the +performance impact of any changes that they are making. They can be used to +help to understand the relative performance between two test runs on the same +test machine, but are not intended to give the absolute performance of OVN. + +To invoke the performance testsuite, run:: + + $ make check-perf + +This will run all available performance tests. Some of these tests may be +long-running as they need to build complex logical network topologies. In order +to speed up subsequent test runs, some objects (e.g. the Northbound DB) may be +cached. In order to force the tests to rebuild all these objects, run:: + + $ make check-perf TESTSUITEFLAGS="--rebuild" + +A typical workflow for a developer trying to improve the performance of OVN +would be the following: + +0. Optional: Modify/add a performance test to buld the topology that you are + benchmarking, if required. +1. Run ``make check-perf TESTSUITEFLAGS="--rebuild"`` to generate cached + databases. + +.. note:: + This step may take some time depending on the number of tests that are being + rebuilt, the complexity of the tests and the performance of the test machine. + If you are only using one test, you can specify the test to run by adding the + test number to the ``make`` command. + (e.g. ``make check-perf TESTSUITEFLAGS="--rebuild "``) + +2. Run ``make check-perf`` to measure the performance metric that you are + benchmarking against. If you are only using one test, you can specify the test to run by adding the test number to the ``make`` command. + (e.g. ``make check-perf TESTSUITEFLAGS="--rebuild "``) +3. Modify OVN code to implement the change that you believe will improve the + performance. +4. Go to Step 2. to continue making improvements. + +If, as a developer, you modify a performance test in a way that may change one +of these cached objects, be sure to rebuild the test. + +The results of each test run are displayed on the screen at the end of the test +run but are also saved in the file ``tests/perf-testsuite.dir/results``. The +cached objects are stored under the relevant folder in +``tests/perf-testsuite.dir/cached``. diff --git a/tests/.gitignore b/tests/.gitignore index 8479f9bb0f8f..65cb1c6e4fad 100644 --- a/tests/.gitignore +++ b/tests/.gitignore @@ -22,6 +22,9 @@ /system-offloads-testsuite /system-offloads-testsuite.dir/ /system-offloads-testsuite.log +/perf-testsuite +/perf-testsuite.dir/ +/perf-testsuite.log /test-aes128 /test-atomic /test-bundle diff --git a/tests/automake.mk b/tests/automake.mk index 742e5cff28cc..ab04461eef69 100644 --- a/tests/automake.mk +++ b/tests/automake.mk @@ -4,9 +4,11 @@ EXTRA_DIST += \ $(SYSTEM_TESTSUITE_AT) \ $(SYSTEM_KMOD_TESTSUITE_AT) \ $(SYSTEM_USERSPACE_TESTSUITE_AT) \ + $(PERF_TESTSUITE_AT) \ $(TESTSUITE) \ $(SYSTEM_KMOD_TESTSUITE) \ $(SYSTEM_USERSPACE_TESTSUITE) \ + $(PERF_TESTSUITE) \ tests/atlocal.in \ $(srcdir)/package.m4 \ $(srcdir)/tests/testsuite \ @@ -52,6 +54,10 @@ SYSTEM_TESTSUITE_AT = \ tests/system-ovn.at \ tests/system-ovn-kmod.at +PERF_TESTSUITE_AT = \ + tests/perf-testsuite.at \ + tests/perf-northd.at + check_SCRIPTS += tests/atlocal TESTSUITE = $(srcdir)/tests/testsuite @@ -59,6 +65,9 @@ TESTSUITE_PATCH = $(srcdir)/tests/testsuite.patch TESTSUITE_DIR = $(abs_top_builddir)/tests/testsuite.dir SYSTEM_KMOD_TESTSUITE = $(srcdir)/tests/system-kmod-testsuite SYSTEM_USERSPACE_TESTSUITE = $(srcdir)/tests/system-userspace-testsuite +PERF_TESTSUITE = $(srcdir)/tests/perf-testsuite +PERF_TESTSUITE_DIR = $(abs_top_builddir)/tests/perf-testsuite.dir +PERF_TESTSUITE_RESULTS = $(PERF_TESTSUITE_DIR)/results DISTCLEANFILES += tests/atconfig tests/atlocal AUTOTEST_PATH = $(ovs_builddir)/utilities:$(ovs_builddir)/vswitchd:$(ovs_builddir)/ovsdb:$(ovs_builddir)/vtep:tests:$(PTHREAD_WIN32_DIR_DLL):$(SSL_DIR):controller-vtep:northd:utilities:controller:ic @@ -171,6 +180,19 @@ check-system-userspace: all clean-local: test ! -f '$(TESTSUITE)' || $(SHELL) '$(TESTSUITE)' -C tests --clean + +check-perf: all + @echo > $(PERF_TESTSUITE_RESULTS) + set $(SHELL) '$(PERF_TESTSUITE)' -C tests AUTOTEST_PATH='$(AUTOTEST_PATH)'; \ + $(SUDO) "$$@" $(TESTSUITEFLAGS) -j1 || (test X'$(RECHECK)' = Xyes && $(SUDO) "$$@" --recheck) + @echo + @echo '## -------------------- ##' + @echo '## Performance Results ##' + @echo '## -------------------- ##' + @cat $(PERF_TESTSUITE_RESULTS) + @echo + @echo "Results can be found in $(PERF_TESTSUITE_RESULTS)" + AUTOTEST = $(AUTOM4TE) --language=autotest @@ -193,6 +215,10 @@ $(SYSTEM_USERSPACE_TESTSUITE): package.m4 $(SYSTEM_TESTSUITE_AT) $(SYSTEM_USERSP $(AM_V_GEN)$(AUTOTEST) -I '$(srcdir)' -o $@.tmp $@.at $(AM_V_at)mv $@.tmp $@ +$(PERF_TESTSUITE): package.m4 $(PERF_TESTSUITE_AT) $(COMMON_MACROS_AT) + $(AM_V_GEN)$(AUTOTEST) -I '$(srcdir)' -o $@.tmp $@.at + $(AM_V_at)mv $@.tmp $@ + # The `:;' works around a Bash 3.2 bug when the output is not writeable. $(srcdir)/package.m4: $(top_srcdir)/configure.ac $(AM_V_GEN):;{ \ diff --git a/tests/perf-northd.at b/tests/perf-northd.at new file mode 100644 index 000000000000..eb0c391c4650 --- /dev/null +++ b/tests/perf-northd.at @@ -0,0 +1,207 @@ +AT_BANNER([ovn-northd performance tests]) + +# CACHE_NBDB() +# +# Save the current northbound database for future test runs. +# +m4_define([CACHE_NBDB],[ + mkdir -p ${at_suite_dir}/cached/${at_group} + cp -f ${ovs_base}/ovn-nb/ovn-nb.db ${at_suite_dir}/cached/${at_group}/ +]) + +# BUILD_NBDB([COMMANDS]) +# +# Configure the northbound database using COMMANDS. +# +# BUILD_NBDB() will check if there is a cached nortbound database present +# for this test group. If present, it will use the cached version. If the +# testsuite was run using the '--rebuild' flag, it will force a rebuild of the +# northbound database. +# +m4_define([BUILD_NBDB],[ + if [[ ! -f ${at_suite_dir}/cached/${at_group}/ovn-nb.db ]] || [[ $at_arg_rebuild != false ]]; then + echo "Rebuild NBDB" + $1 + CACHE_NBDB() + else + echo "Using cached NBDB" + rm ${at_suite_dir}/cached/${at_group}/.ovn-nb.db.~lock~ + ovs-appctl -t ovn-nb/ovsdb-server ovsdb-server/remove-db OVN_Northbound + ovs-appctl -t ovn-nb/ovsdb-server ovsdb-server/add-db ${at_suite_dir}/cached/${at_group}/ovn-nb.db + fi + ovn-nbctl --wait=sb sync +]) + +# PERF_RECORD_BANNER() +# +# Append standard banner to performance results. +# +m4_define([PERF_RECORD_START],[ + echo >> ${at_suite_dir}/results + echo "$at_desc_line" >> ${at_suite_dir}/results + echo " ---" >> ${at_suite_dir}/results +]) + +# PERF_RECORD_RESULT([KEY], [VALUE]) +# +# Append KEY and VALUE to performance results. +# +m4_define([PERF_RECORD_RESULT],[ + echo " $1: $2" >> ${at_suite_dir}/results +]) + +m4_define([PARSE_STOPWATCH], [ + grep -A 6 $1 | grep $2 | sed 's/[[^0-9.]]*//g' +]) + +# PERF_RECORD_STOPWATCH([NAME], [METRIC]) +# +# Append the value of the OVN stopwatch metric METRIC from stopwatch NAME +# to performance results. +# +m4_define([PERF_RECORD_STOPWATCH], [ + PERF_RECORD_RESULT($3, [`ovn-appctl -t northd/NORTHD_TYPE stopwatch/show | PARSE_STOPWATCH($1, $2)`]) +]) + +# PERF_RECORD() +# +# Append a number of metrics to performance results +# +m4_define([PERF_RECORD_STOP], [ + PERF_RECORD_STOPWATCH(ovnnb_db_run, ["Maximum"], [Maximum (NB)]) + PERF_RECORD_STOPWATCH(ovnnb_db_run, ["Short term average"], [Average (NB)]) +]) + +# OVN_NBCTL([NBCTL_COMMAND]) +# +# Add NBCTL_COMMAND to list of commands to be run by RUN_OVN_NBCTL(). +# +m4_define([OVN_NBCTL], [ + command="${command} -- $1" +]) + +# RUN_OVN_NBCTL() +# +# Execute list of commands built by the OVN_NBCTL() macro. +# +m4_define([RUN_OVN_NBCTL], [ + check ovn-nbctl ${command} + unset command +]) + +OVS_START_SHELL_HELPERS +generate_subnet () { + local a=$(printf %d $(expr $1 / 256 + 10)) + local b=$(printf %d $(expr $1 % 256)) + echo $a.$b.0.0/16 +} +generate_ip () { + local a=$(printf %d $(expr $1 / 256 + 10)) + local b=$(printf %d $(expr $1 % 256)) + local c=$(printf %d $(expr $2 / 256)) + local d=$(printf %d $(expr $2 % 256)) + echo $a.$b.$c.$d +} +generate_router_ip () { + local a=$(printf %d $(expr $1 / 256 + 10)) + local b=$(printf %d $(expr $1 % 256)) + echo $a.$b.255.254 +} +generate_mac () { + local a=$(printf %02x $(expr $1 / 256)) + local b=$(printf %02x $(expr $1 % 256)) + local c=$(printf %02x $(expr $2 / 256)) + local d=$(printf %02x $(expr $2 % 256)) + echo f0:00:$a:$b:$c:$d +} +OVS_END_SHELL_HELPERS + +# OVN_BASIC_SCALE_CONFIG(HYPERVISORS, PORTS) +# +# Configures OVN with HYPERVISORS x logical switches. Each logical +# switch has PORTS x logical ports and is connected to one +# Logical Router. The logical router hosts an snat entry for the subnet hosted +# on each logical switch. This is illustrated below. +# +# . +# . +# . +# . +# . +# . Logical Switch ───┐ +# │ │ +# Logical Port ───────────┤ │ +# │ │ +# Logical Port ───────────┼── Logical Switch ───┤ +# │ │ +# Logical Port ───────────┤ ├──── Logical Router +# │ │ (snat entries) +# . Logical Switch ───┤ +# . │ +# . . │ +# . │ +# . +# +m4_define([OVN_BASIC_SCALE_CONFIG], [ + # In order to speed up building the NBDB, we run `ovn-nbctl` in daemon mode. + # We also coalesce `ovn-nbctl` commands using the OVN_NBCTL() and + # RUN_OVN_NBCTL() macros + # + on_exit 'kill $(cat ovn-nbctl.pid)' + export OVN_NB_DAEMON=$(ovn-nbctl --pidfile --detach) + + for hv in $(seq 1 $1); do + echo "Adding hypervisor ${hv}" + total_hv=$1 + logical_switch=lsw${hv} + logical_router=lrw${hv} + logical_router_port=lr${hv}lrp0 + logical_switch_router_port=lr${hv}lsp0 + logical_router_ip=$(generate_router_ip ${hv}) + logical_router_nat_ip=$(generate_ip $((hv+total_hv)) 1) + logical_router_mac=$(generate_mac ${hv} 1) + logical_switch_subnet=$(generate_subnet ${hv}) + + OVN_NBCTL(ls-add $logical_switch) + OVN_NBCTL(set Logical_Switch $logical_switch other_config:subnet=${logical_switch_subnet}) + OVN_NBCTL(set Logical_Switch $logical_switch other_config:exclude_ips=$logical_router_ip) + + OVN_NBCTL(lr-add $logical_router) + OVN_NBCTL(lrp-add $logical_router $logical_router_port $logical_router_mac ${logical_router_ip}/16) + OVN_NBCTL(lr-nat-add $logical_router snat $logical_router_nat_ip $logical_switch_subnet) + OVN_NBCTL(lsp-add $logical_switch $logical_switch_router_port -- set Logical_Switch_Port $logical_switch_router_port type=router options:router-port=$logical_router_port addresses=dynamic) + + for port in $(seq 1 $2); do + logical_switch_port=lsw${hv}lsp${port} + OVN_NBCTL(lsp-add $logical_switch $logical_switch_port) + OVN_NBCTL(lsp-set-addresses $logical_switch_port dynamic) + done + + RUN_OVN_NBCTL() + + done +]) + +OVN_FOR_EACH_NORTHD([ +AT_SETUP([ovn-northd basic scale test -- 200 Hypervisors, 200 Logical Ports/Hypervisor]) +PERF_RECORD_START() + +ovn_start + +BUILD_NBDB(OVN_BASIC_SCALE_CONFIG(200, 200)) + +PERF_RECORD_STOP() +AT_CLEANUP +]) + +OVN_FOR_EACH_NORTHD([ +AT_SETUP([ovn-northd basic scale test -- 500 Hypervisors, 50 Logical Ports/Hypervisor]) +PERF_RECORD_START() + +ovn_start + +BUILD_NBDB(OVN_BASIC_SCALE_CONFIG(500, 50)) + +PERF_RECORD_STOP() +AT_CLEANUP +]) \ No newline at end of file diff --git a/tests/perf-testsuite.at b/tests/perf-testsuite.at new file mode 100644 index 000000000000..31cdc850c55f --- /dev/null +++ b/tests/perf-testsuite.at @@ -0,0 +1,26 @@ +AT_INIT + +AT_COPYRIGHT([Copyright (c) 2021 Red Hat, + +Licensed under the Apache License, Version 2.0 (the "License"); +you may not use this file except in compliance with the License. +You may obtain a copy of the License at: + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License.]) + +m4_ifdef([AT_COLOR_TESTS], [AT_COLOR_TESTS]) +AT_ARG_OPTION([rebuild], [Do not use cached versions of databases]) + +m4_include([tests/ovs-macros.at]) +m4_include([tests/ovsdb-macros.at]) +m4_include([tests/ofproto-macros.at]) +m4_include([tests/ovn-macros.at]) + +m4_include([tests/perf-northd.at]) +