From patchwork Thu Jan 18 08:07:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Townsend X-Patchwork-Id: 862788 X-Patchwork-Delegate: hs@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="EIg3tcT8"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3zMc5Q39RBz9s7M for ; Thu, 18 Jan 2018 19:07:52 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 5F2E9C21E6F; Thu, 18 Jan 2018 08:07:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 307E3C21DD9; Thu, 18 Jan 2018 08:07:44 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 1B480C21DD9; Thu, 18 Jan 2018 08:07:43 +0000 (UTC) Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com [209.85.128.194]) by lists.denx.de (Postfix) with ESMTPS id B8DEAC21C41 for ; Thu, 18 Jan 2018 08:07:42 +0000 (UTC) Received: by mail-wr0-f194.google.com with SMTP id e41so21271497wre.9 for ; Thu, 18 Jan 2018 00:07:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=vNScldHLDXxf9ojxQIixFAOtmwGwsRMQaY82hmKVEX8=; b=EIg3tcT8flM0DNQ1lCZUeVI7zOQotzXGuOKzaoxBwI2v318oa4ZIT2vCb7FIPI0bwH mtaYqIs4+F6AnlFiJnSNoYvNkdpC2MRbuoAnna5S4SZifcoG1sAQ6LU4TcHTTQWgKPTy brf3moRPPbq4lPZDgbDEHCK/PY6zTk2PRl1GO3bOx0JnWb1xf81Uv5xftDs2GOQ8LnC+ bcLkmI6glUF3HN5vgylh92jhA+7CcwHi6TQw8GLSYMXFVu9SXyLuEX7pZvhAWn6mdFZD 4tQCTG7E4FrtksKA8pa/8BuqdgR6F9qUaGouXjeNeASKyYZL5xYMhXAYKpMmCTql8apU oarQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=vNScldHLDXxf9ojxQIixFAOtmwGwsRMQaY82hmKVEX8=; b=VO2pAiO4iWdSV+UjZCTUW3UYhY+DJi25G7RHvLk/p3PFsUQGk9iWxDJDUyNlLOGzzG vtFy9yU/yrdBcZQxL2VfvUcyspROWepqIr9QmibNKr6J/K6gTuz1N6l2daMX79SlAEMO SrQW4y4Eh4sta0BWWUzhK/beBdVISBfD43U9ZA5aTJi4NL8ao+bNtBk06317QGkjH1Ri teShmJ0tfHSKbq8e3NF8ktZO797XNPGw0aZ810NP7/PcWePUBEopUw9yVUJj+LyXCJhe gydS90ElKuAA+fiqY9HlQNXhZ69BAC4+k466eCNeMDMVKsIlVukYEC+EwMRi837WlfEr 4BCg== X-Gm-Message-State: AKwxytcOxUBPyxPqr0QY8vL9ROA3c2nZ8D0DkHBdpoNyBUMF6ZCR38C3 Ow9Z75/x7R1xCjZRVr/pODmWRiAOoM0= X-Google-Smtp-Source: ACJfBouHh91lzjGki5d1CCY6NjsbaRaWUsZLFwqjKi/qO1dPHHbHM2qKS6tkToxRDGADHFdpvBDwjA== X-Received: by 10.223.148.162 with SMTP id 31mr5530893wrr.232.1516262862280; Thu, 18 Jan 2018 00:07:42 -0800 (PST) Received: from localhost.localdomain (cpc81712-swin18-2-0-cust20.3-1.cable.virginm.net. [82.30.3.21]) by smtp.gmail.com with ESMTPSA id q196sm6746295wmb.22.2018.01.18.00.07.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 18 Jan 2018 00:07:41 -0800 (PST) From: Martin Townsend To: u-boot@lists.denx.de Date: Thu, 18 Jan 2018 08:07:33 +0000 Message-Id: <1516262853-8611-1-git-send-email-mtownsend1973@gmail.com> X-Mailer: git-send-email 2.7.4 Cc: Martin Townsend , kmpark@infradead.org, richard@sigma-star.at Subject: [U-Boot] [PATCH v2] ubi: Ensure no fastmap flush after uif_close X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" On detach UBI attempts to update fastmap after closing user interfaces but at this point UBI volumes have already been free()'ed and fastmap can no longer access these data structures. Signed-off-by: Martin Townsend Cc: hs@denx.de Cc: kmpark@infradead.org Cc: richard@sigma-star.at --- Changes for v2: - Fix by removing update to fastmap from ubi_fastmap_close instead of reordering uif_close and ubi_wl_close in ubi_detach_mtd_dev drivers/mtd/ubi/fastmap-wl.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/mtd/ubi/fastmap-wl.c b/drivers/mtd/ubi/fastmap-wl.c index a33d406..b7876a8 100644 --- a/drivers/mtd/ubi/fastmap-wl.c +++ b/drivers/mtd/ubi/fastmap-wl.c @@ -337,11 +337,6 @@ static void ubi_fastmap_close(struct ubi_device *ubi) { int i; -#ifndef __UBOOT__ - flush_work(&ubi->fm_work); -#else - update_fastmap_work_fn(ubi); -#endif return_unused_pool_pebs(ubi, &ubi->fm_pool); return_unused_pool_pebs(ubi, &ubi->fm_wl_pool);