From patchwork Wed Jan 17 12:09:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis de Bethencourt X-Patchwork-Id: 862240 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zM5WD0rLHz9sPk for ; Wed, 17 Jan 2018 23:10:00 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752775AbeAQMJh (ORCPT ); Wed, 17 Jan 2018 07:09:37 -0500 Received: from smtp-fw-4101.amazon.com ([72.21.198.25]:20344 "EHLO smtp-fw-4101.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752228AbeAQMJf (ORCPT ); Wed, 17 Jan 2018 07:09:35 -0500 X-IronPort-AV: E=Sophos;i="5.46,372,1511827200"; d="scan'208";a="703850380" Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-1a-16acd5e0.us-east-1.amazon.com) ([10.43.8.6]) by smtp-border-fw-out-4101.iad4.amazon.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 17 Jan 2018 12:09:22 +0000 Received: from uecb1d7364e75593fe229.ant.amazon.com (iad1-ws-svc-lb91-vlan2.amazon.com [10.0.103.146]) by email-inbound-relay-1a-16acd5e0.us-east-1.amazon.com (8.14.7/8.14.7) with ESMTP id w0HC9Hgk020895 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 17 Jan 2018 12:09:19 GMT Received: from uecb1d7364e75593fe229.ant.amazon.com (localhost [127.0.0.1]) by uecb1d7364e75593fe229.ant.amazon.com (8.15.2/8.15.2/Debian-3) with ESMTP id w0HC9Gv6018918; Wed, 17 Jan 2018 12:09:16 GMT Received: (from luisbg@localhost) by uecb1d7364e75593fe229.ant.amazon.com (8.15.2/8.15.2/Submit) id w0HC9GlM018914; Wed, 17 Jan 2018 12:09:16 GMT From: Luis de Bethencourt To: linux-kernel@vger.kernel.org Cc: Joe Perches , Saeed Mahameed , Matan Barak , Leon Romanovsky , Erez Shitrit , "David S . Miller" , Alex Vesker , Feras Daoud , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, Luis de Bethencourt Subject: [PATCH] net/mlx5e: Fix trailing semicolon Date: Wed, 17 Jan 2018 12:09:15 +0000 Message-Id: <20180117120915.18837-1-luisbg@kernel.org> X-Mailer: git-send-email 2.15.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The trailing semicolon is an empty statement that does no operation. Removing it since it doesn't do anything. Signed-off-by: Luis de Bethencourt Reviewed-by: Saeed Mahameed --- Hi, After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches suggested I fix it treewide [0]. Best regards, Luis [0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html [1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c b/drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c index bf9dc4516d2c..3ff81411ae93 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c @@ -485,7 +485,7 @@ static int mlx5i_close(struct net_device *netdev) mlx5_fs_remove_rx_underlay_qpn(mdev, ipriv->qp.qpn); mlx5i_uninit_underlay_qp(epriv); mlx5e_deactivate_priv_channels(epriv); - mlx5e_close_channels(&epriv->channels);; + mlx5e_close_channels(&epriv->channels); unlock: mutex_unlock(&epriv->state_lock); return 0;