From patchwork Wed Apr 7 17:37:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Sandiford X-Patchwork-Id: 1463449 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=Wy4iHM8Q; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FFs6d5XJ8z9sWS for ; Thu, 8 Apr 2021 03:37:44 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7A95B385483B; Wed, 7 Apr 2021 17:37:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7A95B385483B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1617817061; bh=CsVJbIyTGv7c2nYADhyn9q3wqiqA24nNylbt5/NBQnE=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=Wy4iHM8QlTSBcAiYylsMI4KDvAUh7W9I+EKmrSNa2SIdpaL1hHJDKP1oK103BbbBG MxezJHDbZ7p1ckaMkIqeMMZfFB7S9TvMjDMloUlczVK35XF2HDDrV18zgTyH6jVWUb BxMkFR7n8iBOj+1bkfYCe4ICBLNAMGstJ0Tp89nQ= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 513813854816 for ; Wed, 7 Apr 2021 17:37:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 513813854816 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8AA991063 for ; Wed, 7 Apr 2021 10:37:37 -0700 (PDT) Received: from localhost (e121540-lin.manchester.arm.com [10.32.98.126]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 329213F73D for ; Wed, 7 Apr 2021 10:37:37 -0700 (PDT) To: gcc-patches@gcc.gnu.org Mail-Followup-To: gcc-patches@gcc.gnu.org, richard.sandiford@arm.com Subject: [PATCH] testsuite: Fix many UNRESOLVEDs for gcc.dg/vect Date: Wed, 07 Apr 2021 18:37:36 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Sandiford via Gcc-patches From: Richard Sandiford Reply-To: Richard Sandiford Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" It turns out that, on targets that use testglue, many gcc.dg/vect scan-assembler tests became UNRESOLVED after the change to the dump file naming scheme. The problem is that, when creating an executable, we normally name the dump file after both the executable and the source file name. However, as an exception, we name it after only the source file name if: (a) there is only one source file name and (b) the source file and the executable have the same basename Both (a) and (b) are normally true when building executables from gcc.dg/vect. But (a) is not true when linking against testglue. The harness was therefore looking for a dump file based only on the source file name while the compiler was producing a dump file that contained both names. We get around this for dg-additional-sources using: # This option restores naming of aux and dump output files # after input files when multiple input files are named, # instead of getting them combined with the output name. lappend options "additional_flags=-dumpbase \"\"" This patch does the same thing for executables that are linked against testglue. This removes over 2400 UNRESOLVEDs from an armeb-eabi test run, but in so doing introduces FAILs for some tests that were previously skipped. Tested on armeb-eabi. OK to install? Richard gcc/testsuite/ * lib/gcc.exp (gcc_target_compile): Add -dumpbase "" when building an executable with testglue. --- gcc/testsuite/lib/gcc.exp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gcc/testsuite/lib/gcc.exp b/gcc/testsuite/lib/gcc.exp index dda4d0e6366..4d80606d386 100644 --- a/gcc/testsuite/lib/gcc.exp +++ b/gcc/testsuite/lib/gcc.exp @@ -134,6 +134,9 @@ proc gcc_target_compile { source dest type options } { [info exists gluefile] } { lappend options "libs=${gluefile}" lappend options "ldflags=$wrap_flags" + if { $type == "executable" } { + set options [concat "{additional_flags=-dumpbase \"\"}" $options] + } } global TEST_EXTRA_LIBS