From patchwork Tue Jan 16 10:38:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 861401 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=oracle.com header.i=@oracle.com header.b="PgBWATDf"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zLRXx0sRKz9t2Q for ; Tue, 16 Jan 2018 21:39:13 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751426AbeAPKjK (ORCPT ); Tue, 16 Jan 2018 05:39:10 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:49086 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750908AbeAPKjJ (ORCPT ); Tue, 16 Jan 2018 05:39:09 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w0GAQt2Z144682; Tue, 16 Jan 2018 10:39:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : mime-version : content-type; s=corp-2017-10-26; bh=g3TyxUruPwa0eIbf/JPK4eaTNE+JOXShii1ZVYkjJiw=; b=PgBWATDfEa5TSUorg1T2xaDr6YJV2pGadyjLTmqJVyNbalecL3kAPh5CgjKcMk9cjxOF 4m2O8xOlHOB91mo5kZSrB/dojNoW1NeITZ4MMmjpsBW60zRRb3eLBU6VhalG92RmYglH EDVunaK865sTHreiy6hSKqGr2UtCLLTTfrUf5VvzOB+BmFujoUnktyMTly2af5rVerQH 2BxPMT4jUquUign2x1NyA4QQQAPjcLVmtBQjcWUsnlIYbIhjln8oBqAAzrAiud511rTQ 53+1VZIUrtdO0kr/hlvNBsRHuaD2joLD102iDYTAyL5iVXpJnLDwAYTWAdnnWFTLW9/p AQ== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2120.oracle.com with ESMTP id 2fhfdpg3h2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 16 Jan 2018 10:39:07 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w0GAd6ff014947 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 16 Jan 2018 10:39:07 GMT Received: from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w0GAd62R027267; Tue, 16 Jan 2018 10:39:06 GMT Received: from mwanda (/197.157.0.32) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 16 Jan 2018 02:39:06 -0800 Date: Tue, 16 Jan 2018 13:38:59 +0300 From: Dan Carpenter To: Michael Chan , Andy Gospodarek Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH net-next] bnxt_en: uninitialized variable in bnxt_rx_pkt() Message-ID: <20180116103859.GA3374@mwanda> MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding User-Agent: Mutt/1.9.2 (2017-12-15) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8775 signatures=668652 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=646 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1801160153 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org There are a couple failure paths where "len" is used uninitialized. It means we record the number of rx_packets incorrectly. Fixes: 6a8788f25625 ("bnxt_en: add support for software dynamic interrupt moderation") Signed-off-by: Dan Carpenter diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index cf6ebf1e324b..5b5c4f266f1b 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -1482,7 +1482,7 @@ static int bnxt_rx_pkt(struct bnxt *bp, struct bnxt_napi *bnapi, u32 *raw_cons, u32 tmp_raw_cons = *raw_cons; u16 cfa_code, cons, prod, cp_cons = RING_CMP(tmp_raw_cons); struct bnxt_sw_rx_bd *rx_buf; - unsigned int len; + unsigned int len = 0; u8 *data_ptr, agg_bufs, cmp_type; dma_addr_t dma_addr; struct sk_buff *skb;