From patchwork Tue Mar 23 04:14:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1457026 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=FojWitdd; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4F4J1G5F7Yz9sVS for ; Tue, 23 Mar 2021 15:14:58 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5C4AD80200; Tue, 23 Mar 2021 05:14:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="FojWitdd"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6C12880200; Tue, 23 Mar 2021 05:14:51 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2F69780200 for ; Tue, 23 Mar 2021 05:14:47 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-pg1-x535.google.com with SMTP id m7so10419539pgj.8 for ; Mon, 22 Mar 2021 21:14:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=V+jd+XVO2hg4UCP1cytHR2YWSgzgRe0NDLtkD87xCBc=; b=FojWitddLHjfGOhmUFC2eLJV2+4sjEbBCU7NjNEluRc4HTnbz6OevzsVRoAWMghgKF 6o9pM/QSxJK1lCk6YFV3OpRf94mYg6IHTe6Q7vowOXCqHxrHijuyktG8JlqLw8oE91T8 YAo2BlfcqGnoj6oeFLiaYudtjTARBlRAGSLXw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=V+jd+XVO2hg4UCP1cytHR2YWSgzgRe0NDLtkD87xCBc=; b=pCakiX3gr3YP7GKyUCbAeIITGhOUn66bIfvJ8AhGn0SjyP7YpKcvdrKlZxlmHpNyBy e25vOqXBNf3RK5qd1psZ4E0fnxUW9SMkp/S8Q+FgZ65Jvfu922JEGGMgrWH79ycbRat3 +kUtp/9z3NiexZSmjXB8inopgoZDqzei9GP7vNFhQRkTXj/FpO9Omo6dWdCdG9HwK4+W paG1M9eRFm7Daaza/s8uI1EdAeICX6JSs6QFhxQzzljm8C2mRCDlA9alcm+2/0f6W/RY AyooBzkq6+FE9y+qK3vrlAXVntZIQLhOclScJvl7tdLoBwnoNFdhfYSOXihQv3rK3uMQ gTjQ== X-Gm-Message-State: AOAM532z14zB1JsRqAPv8rfkFtkbVqadr60D2b4dSPH8G/LYn0YG4kX4 +fKdcWuSmMcsIDNnTe3IbzsbmjWbTMZ6lw== X-Google-Smtp-Source: ABdhPJx+w5+qWqxlutMKVftWpNe3ntUtH+RxH0nNJ6A+XT9Yb+zFNIYayr8TxQAjPYYjeueaehHO8A== X-Received: by 2002:aa7:8f04:0:b029:1f7:d71b:6a51 with SMTP id x4-20020aa78f040000b02901f7d71b6a51mr3087565pfr.4.1616472885057; Mon, 22 Mar 2021 21:14:45 -0700 (PDT) Received: from sjg1.roam.corp.google.com (85.72.69.111.dynamic.snap.net.nz. [111.69.72.85]) by smtp.gmail.com with ESMTPSA id n10sm867750pjo.15.2021.03.22.21.14.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Mar 2021 21:14:44 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Marek Vasut , Tom Rini , Heinrich Schuchardt , Simon Glass , Pavel Herrmann Subject: [PATCH v2 1/9] dm: core: Document the common error codes Date: Tue, 23 Mar 2021 17:14:19 +1300 Message-Id: <20210323041427.3252184-2-sjg@chromium.org> X-Mailer: git-send-email 2.31.0.rc2.261.g7f71774620-goog In-Reply-To: <20210323041427.3252184-1-sjg@chromium.org> References: <20210323041427.3252184-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean Driver model uses quite strong conventions on error codes, but these are currently not clearly documented. Add a description of the commonly used errors. Signed-off-by: Simon Glass --- Changes in v2: - Add a patch to document the common error codes doc/driver-model/design.rst | 111 ++++++++++++++++++++++++++++++++++++ 1 file changed, 111 insertions(+) diff --git a/doc/driver-model/design.rst b/doc/driver-model/design.rst index 4e5cecbab6a..30a07bdf768 100644 --- a/doc/driver-model/design.rst +++ b/doc/driver-model/design.rst @@ -900,6 +900,117 @@ Some special flags are used to determine whether to remove the device: The dm_remove_devices_flags() function can be used to remove devices based on their driver flags. + +Error codes +----------- + +Driver model tries to use errors codes in a consistent way, as follows: + +\-EAGAIN + Try later, e.g. dependencies not ready + +\-EINVAL + Invalid argument, such as `dev_read_...()` failed or any other + devicetree-related access. Also used when a driver method is passed an + argument it considers invalid or does not support. + +\-EIO + Failed to perform I/O + +\-ENODEV + Do not bind the device. This should not be used to indicate an + error probing the device or for any other purpose, lest driver model get + confused. Using `-ENODEV` inside a driver method makes no sense, since + clearly there is a device. + +\-ENOENT + Entry or object not found + +\-ENOMEM + Out of memory + +\-ENOSPC + Ran out of space (e.g. in a buffer or limited-size array) + +\-ENOSYS + Function not implemented. This is returned by uclasses where the driver does + not implement a particular method. It can also be returned by drivers when + a particular sub-method is not implemented. This is widely checked in the + wider code base, where a feature may or may not be compiled into U-Boot. It + indicates that the feature is not available, but this is often just normal + operation. Please do not use -ENOSUPP. If an incorrect or unknown argument + is provided to a method (e.g. an unknown clock ID), return -EINVAL. + +\-ENXIO + Couldn't find device/address + +\-EPERM + This is -1 so some older code may use it as a generic error. This indicates + that an operation is not permitted, e.g. a security violation or policy + constraint. It is returned internally when binding devices before relocation, + if the device is not marked for pre-relocation use. + +\-EPFNOSUPPORT + Missing uclass. This is deliberately an uncommon error code so that it can + easily be distinguished. If you see this very early in U-Boot, it means that + a device exists with a particular uclass but the uclass does not (mostly + likely because it is not compiled in). Enable DEBUG in uclass.c or lists.c + to see which uclass ID or driver is causing the problem. + +\-EREMOTEIO + Cannot talk to peripheral, e.g. i2c + +Less common ones: + +\-EKEYREJECTED + Attempt to remove a device which does not match the removal flags. See + device_remove(). + +\-EILSEQ + Devicetree read failure, specifically trying to read a string index which + does not exist, in a string-listg property + +\-ENOEXEC + Attempt to use a uclass method on a device not in that uclass. This is + seldom checked at present, since it is generally a programming error and a + waste of code space. A DEBUG-only check would be useful here. + +\-ENODATA + Devicetree read error, where a property exists but has no data associated + with it + +\-EOVERFLOW + Devicetree read error, where the property is longer than expected + +\-EPROBE_DEFER + Attempt to remove a non-vital device when the removal flags indicate that + only vital devices should be removed + +\-ERANGE + Returned by regmap functions when arguments are out of range. This can be + useful for disinguishing regmap errors from other errors obtained while + probing devices. + +Drivers should use the same conventions so that things function as expected. +In particular, if a driver fails to probe, or a uclass operation fails, the +error code is the primary way to indicate what actually happened. + +Printing error messages in drivers is discouraged due to code size bloat and +since it can result in messages appearing in normal operation. For example, if +a command tries two different devices and uses whichever one probes correctly, +we don't want an error message displayed, even if the command itself might show +a warning or informational message. + +Error messages can be logged using `log_msg_ret()`, so that enabling +`CONFIG_LOG` and `CONFIG_LOG_ERROR_RETURN` shows a trace of error codes returned +through the call stack. That can be a handy way of quickly figuring out where +an error occurred. Get into the habit of return errors with +`return log_msg_ret("here", ret)` instead of just `return ret`. The string +just needs to be long enough to find in a single function, since a log record +stores (and can print with `CONFIG_LOGF_FUNC`) the function where it was +generated. + + Data Structures --------------- From patchwork Tue Mar 23 04:14:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1457027 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=M7ymTjZz; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4F4J1c5GT2z9sTD for ; Tue, 23 Mar 2021 15:15:16 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 924D182821; Tue, 23 Mar 2021 05:14:58 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="M7ymTjZz"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 54A4282816; Tue, 23 Mar 2021 05:14:53 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0828182815 for ; Tue, 23 Mar 2021 05:14:49 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-pf1-x42f.google.com with SMTP id y200so12937972pfb.5 for ; Mon, 22 Mar 2021 21:14:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9BdMZnUtVe860aM9IZ860AhbTKxzSSv6SNj5Z1VtQwU=; b=M7ymTjZzLOeGnzhRUJ6BPZd+kqqvsPyzjF8IJy3iLl2347Cu7eP9HDFhrlSThx7lYe 3i5i/xjfoCYCeusmJFOyw2zxkPSlQW4RE7NpJFmWLVX4E9QFej4B77g2vOVxBPWIhxV4 YikKo+9088kpIkiXKlUC310JQcVJsgcNAtmdo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9BdMZnUtVe860aM9IZ860AhbTKxzSSv6SNj5Z1VtQwU=; b=YPME0HDjnJsWsXyTBsA/PpiEG5eYu6OCUHLAJ/x2q4WO75o7lXCDPHsahA7KVE+hsI amM7ClutTjO+Wem2MiMNSd6pnme111Y3TBiU1Ho1WkmBkksxHmHCJWg7/Laflzx9U/nn XPEJ6qZKZ5cu+Bd0+Xi4ebSKFEnlw4fKbxplmUiPCAcciqPZp/Q5YJiv0UXMclGwb2QV pf04pZNoovZBDArSfgZUEHqJ/TPc7ct4OMgWwBpj5Cc0SllfWogIjhOTGCCgvkJxHHUH DzdLS0F+yyZlPANpEU+UrDjh+FzlawujaojgDX7Ysg3WHPZA5MD9KyvJYm9Al277BhuM HHtw== X-Gm-Message-State: AOAM532AKbMNPiBxyNJ7zQojmisOWryyepREF1XjclSBPqvKA+HNGfio 7CPoVDv3qSyxWEssZk+mB0rDHkCoGQmcOw== X-Google-Smtp-Source: ABdhPJw17jjWGjLNKOluCidRUPGQSNflj07+Vof6HxVbf0LzBD7pWzWETmDXt0MhkR8wA46DmAPdzw== X-Received: by 2002:a17:902:9795:b029:e4:888f:7390 with SMTP id q21-20020a1709029795b02900e4888f7390mr3211994plp.26.1616472888363; Mon, 22 Mar 2021 21:14:48 -0700 (PDT) Received: from sjg1.roam.corp.google.com (85.72.69.111.dynamic.snap.net.nz. [111.69.72.85]) by smtp.gmail.com with ESMTPSA id n10sm867750pjo.15.2021.03.22.21.14.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Mar 2021 21:14:48 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Marek Vasut , Tom Rini , Heinrich Schuchardt , Simon Glass , Pavel Herrmann Subject: [PATCH v2 2/9] dm: core: Use -ENOSPC in acpi_get_path() Date: Tue, 23 Mar 2021 17:14:20 +1300 Message-Id: <20210323041427.3252184-3-sjg@chromium.org> X-Mailer: git-send-email 2.31.0.rc2.261.g7f71774620-goog In-Reply-To: <20210323041427.3252184-1-sjg@chromium.org> References: <20210323041427.3252184-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean Update this function to use -ENOSPC which is more commly used when a buffer runs out of space. Signed-off-by: Simon Glass --- Changes in v2: - Add new patch for acpi_get_path() drivers/core/acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/core/acpi.c b/drivers/core/acpi.c index 0901b9260a1..2176d8b8365 100644 --- a/drivers/core/acpi.c +++ b/drivers/core/acpi.c @@ -91,7 +91,7 @@ int acpi_get_path(const struct udevice *dev, char *out_path, int maxlen) path = dev_read_string(dev, "acpi,path"); if (path) { if (strlen(path) >= maxlen) - return -E2BIG; + return -ENOSPC; strcpy(out_path, path); return 0; } From patchwork Tue Mar 23 04:14:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1457028 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=LBQlWSX+; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4F4J1h5whgz9sTD for ; Tue, 23 Mar 2021 15:15:20 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id ADBDB8285E; Tue, 23 Mar 2021 05:15:01 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="LBQlWSX+"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A938282821; Tue, 23 Mar 2021 05:14:56 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 48D8A82838 for ; Tue, 23 Mar 2021 05:14:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-pj1-x102b.google.com with SMTP id ha17so9519119pjb.2 for ; Mon, 22 Mar 2021 21:14:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+pxsq5P7/va1Gkht23g4NFiCHmbHv/nzI2G5bu3JUFc=; b=LBQlWSX+4NZrG9TfYHWcRHguNKqJ0Dk+PK4oRXsvho0QAHH39IqxSDwz1JW5D4z+P8 slXh2TdlUJAIr0E/b06cLc4Z5G5zV46tZVZpgOAH/MST5GWMdlTlNHxgs5jDnWhP5vel PMTa/y+T3MeBA+0krVaIKWNK0XPqsZJAM5sJw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+pxsq5P7/va1Gkht23g4NFiCHmbHv/nzI2G5bu3JUFc=; b=OzZ5NEwFUc+UZLGOgzUwDI6w4uYKYKK9pDmtpAMHRbKASKHDQNNFsG8z/kbxHl9TD2 avwcfB9VicJB+fMTyD1G0K/hKEcMlG7tsCuV5MhSMDJtwZU6UllLDUSTs69/1UkRlhqt PqQcyh96hfNe87AswynIi4LbV7zRyLbHwCfmHA5z+uNeFy0oVXWkY5bN5GemqfPvAclP v43X8ojKQB1S6TWAaKvkFnSbaoQRrEunVSko2cmlJA01GWvay57NII6niq+XVBts/h/8 1V5FsqlPShy98KYEwdGrVDy/eN/B3x8+DQyNoPFGcjA0al7VCsyhwMQ0T1IxG0rklk2w XcWA== X-Gm-Message-State: AOAM531bQHsosfic2xtkAX1bN1aFdDHrZRZWh7J9DHV2HVpoavlEXjMI tZ/AdHS4YkSiYEcmH6vqvpZCB67PvmR/Uw== X-Google-Smtp-Source: ABdhPJwCyPrmATNPNowXjUgNo3kmRPctoYfcGuYJdNMOwPgzDxNYdD07zi1ScUFthakg0SDGhU0bLA== X-Received: by 2002:a17:90b:e01:: with SMTP id ge1mr2523526pjb.117.1616472891626; Mon, 22 Mar 2021 21:14:51 -0700 (PDT) Received: from sjg1.roam.corp.google.com (85.72.69.111.dynamic.snap.net.nz. [111.69.72.85]) by smtp.gmail.com with ESMTPSA id n10sm867750pjo.15.2021.03.22.21.14.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Mar 2021 21:14:51 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Marek Vasut , Tom Rini , Heinrich Schuchardt , Simon Glass , Lukasz Majewski Subject: [PATCH v2 3/9] usb: Return -ENOSYS when system call is not available Date: Tue, 23 Mar 2021 17:14:21 +1300 Message-Id: <20210323041427.3252184-4-sjg@chromium.org> X-Mailer: git-send-email 2.31.0.rc2.261.g7f71774620-goog In-Reply-To: <20210323041427.3252184-1-sjg@chromium.org> References: <20210323041427.3252184-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean Update usb_gadget_release() to use -ENOSYS, which is the correct error code for U-Boot. Signed-off-by: Simon Glass --- (no changes since v1) drivers/usb/gadget/udc/udc-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/udc-uclass.c b/drivers/usb/gadget/udc/udc-uclass.c index 3053ccf7d97..dbc354e84f9 100644 --- a/drivers/usb/gadget/udc/udc-uclass.c +++ b/drivers/usb/gadget/udc/udc-uclass.c @@ -45,7 +45,7 @@ int usb_gadget_release(int index) dev_array[index] = NULL; return ret; #else - return -ENOTSUPP; + return -ENOSYS; #endif } From patchwork Tue Mar 23 04:14:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1457030 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=dXPkblpq; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4F4J1w5DhLz9sVt for ; Tue, 23 Mar 2021 15:15:32 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DA5AF82893; Tue, 23 Mar 2021 05:15:11 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="dXPkblpq"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D64AA8285A; Tue, 23 Mar 2021 05:14:59 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EC42D82815 for ; Tue, 23 Mar 2021 05:14:56 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-pg1-x52e.google.com with SMTP id v2so10414475pgk.11 for ; Mon, 22 Mar 2021 21:14:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CI24MnMU7kDJduU4HAA7pLyp+dAQlvFyyx3UeNYBm98=; b=dXPkblpqk8CWXpH5hKZV4A5H+W2+TbNfdqi/yOpuToyiUyXdKB9X4QwTIYeMpi4b9m eyXV3vIGk762YhJDb6KhG3W24k+daZrcpKFAPYXPHltROwEkopJ7D5R3GGpgMBzaULea RUd8WzkPuEovf5m/N7dl43ZgwjC9tVdoQ7pns= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CI24MnMU7kDJduU4HAA7pLyp+dAQlvFyyx3UeNYBm98=; b=hbvgbyb1K/OfGeVRXAYAx/KWY+C9iAgAHo96EsDN6WeGFQlI50NcuPy7kL/qnh4wBW 3BsWwFu8PGpIv1lF8kHuiR5U2iqjCjiuDpNfR3p9+6tPeXOZEWcAwaoq1LIqGlBmY9Fk fJUd0BNVziZJU4IdaMnp12gX2SzC54w+iKH6cTtQjMTzmhl462hEUMvdz6u42AqJVJTg vWe4aX2JIXNVzetPBx8Pt/z4IoEEkTAAvB2EOkl1sSlcxAEdMLgAgiwMaRRZXy4rrtEE gMLjiPgF5HEayjESQFtO6dG4s0E5EwnGHDHZVgco80Wy3M1Jlc6IRIpVMdMmVcTSf1ZB xa7A== X-Gm-Message-State: AOAM532MI1o9qRDWDQrb/bMJ+0l8iOhyi3elrVZ2QreMNHUq5sBglf1X JKXX1YPcLozkrmgeUZ4RDS3Q81VJHlMWlg== X-Google-Smtp-Source: ABdhPJw5jMtzPvO0kIwUSSDKPZqDe0LdulXwHejS8rlzM1oYANuxLRiDx0cl4UEjbAeJblqLaFb4jA== X-Received: by 2002:a62:1713:0:b029:1f1:56e2:8ec6 with SMTP id 19-20020a6217130000b02901f156e28ec6mr3020896pfx.56.1616472895276; Mon, 22 Mar 2021 21:14:55 -0700 (PDT) Received: from sjg1.roam.corp.google.com (85.72.69.111.dynamic.snap.net.nz. [111.69.72.85]) by smtp.gmail.com with ESMTPSA id n10sm867750pjo.15.2021.03.22.21.14.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Mar 2021 21:14:54 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Marek Vasut , Tom Rini , Heinrich Schuchardt , Simon Glass , Jagan Teki , Jagannadha Sutradharudu Teki Subject: [PATCH v2 4/9] spi: Return -ENOSYS when system call is not available Date: Tue, 23 Mar 2021 17:14:22 +1300 Message-Id: <20210323041427.3252184-5-sjg@chromium.org> X-Mailer: git-send-email 2.31.0.rc2.261.g7f71774620-goog In-Reply-To: <20210323041427.3252184-1-sjg@chromium.org> References: <20210323041427.3252184-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean Update spi_controller_dma_map_mem_op_data() to use -ENOSYS, which is the correct error code for U-Boot. Signed-off-by: Simon Glass --- (no changes since v1) include/spi-mem.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/spi-mem.h b/include/spi-mem.h index 8be3e2bf6b5..e354c388979 100644 --- a/include/spi-mem.h +++ b/include/spi-mem.h @@ -222,7 +222,7 @@ spi_controller_dma_map_mem_op_data(struct spi_controller *ctlr, const struct spi_mem_op *op, struct sg_table *sg) { - return -ENOTSUPP; + return -ENOSYS; } static inline void From patchwork Tue Mar 23 04:14:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1457031 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=FCkc+FhR; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4F4J290czNz9sVS for ; Tue, 23 Mar 2021 15:15:45 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E2B108289F; Tue, 23 Mar 2021 05:15:14 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="FCkc+FhR"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A161682886; Tue, 23 Mar 2021 05:15:04 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 078D482815 for ; Tue, 23 Mar 2021 05:14:59 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-pf1-x42a.google.com with SMTP id l3so12956149pfc.7 for ; Mon, 22 Mar 2021 21:14:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yqlWWjyq2XxHMoQGcYVgQxLspjx02qpBOT4bWiVtq/8=; b=FCkc+FhRFNIHexRIUXLYdu44FbXCe3M7n5uA5dnGtugGxbYA6TJWLEJ6LmcynIIEk8 2aRbRHOGmV4OcA4qt/KLTTDNiTanxPZfcg+ycosaVPjcTkFpT+Eqa0BycsMhAYenrazL /LTOqjtAnkFl2zJohgMSsil5TOE93U5suixH0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yqlWWjyq2XxHMoQGcYVgQxLspjx02qpBOT4bWiVtq/8=; b=Ou3VIf0lx5vg5PjFh8llkAh70bHyp9utnculT6qC1bTBx4NRIp/XIS77BvFwRNPYvL iHEdnSB6/ClroeuT20mNPWE963sAv6V5AWfBoihyJhqiL2JR0+tipCZTnaxKqI+zcOBg bmUa+qj0ucVreaihzAA/9hMW5zX6QdSBME6chDrGnBATPyjDfa00jpFHNOtWNyI1jK3l XNQWA5dPnSEnppkDPZ9TPfZYiSTr8vSz90ikkb5iwzTOFU2hnLnyc9/4lkEJMdw9xfef 0OAKzVdMPRenL6LlWBK85TWCWuRi/owT+UKfFiSkpWOD0TeyCzEOWzBpLohBjOa8o77E UM/w== X-Gm-Message-State: AOAM531p+jG0hJyLXaYYZgnqs9SSN9FYoDF4knHMoBsClehO6S7OGFq8 dfVkFut4ETOjZPmfX4XMbLsZZVxrTdhI2Q== X-Google-Smtp-Source: ABdhPJxhQrCCPwwjX0NxIQzT8XY9opaHDX8A0yDrL8CqmH8gUb2meOera4GNdUZHW/LMbOjKpS93Ig== X-Received: by 2002:a17:902:e74e:b029:e5:bde4:2b80 with SMTP id p14-20020a170902e74eb02900e5bde42b80mr3177710plf.44.1616472898242; Mon, 22 Mar 2021 21:14:58 -0700 (PDT) Received: from sjg1.roam.corp.google.com (85.72.69.111.dynamic.snap.net.nz. [111.69.72.85]) by smtp.gmail.com with ESMTPSA id n10sm867750pjo.15.2021.03.22.21.14.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Mar 2021 21:14:57 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Marek Vasut , Tom Rini , Heinrich Schuchardt , Simon Glass Subject: [PATCH v2 5/9] tlv_eeprom: Return -ENOSYS when system call is not available Date: Tue, 23 Mar 2021 17:14:23 +1300 Message-Id: <20210323041427.3252184-6-sjg@chromium.org> X-Mailer: git-send-email 2.31.0.rc2.261.g7f71774620-goog In-Reply-To: <20210323041427.3252184-1-sjg@chromium.org> References: <20210323041427.3252184-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean When CMD_TLV_EEPROM is not enabled, use -ENOSYS, which is the correct error code for U-Boot. Signed-off-by: Simon Glass --- (no changes since v1) include/tlv_eeprom.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/tlv_eeprom.h b/include/tlv_eeprom.h index 1de2fe2337c..a2c333e7446 100644 --- a/include/tlv_eeprom.h +++ b/include/tlv_eeprom.h @@ -114,19 +114,19 @@ int read_tlvinfo_tlv_eeprom(void *eeprom, struct tlvinfo_header **hdr, static inline int read_tlv_eeprom(void *eeprom, int offset, int len, int dev) { - return -ENOTSUPP; + return -ENOSYS; } static inline int write_tlv_eeprom(void *eeprom, int len) { - return -ENOTSUPP; + return -ENOSYS; } static inline int read_tlvinfo_tlv_eeprom(void *eeprom, struct tlvinfo_header **hdr, struct tlvinfo_tlv **first_entry, int dev) { - return -ENOTSUPP; + return -ENOSYS; } #endif /* CONFIG_IS_ENABLED(CMD_TLV_EEPROM) */ From patchwork Tue Mar 23 04:14:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1457032 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=LChfD5r9; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4F4J2N37YVz9sTD for ; Tue, 23 Mar 2021 15:15:56 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id F20A182857; Tue, 23 Mar 2021 05:15:20 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="LChfD5r9"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0B23F8286E; Tue, 23 Mar 2021 05:15:11 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8616782815 for ; Tue, 23 Mar 2021 05:15:05 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-pf1-x434.google.com with SMTP id g15so12944816pfq.3 for ; Mon, 22 Mar 2021 21:15:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eT/w+Fjv+zR+vhhVPzb8oNv7ETR/4giL7TLXf5SdZjw=; b=LChfD5r9T0aMpB2jYbhgUIPSLRr18ayVBX9suxGwUsUyCemx0o7Di3aKQ/5CZahAIi /RQx2SBgI9HW6acwgvFdEmqKxmipXoRPPiyC7T0jlvPsIhyHAZnSY5iaWZip81FG89Kq Z57SySuyS+JF3fRF+V6l1Hx8iQAzzsB4suTEQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eT/w+Fjv+zR+vhhVPzb8oNv7ETR/4giL7TLXf5SdZjw=; b=Z1fja9fOhb4o0gLD7/cE9jwwqOzimKOp/tOiE/jHbmTC3bnGIXmnZEB/JNNHQ6L7uC d0OWQtugDUanLh/lQspIbwyj+/ASb7s3v2Btk9P58T6zE9rBt1vhCtZnN9Ov3fv8eYGs 6pssYgHc36AVToB6ByusK8O85JpP3Gqc0nPfDIptWf7/5kiOB+Wk6Pq7gHf3MZ1RRGjy KMdqWsQJnF7ch2tQgoHJafBGsznCOsBeroZxxEwz9ygICS50mpyxLbH5Cf0LYNvx3FnA 4RPQH0pniDKCjTwAeCCt4DSrdJHu3Xn1qvNoPdNVDlrZiHXsXAT5jBUeNci6BiDsrcPK f3sw== X-Gm-Message-State: AOAM532dkSx/dH7AYPUE+lOpJpCI4RKoBYgHv2Kor1HfbfOVa6ULYVko kQWg/XaG2PPqCpxs5HJBDfo3NlZx2wEXpw== X-Google-Smtp-Source: ABdhPJyDEA5GeSDf+aRbKkz3n2rE+LZe0F5OTOf9rDVbBbkyRE6ZPNDa714ctdehQYZWUAtItTCVAQ== X-Received: by 2002:aa7:8558:0:b029:205:2773:69f7 with SMTP id y24-20020aa785580000b0290205277369f7mr3068025pfn.28.1616472903833; Mon, 22 Mar 2021 21:15:03 -0700 (PDT) Received: from sjg1.roam.corp.google.com (85.72.69.111.dynamic.snap.net.nz. [111.69.72.85]) by smtp.gmail.com with ESMTPSA id n10sm867750pjo.15.2021.03.22.21.14.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Mar 2021 21:15:03 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Marek Vasut , Tom Rini , Heinrich Schuchardt , Simon Glass , Aspeed BMC SW team , Chia-Wei Wang , Eugeniy Paltsev , Lukasz Majewski , =?utf-8?q?Marek_Beh=C3=BAn?= , Ryan Chen , Sean Anderson , Stefan Roese , uboot-snps-arc@synopsys.com Subject: [PATCH v2 6/9] clk: Update drivers to use -EINVAL Date: Tue, 23 Mar 2021 17:14:24 +1300 Message-Id: <20210323041427.3252184-7-sjg@chromium.org> X-Mailer: git-send-email 2.31.0.rc2.261.g7f71774620-goog In-Reply-To: <20210323041427.3252184-1-sjg@chromium.org> References: <20210323041427.3252184-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean At present some drivers use -ENOSUPP to indicate that an unknown or unsupported clock is used. Most use -EINVAL, indicating an invalid value, so convert everything to that. Signed-off-by: Simon Glass Acked-by: Sean Anderson Reviewed-by: Stefan Roese --- Changes in v2: - Add new patch to update clk drivers to use -EINVAL drivers/clk/aspeed/clk_ast2600.c | 2 +- drivers/clk/clk-hsdk-cgu.c | 4 ++-- drivers/clk/imx/clk-imx8.c | 4 ++-- drivers/clk/imx/clk-imx8qm.c | 6 +++--- drivers/clk/imx/clk-imx8qxp.c | 6 +++--- drivers/clk/imx/clk-pllv3.c | 2 +- drivers/clk/kendryte/bypass.c | 2 +- drivers/clk/kendryte/clk.c | 2 +- drivers/clk/mvebu/armada-37xx-periph.c | 6 +++--- 9 files changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/clk/aspeed/clk_ast2600.c b/drivers/clk/aspeed/clk_ast2600.c index acb7eca7414..3a92739f5cf 100644 --- a/drivers/clk/aspeed/clk_ast2600.c +++ b/drivers/clk/aspeed/clk_ast2600.c @@ -1140,7 +1140,7 @@ int soc_clk_dump(void) clk_free(&clk); - if (ret == -ENOTSUPP) { + if (ret == -EINVAL) { printf("clk ID %lu not supported yet\n", aspeed_clk_names[i].id); continue; diff --git a/drivers/clk/clk-hsdk-cgu.c b/drivers/clk/clk-hsdk-cgu.c index 449b430e230..26b0aa9a26f 100644 --- a/drivers/clk/clk-hsdk-cgu.c +++ b/drivers/clk/clk-hsdk-cgu.c @@ -718,7 +718,7 @@ static ulong hsdk_cgu_set_rate(struct clk *sclk, ulong rate) if (clk->map[sclk->id].set_rate) return clk->map[sclk->id].set_rate(sclk, rate); - return -ENOTSUPP; + return -EINVAL; } static int hsdk_cgu_disable(struct clk *sclk) @@ -731,7 +731,7 @@ static int hsdk_cgu_disable(struct clk *sclk) if (clk->map[sclk->id].disable) return clk->map[sclk->id].disable(sclk); - return -ENOTSUPP; + return -EINVAL; } static const struct clk_ops hsdk_cgu_ops = { diff --git a/drivers/clk/imx/clk-imx8.c b/drivers/clk/imx/clk-imx8.c index 8484613eed5..b3dc138c4bb 100644 --- a/drivers/clk/imx/clk-imx8.c +++ b/drivers/clk/imx/clk-imx8.c @@ -29,7 +29,7 @@ __weak ulong imx8_clk_set_rate(struct clk *clk, unsigned long rate) __weak int __imx8_clk_enable(struct clk *clk, bool enable) { - return -ENOTSUPP; + return -EINVAL; } static int imx8_clk_disable(struct clk *clk) @@ -70,7 +70,7 @@ int soc_clk_dump(void) clk_free(&clk); - if (ret == -ENOTSUPP) { + if (ret == -EINVAL) { printf("clk ID %lu not supported yet\n", imx8_clk_names[i].id); continue; diff --git a/drivers/clk/imx/clk-imx8qm.c b/drivers/clk/imx/clk-imx8qm.c index 7e466d630a0..7759dc63ee1 100644 --- a/drivers/clk/imx/clk-imx8qm.c +++ b/drivers/clk/imx/clk-imx8qm.c @@ -133,7 +133,7 @@ ulong imx8_clk_get_rate(struct clk *clk) __func__, clk->id); return -EINVAL; } - return -ENOTSUPP; + return -EINVAL; }; ret = sc_pm_get_clock_rate(-1, resource, pm_clk, @@ -237,7 +237,7 @@ ulong imx8_clk_set_rate(struct clk *clk, unsigned long rate) __func__, clk->id); return -EINVAL; } - return -ENOTSUPP; + return -EINVAL; }; ret = sc_pm_set_clock_rate(-1, resource, pm_clk, &new_rate); @@ -337,7 +337,7 @@ int __imx8_clk_enable(struct clk *clk, bool enable) __func__, clk->id); return -EINVAL; } - return -ENOTSUPP; + return -EINVAL; } ret = sc_pm_clock_enable(-1, resource, pm_clk, enable, 0); diff --git a/drivers/clk/imx/clk-imx8qxp.c b/drivers/clk/imx/clk-imx8qxp.c index e6b2fb40da2..ffa2fcee0b2 100644 --- a/drivers/clk/imx/clk-imx8qxp.c +++ b/drivers/clk/imx/clk-imx8qxp.c @@ -126,7 +126,7 @@ ulong imx8_clk_get_rate(struct clk *clk) __func__, clk->id); return -EINVAL; } - return -ENOTSUPP; + return -EINVAL; }; ret = sc_pm_get_clock_rate(-1, resource, pm_clk, @@ -221,7 +221,7 @@ ulong imx8_clk_set_rate(struct clk *clk, unsigned long rate) __func__, clk->id); return -EINVAL; } - return -ENOTSUPP; + return -EINVAL; }; ret = sc_pm_set_clock_rate(-1, resource, pm_clk, &new_rate); @@ -311,7 +311,7 @@ int __imx8_clk_enable(struct clk *clk, bool enable) __func__, clk->id); return -EINVAL; } - return -ENOTSUPP; + return -EINVAL; } ret = sc_pm_clock_enable(-1, resource, pm_clk, enable, 0); diff --git a/drivers/clk/imx/clk-pllv3.c b/drivers/clk/imx/clk-pllv3.c index feacaee1c42..b5cbf800543 100644 --- a/drivers/clk/imx/clk-pllv3.c +++ b/drivers/clk/imx/clk-pllv3.c @@ -290,7 +290,7 @@ struct clk *imx_clk_pllv3(enum imx_pllv3_type type, const char *name, break; default: kfree(pll); - return ERR_PTR(-ENOTSUPP); + return ERR_PTR(-EINVAL); } pll->base = base; diff --git a/drivers/clk/kendryte/bypass.c b/drivers/clk/kendryte/bypass.c index 5f1986f2cb8..bbdbd9a10de 100644 --- a/drivers/clk/kendryte/bypass.c +++ b/drivers/clk/kendryte/bypass.c @@ -157,7 +157,7 @@ static int k210_bypass_set_parent(struct clk *clk, struct clk *parent) if (ops->set_parent) return ops->set_parent(bypass->bypassee, parent); else - return -ENOTSUPP; + return -EINVAL; } /* diff --git a/drivers/clk/kendryte/clk.c b/drivers/clk/kendryte/clk.c index 4b959401a63..3b674a998e3 100644 --- a/drivers/clk/kendryte/clk.c +++ b/drivers/clk/kendryte/clk.c @@ -495,7 +495,7 @@ static int k210_clk_probe(struct udevice *dev) * could fix this, but it's Probably Not Worth It (TM). */ if (probed) - return -ENOTSUPP; + return -EINVAL; base = dev_read_addr_ptr(dev_get_parent(dev)); if (!base) diff --git a/drivers/clk/mvebu/armada-37xx-periph.c b/drivers/clk/mvebu/armada-37xx-periph.c index 0132fcb7e61..b0f47c33b3f 100644 --- a/drivers/clk/mvebu/armada-37xx-periph.c +++ b/drivers/clk/mvebu/armada-37xx-periph.c @@ -340,7 +340,7 @@ static int periph_clk_enable(struct clk *clk, int enable) return -EINVAL; if (!periph_clk->can_gate) - return -ENOTSUPP; + return -EINVAL; if (enable) clrbits_le32(priv->reg + CLK_DIS, periph_clk->disable_bit); @@ -408,7 +408,7 @@ static ulong armada_37xx_periph_clk_set_rate(struct clk *clk, ulong req_rate) return old_rate; if (!periph_clk->can_gate || !periph_clk->dividers) - return -ENOTSUPP; + return -EINVAL; parent_rate = get_parent_rate(priv, clk->id); if (parent_rate == -EINVAL) @@ -445,7 +445,7 @@ static int armada_37xx_periph_clk_set_parent(struct clk *clk, return -EINVAL; if (!periph_clk->can_mux || !periph_clk->can_gate) - return -ENOTSUPP; + return -EINVAL; ret = clk_get_by_index(clk->dev, 0, &check_parent); if (ret < 0) From patchwork Tue Mar 23 04:14:25 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1457033 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=MxKYNbGb; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4F4J2b60lhz9sVS for ; Tue, 23 Mar 2021 15:16:07 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 13BE3828AC; Tue, 23 Mar 2021 05:15:23 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="MxKYNbGb"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7F6A182886; Tue, 23 Mar 2021 05:15:16 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 52C7F82859 for ; Tue, 23 Mar 2021 05:15:10 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-pg1-x531.google.com with SMTP id 32so4288105pgm.1 for ; Mon, 22 Mar 2021 21:15:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1uYlL9Ia5Wgke/Q7/PGk5Hwu+wEvDF3feUIPVsSEAIw=; b=MxKYNbGb9aw/eb1iT9ibFrGXnf8z6SUm1MfuUHXcIfAxD8AneITdF0/iXY599AKViQ 5gkXh8YQMUXbSVgevH+CgtB/7MUIqTGLQP/fTW972GilSH2d7ogE43TGiqqyikUNolN1 0m2EMCGnkz6f72EqH4GTWIhRfh/vxWQH+RQzk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1uYlL9Ia5Wgke/Q7/PGk5Hwu+wEvDF3feUIPVsSEAIw=; b=Rv+En7x5EMFidmFtE29KveNyAOKq1hlyu3vQVLHgXIp2QG6ux7OsCbQVDy3eLGwF6T imseS5klM5gXNYsJIoNh3kSbi3HucbVDWz9xb4tcV71f0iglKl5M+R8k1nkW43tJKKgi hAFp7C+r7crgpw6dY3HT9E05Bf6WVSAup2aeONId0Itu9Bi0ykmPXUf+h+d/pNYxYxYF SveXEqxnRTtoCGlFe7hj0G03wlKDiLXm7ie7GorBHaI0XiukESqIzrkHnnPt1dMbjtOO usht1y6DO9rJWtGszr17g7JVFArMNWaCdBSaCMoIcAYtil1Ipl2BTiAPBVzjldK+8/IS 35Pw== X-Gm-Message-State: AOAM532oh7ok3mL27UoU+jTcrILfMZFC304FODhNtU+O3ZQLcW0d6/T0 lSH8LHx4X2ee95hSgnq24r9Sj6LbXFKd6g== X-Google-Smtp-Source: ABdhPJwEsVlUyzBAiioJ1VMKwxlCr+EiHALmYV3E7Zujj4mKytBJfdIMRAzXnwCxqipkr/TQ690kzQ== X-Received: by 2002:aa7:8c54:0:b029:1f5:3c12:aea3 with SMTP id e20-20020aa78c540000b02901f53c12aea3mr2875924pfd.67.1616472908729; Mon, 22 Mar 2021 21:15:08 -0700 (PDT) Received: from sjg1.roam.corp.google.com (85.72.69.111.dynamic.snap.net.nz. [111.69.72.85]) by smtp.gmail.com with ESMTPSA id n10sm867750pjo.15.2021.03.22.21.15.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Mar 2021 21:15:08 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Marek Vasut , Tom Rini , Heinrich Schuchardt , Simon Glass , Sean Anderson , Lukasz Majewski Subject: [PATCH v2 7/9] clk: Return -ENOSYS when system call is not available Date: Tue, 23 Mar 2021 17:14:25 +1300 Message-Id: <20210323041427.3252184-8-sjg@chromium.org> X-Mailer: git-send-email 2.31.0.rc2.261.g7f71774620-goog In-Reply-To: <20210323041427.3252184-1-sjg@chromium.org> References: <20210323041427.3252184-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean Update clk_composite_set_parent() to use -ENOSYS, which is the correct error code for U-Boot. Also rearrange the code so that the error condition is clearly indicated and the function runs to the end in the normal case, since this is the common style in U-Boot. Signed-off-by: Simon Glass Reviewed-by: Sean Anderson --- (no changes since v1) drivers/clk/clk-composite.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/clk/clk-composite.c b/drivers/clk/clk-composite.c index 7e99c5b910d..bb5351ebc0b 100644 --- a/drivers/clk/clk-composite.c +++ b/drivers/clk/clk-composite.c @@ -37,10 +37,10 @@ static int clk_composite_set_parent(struct clk *clk, struct clk *parent) const struct clk_ops *mux_ops = composite->mux_ops; struct clk *mux = composite->mux; - if (mux && mux_ops) - return mux_ops->set_parent(mux, parent); - else - return -ENOTSUPP; + if (!mux || !mux_ops) + return -ENOSYS; + + return mux_ops->set_parent(mux, parent); } static unsigned long clk_composite_recalc_rate(struct clk *clk) From patchwork Tue Mar 23 04:14:26 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1457034 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=cC7rjCkl; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4F4J2p33Xsz9sTD for ; Tue, 23 Mar 2021 15:16:18 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B779182859; Tue, 23 Mar 2021 05:15:25 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="cC7rjCkl"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 40A768286E; Tue, 23 Mar 2021 05:15:17 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 659D082857 for ; Tue, 23 Mar 2021 05:15:13 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-pf1-x434.google.com with SMTP id l123so12952202pfl.8 for ; Mon, 22 Mar 2021 21:15:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=aHiF/ryDjs35p/fIn1o7AIMjnsEb19okHI1JVg0cM7k=; b=cC7rjCkl257NZte1+5OVnktkiWDyn0JYMzilk8bJk71DeE7kXpRJch1Jueobwt4bze ehJMwYeHCcVr6aNhpL/Bplw7PEfJHh+aOPr2CoeHlXRmhFh2Z4oPFLC3w1CvgtAT6nv4 nXI61b7pUWpTQ4hD83ki4GRVdSHq++GPakRr0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=aHiF/ryDjs35p/fIn1o7AIMjnsEb19okHI1JVg0cM7k=; b=Oi1Yq7zpER8mJAwVVqBR46yxeISJGCYjaH7lKppZVzd5uXwMHv62obe53NmaitjpRe rwBKdGOFiXy+ihc1bV6TPFXPlgNhDqqmVCS5kvR5fGABZfGi6q0vR53vOY4S7uRRp6Cy 2sjzu9kQjPM3CE7WwhcGLeUmrJvNFWx1DbTgPjr1UXWCedNSldw0JEDVRtN/jsDzZl2d 0ppC775iB53GCICAFu/f6IPVSBp204/eyPYwjhTCruQ89Ir7qIYlU7NVFLnmCd1/WXqn l4aNjAStXBBWYKf2S+/iKtfajJhxjPTox3+rWNgFiYENa7pXejkBpk69XqusEZVh/Xot rt0A== X-Gm-Message-State: AOAM533QS8A7FUjSMJhqrZdJIJpjuJN9ZvQyEFQ6+L4jDEi/DY4y/qaw gADmiZIprEJhiuwj3tNJxDteGkPVAJ51eQ== X-Google-Smtp-Source: ABdhPJyIKjfI3PCpENTTXkdpG8gltCHRAwEuLPgUIrR36XVn5LzsieVPhpee7pktus1lHBODhObNpA== X-Received: by 2002:a63:348c:: with SMTP id b134mr2469166pga.86.1616472911742; Mon, 22 Mar 2021 21:15:11 -0700 (PDT) Received: from sjg1.roam.corp.google.com (85.72.69.111.dynamic.snap.net.nz. [111.69.72.85]) by smtp.gmail.com with ESMTPSA id n10sm867750pjo.15.2021.03.22.21.15.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Mar 2021 21:15:11 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Marek Vasut , Tom Rini , Heinrich Schuchardt , Simon Glass Subject: [PATCH v2 8/9] simple-pm-bus: Use -ENOSYS for checking missing system call Date: Tue, 23 Mar 2021 17:14:26 +1300 Message-Id: <20210323041427.3252184-9-sjg@chromium.org> X-Mailer: git-send-email 2.31.0.rc2.261.g7f71774620-goog In-Reply-To: <20210323041427.3252184-1-sjg@chromium.org> References: <20210323041427.3252184-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean We don't need to check -ENOTSUPP since this is not used for this purpose in U-Boot. Update the code accordingly. Signed-off-by: Simon Glass Reviewed-by: Sean Anderson --- (no changes since v1) drivers/core/simple-pm-bus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/core/simple-pm-bus.c b/drivers/core/simple-pm-bus.c index 7a18953cba1..1bb0d86e289 100644 --- a/drivers/core/simple-pm-bus.c +++ b/drivers/core/simple-pm-bus.c @@ -21,7 +21,7 @@ static int simple_pm_bus_probe(struct udevice *dev) return ret; ret = clk_enable_bulk(bulk); - if (ret && ret != -ENOSYS && ret != -ENOTSUPP) { + if (ret && ret != -ENOSYS) { clk_release_bulk(bulk); return ret; } @@ -34,7 +34,7 @@ static int simple_pm_bus_remove(struct udevice *dev) struct clk_bulk *bulk = dev_get_priv(dev); ret = clk_release_bulk(bulk); - if (ret && ret != -ENOSYS && ret != -ENOTSUPP) + if (ret && ret != -ENOSYS) return ret; else return 0; From patchwork Tue Mar 23 04:14:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1457035 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=MmSo8482; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4F4J305s3Xz9sTD for ; Tue, 23 Mar 2021 15:16:28 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E8EB1828BC; Tue, 23 Mar 2021 05:15:27 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="MmSo8482"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BB4F482857; Tue, 23 Mar 2021 05:15:19 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9888E82859 for ; Tue, 23 Mar 2021 05:15:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-pg1-x533.google.com with SMTP id l1so10400127pgb.5 for ; Mon, 22 Mar 2021 21:15:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=crXFQB5i+SAia0dO0QTUnEAay+506Aw636oQrHWdaok=; b=MmSo8482LSnj1m6suo+p5Xty9oBiww3/ncDSxZc7lmWlk9uSe0chudFQ5t5rZO8AOm Cq10w5q3e+5yl0BtGgJamDfuqa1SOVWAoKs6Pm67VlH7+7Dl2JCrFRAaHdxmIQNyDSb8 lfySGHhLxfY6iswGlAl5SqN4bJjbeO11zbNwQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=crXFQB5i+SAia0dO0QTUnEAay+506Aw636oQrHWdaok=; b=s94q/E004COPpA4l2OcigiOsgaz+lPjuV3Ljwoca23ShXRjPYEdhP79Ly6qkP2pOGu OT63eDPJpX0JcUiYk2hsnfRS1qsxGKMYjgqjoN9xygUEJSIZN9HPDVI/VvkKqSS1l3j9 mcUF0fwRv1PhSvT9jnauqtEioZMmaNS3FcAirE4NA4RI/UXvUkrsRdGrxNRekOC81wou wAFvcuCzB6z6AK/pjaMxWnBfqggawrHNxQk2N01Lw5CtjfSUMRNGMH52rfhPX6A/g3Pz aJbugcaHHu4INr6XH5xEZIVI/XfMW3hv6NDDat6lmAkTMMX+RfzlkJT7x1Q1GB30MqCH zXJw== X-Gm-Message-State: AOAM53399Iqsir5ie4nRat+jU4D4TknfNF0TXXBr9LdruGJEYVcowGFI WZJjuSgIq4pq40TFRf5FCtIxma2fF9PaLg== X-Google-Smtp-Source: ABdhPJzS+erEdqdMZJVCGpMzVr21/cIAVUF8mhdfMegccHmPK9NcOridQdqowovvGiMxZ2RNOZx1gw== X-Received: by 2002:aa7:808d:0:b029:1ed:993c:3922 with SMTP id v13-20020aa7808d0000b02901ed993c3922mr2959095pff.75.1616472914980; Mon, 22 Mar 2021 21:15:14 -0700 (PDT) Received: from sjg1.roam.corp.google.com (85.72.69.111.dynamic.snap.net.nz. [111.69.72.85]) by smtp.gmail.com with ESMTPSA id n10sm867750pjo.15.2021.03.22.21.15.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Mar 2021 21:15:14 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Marek Vasut , Tom Rini , Heinrich Schuchardt , Simon Glass , Andy Shevchenko Subject: [PATCH v2 9/9] pinctrl: Return -ENOSYS when system call is not available Date: Tue, 23 Mar 2021 17:14:27 +1300 Message-Id: <20210323171420.v2.9.I45e49e847b3b2a17161445f423e00e909c3adbbe@changeid> X-Mailer: git-send-email 2.31.0.rc2.261.g7f71774620-goog In-Reply-To: <20210323041427.3252184-1-sjg@chromium.org> References: <20210323041427.3252184-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean Update the code to use -ENOSYS, which is the correct error code for an unimplemented system call in U-Boot. Also we should not check for a missing operations array as this is not permitted. For now this can be covered by an assert(). Signed-off-by: Simon Glass --- (no changes since v1) drivers/pinctrl/pinctrl-uclass.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/pinctrl-uclass.c b/drivers/pinctrl/pinctrl-uclass.c index b0f30aa1f75..6e68e52c32c 100644 --- a/drivers/pinctrl/pinctrl-uclass.c +++ b/drivers/pinctrl/pinctrl-uclass.c @@ -235,8 +235,9 @@ int pinctrl_gpio_request(struct udevice *dev, unsigned offset) return ret; ops = pinctrl_get_ops(pctldev); - if (!ops || !ops->gpio_request_enable) - return -ENOTSUPP; + assert(ops); + if (!ops->gpio_request_enable) + return -ENOSYS; return ops->gpio_request_enable(pctldev, pin_selector); } @@ -261,8 +262,9 @@ int pinctrl_gpio_free(struct udevice *dev, unsigned offset) return ret; ops = pinctrl_get_ops(pctldev); - if (!ops || !ops->gpio_disable_free) - return -ENOTSUPP; + assert(ops); + if (!ops->gpio_disable_free) + return -ENOSYS; return ops->gpio_disable_free(pctldev, pin_selector); }