From patchwork Mon Jan 15 04:16:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: linzhecheng X-Patchwork-Id: 860581 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zKg7Z3yjPz9sBW for ; Mon, 15 Jan 2018 15:18:01 +1100 (AEDT) Received: from localhost ([::1]:34233 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eawDd-0008Ex-Ga for incoming@patchwork.ozlabs.org; Sun, 14 Jan 2018 23:17:57 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39275) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eawDD-0008EW-1x for qemu-devel@nongnu.org; Sun, 14 Jan 2018 23:17:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eawD9-0006Ag-Qd for qemu-devel@nongnu.org; Sun, 14 Jan 2018 23:17:31 -0500 Received: from [45.249.212.32] (port=58044 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eawD8-00064g-KC for qemu-devel@nongnu.org; Sun, 14 Jan 2018 23:17:27 -0500 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 208C638D775A9; Mon, 15 Jan 2018 12:17:09 +0800 (CST) Received: from localhost (10.177.131.80) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.361.1; Mon, 15 Jan 2018 12:17:00 +0800 From: linzhecheng To: Date: Mon, 15 Jan 2018 12:16:48 +0800 Message-ID: <20180115041648.33740-1-linzhecheng@huawei.com> X-Mailer: git-send-email 2.12.2.windows.2 MIME-Version: 1.0 X-Originating-IP: [10.177.131.80] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 45.249.212.32 Subject: [Qemu-devel] [PATCH] scsi: handle the special parameters X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, wangxinxin.wang@huawei.com, famz@redhat.com, linzhecheng Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" scsi_disk_emulate_command calls scsi_build_sense(NULL, 0, outbuf, r->buflen, (req->cmd.buf[1] & 1) == 0); But scsi_convert_sense doesn't handle the case when in_buf is NULL or in_len is 0, which will lead to segfault. Signed-off-by: linzhecheng --- scsi/utils.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/scsi/utils.c b/scsi/utils.c index ddae650a99..b769e80c12 100644 --- a/scsi/utils.c +++ b/scsi/utils.c @@ -322,6 +322,10 @@ int scsi_convert_sense(uint8_t *in_buf, int in_len, SCSISense sense; bool fixed_in; + if (!in_buf || !in_len) { + return 0; + } + fixed_in = (in_buf[0] & 2) == 0; if (in_len && fixed == fixed_in) { memcpy(buf, in_buf, MIN(len, in_len));