From patchwork Wed Mar 3 18:46:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 1446812 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=UX2FktL2; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DrNRH2NW4z9sVt for ; Thu, 4 Mar 2021 05:52:43 +1100 (AEDT) Received: from localhost ([::1]:34836 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHWbx-0005N7-AQ for incoming@patchwork.ozlabs.org; Wed, 03 Mar 2021 13:52:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33438) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHWWX-00056Q-5r for qemu-devel@nongnu.org; Wed, 03 Mar 2021 13:47:05 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:25085) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lHWWS-0007xU-GU for qemu-devel@nongnu.org; Wed, 03 Mar 2021 13:47:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614797219; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0ygJSAUu3nItqoE7XwzNiQqtuF4qShdTNiOm3t1xDK4=; b=UX2FktL2VVx7OSUk4O/vxLlytWIWEcZlY+A7nMHit5Oh4D+sgNvKI96wRb7r1p1oL1+VBr MUFwq4xvf/GPvg4WdiUDuoWnzdlB6jjZoeWNzYPW9Qofq8HtgsisByWBhZ9gxVRyJTefjF bu43dfjccHA+ChPuk1PCq6Kzy9q27T0= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-359-Jai6DimCNZWACwfgie1ikA-1; Wed, 03 Mar 2021 13:46:58 -0500 X-MC-Unique: Jai6DimCNZWACwfgie1ikA-1 Received: by mail-wm1-f71.google.com with SMTP id h20so2173628wmq.9 for ; Wed, 03 Mar 2021 10:46:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0ygJSAUu3nItqoE7XwzNiQqtuF4qShdTNiOm3t1xDK4=; b=Gun2xIPmnwLLkC5ZVmslp4f4IzyMusEu00SYm+U+9RKvAkWT7c6BErSn4pOl3gzJM6 GB2PjN5TsD8d5oRKqfTwmqk0I94yNj6ZSG4Dnshf/I51KiCjXvaaLxnvh0vm6K8498cZ CcRN5jBUYlr1d3ZTZCzi4dskJGXWNLUtSulS6v+6Sb5fbGknwFo5s+bADIRIiV9bwL9L tKcke9wOkvLCVv5LOR1vAmGVALjYANEo+bD/OgoBItAbTrKos5OKX7PcuNZABFdBcZvi HnlJ97eC/ySahM/jpTF3PLIGKbAka4cPdHeknBXGwop3ApzJTEOTz0sUl71sJiLU/lQ+ nwgg== X-Gm-Message-State: AOAM530bn78FBpIpV6UMMvFbtNswqZhyIph6lKIcE+6z8bvxmgu/jrCr XdDESEvBi2DeFFdSSieMYUhUFfqwOPRoD1Lq7GXgXZ5vm3hv2YeaQC8tqVaM5M2dA/CWPzmI6Vk CeoEErPlD/w2c3fn2W/iXXUcUX9gJAHgd/ajSi0sSC9D7tHrdpmU+bjtXm6Xs/X1f X-Received: by 2002:a1c:2e58:: with SMTP id u85mr317025wmu.71.1614797216622; Wed, 03 Mar 2021 10:46:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJyfHSzIWGLrgw5CwL8PqoywVG313c7fQf3yvNocBzZ2Tfq9ubtsxolSUUrI7Mp7vTD1awYHlA== X-Received: by 2002:a1c:2e58:: with SMTP id u85mr316991wmu.71.1614797216348; Wed, 03 Mar 2021 10:46:56 -0800 (PST) Received: from x1w.redhat.com (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id x6sm5938379wmj.32.2021.03.03.10.46.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Mar 2021 10:46:55 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v3 1/5] ui: Replace the word 'whitelist' Date: Wed, 3 Mar 2021 19:46:40 +0100 Message-Id: <20210303184644.1639691-2-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210303184644.1639691-1-philmd@redhat.com> References: <20210303184644.1639691-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Peter Maydell , Thomas Huth , qemu-block@nongnu.org, qemu-trivial@nongnu.org, Michael Roth , =?utf-8?q?Phi?= =?utf-8?q?lippe_Mathieu-Daud=C3=A9?= , "Dr. David Alan Gilbert" , Max Reitz , Eduardo Otubo , Alex Williamson , Gerd Hoffmann , Stefan Hajnoczi , =?utf-8?q?Alex_Benn=C3=A9e?= , Aurelien Jarno Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Follow the inclusive terminology from the "Conscious Language in your Open Source Projects" guidelines [*] and replace the words "whitelist" appropriately. [*] https://github.com/conscious-lang/conscious-lang-docs/blob/main/faq.md Reviewed-by: Gerd Hoffmann Reviewed-by: Alex Bennée Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- ui/console.c | 2 +- ui/vnc-auth-sasl.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ui/console.c b/ui/console.c index c5d11bc7017..5a8311ced20 100644 --- a/ui/console.c +++ b/ui/console.c @@ -1708,7 +1708,7 @@ bool dpy_gfx_check_format(QemuConsole *con, return false; } } else { - /* default is to whitelist native 32 bpp only */ + /* default is to allow native 32 bpp only */ if (format != qemu_default_pixman_format(32, true)) { return false; } diff --git a/ui/vnc-auth-sasl.c b/ui/vnc-auth-sasl.c index f67111a3662..df7dc08e9fc 100644 --- a/ui/vnc-auth-sasl.c +++ b/ui/vnc-auth-sasl.c @@ -288,7 +288,7 @@ static int protocol_client_auth_sasl_step(VncState *vs, uint8_t *data, size_t le goto authreject; } - /* Check username whitelist ACL */ + /* Check the username access control list */ if (vnc_auth_sasl_check_access(vs) < 0) { goto authreject; } @@ -409,7 +409,7 @@ static int protocol_client_auth_sasl_start(VncState *vs, uint8_t *data, size_t l goto authreject; } - /* Check username whitelist ACL */ + /* Check the username access control list */ if (vnc_auth_sasl_check_access(vs) < 0) { goto authreject; } From patchwork Wed Mar 3 18:46:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 1446809 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=D3s6mHAU; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DrNQ30mlLz9sCD for ; Thu, 4 Mar 2021 05:51:39 +1100 (AEDT) Received: from localhost ([::1]:58320 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHWav-0003Ri-1T for incoming@patchwork.ozlabs.org; Wed, 03 Mar 2021 13:51:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33478) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHWWZ-00059M-KE for qemu-devel@nongnu.org; Wed, 03 Mar 2021 13:47:07 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:36728) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lHWWX-0007xm-JM for qemu-devel@nongnu.org; Wed, 03 Mar 2021 13:47:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614797224; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NoCyAkDbqm7qqBRK5Dn5W3Vg1Q8erVg+5wGiFEk0raM=; b=D3s6mHAUjgBadNLU2l4IslPc6/7YM5GzEqLCaVG+8zJrlEGBSqM1lsG8WTK+1FpGZC5TvM KL/skJwaUtyPG91Q8oSQCkGd6lOxT4Jrw3bcq/X4Xb9JtbO5VLRxO6daxksdYsFfby6NJu +6PLxFKHvi4vf7BAImkzSEvsZIFX17k= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-534-INFuYAjcNbiIrd0-UTYdsA-1; Wed, 03 Mar 2021 13:47:03 -0500 X-MC-Unique: INFuYAjcNbiIrd0-UTYdsA-1 Received: by mail-wm1-f70.google.com with SMTP id a65so2192899wmh.1 for ; Wed, 03 Mar 2021 10:47:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NoCyAkDbqm7qqBRK5Dn5W3Vg1Q8erVg+5wGiFEk0raM=; b=HBHvJ5IGwiYFxfYvaSSTnSMh6H4ph6LJaPwWVBjkb8ER79+TmWaRL3vqYE4vonTUh5 idhSD1XYSsAgzcWCiknrjRMDG+Y1bPWRaxNM9tx0MFMYCC4FxZR2Q/PXxIvG2a6Cyx1f 3n5ug/XnTCp5sp8XecaQWhlRZo50UgGvfJN9LhfCCM1d214jywW28aetwLJouOU43XZk +LR1Djwd2H+GsOwB+zCpxiK5vyTk8ApZs4RDLzgaWfx6OTlCywm6f6Kq2YAvnQzNJmel CkfNkG6eQJWmxOuPoZzheOU87Tayj8mZGT507H+OBe17z7x3mvU/yjO3MvLEbunlYSKS /kMQ== X-Gm-Message-State: AOAM533KzbuwY2c0wUTPkIZbtwNOPSXTd5ZJ8KHZAZ4aQ1I2mAnc0fqP xCbYgBsLZFoaFpfVkbtsrIbURGbfZht7lGGlk5NiFzLgHb83Fkhr47ca4+H699cN05+x7Z/rDLN ZPmq9oqEctQv20N5LlOcOKC4UxnTAc/Qi6Ylx4iJJ+GJO1RLdLIi00bZVWnsY4Qzi X-Received: by 2002:adf:f292:: with SMTP id k18mr29025387wro.335.1614797221692; Wed, 03 Mar 2021 10:47:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJwXNoAkTi1EjnqkFTfdC9dxH+7fkHpU2XpEtaWryEqqFaJWWzS4eXv81bSvplkiukPBV5j0sA== X-Received: by 2002:adf:f292:: with SMTP id k18mr29025362wro.335.1614797221547; Wed, 03 Mar 2021 10:47:01 -0800 (PST) Received: from x1w.redhat.com (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id p17sm6248355wmq.47.2021.03.03.10.47.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Mar 2021 10:47:01 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v3 2/5] scripts/tracetool: Replace the word 'whitelist' Date: Wed, 3 Mar 2021 19:46:41 +0100 Message-Id: <20210303184644.1639691-3-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210303184644.1639691-1-philmd@redhat.com> References: <20210303184644.1639691-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Peter Maydell , Thomas Huth , =?utf-8?q?Daniel_P_=2E_Berrang=C3=A9?= , qemu-block@nongnu.org, qemu-trivial@nongnu.org, Michael Roth , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , "Dr. David Alan Gilbert" , Max Reitz , Eduardo Otubo , Alex Williamson , Gerd Hoffmann , Stefan Hajnoczi , =?utf-8?q?Alex_Benn=C3=A9e?= , Aurelien Jarno Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Follow the inclusive terminology from the "Conscious Language in your Open Source Projects" guidelines [*] and replace the words "whitelist" appropriately. [*] https://github.com/conscious-lang/conscious-lang-docs/blob/main/faq.md Reviewed-by: Daniel P. Berrangé Reviewed-by: Stefan Hajnoczi Reviewed-by: Alex Bennée Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi --- scripts/tracetool/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.py index 96b1cd69a52..5bc94d95cfc 100644 --- a/scripts/tracetool/__init__.py +++ b/scripts/tracetool/__init__.py @@ -100,7 +100,7 @@ def validate_type(name): if bit == "const": continue if bit not in ALLOWED_TYPES: - raise ValueError("Argument type '%s' is not in whitelist. " + raise ValueError("Argument type '%s' is not allowed. " "Only standard C types and fixed size integer " "types should be used. struct, union, and " "other complex pointer types should be " From patchwork Wed Mar 3 18:46:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 1446807 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=VumwdGrv; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DrNNc4jqSz9sCD for ; Thu, 4 Mar 2021 05:50:24 +1100 (AEDT) Received: from localhost ([::1]:52504 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHWZi-0000x3-KG for incoming@patchwork.ozlabs.org; Wed, 03 Mar 2021 13:50:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33548) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHWWh-0005Sm-JB for qemu-devel@nongnu.org; Wed, 03 Mar 2021 13:47:15 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:34304) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lHWWe-000807-G1 for qemu-devel@nongnu.org; Wed, 03 Mar 2021 13:47:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614797231; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OrF+E+zCequnzlZnWp4hjwf+NwYf8uUkBRCyiILemeQ=; b=VumwdGrvvxw1/Ref0yhnf6fqgQd9VaWb8aRL5JQE7VV8g86ddrWzK2Aua6LrlSnf+uBzdc MZg297kjMKfQJhFHvoYiuQaqfNCkCNtIegO5oLjX0vfEI6yOxxEVT4+gsR0WjPiyOGgVLw 1EghhOkj9o7YPE4Q1msfWppMUYxIabI= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-45-2kH-glYSOHOmRTBpBzBi0w-1; Wed, 03 Mar 2021 13:47:08 -0500 X-MC-Unique: 2kH-glYSOHOmRTBpBzBi0w-1 Received: by mail-wr1-f70.google.com with SMTP id n17so1024193wrq.5 for ; Wed, 03 Mar 2021 10:47:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OrF+E+zCequnzlZnWp4hjwf+NwYf8uUkBRCyiILemeQ=; b=UzABvt6vcA+LdWD+u44sqWR7+JlzcWeotr+YLKMA6UY6uRIpLDtnPeIbvLqY4dtHKV YhplKBXWwrVEq92LXgfj4Kpa6jFZMYlarnuhzL4eVAo3Cmwa7NhRNMEIBqh+5Fhe0izw 2fbpjbswf0RGNSNS1oSF6MsWfGMBS8NAdE+xdeWnE7LQWq4Kd43pLp35xlRskt6W7iy5 tmkAWdeZgSJ0c48IYe+zUG199xIoavDaV8qnKwuf+De2lrjG6sduYZDciZkVzTcQqtue ujEvs6ONbDfxGBntS1kOLT8QAQiiGsra0SwXO09zZtt1x1uPoB8ldV8NZfuJgl0TpXKg ETvQ== X-Gm-Message-State: AOAM533bU1F2TNxI5MRJS3KfoGEnEBJ6pituA+3eVkxW2WfhPSXSFcVu I8TFfKcHPC+77W3a/QJnVSNJScOoVO277my+pg5mMpVtSBHoDKmWrAh4K97CR5T8ra3bVcFZ3RC Lk+LUoxFM7TFpO3gyCBO+YVHszpRUecfRGoNkCZMk3V4mcXf3BjUf884Rx23Dmy79 X-Received: by 2002:adf:ecca:: with SMTP id s10mr99443wro.324.1614797227135; Wed, 03 Mar 2021 10:47:07 -0800 (PST) X-Google-Smtp-Source: ABdhPJycHxQvlOnM6FizoZ5rxZXTKjf0vtyPdQkxbbHaBtg6FZ0jWTbXMMadH/C/uhtJJbVK69mS1g== X-Received: by 2002:adf:ecca:: with SMTP id s10mr99413wro.324.1614797226889; Wed, 03 Mar 2021 10:47:06 -0800 (PST) Received: from x1w.redhat.com (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id e1sm5848347wrw.85.2021.03.03.10.47.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Mar 2021 10:47:06 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v3 3/5] seccomp: Replace the word 'blacklist' Date: Wed, 3 Mar 2021 19:46:42 +0100 Message-Id: <20210303184644.1639691-4-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210303184644.1639691-1-philmd@redhat.com> References: <20210303184644.1639691-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Peter Maydell , =?utf-8?q?Daniel_P_=2E_Berrang=C3=A9?= , qemu-block@nongnu.org, qemu-trivial@nongnu.org, Michael Roth , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , "Dr. David Alan Gilbert" , Max Reitz , Eduardo Otubo , Alex Williamson , Gerd Hoffmann , Stefan Hajnoczi , =?utf-8?q?Alex_Benn=C3=A9e?= , Aurelien Jarno Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Follow the inclusive terminology from the "Conscious Language in your Open Source Projects" guidelines [*] and replace the word "blacklist" appropriately. [*] https://github.com/conscious-lang/conscious-lang-docs/blob/main/faq.md Reviewed-by: Daniel P. Berrangé Acked-by: Eduardo Otubo Reviewed-by: Alex Bennée Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- v3: Reworded comment (thuth) --- softmmu/qemu-seccomp.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/softmmu/qemu-seccomp.c b/softmmu/qemu-seccomp.c index 377ef6937ca..9c29d9cf007 100644 --- a/softmmu/qemu-seccomp.c +++ b/softmmu/qemu-seccomp.c @@ -45,8 +45,8 @@ const struct scmp_arg_cmp sched_setscheduler_arg[] = { { .arg = 1, .op = SCMP_CMP_NE, .datum_a = SCHED_IDLE } }; -static const struct QemuSeccompSyscall blacklist[] = { - /* default set of syscalls to blacklist */ +static const struct QemuSeccompSyscall denylist[] = { + /* default set of syscalls that should get blocked */ { SCMP_SYS(reboot), QEMU_SECCOMP_SET_DEFAULT }, { SCMP_SYS(swapon), QEMU_SECCOMP_SET_DEFAULT }, { SCMP_SYS(swapoff), QEMU_SECCOMP_SET_DEFAULT }, @@ -175,18 +175,18 @@ static int seccomp_start(uint32_t seccomp_opts, Error **errp) goto seccomp_return; } - for (i = 0; i < ARRAY_SIZE(blacklist); i++) { + for (i = 0; i < ARRAY_SIZE(denylist); i++) { uint32_t action; - if (!(seccomp_opts & blacklist[i].set)) { + if (!(seccomp_opts & denylist[i].set)) { continue; } - action = qemu_seccomp_get_action(blacklist[i].set); - rc = seccomp_rule_add_array(ctx, action, blacklist[i].num, - blacklist[i].narg, blacklist[i].arg_cmp); + action = qemu_seccomp_get_action(denylist[i].set); + rc = seccomp_rule_add_array(ctx, action, denylist[i].num, + denylist[i].narg, denylist[i].arg_cmp); if (rc < 0) { error_setg_errno(errp, -rc, - "failed to add seccomp blacklist rules"); + "failed to add seccomp denylist rules"); goto seccomp_return; } } From patchwork Wed Mar 3 18:46:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 1446806 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=CGckAb2q; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DrNL139NWz9sCD for ; Thu, 4 Mar 2021 05:48:09 +1100 (AEDT) Received: from localhost ([::1]:43260 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHWXX-0005ZY-EK for incoming@patchwork.ozlabs.org; Wed, 03 Mar 2021 13:48:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33594) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHWWp-0005Ym-PJ for qemu-devel@nongnu.org; Wed, 03 Mar 2021 13:47:23 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:22461) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lHWWm-00081y-P1 for qemu-devel@nongnu.org; Wed, 03 Mar 2021 13:47:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614797240; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8KZhKK31KyfnjQDhDEVhCsxY2Kwq4sGCBZtEFirnrhs=; b=CGckAb2qA1bswyJBlt029fWZ0g2jziE41n1B83edXC3eEkCy5GfO1KARbhu43+wBOJX8yA qlEE+9Z2XYYMKlJ0LqYuULkcoJWw25SEgriCr31N3yDG3JpnMMHyY9T8+wWb+hBkmv/gAY M4zpS9ihNWaNKoJXZvNsIj1E1Z6thtk= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-6-xLMngQH7NXGFugCG2tjs_w-1; Wed, 03 Mar 2021 13:47:18 -0500 X-MC-Unique: xLMngQH7NXGFugCG2tjs_w-1 Received: by mail-wr1-f69.google.com with SMTP id y5so2735617wrp.2 for ; Wed, 03 Mar 2021 10:47:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8KZhKK31KyfnjQDhDEVhCsxY2Kwq4sGCBZtEFirnrhs=; b=oHFBVwWbuywrqQOYH2hlPiaGDIQI6XpcXxyMstk4xFOAxNXwzZpJAsM3F7rRmi7NI4 MHes3P9nc3Sik/uEM36Ot9VNGZgjyw1lzbFbTtfTn+QCx3mbu+hE9a/iTzAMcFVSau3x 9+qNqzckJxtlJMyO35CCOc70AAy1S5pg/pVrXyRSQXK3zYA6w+CkmAezmiECQzAbO1j/ uk9Z2mEZdniGYls++N0lJkZn01ibZyi9TDtLRqL5BGxUkehtnfSyUgKm2dtBiSvt8pxg IOzemfPURXCOF2V0Ix9MG8lNAdAt+bZoaDxrmjepj0gVRw5rnij6+SK6gOVbxASTwuVt vs7A== X-Gm-Message-State: AOAM533qs4hYLm50CiVW3FJwnDdFI2Fo50DuvW28PNUV8tv4fsry6WF/ //zVPHE+aJL2P68OGUiOxowtx4PzZo9LdD9ZrkxOtbUcDouBYJOOWkzYvq89WmtsckdqfNBzjYt RdOtU1q4lhjJkZbsDiUelYfEN1eRWo8PMO0PAUMvNEr81e9TRxCiRSuUPjSJxP5eY X-Received: by 2002:a05:6000:5:: with SMTP id h5mr12124wrx.97.1614797237378; Wed, 03 Mar 2021 10:47:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJx4HCfJjsCF5sPq6Cl+Y+hdP+ZJ1b47KHwEHN5NwjCgeUwkyzysRQYLOfHZnxnzpEGqO1bDfA== X-Received: by 2002:a05:6000:5:: with SMTP id h5mr12094wrx.97.1614797237174; Wed, 03 Mar 2021 10:47:17 -0800 (PST) Received: from x1w.redhat.com (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id y10sm24628852wrl.19.2021.03.03.10.47.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Mar 2021 10:47:16 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v3 4/5] qemu-options: Replace the word 'blacklist' Date: Wed, 3 Mar 2021 19:46:43 +0100 Message-Id: <20210303184644.1639691-5-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210303184644.1639691-1-philmd@redhat.com> References: <20210303184644.1639691-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Peter Maydell , =?utf-8?q?Daniel_P_=2E_Berrang=C3=A9?= , qemu-block@nongnu.org, qemu-trivial@nongnu.org, Michael Roth , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , "Dr. David Alan Gilbert" , Max Reitz , Eduardo Otubo , Alex Williamson , Gerd Hoffmann , Stefan Hajnoczi , =?utf-8?q?Alex_Benn=C3=A9e?= , Aurelien Jarno Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Follow the inclusive terminology from the "Conscious Language in your Open Source Projects" guidelines [*] and replace the word "blacklist" appropriately. [*] https://github.com/conscious-lang/conscious-lang-docs/blob/main/faq.md Reviewed-by: Daniel P. Berrangé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- qemu-options.hx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 252db9357ca..8462dc5f158 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -4299,12 +4299,12 @@ DEF("sandbox", HAS_ARG, QEMU_OPTION_sandbox, \ " use 'obsolete' to allow obsolete system calls that are provided\n" \ " by the kernel, but typically no longer used by modern\n" \ " C library implementations.\n" \ - " use 'elevateprivileges' to allow or deny QEMU process to elevate\n" \ - " its privileges by blacklisting all set*uid|gid system calls.\n" \ + " use 'elevateprivileges' to allow or deny the QEMU process ability\n" \ + " to elevate privileges using set*uid|gid system calls.\n" \ " The value 'children' will deny set*uid|gid system calls for\n" \ " main QEMU process but will allow forks and execves to run unprivileged\n" \ " use 'spawn' to avoid QEMU to spawn new threads or processes by\n" \ - " blacklisting *fork and execve\n" \ + " blocking *fork and execve\n" \ " use 'resourcecontrol' to disable process affinity and schedular priority\n", QEMU_ARCH_ALL) SRST From patchwork Wed Mar 3 18:46:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 1446810 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=YkhvWXTB; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DrNQb39Jcz9sVt for ; Thu, 4 Mar 2021 05:52:07 +1100 (AEDT) Received: from localhost ([::1]:33054 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHWbN-0004dx-EX for incoming@patchwork.ozlabs.org; Wed, 03 Mar 2021 13:52:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33706) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHWX0-0005hv-NH for qemu-devel@nongnu.org; Wed, 03 Mar 2021 13:47:34 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:49017) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lHWWu-000841-1f for qemu-devel@nongnu.org; Wed, 03 Mar 2021 13:47:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614797246; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zv/BwC5POPyWjWYZMgFmMVd8R/Xa4KoRgVF20B1JO98=; b=YkhvWXTBYWEN1T4W1lxqBQ+DI+k9OM1c4VxgxeBXgOrJSTjLNS0HO7LmSMNvcyvIsUIO7l Y/vtdnIjn1/x/NXj0+Oc0JNg13buuxNxtM2hNF7ISlpUobmopLfNYIx6b4UM+IvZsPMSGo akutwxFjSBvvShx4odGl4OudHQcis0k= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-598-2xdy6nPKMZSztJ9mFSI7EA-1; Wed, 03 Mar 2021 13:47:24 -0500 X-MC-Unique: 2xdy6nPKMZSztJ9mFSI7EA-1 Received: by mail-wr1-f71.google.com with SMTP id g5so13124356wrd.22 for ; Wed, 03 Mar 2021 10:47:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zv/BwC5POPyWjWYZMgFmMVd8R/Xa4KoRgVF20B1JO98=; b=BRn70HbRdd3gj4zbsGsegLcpPkn0MBs526JfV8QpP+8BHreFLkWzJFHilMfZqqBrjG M+CBA0K0Q/lMU9S2pn8RH+gBMjQGhxAVFHQAozdSMWI71eGwVxgvtjD9TnNi1Ff4ki2M X83MhLAxgN0NY6qcSTWD3exNQGoYFZpSbBkpEA93VKy6zfwGCy1AR+nC4Ax//50q5OlX HxDEdr8p+mSUk5PDOOwaxfsCJJkr57aHqh/SfKsmyeWJxknAw17ykw7DKNhqJoi4pEb5 L0GwbtSFr6vU7KxJUpUcufqkVOuU2K4s2woHf563x5x8y/3QBdVhhk8PTxcQd+vTx0Bb FG1A== X-Gm-Message-State: AOAM533EtnGPOSo9SlgHB84EM5wLUfxKhWuvJCoqNyZYvRRYMM50101p iDT0xkr7N2ATEyFmtyYIbDtGQV4VZeMc8+Hdy1nOQ9Mw+2EVTM4/7bd67/gOjXy9D42i071xSyg gP/ogwydZcgnMXm1lQUk/m2BdOdLzsZlXC9TsFziXGvJrMM4XPvrXI1C6pWGb8YLe X-Received: by 2002:adf:a4d0:: with SMTP id h16mr130694wrb.52.1614797242570; Wed, 03 Mar 2021 10:47:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJz5JgQpBX92H6UGgShZ4/nvXSRy+FEwNApU2icyYpt9aUmnJnLP8p5aGqMj2y+myurUBLCLZA== X-Received: by 2002:adf:a4d0:: with SMTP id h16mr130662wrb.52.1614797242368; Wed, 03 Mar 2021 10:47:22 -0800 (PST) Received: from x1w.redhat.com (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id m11sm20480462wrz.40.2021.03.03.10.47.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Mar 2021 10:47:21 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v3 5/5] tests/fp/fp-test: Replace the word 'blacklist' Date: Wed, 3 Mar 2021 19:46:44 +0100 Message-Id: <20210303184644.1639691-6-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210303184644.1639691-1-philmd@redhat.com> References: <20210303184644.1639691-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Peter Maydell , =?utf-8?q?Daniel_P_=2E_Berrang=C3=A9?= , qemu-block@nongnu.org, qemu-trivial@nongnu.org, Michael Roth , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , "Dr. David Alan Gilbert" , Max Reitz , Eduardo Otubo , Alex Williamson , Gerd Hoffmann , Stefan Hajnoczi , =?utf-8?q?Alex_Benn=C3=A9e?= , Aurelien Jarno Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Follow the inclusive terminology from the "Conscious Language in your Open Source Projects" guidelines [*] and replace the word "blacklist" appropriately. [*] https://github.com/conscious-lang/conscious-lang-docs/blob/main/faq.md Acked-by: Alex Bennée Reviewed-by: Daniel P. Berrangé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- tests/fp/fp-test.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/fp/fp-test.c b/tests/fp/fp-test.c index 06ffebd6db1..5a4cad8c8b2 100644 --- a/tests/fp/fp-test.c +++ b/tests/fp/fp-test.c @@ -123,7 +123,7 @@ static void not_implemented(void) fprintf(stderr, "Not implemented.\n"); } -static bool blacklisted(unsigned op, int rmode) +static bool is_allowed(unsigned op, int rmode) { /* odd has not been implemented for any 80-bit ops */ if (rmode == softfloat_round_odd) { @@ -161,10 +161,10 @@ static bool blacklisted(unsigned op, int rmode) case F32_TO_EXTF80: case F64_TO_EXTF80: case F128_TO_EXTF80: - return true; + return false; } } - return false; + return true; } static void do_testfloat(int op, int rmode, bool exact) @@ -194,7 +194,7 @@ static void do_testfloat(int op, int rmode, bool exact) verCases_writeFunctionName(stderr); fputs("\n", stderr); - if (blacklisted(op, rmode)) { + if (!is_allowed(op, rmode)) { not_implemented(); return; }