From patchwork Wed Mar 3 11:55:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 1446773 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2001:8b0:10b:1:d65d:64ff:fe57:4e05; helo=desiato.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=UmglGGiU; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=tcqjeMZB; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.a=rsa-sha256 header.s=dkim.wdc.com header.b=IGhqyWhs; dkim=neutral header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-sharedspace-onmicrosoft-com header.b=R4DT2LhN; dkim-atps=neutral Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DrMfd2gC7z9s1l for ; Thu, 4 Mar 2021 05:17:29 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Id8K4wGTVnL9Vx+CeTxjHtDn9+Nhf1h9zh5bpBdNSNg=; b=UmglGGiUGfZ8LMy58lYcGiAAz 2GTEjQlb1NDhESFeJy7uEwUgY/6PxAsKxSGoQz5SDREz6DcKaUnNB1l87z9m0w3MTxMixuk2EtksB +RlhDlfiLEodd80MXn0AgOH6Zs/Qqq6OimBAhfUQ//ifVSHPxIIXp8++Yhzd9YkEJUGrnNU74DxBm 76RyPcmog6f1CpsmYexrHcq7etCK2YlxV5IejAqVn3EKbaPllFm4UvoIWsfgBMfj/6EgQCtGU72jw P+ogCBpacCZAV2Qm/T6siW6eAYZ/NBf7xk498/whwpxGDUNfFalwjzmkHm8L6wH5U57p2LIwA41CB x5NsuixIQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lHW3e-005yvK-Oy; Wed, 03 Mar 2021 18:17:14 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHSzG-005Gfk-VV for opensbi@desiato.infradead.org; Wed, 03 Mar 2021 15:00:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=oEN4WveOeKLxFUrnHw8bdI82rK9e7ZnX6mrUTjLP8F4=; b=tcqjeMZBBa2Celmz8FqAJV9f/d LwlrBapw7IvEtVP17wsAkivKcimLWKkN3M3/WzmwaJnUiXfspi0IDTmdK6ZocxXkuLgHHr4RP9Ku9 uQa5jMqpD3y/1nYQb7KhHAr+0L0irgYJSw1Sb6s68lvnt0nd6y51ooNEgcTDZKdykT1BnLUXmQkHa 3VNd3d5Qt4SNQrHbSyHjbNQj6Ksa8m2Ei/FO2154gv25SzS8loqPDcOt3K07Yig6zKks9ymjCVOm7 iTq4I5J2RbWOvWgb5cJC6r7FKguR5k45yrgqqjt+sX3rLMMAJmEouYMJLkctNgODAfOv7jo2RYkhj Uz4Op3vA==; Received: from esa3.hgst.iphmx.com ([216.71.153.141]) by casper.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHQ7O-002Rah-57 for opensbi@lists.infradead.org; Wed, 03 Mar 2021 11:56:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1614772602; x=1646308602; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=1rfvT00kG3AZIMe3pcuLkAsV6i9sYgS6P+IMN8qy1TI=; b=IGhqyWhsyUqeuvushUO6bLTlPhrbD9gHCFbN1fsqrZ9sm04O92OQ4fpL kHUEnPR3tugY1siI06VEhXtEUs4Ebg15wYldRd/TKlwIef5wAVWVjr7Ph FHCdQNkQ0mM7pCat8d/nlF9rKj5PtIWtlCYEU3m7hR6kDqNWO/TVSlWxS /lveU3vtmneoqVi6RdDKNoiPrz9wbkjXCJwCRoeExm5sGG4vufy/Uj05t Oxt4/b95kyM6stpWWI60DLWqJ1xAyBEkD5AacGE6wG2viwcKoKkyPfd02 FPgNFr/xmMa1a6lNWcNtuFZUxMnrzbLZIQx1HJ14/WQyTpfcSd+jHHc5P A==; IronPort-SDR: jzEf1/ey2yOdAlXtoBTgfyb0oj21ANLg6H1gTtxhoLvBFgq0ndcmwuvoNcvxXkJtgsbiRENecY Tvd1kdTK9uSs1UP40NgtpgJXRnnuEt9blBkmZaKpMBtfJGg8sS4iy4AxZ6FsSGKryeEjKYUaiv Wx4inei4+A1PhaiohUWiMs/p4BZJvkNvVh9eU4BzSwbIpSitYwDTX52HKOjsdJOypADhjulTsB lQ+yfyR8GAdAhK2X4/C4oK7TNlLHh7OACAh+vyzX2S4Byft9PkMVH8A2Bj9mrfBB85p4w+SPS7 EaQ= X-IronPort-AV: E=Sophos;i="5.81,219,1610380800"; d="scan'208";a="165729484" Received: from mail-dm6nam08lp2042.outbound.protection.outlook.com (HELO NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.42]) by ob1.hgst.iphmx.com with ESMTP; 03 Mar 2021 19:56:21 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BjU2yLoANHLRwQ/j3BqBxKRD3AhvyBuVA5Nf0bvs0pYAbPeUy9RVQVf3l11GcqvQ9eJxbzJthtLPItyM34+EaszuxVN+DenEs7nLpmXx2u65Fg+TaLK8q0YgB2TKlkTdwmhA75TzSF365eVEPNtmWCevUJ+dTG3Vk0ePOwUyT+dhTLKrU0+VpvIZhVEs1tn7F+KhbpXgMz26O15Dk0TpZROzIDuOHIm1S4q1RBZj46I7G547IkBZtvxxew3gZS6sU0F4trZcF3fm+ShMHWqykg4MefPGDNKr2jzHmsoxQJQb6w/YJXbKxha3/UogIayJovWVJBX1vluHEcFt6KG4ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oEN4WveOeKLxFUrnHw8bdI82rK9e7ZnX6mrUTjLP8F4=; b=LOt/6EFIQbJVfV7R9kzcZ/3s8fW7/CEvPs2BxcenoYH81AloIQ7FM0KwcURz1fOSExBsW5sO1UkBDL8aKPvATyHA+ZcVQVD2/9icyLQkbzVABtOsOGDP/RhZgAuK8NsfLGojUE4ySCvV1jLqsA8z9Vc7NnRZDScL+eLxIN3OALuBM3/yhhdWu2pQVJOv6P8Rrv+j378u/07yxTe4isD5bjMnxc3cUoKSNo4SjK5VS8WMvcSp/IkeQs5qUINN4bAHLpvpJJXiRGrbxtov9OXl7CQT3KmHVayO9qoxRT38ka82gPWrB0w9ITp3O+NcZKC2x4cSd8KdJruw75/FifhkKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oEN4WveOeKLxFUrnHw8bdI82rK9e7ZnX6mrUTjLP8F4=; b=R4DT2LhNknHvziU5GVpPmbMX1OQ7O4zfh1sgdpOocPOKGryWLqHdjQewWJ2L2yXoUrGg6dvYwFxPpBhG8lgq+rZYAEuOGukhVseBjL+A5SOTGnxJg3MPLn+1pthyGm4SB3pK83ikHmKLEugQ872vJmmvv9QuAj7LkisJx2h0q/0= Authentication-Results: wdc.com; dkim=none (message not signed) header.d=none;wdc.com; dmarc=none action=none header.from=wdc.com; Received: from DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) by DM6PR04MB6809.namprd04.prod.outlook.com (2603:10b6:5:22a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17; Wed, 3 Mar 2021 11:56:20 +0000 Received: from DM6PR04MB6201.namprd04.prod.outlook.com ([fe80::38c0:cc46:192b:1868]) by DM6PR04MB6201.namprd04.prod.outlook.com ([fe80::38c0:cc46:192b:1868%7]) with mapi id 15.20.3912.018; Wed, 3 Mar 2021 11:56:20 +0000 From: Anup Patel To: Atish Patra , Alistair Francis Cc: Anup Patel , opensbi@lists.infradead.org, Anup Patel Subject: [PATCH v3 01/11] include: sbi: Simplify HSM state define names Date: Wed, 3 Mar 2021 17:25:02 +0530 Message-Id: <20210303115512.470786-2-anup.patel@wdc.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210303115512.470786-1-anup.patel@wdc.com> References: <20210303115512.470786-1-anup.patel@wdc.com> X-Originating-IP: [122.171.215.70] X-ClientProxiedBy: MAXPR0101CA0040.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:d::26) To DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from wdc.com (122.171.215.70) by MAXPR0101CA0040.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:d::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Wed, 3 Mar 2021 11:56:18 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: bbc16183-c242-4afc-2ea4-08d8de3b5bd9 X-MS-TrafficTypeDiagnostic: DM6PR04MB6809: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: WDCIPOUTBOUND: EOP-TRUE X-MS-Oob-TLC-OOBClassifiers: OLM:466; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ygUAoxaMSCiC4vTRgEExdoBX6QDNYKP/dzG2mRuGqIcuFY7EyUxtpJK82yF2g3Pk3fXYkmoUUrpSYtGZa5TAPa2hNBm0gOc1m3fHG9jGk9v6gbN9aRc3XabGQyQoSZM6nJgCHAbdTMJ15/Y2uSanGyfhonXre2F5yzpjLG3m/RWQ7D7xblH1QQjmmpZvrE9fy8xFWTulzO6h1Sk4Uwp5QRaSm3b924wHpes1dd61PcoQ+L/SlzMXitEVzjCi8bYlivq8dAwkB9J126olLVxaBblND4rNTbBAGX352dh9xrun674TL9Py59SN3b9PeAuPlyPDOBLqQAc3R3+n/uVR4WadJwkD4oG7UZh9ffjubOuYXEGxSkJP4Z993+HuXLp2IE7yT3gCcFZcpOPgo3li/sK5qNyvGDoWdBPdwvcxrtJ8PFB5j3GClpQEgn502wahSxSsdqr0IwxdJUsjtwj17jcfe9NJK2GShgAVrBSXzcdWdfRr9AhPsF7CZ1FNKWkyHnHW5ko+J26b4nTqnkcInw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR04MB6201.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(346002)(376002)(366004)(136003)(396003)(83380400001)(316002)(186003)(16526019)(4326008)(6636002)(110136005)(1076003)(54906003)(55016002)(6666004)(66946007)(26005)(36756003)(8886007)(956004)(2906002)(44832011)(8676002)(8936002)(7696005)(66556008)(66476007)(2616005)(5660300002)(52116002)(478600001)(86362001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: ReRGKK9HG6APavpRExEU0Fryf4QuMudVvIsMZQB9B+vAGomWQEKvXlzgyC8UxR+jawI52AKEEcalnerpOPSP7+R8EYRr4u1WU2VTnP+8+EJh7QvOmGx/sffnmo8f6V3JozrbATzWLuZM1NBNkK4ufWPlRHDiJBhIWEcHXCqo4+vfaiNf5EbSMLDcF+fW2kSdIoQGloZtjz6mf67bjyMtoGLs+uELJQ0rX+rE74/hmFwACSssmSHH/8S4rS1rPMWeFW8HmoAzwbR4M9OUCV/r33LQ/ypOpkqgAIQf5dAlQ096mhXe6L08rbJs0CH2Dq05FtKsJfj0Y2RVZYYj5PRxHAXMgfiz992a6ndrgZPC0AhffKqe26ozx5gx8yIbe6mqbpM3McPw+SOpPzEVS4A/TkMXyZTl8ayWT/8qCG0yaJzgQSNPxNwZSWjkx1olz4dJMk4Ka3KU6uYe7MvO2EtVFm5ix1jOVXcu5n3pYoU9qI2vVQPb2EiFHEF2EICvhOU6TBlfkUA6u9/njaWH86qJNWZY54M2BQ/MKBfWUcQRXk4kRX2mqkJXNTzEy2GY1HFCa+4XmUavgNHavwUG/iIz73TtI/OSpyLCuzYNTSRmMpGhML7sPuZ1zoRsdD7rkOGQhzTWHRSQE5ohTiDBhGlZOVEZBCwCoMlnhki8F7/TRmiTHQqI9ex8c4SO8cWgVZ0tFSh1+Isifqb2gLT8CxrFMNwuQISexqdN5du/TpPWCdUYaRBBy/k9y0y6NZ6kdRkqL/K/+E+zW8GHtlpdHjy0SkAdxQ3o4Yi9uYGE8oDCIPkHsUTODBesP9YhUPPug6hLu3mzDU6p3n8Ub70y/EwNe5WylMX/ejLr+zpfRpfQ/s7qWy3LbacSj0lTxqMebyb4H45SRn3oLXkUsP9T/wj6VAAkBtQyQ8ii0L6Pv631GjrbLgCEKJ15M6jVPGfKZubtINEaFe8sdsfJBAGwBsZ2QjmE/BiphWWaa/S3BWIxYc/5A+dTH2b6ysUCI1e+NszPDStrJlJYQWtJ8MT4OOi6mQXp10zWmz8Ir2dpA3vcXz2N1J+sCy9MXjmzF0kt4k1i9HQ/1tMiohD53ZcUS7T7uT/ZFLc0zZuxoPGT992ybXgWJlRB6ZJGVKa/p4XHJA1sk1qq9s2dYtgAEB9zpvmUhPuENWKb3LbsdDZwnp/j9YIaFGfWAiNYIvJBO6oKWD3Br6IJhN43fVCYK53fJMIe9Qb2f1f41paPzXGv4+AQ9+kGyDAUBoGrCrWWASgsLRXF1TCUfyXzOLqpBE6xJSvyEwsJ9wEGlHLNFbGrcwA2DQIvYWAk5qR7SHbW2A5ne+zi X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: bbc16183-c242-4afc-2ea4-08d8de3b5bd9 X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6201.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2021 11:56:20.2269 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rYOuXuR9eZEFb3GdxfuecdtF2hqk5iLwGdtUWcWWybUU2eTO0FyiYpHUEQ7CcQ4qUY28/H1SbFyX1mfxn/5fmg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB6809 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210303_115643_296782_8AADF29E X-CRM114-Status: GOOD ( 12.17 ) X-Spam-Note: SpamAssassin invocation failed X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org We simplify HSM state define names so that these defines can directly replace SBI_HART_xyz defines used by SBI HSM implementation. Signed-off-by: Anup Patel Reviewed-by: Atish Patra --- include/sbi/sbi_ecall_interface.h | 8 ++++---- lib/sbi/sbi_hsm.c | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/include/sbi/sbi_ecall_interface.h b/include/sbi/sbi_ecall_interface.h index 002c6f9..b272213 100644 --- a/include/sbi/sbi_ecall_interface.h +++ b/include/sbi/sbi_ecall_interface.h @@ -58,10 +58,10 @@ #define SBI_EXT_HSM_HART_STOP 0x1 #define SBI_EXT_HSM_HART_GET_STATUS 0x2 -#define SBI_HSM_HART_STATUS_STARTED 0x0 -#define SBI_HSM_HART_STATUS_STOPPED 0x1 -#define SBI_HSM_HART_STATUS_START_PENDING 0x2 -#define SBI_HSM_HART_STATUS_STOP_PENDING 0x3 +#define SBI_HSM_STATE_STARTED 0x0 +#define SBI_HSM_STATE_STOPPED 0x1 +#define SBI_HSM_STATE_START_PENDING 0x2 +#define SBI_HSM_STATE_STOP_PENDING 0x3 /* SBI function IDs for SRST extension */ #define SBI_EXT_SRST_RESET 0x0 diff --git a/lib/sbi/sbi_hsm.c b/lib/sbi/sbi_hsm.c index e1b2b2c..1722280 100644 --- a/lib/sbi/sbi_hsm.c +++ b/lib/sbi/sbi_hsm.c @@ -39,16 +39,16 @@ int sbi_hsm_hart_state_to_status(int state) switch (state) { case SBI_HART_STOPPED: - ret = SBI_HSM_HART_STATUS_STOPPED; + ret = SBI_HSM_STATE_STOPPED; break; case SBI_HART_STOPPING: - ret = SBI_HSM_HART_STATUS_STOP_PENDING; + ret = SBI_HSM_STATE_STOP_PENDING; break; case SBI_HART_STARTING: - ret = SBI_HSM_HART_STATUS_START_PENDING; + ret = SBI_HSM_STATE_START_PENDING; break; case SBI_HART_STARTED: - ret = SBI_HSM_HART_STATUS_STARTED; + ret = SBI_HSM_STATE_STARTED; break; default: ret = SBI_EINVAL; From patchwork Wed Mar 3 11:55:03 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 1446801 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2001:8b0:10b:1:d65d:64ff:fe57:4e05; helo=desiato.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=Q9UaHbmX; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=VvUw+nHT; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.a=rsa-sha256 header.s=dkim.wdc.com header.b=B5VnV/G+; dkim=neutral header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-sharedspace-onmicrosoft-com header.b=K6Tuqq10; dkim-atps=neutral Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DrNC743FYz9sj0 for ; Thu, 4 Mar 2021 05:42:11 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uC+ccIy9SIdVfwz+hQMQdMDHnaOevhrK85J9suv4rkM=; b=Q9UaHbmXd4ulDtDK6zAqhFzTl NaE1hzvFBaFjRa7VAU2AhfDNCNYlHzILzWwl0+2E4moHEVpuLryR4+l7n4AEzb3oAjm+88yVTmsYB GueVJcVm1P0oLS88N2QH52ZAQczETQkp1XpdrOmYcZ4QxJJk8etMHD9+XjuPtAMixLTXySJZWeV06 +dDx5RkXkdGlgxK+gM+20IMkMdVtn8VDNp5UZgFkEmWbA7RnF35nbRRY+vF8vmPZpbfuWfhEorH+K M7RqrL6ii2maW8YcgbnfGerd9rfP1cO9C3G2g+jJsahHpolS0mdZG0nVpZ0+PjGCeQ+UgrA2cZ50H YYGIX3zFQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lHWRh-00646p-Fd; Wed, 03 Mar 2021 18:42:05 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHT1D-005HGu-1o for opensbi@desiato.infradead.org; Wed, 03 Mar 2021 15:02:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=rhby+6xpV8d4uqmZRXOQ4rfJQhpMroWJrnWuXr79R/o=; b=VvUw+nHTZULQTtg40v6QcqxYTn VWk6DiYABUiu+qdxxYkL/eEoUyFUxJbSPnlLQfUnHlIPnessPMGnfH7FlcRDkU1pQhS7I9acgDCch 2FexBwzJE3ppg8eBcAreKul9fGzOhYu7nUzDqOQkL1bBNYYSS65ZJzhcrUmyswTWRetYJzTxqmdvk 5CGWHei17Ej0PlyvHO1mG8/rdPSjjpVdKXjmmbC1RSgeVqkjzc+piemgPBwkTbg1bKUHlG3S89WPV oL3D9BCjwSnG0m5W4TCxjQhUydQtfnuWMfZ4SL6lra+sQAKeu+6xVkexsztcX9Ew3sjTXZ+WAFIpz XpJBNLIA==; Received: from esa3.hgst.iphmx.com ([216.71.153.141]) by casper.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHQ7O-002Rai-5L for opensbi@lists.infradead.org; Wed, 03 Mar 2021 11:56:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1614772602; x=1646308602; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=UZHBGgLRjlIEoKajYR4IBTR0BBUe/rmAw3i5AortW/0=; b=B5VnV/G+dRmj0hJu0KZaQTBj9b2mFaKbZZn1+v6zaW0XEkzP6ioZA7hO +V+ZWkWcMlNMz8z7wBzX0xZnALXGsXAwZKjeKhYB8zlx6Ehe9NYkAutIw pLeZOhxIUMPev6uDMh1Cm2j7tM38ELgqPTV95vU7TOvumXd1e6ZmRRge5 aN8fSqRwkxGIuJPBazOa2SrDqujtq8iBzSNqb5Sn6fgCRVg0LBWRtth1f wlWdGFck0F3aigZYKwrypBbTNo5lIdyfBqahyoAwTysUFQk0SaxvHszkc /1iga8kPiQzohsRDy/z6McTxvwyMlAWwr/q8El7sxnTsHsHl0FQg2E+0m A==; IronPort-SDR: iUq22PI+NzZTXHa4cM+pT3BRqi49BXYX5MYzxB22QjVYoJjbyQD+j5EayTgF0gdPs+x2LKozoj 7SQxbgN8O2PwIF1EQI+eDZZ4gm5IfrAun7wpHZdjikQGNdJ+RegKebGHbHhd1SH24Ji8L6tkYa 0DOzg99j0+p8YWjpCjg/939XpC/AiEpLjlPI9UaXYk6nLyoOBBD7c+r/SX933gdYgRLywDS3fd wyge24Q26k33J6IPEKuh1LohRWYunXnrn+3cQB1ZjhvwMRsdh6/NHBrkycPTzuNSj0uZL04yFA gHs= X-IronPort-AV: E=Sophos;i="5.81,219,1610380800"; d="scan'208";a="165729488" Received: from mail-dm6nam08lp2048.outbound.protection.outlook.com (HELO NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.48]) by ob1.hgst.iphmx.com with ESMTP; 03 Mar 2021 19:56:23 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PAzo21pPZ74GZZtOgN+uvPefhbNB3aM6a+iKFuonoRPQjLDhp7U76W5mHNoJ9PuNQGxLCRANS+M2atswgcTfSogVVHD52iP3zhkKBt7EjHH2ts2hlsHTU+GE0kdoGKjvH71Q7sfJMiOw28UTtv/C4zS6Lq7+lYj0dA8BOTNqV6WHHKNqehOHpP3Cia6HkswSQFvXOsTWw9CvZ5IpmeNbteF9OA9Xjc4/N11/vYlO998fIvgyWxBj9+Dzu4eRayHXHy8bvOm0ULh3Lobh6TC54J+kBfAvwW/8Ubo9gjILAzTFox/0zKVEm0yj1oWx6krblLIWx07eaiSM3hVECpgszg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rhby+6xpV8d4uqmZRXOQ4rfJQhpMroWJrnWuXr79R/o=; b=X+RzqXINu5yoFCCVmgDkAYRRYmyodgAz7i3hRcBp6E8RKyG4JqJZ/6CjTnHPBZrsEVjhlEpyGrgIep8LRRDWRow3ASkaoYQPOk4PU2OPg7cCKxICeDh41mtjWEVgkxYZlMIq3EI14ZT7qwOWEsVUPUEh1sg6KnyvvLCB0Bo9qm9+WXmNCpvZpMjviMrVnfwfx542xNX/v2TMLZzB20uWYJyi/GgdJCMCZDF1pBHMAMs6kh23/i/WFac+V2zL3vQOVimnWbEdhY0wKvCubjqXfbomLe6BRoZgkqg0lxro3xUx/5EKeoYhwFPEq+VrkEjsQgcoGoU0eKNF3QxLo/rHYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rhby+6xpV8d4uqmZRXOQ4rfJQhpMroWJrnWuXr79R/o=; b=K6Tuqq10ZelCAoGaCLkZ+4P3yDJQqhlrZo0V3E3k1fC4OpSELmQO2Zj+EdHEZ5fvRkB0g6oRFzNFh3dTXigw1Twi8OQRUUSFaQxdYFSt/vTyc194F6ECUbGfFQYUhl4DGhgeH3ED7MgY7RpIr4+mtvWWu78/lCTUoshFSIWMcsg= Authentication-Results: wdc.com; dkim=none (message not signed) header.d=none;wdc.com; dmarc=none action=none header.from=wdc.com; Received: from DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) by DM6PR04MB6809.namprd04.prod.outlook.com (2603:10b6:5:22a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17; Wed, 3 Mar 2021 11:56:22 +0000 Received: from DM6PR04MB6201.namprd04.prod.outlook.com ([fe80::38c0:cc46:192b:1868]) by DM6PR04MB6201.namprd04.prod.outlook.com ([fe80::38c0:cc46:192b:1868%7]) with mapi id 15.20.3912.018; Wed, 3 Mar 2021 11:56:22 +0000 From: Anup Patel To: Atish Patra , Alistair Francis Cc: Anup Patel , opensbi@lists.infradead.org, Anup Patel Subject: [PATCH v3 02/11] lib: sbi: Use SBI_HSM_STATE_xyz defines instead of SBI_STATE_xyz defines Date: Wed, 3 Mar 2021 17:25:03 +0530 Message-Id: <20210303115512.470786-3-anup.patel@wdc.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210303115512.470786-1-anup.patel@wdc.com> References: <20210303115512.470786-1-anup.patel@wdc.com> X-Originating-IP: [122.171.215.70] X-ClientProxiedBy: MAXPR0101CA0040.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:d::26) To DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from wdc.com (122.171.215.70) by MAXPR0101CA0040.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:d::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Wed, 3 Mar 2021 11:56:20 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 2155a192-44d0-45b2-d73a-08d8de3b5d6a X-MS-TrafficTypeDiagnostic: DM6PR04MB6809: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: WDCIPOUTBOUND: EOP-TRUE X-MS-Oob-TLC-OOBClassifiers: OLM:2512; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vRUYSraP/OIZgirR+7Sl+jLtD7m+5PN2DqRYbE2EMn6/J5Rd0Wpp3fz6ZluCDm54I9iCK/rCy1jBWO9S/4DQHqEeGrsIYJaEkD21Gr0uIt3RZ0BbQu0YvwzuAr0YKX82BPCwWWSBd3eMJNkA2WqqN6ye55gmqHxt4/AMKGZ3SeKyE1uM8eh/bZ5PZ5/htYhijawhmKdVD/OaTFjT6mWeMZk8ccrpvze+mwQTAA/LUeLnthXuzgLdhyTzindaxggf50rz8Ho47MPHSnYEjUogKS76wnJF4Jr0PYloAX1KpQbyoyd6KhtdY0yFQ7kzT0VdcvGI+tuHK47qZThRaun4fIQ33eLLCxkBxQr0FaJBXfYlLOexBXCEDVGh+Js4DqyTgK3tVOEcHXqey30I7kADSYGsOmyfHCCDGMeLcArSAcwNaJfurNU+KAN0ZmNkcNo1WfmN8UcvjxbxWHsahFy+1JQLQku09Z5Yu2SC0Ho1OGHXf8p2sKG8D8Vj3AU9uUipOxgR5xkxNhgwInAFgSpfWA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR04MB6201.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(346002)(376002)(366004)(136003)(396003)(83380400001)(316002)(186003)(16526019)(4326008)(6636002)(110136005)(1076003)(54906003)(55016002)(6666004)(66946007)(26005)(36756003)(8886007)(956004)(2906002)(44832011)(8676002)(8936002)(7696005)(66556008)(66476007)(2616005)(5660300002)(52116002)(478600001)(86362001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: Ji3GtnuZWX1suB4BJ+apTcTzAbr6SDWaYoj9vgy0gxnBnFf9UEsU3gOgIL44ZtfumH2+94HI4MtpiFsNh9CKF4vc83S9t5PQGv1c+hMuWdHmkpUuXWouYY6r/V+AB7dsDiZKIBmea43RXBVTtEypHGZ9md4Po8mtwwdnjb7Pqphk3I/och1lLa7oyCyvEYRlcqHzBadFCARgFSIac3lY6lkMIQAihl9JwCzrSZiWwKeqvRpmjxYoInznfvA7Gx16Ndsak0OoEhlPqemqHFu4GHNuzlZhF+sjl+XpM8THAdey7QoGmVUdEQlbBvkBCIkbOKA05mnoJzWn7AAu1jMUCtOu2hz8K4ICA7bUFQb0nkoKVXcsg09o2h9DDnU1mPRT8YXD0NCy8BPAH7FQ41tHxFOuZ1okBKAjaFfaXThKvCCv7KIOAmf4WwP+IP8hZmXRVFGl12gO5UxfJNy3m5GR/0MaJxllwRSogDxq+Gf/GwywnYeIL/p4/ykVEwOKnElxThHK9QzYOQ8wY/OFg4uWN1rEJgUikmNT4hlzyCipnU1ukFaLKfogsdYRAxT7nk4UWzQVFAe1VDtRJVGZM2wlhnp4aCXysnS8InY9foaM/6/hwPKpTHKOU/nhpEU0VCqbNYdt05Gq9QB2BS8Xg8OC2eum+InWClO848ZtsRL4zVDAdXeLPM5APAF0crCeNmwww27msPw2/aDSrvoJX1c5WHLPA/Thu8J0kX+FwUepeKRWSMW5sFbiOUzI9fOWukXMR7tqdTv07XeAhXdv0IaKkKMYrhKTZRU6r7y4Ycw7wJZoepf8ZqE5kEJCwpSOayLK3b7s6NotHKA1+4vtHd4hMbH1oFYETEGaiPMJW7BANfBP8KCGOQ330DlZIvU3OGTjyYwoB5Jmszocn58U+NpQgXw1oUQqpkAzPma7UEQNEtKVDoI8TEJ01J7CYn/5Jo9VCnNoQ3AfyO8dHcHaxTXOuNdyYGAlY+/iXBAH5YLDEa63EUnz+PgW88Jpmgyv+wkVIPlBjaD8gGRswWy7C8CKWqSCZsLd3AldHxs3RIxCOD99j6pRnY7ceAIbCdOOswc6V+yv+9/2RFFDfPqAFPp3vq2ttOY1HqrE+n2/7IPx99f+hK3UQwt4U/G3VrLl0dTpDXwwYBwPD/wJXzA8oP5oJj7kAIh9frjgbiPfrjliD4vjzVKDg/tLD6jBFhv74MjclInOSA7g6UQ/4y60IyPYuL4eF1tUWjk6el+PY/P6wjiyNM99TYB2yCC7A8PfWA2vOAvfYIaA42E9aLlSd0ksBS1QASv8HANJTvcdRMzpcIF2vdiYZTvV5x6YucKLgsiW X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2155a192-44d0-45b2-d73a-08d8de3b5d6a X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6201.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2021 11:56:22.6883 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CTAi8slg+lo4Zi0QdtH0XG1gO6VkloCpDxVZZJZx8uNOCOYGFdrHhJETs/tGV9YhrNaJGqIXyb9nlVby6iYcbg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB6809 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210303_115643_318692_6EAC601C X-CRM114-Status: GOOD ( 19.31 ) X-Spam-Note: SpamAssassin invocation failed X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org We replace the use of SBI_STATE_xyz defines with SBI_HSM_STATE_xyz defines because the HSM state defines are complete enough to implement HSM state machine in OpenSBI. As a result of this, we can now remove sbi_hsm_hart_state_to_status() function because it is now redundant and sbi_hsm_hart_get_state() can directly return HSM state or error. Signed-off-by: Anup Patel Reviewed-by: Atish Patra --- include/sbi/sbi_hsm.h | 8 ------ lib/sbi/sbi_ecall_hsm.c | 7 ++--- lib/sbi/sbi_hsm.c | 64 ++++++++++++++--------------------------- 3 files changed, 24 insertions(+), 55 deletions(-) diff --git a/include/sbi/sbi_hsm.h b/include/sbi/sbi_hsm.h index 4823383..69ddee7 100644 --- a/include/sbi/sbi_hsm.h +++ b/include/sbi/sbi_hsm.h @@ -12,13 +12,6 @@ #include -/** Hart state values **/ -#define SBI_HART_STOPPED 0 -#define SBI_HART_STOPPING 1 -#define SBI_HART_STARTING 2 -#define SBI_HART_STARTED 3 -#define SBI_HART_UNKNOWN 4 - struct sbi_domain; struct sbi_scratch; @@ -30,7 +23,6 @@ int sbi_hsm_hart_start(struct sbi_scratch *scratch, u32 hartid, ulong saddr, ulong smode, ulong priv); int sbi_hsm_hart_stop(struct sbi_scratch *scratch, bool exitnow); int sbi_hsm_hart_get_state(const struct sbi_domain *dom, u32 hartid); -int sbi_hsm_hart_state_to_status(int state); int sbi_hsm_hart_started_mask(const struct sbi_domain *dom, ulong hbase, ulong *out_hmask); void sbi_hsm_prepare_next_jump(struct sbi_scratch *scratch, u32 hartid); diff --git a/lib/sbi/sbi_ecall_hsm.c b/lib/sbi/sbi_ecall_hsm.c index df29d51..79a9f21 100644 --- a/lib/sbi/sbi_ecall_hsm.c +++ b/lib/sbi/sbi_ecall_hsm.c @@ -23,7 +23,7 @@ static int sbi_ecall_hsm_handler(unsigned long extid, unsigned long funcid, struct sbi_trap_info *out_trap) { ulong smode; - int ret = 0, hstate; + int ret = 0; struct sbi_scratch *scratch = sbi_scratch_thishart_ptr(); switch (funcid) { @@ -37,9 +37,8 @@ static int sbi_ecall_hsm_handler(unsigned long extid, unsigned long funcid, ret = sbi_hsm_hart_stop(scratch, TRUE); break; case SBI_EXT_HSM_HART_GET_STATUS: - hstate = sbi_hsm_hart_get_state(sbi_domain_thishart_ptr(), - regs->a0); - ret = sbi_hsm_hart_state_to_status(hstate); + ret = sbi_hsm_hart_get_state(sbi_domain_thishart_ptr(), + regs->a0); break; default: ret = SBI_ENOTSUPP; diff --git a/lib/sbi/sbi_hsm.c b/lib/sbi/sbi_hsm.c index 1722280..1f54c9d 100644 --- a/lib/sbi/sbi_hsm.c +++ b/lib/sbi/sbi_hsm.c @@ -33,30 +33,6 @@ struct sbi_hsm_data { atomic_t state; }; -int sbi_hsm_hart_state_to_status(int state) -{ - int ret; - - switch (state) { - case SBI_HART_STOPPED: - ret = SBI_HSM_STATE_STOPPED; - break; - case SBI_HART_STOPPING: - ret = SBI_HSM_STATE_STOP_PENDING; - break; - case SBI_HART_STARTING: - ret = SBI_HSM_STATE_START_PENDING; - break; - case SBI_HART_STARTED: - ret = SBI_HSM_STATE_STARTED; - break; - default: - ret = SBI_EINVAL; - } - - return ret; -} - static inline int __sbi_hsm_hart_get_state(u32 hartid) { struct sbi_hsm_data *hdata; @@ -64,7 +40,7 @@ static inline int __sbi_hsm_hart_get_state(u32 hartid) scratch = sbi_hartid_to_scratch(hartid); if (!scratch) - return SBI_HART_UNKNOWN; + return SBI_EINVAL; hdata = sbi_scratch_offset_ptr(scratch, hart_data_offset); return atomic_read(&hdata->state); @@ -73,14 +49,14 @@ static inline int __sbi_hsm_hart_get_state(u32 hartid) int sbi_hsm_hart_get_state(const struct sbi_domain *dom, u32 hartid) { if (!sbi_domain_is_assigned_hart(dom, hartid)) - return SBI_HART_UNKNOWN; + return SBI_EINVAL; return __sbi_hsm_hart_get_state(hartid); } static bool sbi_hsm_hart_started(const struct sbi_domain *dom, u32 hartid) { - if (sbi_hsm_hart_get_state(dom, hartid) == SBI_HART_STARTED) + if (sbi_hsm_hart_get_state(dom, hartid) == SBI_HSM_STATE_STARTED) return TRUE; else return FALSE; @@ -110,7 +86,7 @@ int sbi_hsm_hart_started_mask(const struct sbi_domain *dom, for (i = hbase; i < hend; i++) { hmask = 1UL << (i - hbase); if ((dmask & hmask) && - (__sbi_hsm_hart_get_state(i) == SBI_HART_STARTED)) + (__sbi_hsm_hart_get_state(i) == SBI_HSM_STATE_STARTED)) *out_hmask |= hmask; } @@ -123,9 +99,9 @@ void sbi_hsm_prepare_next_jump(struct sbi_scratch *scratch, u32 hartid) struct sbi_hsm_data *hdata = sbi_scratch_offset_ptr(scratch, hart_data_offset); - oldstate = atomic_cmpxchg(&hdata->state, SBI_HART_STARTING, - SBI_HART_STARTED); - if (oldstate != SBI_HART_STARTING) + oldstate = atomic_cmpxchg(&hdata->state, SBI_HSM_STATE_START_PENDING, + SBI_HSM_STATE_STARTED); + if (oldstate != SBI_HSM_STATE_START_PENDING) sbi_hart_hang(); } @@ -142,7 +118,7 @@ static void sbi_hsm_hart_wait(struct sbi_scratch *scratch, u32 hartid) csr_set(CSR_MIE, MIP_MSIP); /* Wait for hart_add call*/ - while (atomic_read(&hdata->state) != SBI_HART_STARTING) { + while (atomic_read(&hdata->state) != SBI_HSM_STATE_START_PENDING) { wfi(); }; @@ -174,7 +150,9 @@ int sbi_hsm_init(struct sbi_scratch *scratch, u32 hartid, bool cold_boot) hdata = sbi_scratch_offset_ptr(rscratch, hart_data_offset); ATOMIC_INIT(&hdata->state, - (i == hartid) ? SBI_HART_STARTING : SBI_HART_STOPPED); + (i == hartid) ? + SBI_HSM_STATE_START_PENDING : + SBI_HSM_STATE_STOPPED); } } else { sbi_hsm_hart_wait(scratch, hartid); @@ -191,9 +169,9 @@ void __noreturn sbi_hsm_exit(struct sbi_scratch *scratch) hart_data_offset); void (*jump_warmboot)(void) = (void (*)(void))scratch->warmboot_addr; - hstate = atomic_cmpxchg(&hdata->state, SBI_HART_STOPPING, - SBI_HART_STOPPED); - if (hstate != SBI_HART_STOPPING) + hstate = atomic_cmpxchg(&hdata->state, SBI_HSM_STATE_STOP_PENDING, + SBI_HSM_STATE_STOPPED); + if (hstate != SBI_HSM_STATE_STOP_PENDING) goto fail_exit; if (sbi_platform_has_hart_hotplug(plat)) { @@ -238,16 +216,16 @@ int sbi_hsm_hart_start(struct sbi_scratch *scratch, if (!rscratch) return SBI_EINVAL; hdata = sbi_scratch_offset_ptr(rscratch, hart_data_offset); - hstate = atomic_cmpxchg(&hdata->state, SBI_HART_STOPPED, - SBI_HART_STARTING); - if (hstate == SBI_HART_STARTED) + hstate = atomic_cmpxchg(&hdata->state, SBI_HSM_STATE_STOPPED, + SBI_HSM_STATE_START_PENDING); + if (hstate == SBI_HSM_STATE_STARTED) return SBI_EALREADY; /** * if a hart is already transition to start or stop, another start call * is considered as invalid request. */ - if (hstate != SBI_HART_STOPPED) + if (hstate != SBI_HSM_STATE_STOPPED) return SBI_EINVAL; init_count = sbi_init_count(hartid); @@ -276,9 +254,9 @@ int sbi_hsm_hart_stop(struct sbi_scratch *scratch, bool exitnow) if (!sbi_hsm_hart_started(sbi_domain_thishart_ptr(), hartid)) return SBI_EINVAL; - oldstate = atomic_cmpxchg(&hdata->state, SBI_HART_STARTED, - SBI_HART_STOPPING); - if (oldstate != SBI_HART_STARTED) { + oldstate = atomic_cmpxchg(&hdata->state, SBI_HSM_STATE_STARTED, + SBI_HSM_STATE_STOP_PENDING); + if (oldstate != SBI_HSM_STATE_STARTED) { sbi_printf("%s: ERR: The hart is in invalid state [%u]\n", __func__, oldstate); return SBI_EDENIED; From patchwork Wed Mar 3 11:55:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 1446832 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2001:8b0:10b:1:d65d:64ff:fe57:4e05; helo=desiato.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=nZ+tz0Jw; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=Kwxn0Lwp; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.a=rsa-sha256 header.s=dkim.wdc.com header.b=YDwKvrgm; dkim=neutral header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-sharedspace-onmicrosoft-com header.b=Mvi23U4q; dkim-atps=neutral Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DrPrh3V07z9rx6 for ; Thu, 4 Mar 2021 06:56:20 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tcJYh4b68vvafcDcPECml1/f7IGZEJ2a+Cc8/PzMUtE=; b=nZ+tz0JwRUtK0+3mL3nbdK0Pg z0nM/Fj8K/tSE9FKUleV6IMoXHpcRf5Si9w0QKXYv6erBq77viuHOHxBkj0JpGJgZuCl2V3sx8E2+ udfCBbxoMig6eVlk4NTNpdRpts/G5XjjqA3Pu7B3Zq2ORx2f3dfWq1wiwhAI9sgwHQbi2xWFCQYBw QjTYGZ3ewbWcoQCf1k7oQ2b9G0HiNHfpfVP8BhOz1mK7ugcH6Fhe9iXAwy5nEEEkd9/yzBUMv5HTD T4wMgGpT25lTXozfPmSnDdIF3a7Ynh5qGYRZaq6Ur4pxvoPv7mEx28LVzpgn6jYiskgp6fVsoNaw4 DDwL930sw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lHXbQ-006JiG-Hd; Wed, 03 Mar 2021 19:56:12 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHT4T-005IP8-LA for opensbi@desiato.infradead.org; Wed, 03 Mar 2021 15:05:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=XHZbHDHKsy7ketsnF4G158AqJ6KeVj0vZOOV8eSCESI=; b=Kwxn0LwpX83yEpPZ8445I9y20+ MJ22IyPnHEyLsBPGfFtYFgmFfkft70vsfxAcYbx9/hBo8TQ0PRHkTjpdJEu/GT9jx4MrV6W+HA37l +YFid9GswXJcKavXbOeDmf3/zFRwKNEThN0yUxRkjg9M36MwDJggKuNex7onc+UYOJ3Gu6EoLrnpD L85Hses2kD8jjjSyW+H6t6GLpdEFCLZBTD1BKSG6J64x5AL9EdApVVK52bWh43PZbtCK0LiONKJ4x H1ZSbbrxnJp4z6BERH08bE/5Y/QzGdoThipKMiouhcyM858lH2NCvq62juTEU7SIh8upOf+xwRzYn YCBe+2/A==; Received: from esa5.hgst.iphmx.com ([216.71.153.144]) by casper.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHQ7Q-002RaZ-L3 for opensbi@lists.infradead.org; Wed, 03 Mar 2021 11:56:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1614772604; x=1646308604; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=u2H5jVwBqcdlt9+vc/G0CdxuhXna4zj1/gOXb/Yj7mE=; b=YDwKvrgmQ7FxpdJTEtMq8940b3+iz6Nd7+L1zqgx7O67p47cE3rbMabz 9wX/ImSAA5pH+LT9qZv6mMWLcW/ckpzFCyqbmNBLKFL1KPnJRt6MFFkNf o5QUbac+JKpS5AAnvs/8O8XlNk1p9vHKnP0qcV8+RaUPqUkPfllsp0oxP 2mpsyno96CD6TRUsgkNugmNjiVEp5F5QCTGJIfBCu0rULdMGi3jYEeLl6 MwWHLutUu218TUSPbq4wmVj7cdcnEkmtqW7MrJFCLo/VYn7bTA8HPL6iN uA0p7pFv7vCY0LKdPxySA8Lppw2VhmVFhFGqVPBWeDL00j5UUYSK9Uuty Q==; IronPort-SDR: San9YkrwWZnJaNILYuUtX09EH/k3+AGB65VXA81ox25UmUsYtvX3K5xfYx+tSqgGNUpM0CyIU/ VG911tBmxLWHWKt4Vah7ot5m6cTXYSuIy/p2FNrzyxksCnbGM+gOSQ5s7NZWrci0KOdV2+Jot7 QL4TwAuHvIVXynTg4qMk7mlyJArsaoCvdMVmn2iN27rZWbW/Bps4OvWJxhA47JtWtlPMRZAx2v tDHIQwitjC2AVukJm96X2MpLl7zKFX/d6kSgudeBGkjX+sd9sMNLPXuMwfXcS97y3Rnua/2ieM WAM= X-IronPort-AV: E=Sophos;i="5.81,219,1610380800"; d="scan'208";a="161265014" Received: from mail-mw2nam10lp2102.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.102]) by ob1.hgst.iphmx.com with ESMTP; 03 Mar 2021 19:56:26 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GgfctckFMdSnXKsegoSqfyDnlQKKR0wA3SkHgx1yHBSlCtvsiAMREcfVJB6+j1pP2FACiK478SSlvh7bGA3WD7vi91Yxv26is2HqP6LvmEDY04+brHQDU/bb8u6hj78bqK3Xr8r8gH51o/9DE896Khb7HyBxWlRQLx7fE4iIWCfMe9xM39WbStJKV5kOMUYzuBDuqyeYYDE3FPB3TLrOsgAI6HGCPc0cl60OfPJ6VZxB0b8u0b+BLEJRCFrBndhYPzSKAjEZuwsFmBiOQesNGHvTgDDUr5m7xofXNpdrLYyRdTGkGdpFrQ+2bmTsukZUmI6qiJeDtItoBJ44vCeSCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XHZbHDHKsy7ketsnF4G158AqJ6KeVj0vZOOV8eSCESI=; b=DNpPxlqzHVbScP8xx9qCs4T4VcmDFqqagE8Za/eChvTnnCOsIpLb2kOPSn51CCMtO8ePswz05HdjNTfFvuBAMrUhP2TUQQqSlHQNLyZfm3xVRNGubmJaP7tl5a+Wd4gCDXmRykVEDBcD8JUTOYK9FpNYwW0bY86/rpLWqAK2WSI4RlNP9hed8VicT/dRpj7uiWYWnGJDE5LHerc4FFl9ksVVC8GWWTG1rrbS0IOxJVUApPnO4YOahBmymDEyn0mAI9SMXVv2NgSJXY9TLn5l5asclXmPQ1bPAYIrD1Hb/RjxsQWKjSCC6Ozof9wuw7YdNjXPylrEz9VQIxE8vH46+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XHZbHDHKsy7ketsnF4G158AqJ6KeVj0vZOOV8eSCESI=; b=Mvi23U4qXVeBA7qtG9VdTQ6uM/oVVy9BqzcWsH9Rzr7HG9U3hr1BUP1a5eWjoLbL5MhPjxcyrPsdkpySA7HqqNcOxIxW+AexGTfogXoVUWzoY2jCB5esY8zKuU6XeDkObpWJYDtcCnPCUAQZY/HtCaMSuH2pr269QhdOptkFNHM= Authentication-Results: wdc.com; dkim=none (message not signed) header.d=none;wdc.com; dmarc=none action=none header.from=wdc.com; Received: from DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) by DM6PR04MB6204.namprd04.prod.outlook.com (2603:10b6:5:122::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17; Wed, 3 Mar 2021 11:56:25 +0000 Received: from DM6PR04MB6201.namprd04.prod.outlook.com ([fe80::38c0:cc46:192b:1868]) by DM6PR04MB6201.namprd04.prod.outlook.com ([fe80::38c0:cc46:192b:1868%7]) with mapi id 15.20.3912.018; Wed, 3 Mar 2021 11:56:25 +0000 From: Anup Patel To: Atish Patra , Alistair Francis Cc: Anup Patel , opensbi@lists.infradead.org, Anup Patel Subject: [PATCH v3 03/11] lib: sbi: Rename sbi_hsm_hart_started_mask() function Date: Wed, 3 Mar 2021 17:25:04 +0530 Message-Id: <20210303115512.470786-4-anup.patel@wdc.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210303115512.470786-1-anup.patel@wdc.com> References: <20210303115512.470786-1-anup.patel@wdc.com> X-Originating-IP: [122.171.215.70] X-ClientProxiedBy: MAXPR0101CA0040.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:d::26) To DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from wdc.com (122.171.215.70) by MAXPR0101CA0040.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:d::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Wed, 3 Mar 2021 11:56:23 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 82f4943a-6e79-4d67-5763-08d8de3b5eda X-MS-TrafficTypeDiagnostic: DM6PR04MB6204: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: WDCIPOUTBOUND: EOP-TRUE X-MS-Oob-TLC-OOBClassifiers: OLM:5516; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pYqPBdjObd/lgVVufhjkc1RLjO+ImouShH6JTjIdJWFeMHYMskp3Y4Wn0p9nIX/cC7eTBdonD6nkSvsCusMIYNuP8P6hlxbVOqIHrX8vGDcVoCGwiP6x/BY+2Wv8MV2Q4k/v0MqguD2BGz1P1asCZGEj874M9SMHppWEU69G9fIx6p0DsTHpaE3oON9gpfLDSdeNd4O01/i7RLoNEfSkpL/J1OzUpPYM9J2Z5J28D6WeOfDj4VxPmXz4kmLDD9cEkAiKBNf80oBCxwBH8B4e8qDabjbAOEIIPvGoLn/SObXVgpvNAbw68dvgz1TKXFBnqJCMrGQM3m+UMDCH/yxr2L9t1dGFxWLTRRCf66gvbIkeYhVKbhVcn2fDAAlnaRUCoTJFhaPXscgEdrYzaJfyDf4TDzUS6b5+RrQu4PI4rkoryFRySQiQMgqZ/c7ypdE+MD8sIl9uXRZgYUqczDH1xg3NInK5R2Ib7ZcdD9DCwM/wulCKxGM+CepRm82SAC/51M1DaeEXuI9uKr+FW9WeIQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR04MB6201.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(136003)(396003)(366004)(346002)(376002)(316002)(4326008)(52116002)(16526019)(186003)(66946007)(5660300002)(8936002)(7696005)(36756003)(478600001)(66556008)(2906002)(2616005)(956004)(83380400001)(66476007)(8676002)(1076003)(8886007)(6666004)(55016002)(6636002)(44832011)(86362001)(110136005)(54906003)(26005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: DBWFvkKguAGaxpYYzKWNZ3eJm3EVhMGrggjajvy/QyCxFfnfz0MyGjy+57py4uZ2Y0DUgbSMg5RuvUecGm16rmbxRSU1cS03KmABUKXtEjTK5zO5URqODjdwO0zC57rNVhGB6gLLczk8VmNInv+InGGZs7Unh4wbBDUtaNN8w8+XUjygiyglt6QjqOgllRR3ZThKrgD75zBzoc45I9QHzcY3PhFV8A97dBGiezkWxkP8NLxMb4CEBuVIc/aw82AYjMfzfYcAegnn8ZS867k/yKf44WPEWB64GVgS3RCSJdM86/WfhtAYvN4UrXhE7pTME7dOdPVIsEQNWsnX58mINX9d6bYofI/0M6L62YnmBvJk4dOAcGTQTDvIJqhxcnyE2W+l8Dkw5fkTU2Q1a2tzhFnq/gr0atHJq6dIL4iyexJLf3nHsztjJaMi/lz7XhoowPxMEohVSEoHbfCThtLdn1FUhtHDltQ4ep2vLc1oHsnor++C8aS+3gtdPKgSDu1KLP4iajS6CYwN4k7GRAKlivvptpMeApi9dqNeHXu7ZH8iFEOnlCJ8EXWptvO6jE+oFJNnn6CB1r9AoC7ZEb/MWiNUC0Z02Yz42scXx3LYfYIn3Fhk5k/nCspEYMkGYUda89sgc/uN00fu37qa9KOMKaAHScsRNWqH+FUt55l8p/cj0/k+/NuCchJLMefG6ATRDUtcT6bwiCcWpoG5kavQ2oJIT8Sy3jg30WGwVEjN6kZ3aHx4TTsI5P3aEu442v95iR3W83u1Lk38BdmWg3Z9Pijvs/3GX5nWraGVQNVDQEey9CJJVaa0rHGGRpu55KoLdeMwMQhw2mkfvFBRftwzC7OQmni5OXlNjyo+TXp+lw/EE7nX3zzaOKQcvcPjwrPGB0Zpxo7/AHkxQ31i6RcxjmIBPt/XJFib8/sGWd8hrQXxB+SDruFV7ogBiDOGrc9PI6P/bnrT7uVEW+uXwtHIWpLaVyPE2nN0nS4ntNhwPY8/9tDhVUl8dOV2BCr3uopXO0d9aByqWYK3fNDJQE6lbEeky5wrFQPGd0Pakb7W276ImxGz+n90ni7cmyY5DivVrosOaMrnMsQBcRcA2/tQ1d5uapzQUABZ4gnphO2AjuIxgNEf/m0TadruIxDxSQDnuCCC3ncnSTLFJGWSz06hkSTX2HKDAdfWUZ8P3PEKzDYBsMQL0kZB24tX+ewyy3JcLH83Ogb7eLiaHljSa7qLguZjSoTcf2mcNqjLCWT4IihcnpczTwIb+X/QiU23HYbdzLUAz2K+hZRMrt2rnob3GjY77YZgCOwwYwxaeAP453xk8JbAmZtoUEY2ybfaSSGh X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 82f4943a-6e79-4d67-5763-08d8de3b5eda X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6201.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2021 11:56:25.2546 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8WJjMlWIiUvds8Zp2j0FQXqP+u8VhSSIQn34bXRSzaeS3FQ45Or6SL4Vn/0Y5Tos8NWhJSA81BYWOO55qfNhgA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB6204 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210303_115649_716429_6C27E563 X-CRM114-Status: GOOD ( 14.69 ) X-Spam-Note: SpamAssassin invocation failed X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org A hart can take interrupt in the new HSM states introduced by the SBI HSM suspend function (such as SUSPENDED state) so we rename sbi_hsm_hart_started_mask() to something more generic such as sbi_hsm_hart_interruptible_mask(). Signed-off-by: Anup Patel Reviewed-by: Atish Patra --- include/sbi/sbi_hsm.h | 4 ++-- lib/sbi/sbi_ecall_legacy.c | 4 ++-- lib/sbi/sbi_hsm.c | 4 ++-- lib/sbi/sbi_ipi.c | 4 ++-- lib/sbi/sbi_system.c | 2 +- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/include/sbi/sbi_hsm.h b/include/sbi/sbi_hsm.h index 69ddee7..4250515 100644 --- a/include/sbi/sbi_hsm.h +++ b/include/sbi/sbi_hsm.h @@ -23,8 +23,8 @@ int sbi_hsm_hart_start(struct sbi_scratch *scratch, u32 hartid, ulong saddr, ulong smode, ulong priv); int sbi_hsm_hart_stop(struct sbi_scratch *scratch, bool exitnow); int sbi_hsm_hart_get_state(const struct sbi_domain *dom, u32 hartid); -int sbi_hsm_hart_started_mask(const struct sbi_domain *dom, - ulong hbase, ulong *out_hmask); +int sbi_hsm_hart_interruptible_mask(const struct sbi_domain *dom, + ulong hbase, ulong *out_hmask); void sbi_hsm_prepare_next_jump(struct sbi_scratch *scratch, u32 hartid); #endif diff --git a/lib/sbi/sbi_ecall_legacy.c b/lib/sbi/sbi_ecall_legacy.c index 1a7fe26..e20de76 100644 --- a/lib/sbi/sbi_ecall_legacy.c +++ b/lib/sbi/sbi_ecall_legacy.c @@ -34,8 +34,8 @@ static int sbi_load_hart_mask_unpriv(ulong *pmask, ulong *hmask, if (uptrap->cause) return SBI_ETRAP; } else { - sbi_hsm_hart_started_mask(sbi_domain_thishart_ptr(), - 0, &mask); + sbi_hsm_hart_interruptible_mask(sbi_domain_thishart_ptr(), + 0, &mask); } *hmask = mask; diff --git a/lib/sbi/sbi_hsm.c b/lib/sbi/sbi_hsm.c index 1f54c9d..a81b821 100644 --- a/lib/sbi/sbi_hsm.c +++ b/lib/sbi/sbi_hsm.c @@ -70,8 +70,8 @@ static bool sbi_hsm_hart_started(const struct sbi_domain *dom, u32 hartid) * @return 0 on success and SBI_Exxx (< 0) on failure * Note: the output HART mask will be set to zero on failure as well. */ -int sbi_hsm_hart_started_mask(const struct sbi_domain *dom, - ulong hbase, ulong *out_hmask) +int sbi_hsm_hart_interruptible_mask(const struct sbi_domain *dom, + ulong hbase, ulong *out_hmask) { ulong i, hmask, dmask; ulong hend = sbi_scratch_last_hartid() + 1; diff --git a/lib/sbi/sbi_ipi.c b/lib/sbi/sbi_ipi.c index 4347832..a3a6ce6 100644 --- a/lib/sbi/sbi_ipi.c +++ b/lib/sbi/sbi_ipi.c @@ -82,7 +82,7 @@ int sbi_ipi_send_many(ulong hmask, ulong hbase, u32 event, void *data) struct sbi_scratch *scratch = sbi_scratch_thishart_ptr(); if (hbase != -1UL) { - rc = sbi_hsm_hart_started_mask(dom, hbase, &m); + rc = sbi_hsm_hart_interruptible_mask(dom, hbase, &m); if (rc) return rc; m &= hmask; @@ -94,7 +94,7 @@ int sbi_ipi_send_many(ulong hmask, ulong hbase, u32 event, void *data) } } else { hbase = 0; - while (!sbi_hsm_hart_started_mask(dom, hbase, &m)) { + while (!sbi_hsm_hart_interruptible_mask(dom, hbase, &m)) { /* Send IPIs */ for (i = hbase; m; i++, m >>= 1) { if (m & 1UL) diff --git a/lib/sbi/sbi_system.c b/lib/sbi/sbi_system.c index 08a8b47..10915b4 100644 --- a/lib/sbi/sbi_system.c +++ b/lib/sbi/sbi_system.c @@ -35,7 +35,7 @@ void __noreturn sbi_system_reset(u32 reset_type, u32 reset_reason) struct sbi_scratch *scratch = sbi_scratch_thishart_ptr(); /* Send HALT IPI to every hart other than the current hart */ - while (!sbi_hsm_hart_started_mask(dom, hbase, &hmask)) { + while (!sbi_hsm_hart_interruptible_mask(dom, hbase, &hmask)) { if (hbase <= cur_hartid) hmask &= ~(1UL << (cur_hartid - hbase)); if (hmask) From patchwork Wed Mar 3 11:55:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 1446900 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2001:8b0:10b:1:d65d:64ff:fe57:4e05; helo=desiato.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=cytbYvOh; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=sJYDp/UG; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.a=rsa-sha256 header.s=dkim.wdc.com header.b=amdiEyrB; dkim=neutral header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-sharedspace-onmicrosoft-com header.b=eS1u3xb4; dkim-atps=neutral Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DrSNh70dsz9sR4 for ; Thu, 4 Mar 2021 08:50:44 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MrilPY6lH9unuL471nhRbWDDmtu/g6M6QQaNN4kP6pc=; b=cytbYvOhZrBIdas/9pHCtlPiY EsBZhH55fj/pmXk14qisG6ttPAE8djrl4jOc7DKZTDDp6EbLp6QWSI4nNSk62yTpOi7woTNOR+1XE CWMdlEfhQ16HFLHjgytbG1+HwSq99N2ya/+BpcTUVS7ifvtPSW13y2PV/iMVGcOGZm5rDlsXMQK2c xXkfO45GHnc7IpiEDT3dfo8GMvMMn1Q7pmlbgmgcIwkKdLvBePR3CAJ/Fk/DlpY5UXPi5UxiHVNEP 9xHfVUXmfw9OmHSjTSmGOpLgyaMrENn2xc9Ab3IGp2i48dnaWcnmXpxygKho1jiJ7hyQuCixUqrWg c7ZPo+s3A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lHZO8-006eKl-Ur; Wed, 03 Mar 2021 21:50:37 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHT9d-005KGo-Mv for opensbi@desiato.infradead.org; Wed, 03 Mar 2021 15:11:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=z+Prdj2zATafZhmDVFB4dP4LabIifWK+FZniBgnPHdY=; b=sJYDp/UGCYj7zLBBrdQniYJO1L 9d68jUvoVs5y1YI+4ib106z32orguBfPs6+iU147jdKPmPCkorMZlKPlAqIrmQtwNYuY6qYz4rAMb +4z7Ml8MQfJ7c2aBzJ/2L/qTsGL3Hr819dAQMgVXNBF/0ygY/FyOnajJDYUFp4OYXi+coWydGhgXV uff5uMkiv9ng+vBqWRymlg2b+GbAlTpuXtlNXmLhWGWlS1Y7V+xBkMiUVwnovQYT1vUifq4DztRZs YFIPgC8+uhagTx/D8422h3xO55tYjx14Tn4yKwBW3yWIYpNvymPJ3RLDvBA1Sd0F2meNvEonANKKZ zp+M9glQ==; Received: from esa3.hgst.iphmx.com ([216.71.153.141]) by casper.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHQ7Q-002RbK-03 for opensbi@lists.infradead.org; Wed, 03 Mar 2021 11:56:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1614772604; x=1646308604; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=w5N3VXsnPu14jpaCXYWmxEkpnyGFwRnLbqQ0xHDDBAA=; b=amdiEyrB0+MU6aA4g+NamaF/sduEOxzA5GeA9ZCkgJ4eircmnvZ0UgK5 ZATq+ipLNWVdW5WRsBYNbXE4P7dtneyrHakRm9nBkBCtG1uYytdruzeT7 13Mmi40mzTXAM3Jm3ao0uYrgw87SLkF5Y8847ouAHM0UKxtE3hfrgrgzW cpe3vH8m/Aqyvrg06PM0nblkPyXxcbh+OTipPdyTPrnJ9pXFkGlIrsWIq FtamK9wSnpjtlzgBpAeha4bhkGUyYUZPiDy7TVrcAZBltqTpLHZWr7pok 0Cd1WQ6Iviczkbgb9KbA4j+IXq9I7XehOaFr5WBMulVC/iS+9cpbZQWDQ w==; IronPort-SDR: NGCSH6L2AeZ6vkN0n8BksTSnRd5ZVGjeD1DkIpkkSqhF4ZTbnIkGaHIcOtzzZssjLo9oIBTsV/ KsJFou/GA91ImjXOI4uWmagdbSY84SGspMPRJ0/Zyt8NAdJV6qw1vu86KGkUb4QoI6IsgPlvaC VPkDb6C4RnojiP9F+FbGef/x+2wWly/ScbJCfJ+G5VqCBk5IKEbq5L7HxDvr3JAbLo9IbFBiH4 ERtfOg5xbEp9lL2FmqeleKyzla0yOE8GHcJmGbW+KpUWkD1aLxsn6a5iJfubs4gdgBb7N++Asz UUQ= X-IronPort-AV: E=Sophos;i="5.81,219,1610380800"; d="scan'208";a="165729492" Received: from mail-bn8nam11lp2174.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.174]) by ob1.hgst.iphmx.com with ESMTP; 03 Mar 2021 19:56:29 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N2y/xjzqQL0b3Zej+95/vCdrlANGNovBPHmRJ5smNxYjQ33WWLLUzgKdTUmBrlDxngtyLO2MixxbLYsVQUpnXVNOwkHOqkXvRsYdJjet5cLXuHk5Tnqz678GAYYITxmr4lovVNy5kcJHI5z5YqjsgozAF2dxFAykeYyW0eEnSQoG+/ISOFk+702QJrW8hnnqeaIMsSd3BAM/OUfhvYIiaQq7ph4Fz0O96AqZU5Pi09wmUjSEGedvZy7wpgytmjLTiYGGDVlY23by2tloOzCBy4aA5VQZD1/FRAI1JqXVK2eVAmBtYp8c3h0ZZvOJsIyr5f1h3B8ZrgqPtmIgvQFQ+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z+Prdj2zATafZhmDVFB4dP4LabIifWK+FZniBgnPHdY=; b=DPZd97qHpjLkVAdsMjUcuJrX791Rxy5RF4suMSCToAgSpLeFvMoLFQQZTwktloaEeb/uds5JbyoWibpyqpAe/erI3Zn2yKt6BUoTYj8Sd2vt82VIIPOWWRIs7GhEpw/sXfm0VLjbXEGQ+Sxv2gwgL5KwMGOeYZpN/EK8fxVkGsK0cHqRo0VQsltJngWky9RZNpudk78masiGVN1QZmnwpCYPYdcjt7f/h+045rXV1pF4ozgQUDmbmbvoEJWPhF/M9az53yXHFNaWlfjv1n+j+OGtGtoleAiyVhiWPbhRTqi3ccv7lOg1vytkGJG94PJIbk2Evm2qm60ESjPq7owoAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z+Prdj2zATafZhmDVFB4dP4LabIifWK+FZniBgnPHdY=; b=eS1u3xb4pp/QkTbsbV2PlWJCee5JcyaneNltSFhJLYVLytllVxbWOlBteZFhTQJl+Q9F0Sg+WyxydBN9PTlfAsiOcPvAUA1SoqZZAx0pNT4iG4gvQ9/IZeESJv2EOGXN9UNl/NF/r6vagx5VUI62zNuMYPh+voEDbwjyL7XUgE0= Authentication-Results: wdc.com; dkim=none (message not signed) header.d=none;wdc.com; dmarc=none action=none header.from=wdc.com; Received: from DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) by DM5PR04MB1148.namprd04.prod.outlook.com (2603:10b6:3:a7::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17; Wed, 3 Mar 2021 11:56:27 +0000 Received: from DM6PR04MB6201.namprd04.prod.outlook.com ([fe80::38c0:cc46:192b:1868]) by DM6PR04MB6201.namprd04.prod.outlook.com ([fe80::38c0:cc46:192b:1868%7]) with mapi id 15.20.3912.018; Wed, 3 Mar 2021 11:56:27 +0000 From: Anup Patel To: Atish Patra , Alistair Francis Cc: Anup Patel , opensbi@lists.infradead.org, Anup Patel Subject: [PATCH v3 04/11] lib: sbi: Remove redundant sbi_hsm_hart_started() function Date: Wed, 3 Mar 2021 17:25:05 +0530 Message-Id: <20210303115512.470786-5-anup.patel@wdc.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210303115512.470786-1-anup.patel@wdc.com> References: <20210303115512.470786-1-anup.patel@wdc.com> X-Originating-IP: [122.171.215.70] X-ClientProxiedBy: MAXPR0101CA0040.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:d::26) To DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from wdc.com (122.171.215.70) by MAXPR0101CA0040.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:d::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Wed, 3 Mar 2021 11:56:25 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: eed17f25-a1f9-47fd-e2b9-08d8de3b605e X-MS-TrafficTypeDiagnostic: DM5PR04MB1148: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: WDCIPOUTBOUND: EOP-TRUE X-MS-Oob-TLC-OOBClassifiers: OLM:747; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WJHW6GsdCthMkzSPvQBhq1LFaQYxGidRUfQywaniNYo1+rDpXdF8T98YsrJrsmDM8V9Hdot7tu6bJq94b6iGdu5LzOSsknBQeTE1jOq/sXDnbFZ9pX+LDLZs0W7QuZ4M7NKRBIq/JtRox+jkW5j61gKIZUcxCaR1Xtj4d4dmGVsUXZu2KQA5j8Hhedonz9Jcv2BM2lHbqjY8vLqIuHmhbKUURTy+ZJkvPV3vTp55/XaWbsv21KHN81MwfqXJBMBuLOTwYrIyy1MHPc8aDnpEMQw8IBYR1n4EC+UlyYlvKuy2Wv3iFLWCNCjkBrOZ5MIPRlbjZwxdKQf49TzOpRXAkxP0o07CAu0uFpl19qorhFj1rXYdzEwTYsVTcUY7XjoeW88jEf+cBizDJ36A9cPS59QFLlyHUtGSVzP7akjbE2XJFApg75lCxfhLDvcGqlsXnFwIj3lzn4GxX3lYOq4J45D0WB53y1QnbwwTgDqaTNyKKcgnRQ90saFEVBbav36jDWk/XcBQuaLDHll36bV05A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR04MB6201.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(366004)(396003)(376002)(346002)(136003)(7696005)(8676002)(8936002)(1076003)(86362001)(316002)(478600001)(55016002)(52116002)(26005)(54906003)(36756003)(6666004)(8886007)(110136005)(83380400001)(66476007)(66556008)(66946007)(5660300002)(2906002)(16526019)(186003)(956004)(4326008)(2616005)(6636002)(44832011); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: 6dpVSWTcvTC8z2PafHFh7YYQSH2GOaSf5PrV9UG2+L5ySW9drOaLsFnxbkTwbkP4YKftL01S/dGIVWZqnshWjwuUEA1M6voUcMLcUmw0L7Nz3E6OBWgsEdJmL2voGORzUPXBUuTcKdxUAImi/RdrogZvpTnPrXyy4jiG73SpzhR58eYOKd7O+iSWiKnVjGTg6FrlzDS6ziqPbgqKQ1JfA8mDmbsx9soTzFkOfVFI8S7U/2jxuBa+P5+f4aUFpD1563cf2vGQWV3SRAn2MUKIzIJmdUoo/PgQNKU8itzss0Kc2O1zghPBTHE9bsc8ZyP1cvJ0RDWL2/cRtQ/xuOmAbEn955MDIW3WazIFRS+HelfdCqhS4D0duNgVt5KxU4rPIyoY6sMqY1nCS6JOnwHnrpyU5Z+g+BWuvgiJzgz72oM5TiQRKz7ruY6WoKa3+XNaPLCOn0JPjZ6oagbtO5BiESXJVb4y2NVJDfzNEEWpOs0e+3gvOhYgm8Bt2i1nMdHkcM3JIEl5JEQ2MXny8CXkFrrPIsFIJYXbffTqoP/YV5AiW1otDLCHCl+3hVORBqmSt/xeIrT2SCD9DI5OttVeiSs8zEM43aQUcq2N//M4MQ1IgTPVdOQrq5YydHjscqJJRZAHPu2v4rg5IcA3+IREVN7fTgvQ6qFnzQBoy3I/TrQa2MAa/vSFskZYRVgd4tSDvwmKoyzEJqujr2z6hdJikx31QRZZ54BMp4E3eoe+SRi6DCvRVyf4ru+4tZ4CgGfDpPh463LtBkkCA6zU34k8c+uiqc8zHKP0LJNs4VO7Tbdnq8HJNGt8Yr9URzRmIj9vrFIOvL0W1IDEQEsczp9ofhzWgwd/UKQ+4Dw/5Md+OC+xiu1ppyhclOYmeaCBPpisWoND0TI7LUrjk6JEFI/pBf+WcybqfTxNca0IFbUv29xykVUs4SfVIZbNZ0A4Kx/ltH2VzXSHAfvojfNDlgExY++JEHUTNso/O9o6Ara4ykjTFrTB5H8gSmZ1jAAUWguY1xb1wX9l2oI7YleGyuIdnj2xcevXY60OpMxMWL1C45W3LD3YANAltRvxuxsMyiaq789luzrlgBCR6pUetpHUl4ZcQWFvV00ED24BBGPPUXqGn/oJ5zrMSL9UvcNKTCqThPbVLFn3GpaQMLoWmHfs1MPAMnCBsF5aCCUGjuXdLiy8uvhzsImkJjkdMy7VGyu6G+Z6DhEnG57hNWCpFHu60+IkAZsrnvvDHuwPN3xE4ogaNYNUqs6Q446eCOsDjLgwI8asujqA3Lkr/0OpmX9CrLa3znSDjB06pTwbmjpV+WtmtAtIfVv18CD8y+0+bYlo X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: eed17f25-a1f9-47fd-e2b9-08d8de3b605e X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6201.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2021 11:56:27.8390 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: p3hEV+9+m+YfDrib+tgGH3TFYJ4uB4Cc0HM/yiZXdb4qbFobggqi6xqgLzTDPUjVj61Lbjh/4xKKSCwryRwwUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR04MB1148 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210303_115646_270565_A3726DE1 X-CRM114-Status: GOOD ( 13.56 ) X-Spam-Note: SpamAssassin invocation failed X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The sbi_hsm_hart_started() function is only used by sbi_hsm_hart_stop() for checking state of calling HART and current domain assignment. The atomic_cmpxchg() called by sbi_hsm_hart_stop() will check state of calling hart anyway and domain assignment can be checked by other domain function such as sbi_domain_is_assigned_hart(). This means sbi_hsm_hart_started() is redundant and can be removed. Signed-off-by: Anup Patel Reviewed-by: Atish Patra --- lib/sbi/sbi_hsm.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/lib/sbi/sbi_hsm.c b/lib/sbi/sbi_hsm.c index a81b821..10099c2 100644 --- a/lib/sbi/sbi_hsm.c +++ b/lib/sbi/sbi_hsm.c @@ -54,14 +54,6 @@ int sbi_hsm_hart_get_state(const struct sbi_domain *dom, u32 hartid) return __sbi_hsm_hart_get_state(hartid); } -static bool sbi_hsm_hart_started(const struct sbi_domain *dom, u32 hartid) -{ - if (sbi_hsm_hart_get_state(dom, hartid) == SBI_HSM_STATE_STARTED) - return TRUE; - else - return FALSE; -} - /** * Get ulong HART mask for given HART base ID * @param dom the domain to be used for output HART mask @@ -247,12 +239,12 @@ int sbi_hsm_hart_start(struct sbi_scratch *scratch, int sbi_hsm_hart_stop(struct sbi_scratch *scratch, bool exitnow) { int oldstate; - u32 hartid = current_hartid(); + const struct sbi_domain *dom = sbi_domain_thishart_ptr(); struct sbi_hsm_data *hdata = sbi_scratch_offset_ptr(scratch, hart_data_offset); - if (!sbi_hsm_hart_started(sbi_domain_thishart_ptr(), hartid)) - return SBI_EINVAL; + if (!dom) + return SBI_EFAIL; oldstate = atomic_cmpxchg(&hdata->state, SBI_HSM_STATE_STARTED, SBI_HSM_STATE_STOP_PENDING); From patchwork Wed Mar 3 11:55:06 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 1446731 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2001:8b0:10b:1:d65d:64ff:fe57:4e05; helo=desiato.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=oBPwJE0k; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=NvDMQeB/; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.a=rsa-sha256 header.s=dkim.wdc.com header.b=CBSGH1eo; dkim=neutral header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-sharedspace-onmicrosoft-com header.b=CR/3YBtR; dkim-atps=neutral Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DrKcH3GLZz9sSC for ; Thu, 4 Mar 2021 03:45:19 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1BTsQkIdanEBYAyLyIUPqj7FR3Rw/4NZcx8LRh1lEMk=; b=oBPwJE0kKzTlKWLvitVXFWyKw 6w4vY/a1qs/s5iWwYTGuZQFFvabUgiVdZ2M/Hpqr7wRLP/1vL1vV0YE4Cqau+Eac+WE5d70Tq3ZM1 8/KsWDOv8aHr3EeWj4ru7Bl1jo6CCtQT+NgJK0r2vSjWFWPg3WS750qpDdnSTxItD9T0K3qtIaAQZ a9z2ugdNO8gYMS+/IdYF+BnvV1IRlkMbO20vKB1VpeFsRJtfxr1DvgaC90qUNk1EpXeKb193C0Z4J jKzeZVjwGUmgRP3759mi3JmgWgf+sr1RZMRCqqQ685cOaUnKqvjyLJsO8Qij4is2A2gETmgoJSFO+ SML9LEARg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lHUca-005emB-NE; Wed, 03 Mar 2021 16:45:13 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHSqu-005EMC-93 for opensbi@desiato.infradead.org; Wed, 03 Mar 2021 14:51:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=X3F4vmevhhmmEaArjG7SUFe9YFCses2kv8w/fkPn0y8=; b=NvDMQeB/VpM2B5PyY1JAJhAVpP noLV3pqy3QAt/1vSwxvEx9bm1L5KjVM50pnhxu2DkYtiYE/Ug9LpgIZIWjryKFiHeukFb8rvcsKnT xUJKLayEGbjZz0jnTWXod/cotBEI7Jyf1yaRpiCsh6vT1FyIPPAudNzvnx6IhShCw+zjMQO3tvxVi NYXMfyMlsX6ytofxaPT8WVg2tp4RrhqehKxEDLe8TZq9b5lwo8IE+vjcsrQIZD6fx419MWCS1SBuF YdCSGXu/h+a5OsCdFZZpxJhXCmaUtuYjC9gVwNJKsuH3KK54zjxojaSJONWr+vPY2zbpJLukqoI4k p8SWGDwQ==; Received: from esa4.hgst.iphmx.com ([216.71.154.42]) by casper.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHQ8H-002Rgx-KY for opensbi@lists.infradead.org; Wed, 03 Mar 2021 11:57:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1614772657; x=1646308657; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=yKQqpmU2pGRrrV/TGnpEHuc2BYQvQkbCfgO+AhR0KqI=; b=CBSGH1eoeFY92ifms9x2nP2pEfPoYglPlag8WUm93TeL7tRaiKvoIKIl VaMOqRTjvyc6ob7clJH+jQkmWLP6OLWlb1GOYDginibq73sNeQjR8VyCm o55vRvP8XWKZQ17uupMNfakbccCW3jL1tCAr9lXhjR3sFn3Png35XV/u+ FLQ1PLPccuw2O90FuAfzIFTrVDplxeE+o/rzKSYbJvlC8rh1eKdTPguWm DZ7EGBrOqUeEhW93m3163k5WzGSnAHiFBU6fKveB/5f2+AhuKwPk8UCIf +31opU7IDa3kLAtFz1+xiBeEyFmf5ll8jMV0dAtqssni3ZOVxKhJ+eTO9 w==; IronPort-SDR: s6Yq6A0jjPFG0HrLK++7J5Pab7QQvnqHtnLJQfO1ZXan0ByF9OHOAN6Mx+yofWLisopBrLSA9B 0RN7gmjyDtf6tBBz1iSWaNjCAttpUA7PGKumMymbhfULU2mgxAF71ymdzPGYjmVIzkIr8vr8Nr ZauhVH6J6J93+xuRTtlePwTIkcRr9iX4pBKSILfIkuLltSi/7O9Mymng7+dPWVr9IpJhzg71Dp KQF6YXCP0zVITG3iwbxT+C6xIiBPwP2wGrAqLu2SxB/Zi0mjob10QfbPquD+/xNlxj6t4me2n3 pyM= X-IronPort-AV: E=Sophos;i="5.81,219,1610380800"; d="scan'208";a="161237781" Received: from mail-bn8nam11lp2174.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.174]) by ob1.hgst.iphmx.com with ESMTP; 03 Mar 2021 19:56:32 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CNilAKF+TjgZPDCJee6xS894/fxWu35WXxX6WyamauqEvS4fGoH6o7Bt7mH4LTHs8K3XDA2z4ss8hCFGmG+JDV1DVS3uRUR/sp7Khcbm3nXuKl8Aw7QiLVFNv4Jx0IDzbisk0FZ0rbRoaRxq3eucqrO3vkIR8/hBymEs4de9E5uwlqfWfXXrAF2lga1efjW6RZULiKBzkiB8Ok8A3WFgRClOxWUkfx18UYaCS2jzbbBPYS06xHQxtGyGQ5YAmDiBuKsdJ8i7FpxubqCaKZJcE6/XqHAE84qLBgsLWI1Qfch3EYO2SZRPuLtDzQkxuLGc92gX5R3GnC8AFoBUkJnwZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X3F4vmevhhmmEaArjG7SUFe9YFCses2kv8w/fkPn0y8=; b=kC5muVp4l0GTdr9pXLVkeJsPg1j+EjnT/eyyc0pMUN7alyY6iKQR/YpQ59wdbvAPDOP5V35oUjjJhXdTvphI3I1id9S+Mr73DDfGwZVQ3BIQ3EJW5Tlu4vb27WFZm1xkCli/WS08R0HP5ESb0m8bjbti3TqNv9k8RvdT3KH5eIBLHiZ88kXjhhvRQmcZjG0FcTg3DpqIdYws7lC/AZNISLXjA08eRQWwU/u0yU2HdhAVcA+Z3kkJ2O/IihwfOoHd1fwZ6AIEKrjebrEqkmJ+EpkIbllnmPYgf/u496tonAKAo3ZGMW5ZUVk8fNKEmFWIOhh6N103Q5UKcAgBb8Q/xw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X3F4vmevhhmmEaArjG7SUFe9YFCses2kv8w/fkPn0y8=; b=CR/3YBtR0T1HLMsUYGM7S3DpWnJMQHDZ41Ol2aXOupc1wnSzpdETohImsO4jvY7R2bIW4E/wbzrG+lsilBufKCr6q2ntb4JC7xpwNcPnYkgneJdKYatfU49ubax2NmRNf6PwZ0uCz0xrqiNNYZ0KNNBMXyNK9jYftt6Aktw3SD8= Authentication-Results: wdc.com; dkim=none (message not signed) header.d=none;wdc.com; dmarc=none action=none header.from=wdc.com; Received: from DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) by DM5PR04MB1148.namprd04.prod.outlook.com (2603:10b6:3:a7::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17; Wed, 3 Mar 2021 11:56:30 +0000 Received: from DM6PR04MB6201.namprd04.prod.outlook.com ([fe80::38c0:cc46:192b:1868]) by DM6PR04MB6201.namprd04.prod.outlook.com ([fe80::38c0:cc46:192b:1868%7]) with mapi id 15.20.3912.018; Wed, 3 Mar 2021 11:56:30 +0000 From: Anup Patel To: Atish Patra , Alistair Francis Cc: Anup Patel , opensbi@lists.infradead.org, Anup Patel Subject: [PATCH v3 05/11] lib: sbi: Fix error codes returned by HSM start() and stop() functions Date: Wed, 3 Mar 2021 17:25:06 +0530 Message-Id: <20210303115512.470786-6-anup.patel@wdc.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210303115512.470786-1-anup.patel@wdc.com> References: <20210303115512.470786-1-anup.patel@wdc.com> X-Originating-IP: [122.171.215.70] X-ClientProxiedBy: MAXPR0101CA0040.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:d::26) To DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from wdc.com (122.171.215.70) by MAXPR0101CA0040.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:d::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Wed, 3 Mar 2021 11:56:28 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 86132cc3-edd8-4b4b-d4dc-08d8de3b61f2 X-MS-TrafficTypeDiagnostic: DM5PR04MB1148: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: WDCIPOUTBOUND: EOP-TRUE X-MS-Oob-TLC-OOBClassifiers: OLM:2089; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8p//Aley4hux2aZu6RonDLTGVhxZZqGhOtX777HfJNT3PWI3KNZjBaw7E5ET3mMRYpW3KJMFEJ9w20S9W8ijUCVO/vLGz0VtfyT4bjBqvvGjLXqpfwGKUw7uDPJgjl6boQ1a+HKmsISd5/JMAPgtF724AAh+GDYTHa2Ftq1z96mpl1T983tUxHBvf4HikLVZ9gjOVJLiueiGjea1DMG6eVLioER73vyvIYPJF89gYNSJMazlvXWW0LkRoGyDGIJfNELlMX39KBs1lB7WDrOT+M6mT2ifpzEpE2+THR2EIH+lzKTiNMBQCLrMYQ5TbVUJ+SKeAuAFjGWkpO5iMJ2kmpd+GQax46OHgUWWKZDeoxDcsl1OF0lSP4RIju/mqg1SPIUC5Pr2SY3elsKz/WTAJYPKmaJ65JmHZ96SHod4NOBt66UURTMF/vJ3JyS4kts7WHu/cNkUZR2dZV5f+J68u6rdZvj3kuVC0urIaH+RxDVmjYcuRHDxmcRPVOyHXEA7P93E3yohWFdkxbyFX8oEBA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR04MB6201.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(366004)(396003)(376002)(346002)(136003)(7696005)(8676002)(8936002)(1076003)(86362001)(316002)(478600001)(55016002)(52116002)(26005)(54906003)(36756003)(6666004)(8886007)(110136005)(83380400001)(4744005)(66476007)(66556008)(66946007)(5660300002)(2906002)(16526019)(186003)(956004)(4326008)(2616005)(6636002)(44832011); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: ZgGP/qd6LYBqPLM+CMG9i3b422rFzVydNAbot8ev1412eAvO6K48AUkZhRSruvn7np8F6svalccuuRs2Gu9ARPTIMnhakUHvqhrKyrKkKV0nGmtsiJu5w/VAb1rwFsbevxaMx3j2eCGPwG5BNvP5RfvTE5yih0G4gddsvrOJD/LApWX9X3L3IGUxyAVVuNBNyuJYrWRc5jPffWm9NG8GvQmFczFIVu8p6u8Yy8WAb7WF0HyCoIy5/yTBpylT2D01AyDiGH0AjayfunPoMwSKopvKbX+7S9XRSHNxo2K59kJtdn634xq9FCUq//OBici3vupElKxcCZIE7tAI+8LVBJn/7h91XoLSs0KLygheOKUa/RnM50b6rBt2X3QDQ29vFnS6gVOit+7ujuidu9jFwWhaDb2Y6WpwZwNMvJvnna3ILKYiXQ7GGwSIVoX42Y08gC4DHL1Bn/AIJnd70Et7uVMa5LK+P1HIysQd7Zk7SD0v8dLn2xnxNGc43bvOTGub5xfHkCgDOFRpyPsDl6lwKvpfJMAbXMmOvj99vZggTi+5SeRSdP7KOMX2iDrz/cUEHRWmHL3joC/xaVE+hmma0q08+jf2W7ExWjm0rmDThn+pdtwFq7UoHrecS6hnB0rTqHHG899WH2dmkR96tnQcrUkC7DsKSMSW4quZBqlfD+pb4bo0cMFHNKnzusFRpHvpFJKJ7pr1ePcv1YsfncV32Nw8Hk/YYvp3h652t1kcu+S6nmHULoXwcNmHc1PNALcrWQ32OsEDVFaAQ6u+kzp9sBdSsQq1GHRGDibWO7gV+1WitLWtwYuBUKBQtFoEkxXwqNkDowmbghS8RJ3S03+Gi0CnEmFI3EiQOr4DxBsoJ9UIQyoS/MH13xckQ/wGqKTgZeK9Uewe1QZwj1NuoU2eat5HFxFukBiLW6Us2ssU6lPc8MtRCCN3ZicFbVTf99hYq3F5zHnn3ZtQuICOJVf307iH3AJfRwCHBx2ON4tsJ7oZ/HZBZNHgBiI8ff/sngOBYBiOrxZf3UyvQyojXkozU04jDsd3trLg7d3Z68jJpQXtnW0Lrm6cT7mWfewn9PNTm06GDYCQwStMLxe0yHw+xDvyUKsvYr3RvbM8cE3froTO+S5sHxpi8jBEzvHvbL4kzmCML9ZsZ3SaobuHMYlTzSs8GYRIDW9gMHU1i0U2/UjDVPSaXDAaLDfwuthSnsf7A70o2VIbvqwqOwzChNvJ5Yp74tNqdAdSBEFb5medBQGlslV+Q+P9UG0H91HCdncbu1UKpWgKq0A8RVAZuzBzwhlYDp6sc/iUbOY2mWIJIOw5xpfyz5slm6irGnOi2weO X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 86132cc3-edd8-4b4b-d4dc-08d8de3b61f2 X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6201.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2021 11:56:30.5962 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qN4z88b+Pxc7u0DkKJlYASNWjfyaTIKnor6P6BYm2n2HJ6KyOu4LnB3gbc9kBkGa+EUOwZdKmE97ug/gRWTnIA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR04MB1148 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210303_115740_986949_A7870545 X-CRM114-Status: GOOD ( 13.53 ) X-Spam-Note: SpamAssassin invocation failed X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The sbi_hsm_hart_start() and sbi_hsm_hart_stop() functions should only return error codes as defined by the SBI specification. Signed-off-by: Anup Patel Reviewed-by: Atish Patra --- lib/sbi/sbi_hsm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/sbi/sbi_hsm.c b/lib/sbi/sbi_hsm.c index 10099c2..63fa8c2 100644 --- a/lib/sbi/sbi_hsm.c +++ b/lib/sbi/sbi_hsm.c @@ -202,7 +202,7 @@ int sbi_hsm_hart_start(struct sbi_scratch *scratch, return SBI_EINVAL; if (dom && !sbi_domain_check_addr(dom, saddr, smode, SBI_DOMAIN_EXECUTE)) - return SBI_EINVAL; + return SBI_EINVALID_ADDR; rscratch = sbi_hartid_to_scratch(hartid); if (!rscratch) @@ -251,7 +251,7 @@ int sbi_hsm_hart_stop(struct sbi_scratch *scratch, bool exitnow) if (oldstate != SBI_HSM_STATE_STARTED) { sbi_printf("%s: ERR: The hart is in invalid state [%u]\n", __func__, oldstate); - return SBI_EDENIED; + return SBI_EFAIL; } if (exitnow) From patchwork Wed Mar 3 11:55:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 1446836 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2001:8b0:10b:1:d65d:64ff:fe57:4e05; helo=desiato.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=WIjj5N7u; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=GjohVaeh; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.a=rsa-sha256 header.s=dkim.wdc.com header.b=Etox5Cjj; dkim=neutral header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-sharedspace-onmicrosoft-com header.b=cc3j8vHB; dkim-atps=neutral Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DrPyc4zNYz9rx6 for ; Thu, 4 Mar 2021 07:01:28 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Etp6LnpUH0vI1IBub6w6IttJ+otz4ksV4LwrQ18mesE=; b=WIjj5N7uBopy/ZSzJp28iSotc bY6N4v55Qr1EKq5BhOWNsPTXJXN6ftLjxlEYvYkCAaszsnIGt7JvP1037XL8zEkTmUhIiLlcI/9YH jtLuA+OBfiKvJo6X5C6UOpErvVBGjaINbGogph9d7vuCCNqfJ9MsjzdO79B3T83HcrAVy93WivqWb I2a2ylymWbqiOOmaMkyDNk8yFPbRHMRopOEeoshUO5Qnv3pZmte0m71ZFZcBWRmcqLl8RT5oiCbxy QWG9xqJerXo5xdiK0pKuTM5yVi9AiP9ZnZaARWa9LowGP1xXLg3assNzfeAdu2b+vqne5SAPAwFtQ eq2N72D+g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lHXgO-006KvD-TQ; Wed, 03 Mar 2021 20:01:21 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHT4i-005IU6-7q for opensbi@desiato.infradead.org; Wed, 03 Mar 2021 15:06:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=izZQQZNstia5kOgr3elv/pPdYTnI3Sq0vfSEu5LtXU0=; b=GjohVaeh02Qru4NFzGulZZ9lto isNUdrdW0qbO6s4FuKS26lBgTB/vmiLoD2JAt6esuzqhp6VPPDVOa0ftvvWd0L/gcw9d8TukuiT/b mVgsaEJTrPIzWowS1cVpgG8BrgyHshoaMdPwIWsDHLOdGEsWTw70y6x8bnM/Uysgw2Fh3ufUh3UUs zerPviOCYA3yHLCUtulhM7+XS0IF25uqH5dP+wPy63Z8iYQZ2yOPyyNfcxgjp2QgNoYOlDzSY7J4g CMyKHUwavyaIto/Hy6hh2Hvryc1/1PBgwYHZOzbYoohd5c1cpQrL7YnqqP5OjnCbcl2QWUUMX+upJ IDKhzpvw==; Received: from esa3.hgst.iphmx.com ([216.71.153.141]) by casper.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHQ7Q-002Rah-SE for opensbi@lists.infradead.org; Wed, 03 Mar 2021 11:56:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1614772604; x=1646308604; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=FqjgGeSOD3d+2uyu0OB1/+bXwQ2e9LoZFo33zaiY8fw=; b=Etox5CjjudXyq1fl49jCF33uJD/1sS94Rf3mn38knwXJfEkWklfH0D5t R+hh0vnl+PjyjrZ7o4lDGXaQlkbxCR1i323Ab4/DZblPKioZjeKmSt+lh 0rzAQ3JTJj4im1FN72I8uMdAZtt1P4BDzmrspku4iFcJ0kuIZMrOT97Gp g/gxdJaB+WFct9trq3aUkFv0ej3B9sQl6bgYFVwR0HNNRYQy77vugS40s 5L8WjHEuFzs44Wr+5ItDQxUcr7NqgcNnIZVHimuVJqpfqjnjLa2rBZ00S JVhc3ngJTQqdvRiQCv1t9wqPw025/CYVNg0LjHqZfyVi4abOtowu8pIxI g==; IronPort-SDR: W7V4TK483kqNULH6vQ67JnljAqWy7OSDgx1e3y6U2BIgUYYqfA05XwrQ/sBFu8VKqpoM0/3tb0 eBj3qT+UeI7Mm4JcluBazZVjIo/IfZhAL30h04mjDmHfTqO49Myp131HnywsFx3FrUu+uppHI/ WJhZKNh64tof/ED35r8N+QTUj3SMvMUO3iQWSTYWY82zluuyLpBJ4O1BZhkiX6y6vu7KPkF4SD dJpipb4QfXJBkSwlAGyIegVg2UaCFfaF1QuX5vUqY1o1ZIZenuN/dARsPB6PZ/cBpwqkKdipob opk= X-IronPort-AV: E=Sophos;i="5.81,219,1610380800"; d="scan'208";a="165729500" Received: from mail-bn8nam11lp2170.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.170]) by ob1.hgst.iphmx.com with ESMTP; 03 Mar 2021 19:56:34 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mMw+2M8RKQkTG2PX+HThRSnq+LE7RqYmJAZbygqulXLoxN9jD3lXY1Qi+G+Xzf0qmPsifLXz7QxRiQAZG+0sMK13rs9egKuXfH4COfvaETk5c4HJPkDJegJkIsT6aL8/bWTc+wNSE0YzMF7qjah4nqNj7Gql8HlukDNLF+a4mjJ4n9kzwVOBwq8qD6ydbTjnXXkPo41dNQVJi0sBiUDy5ugNfdvInXndHFWBNAfQAi1h5qtfqLy7el1vW0fo5m/wcP77aBR4/oSbx/wp7gmerfM+6Fh8v9XbV6UzLMKjt3crOSwEeg88HlT676DNpqFEADAQPqZYx4jsw7FURcctSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=izZQQZNstia5kOgr3elv/pPdYTnI3Sq0vfSEu5LtXU0=; b=Iuh9rmt4u7N9yIIon+JVQPouDv9ddb2J9jU1JTgaxGicnla+s1q54hd85Hp5wgZMA1G5iWrE/PcP2XjpWW5nkoUxEFT1BuqfBtuKZ05EFc5hmgnOK9wa+kuvptPZJLrWW5DCwBXz4E35mYN553AB+MOvMLTuEnQ6eaCKqN5YEbpulq69gwiI93OIm8vQW15jzTEqvybDcHAt+vcx7x7Hn7+8RPEEmp62wfPOMLhOqjGE+Qh62z5m+wsd9/U2CqGpia/Fq+5E7IG+Zjw1n0YuAMG13g1Ckyy/4km0S88U/PPkuVhka7cylZ24901Vpo6ZlDzgB4PoJ99W7mtk0l6Eww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=izZQQZNstia5kOgr3elv/pPdYTnI3Sq0vfSEu5LtXU0=; b=cc3j8vHBlUZvW/nwfzfCQDF5zaiVmEtaFweGScXVKXaInaMVo2mm0KAoZkd2h9QL0BkFRsfr2Q/g+tTmqG49AaYaXmlOPK10t+EUTjW0SWlWmUALFdK4tMEqAaO0K7ndzSt8IkHjUYkXxuvCHOcsPwowuQ2K9zYij1v0EgcYOlI= Authentication-Results: wdc.com; dkim=none (message not signed) header.d=none;wdc.com; dmarc=none action=none header.from=wdc.com; Received: from DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) by DM5PR04MB1148.namprd04.prod.outlook.com (2603:10b6:3:a7::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17; Wed, 3 Mar 2021 11:56:33 +0000 Received: from DM6PR04MB6201.namprd04.prod.outlook.com ([fe80::38c0:cc46:192b:1868]) by DM6PR04MB6201.namprd04.prod.outlook.com ([fe80::38c0:cc46:192b:1868%7]) with mapi id 15.20.3912.018; Wed, 3 Mar 2021 11:56:33 +0000 From: Anup Patel To: Atish Patra , Alistair Francis Cc: Anup Patel , opensbi@lists.infradead.org, Anup Patel Subject: [PATCH v3 06/11] include: sbi: Add HSM suspend related defines Date: Wed, 3 Mar 2021 17:25:07 +0530 Message-Id: <20210303115512.470786-7-anup.patel@wdc.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210303115512.470786-1-anup.patel@wdc.com> References: <20210303115512.470786-1-anup.patel@wdc.com> X-Originating-IP: [122.171.215.70] X-ClientProxiedBy: MAXPR0101CA0040.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:d::26) To DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from wdc.com (122.171.215.70) by MAXPR0101CA0040.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:d::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Wed, 3 Mar 2021 11:56:31 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: a9c36442-77e5-469c-a1d7-08d8de3b63d3 X-MS-TrafficTypeDiagnostic: DM5PR04MB1148: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: WDCIPOUTBOUND: EOP-TRUE X-MS-Oob-TLC-OOBClassifiers: OLM:372; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NMDBkrRvyRzIq8L5qsZPnQlvTZ2U430wMmZL2SvlW46LQh6r0iYgKSW2gKXaFet2gV7w571O1VflKScw2dMUpmQnLrewJyzZI6AGBgWKIL+L0cgVJUtRigYWKK+h2Csmth/7zNUzuhWUgtwWmYcxvvoHfAf43zYBHBrVncxdubE96ZH08kiYeosu/id5ZkJGidpD+if79vclIYXk/vfLUKXlzs0m2oGvElmscE0gsqwiMdACE71aEaiqXQxBbbw9LEPb44OmSGpDCRuXrtxunh1XDSuWhe+F/YQe3cwLze2jc6K0JRw2OongYyPsfU+4VPYNMSGw14LwtTo39tXyNoymD8UzFf4zeoGEPWfcXsEtf0IslBVuD7l7BG6BRqZ6/4iI60VkYXUsMPo8RVj6kFY+m1HqCkzxvcEPxmRSqcxSJMgEih9vyrulxh0XDCaw1ZXoadTTmIab86hbDNHFE3eoVmaX1nbispRnY6/R/GZzFw6XMMop52aU8xk7Vt8pXE3BITrr/I7qWNHVr3TFRQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR04MB6201.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(366004)(396003)(376002)(346002)(136003)(7696005)(8676002)(8936002)(1076003)(86362001)(316002)(478600001)(55016002)(52116002)(26005)(54906003)(36756003)(6666004)(8886007)(110136005)(83380400001)(15650500001)(66476007)(66556008)(66946007)(5660300002)(2906002)(16526019)(186003)(956004)(4326008)(2616005)(6636002)(44832011); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: pIACSjaj/zYxZ9otdirzxh+GCvXvQde/ERJhiHeO6zBpn1oKTPDwtCwdHJo/mV48Ud1t+UOk3v1jFdrS+8QGzVbRwxDhD7ydRUlvgn1j+CcMGgstFH9P0BHpdvBh1L/cOoCzj+nVKAzl4W/9r/fNxDG0v598cqiRPNvGuHSG+vg2RcCgo9HK38fn/G57o8x6umPkvgoRhueyH+fU8db/JlC8atKRir82m8szCNiA/+cNXt966ziU8WYIqlZQxXnZ/KPIW6n6c474pnJkarzYNdbqinJxubv+cOhYL4tBVTC9cXWKidno47k3+f7f4ULKV033uqLN9qeNpxjZlDnkr5riNDEyTIjVQAP1DcCCZnHRFCX80x/M7g2V50LdCWGF7iYJ/LTkR3k+piu7UlqI/t0qGQ6rGhKQKbJc/BT18SwTq3THJVvGQeu8YDZr/rQ63pIf41nl+Lab9IHZUDveeXZn2jnpG+kceL1ghijU9Ll7os4oG4wPzoPfmOvnPICic+Ym6HTjHk9Ycy9STd9mpCOtfRJcPcrJ9uDHay7Fm3aaZPFjVNy31AC65LJLXUxBJCxSeT2vs3hTlD2t1ZWLh1LYJgE+XL07PURz3QtKGymAivyXLi545UeUSww3Xhr4spukfygQ639G1i43W+mCiSBwBSjuzj/6ORYsX8qw6scgNGRPvE388ymEmhotVIw3uSFCEXCa4c4WqnDG1stoeYGQT8NtiF/3ixJ259NplGyBzJSvGyn/V+3R5mcRcrIW6wPYjQ2KYXoJNCPUZl8m5uA+7KqFK3W/kA7ajImItehdb8ByfoCEqX8N3jTpBMrZZ+2gDOvClZPgaG7cibe+eYvAmH26vacSxo/Va0B4ccJOb3aZUAtgV+lRt0f0cy9mym0bm2GE1ljtcxUtBS0xQUMniIIgW1EMiv232uq2pXdiq4k6HnLVjiJE8zMP44QvEsNFelrrUGspLx8HaPg87jko0evzhXcPM3aEXMnJG/o37pQ31KUgaS+4/NIC8SpEw2kYCS4TInArnr5Po2xzxmh/9TFh65TcTmNKbEzQekY2RCP3fxBjZu31RmGAGMx3QpvytkbS4DGjf2eySSb414ZjGIbdEN0yUl02peda6cqsNDLRv9oD81s2UYzSFrdoK9TLa4xWNB5PTAvi1kZoSij3zWDoN34pRpz7XlWOH/pU2NJFDc9HLTTeh/8ARGlHD07YN9TfiBjrZ963OENunyFs45O881SPl5Z7y1FV3p13Pw+45J/k9GI4B5VsZzIAwsmifthf/Fobtmzl/50hJUYKU5YnSy5nT3221uKsE94aukkdP/eHdJ+XDKdnDc3H X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: a9c36442-77e5-469c-a1d7-08d8de3b63d3 X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6201.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2021 11:56:33.3524 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fyRrfWMaIQwiUKbhiekIYndOnCYgC+2YFashVIt7XaaCrI/+J6tlvGs3GkCVEgc2O8rRxzGpbJLtHHP9qeINVg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR04MB1148 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210303_115649_750424_5E5F1F3F X-CRM114-Status: GOOD ( 11.16 ) X-Spam-Note: SpamAssassin invocation failed X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org This patch adds SBI HSM suspend related defines to ecall interface header. Signed-off-by: Anup Patel Reviewed-by: Atish Patra --- include/sbi/sbi_ecall_interface.h | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/include/sbi/sbi_ecall_interface.h b/include/sbi/sbi_ecall_interface.h index b272213..7fcb373 100644 --- a/include/sbi/sbi_ecall_interface.h +++ b/include/sbi/sbi_ecall_interface.h @@ -57,11 +57,28 @@ #define SBI_EXT_HSM_HART_START 0x0 #define SBI_EXT_HSM_HART_STOP 0x1 #define SBI_EXT_HSM_HART_GET_STATUS 0x2 +#define SBI_EXT_HSM_HART_SUSPEND 0x3 #define SBI_HSM_STATE_STARTED 0x0 #define SBI_HSM_STATE_STOPPED 0x1 #define SBI_HSM_STATE_START_PENDING 0x2 #define SBI_HSM_STATE_STOP_PENDING 0x3 +#define SBI_HSM_STATE_SUSPENDED 0x4 +#define SBI_HSM_STATE_SUSPEND_PENDING 0x5 +#define SBI_HSM_STATE_RESUME_PENDING 0x6 + +#define SBI_HSM_SUSP_BASE_MASK 0x7fffffff +#define SBI_HSM_SUSP_NON_RET_BIT 0x80000000 +#define SBI_HSM_SUSP_PLAT_BASE 0x10000000 + +#define SBI_HSM_SUSPEND_RET_DEFAULT 0x00000000 +#define SBI_HSM_SUSPEND_RET_PLATFORM SBI_HSM_SUSP_PLAT_BASE +#define SBI_HSM_SUSPEND_RET_LAST SBI_HSM_SUSP_BASE_MASK +#define SBI_HSM_SUSPEND_NON_RET_DEFAULT SBI_HSM_SUSP_NON_RET_BIT +#define SBI_HSM_SUSPEND_NON_RET_PLATFORM (SBI_HSM_SUSP_NON_RET_BIT | \ + SBI_HSM_SUSP_PLAT_BASE) +#define SBI_HSM_SUSPEND_NON_RET_LAST (SBI_HSM_SUSP_NON_RET_BIT | \ + SBI_HSM_SUSP_BASE_MASK) /* SBI function IDs for SRST extension */ #define SBI_EXT_SRST_RESET 0x0 From patchwork Wed Mar 3 11:55:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 1446811 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2001:8b0:10b:1:d65d:64ff:fe57:4e05; helo=desiato.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=NVWVPar6; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=Ficmit/Q; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.a=rsa-sha256 header.s=dkim.wdc.com header.b=ozorK/CG; dkim=neutral header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-sharedspace-onmicrosoft-com header.b=hSXrPzSy; dkim-atps=neutral Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DrNQn3ZLjz9sCD for ; Thu, 4 Mar 2021 05:52:17 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zQcf3L2zmEEsw9Q/wizXITOC3pzzIDl5lJRipfa8Ku4=; b=NVWVPar6M55AWhhhzQdjtzbQV B9FHFMlRIDq5cl7eKdt/vCwBTR3H8G+p2bVANTF8NVNRckwHEEe4H1qQX9oW+60dVeVACuq+f5Eo+ QX3MfElulJuAs4pjIyfXrsm5WzqWQ6eWgwScUhNITHJQgZEHHwVKgSrJArVQLkmzJGEOFjr3ab7GA JGPDzOItFDjX4ez7qjZs59fCnzqZHkxw+dUhsh928TGDfrwjUZssJ3FPhOdyevX9+nTsrarmGgNpL YY9XrSpDfHloO6RwYfeqrE9iz0RypukJrwDniseADm02izJyukRqisaKzpMsacNHnrjxP1Mh8kzlE Q79POFN3w==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lHWbT-006652-6u; Wed, 03 Mar 2021 18:52:11 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHT1p-005HUF-NY for opensbi@desiato.infradead.org; Wed, 03 Mar 2021 15:03:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=2Bo9iEvdcJyRIqYGwp8RBTHrb5Fr2GYVPb3TIiWEBgU=; b=Ficmit/Q3h79Dm7rpLGCLyUWGc gvGODMOpIB4ApMYiL6oVj399yaiLW5eAGR7SxTW5onkCzVhvxkEtrLrPtdzp6KA3iHTAtFYskaHR3 daWWHlzb+ICl07ThJrrZL71T+yf6eEyBVQauKPETUVXQwHCe7zyJMcEyenrePmfC2cal6mfUQKu6G Zip6P/Q2VZxGAgettbIQxekwvJYM1Yu7y+aqARclVTvqziFdsJPUyR4SnB1KGtvfo+wqlODwGosN6 6+Ez7MdLipy2IvbWE0eEEevWA1Vspvp3FryF/E2rO5xCD7toLf/ngvwbxVu28Twq/wsicLeBzGC4k XexOXPiQ==; Received: from esa3.hgst.iphmx.com ([216.71.153.141]) by casper.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHQ7R-002Rai-1h for opensbi@lists.infradead.org; Wed, 03 Mar 2021 11:56:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1614772605; x=1646308605; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=1wf6dPXty6Hxk2YLJQCVPKvJIjVh8bygVgYSalnH39Q=; b=ozorK/CGnhy/XEEl/WRkEQeUR8qFSoG/OilxNip7S6RuZzov/iyxPfxZ RiqGdFdaP8UyG5n2JR525Xklbtvv1sfDt9e+UE20fN7Dgsjsjt+FJXD0X QrnIVqqLnbZRT0s2Dj0ll2MTw64XDAVAnlhlWFL3w5vUtqX0Z65H2misa fuGwQ0fAKCXEAXo/xuC0vDyq6lp99gZLgerJF24uOXikUW3dJnB7LXySo uaq7dnmQxTgqN43q2gonXtOz+ohJgwcNsYGsgnGjtzXI3PD2W95nOX6hM g4icrSAo1p24hJlxGYuV9ZoLNUm22WFIb6XX2M2PBaFC90Vln35wPWGHP A==; IronPort-SDR: kBEqSxlakcpkpzchBSU9xZDg7Fh3l/8ZI7YHhxoZzgX4T1jmN1eFtt4UR71YcnVK+62yTirIsY NkwwwkBosjxamGo8tqsQgcTshcAMPWHurNJzNvl8a7AzXojl6RDFpVC9DXbi5gUvUxHPvFnXXG aWQ/Wq+RDXF0LIXeZkZ/lnkOkXVMPMtrAnEHkZIeMBO6zyL2Bq+XqlHQgXMhaK0ks5nW74ZsAk P51pGfLbuO4X+bR27eZ8ZDV2dAn9IlAM6A/e3T5eF3Njh3ejwUbStL48LKg8zKfZU+Z3fHiWyx m6c= X-IronPort-AV: E=Sophos;i="5.81,219,1610380800"; d="scan'208";a="165729506" Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169]) by ob1.hgst.iphmx.com with ESMTP; 03 Mar 2021 19:56:38 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LAQP4oDsf0dofZwDN1UzDhQtn9HKMWsyT9EUk9ReCGz32YVDSLGn6WFhXNZVFfxzTWH7lRtu7Y/WnIX7regyqq63y8AEQFVV54YyxEkqBUFDNxbhVXKS7WX4hT6G9UdJvGwEXiDGQem9E+NRqHrrDSsGaBV1Ugkf4wE0NPRNhaAeUYQlbHTsarxYXVMi0BvvtOhZ8OjKQ6NQiaAy/adNIa2ckeXAWLQAzr2dJR5NOHCKhkwZmMm4MtqvaQFpnK64WXV46Few81l087IGiIk77Er50Hgcl94wPcskzByi7jvuYBniR0k+j+GE3B/7SBj4Jof2fuCADwLMN2T/2UCihQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2Bo9iEvdcJyRIqYGwp8RBTHrb5Fr2GYVPb3TIiWEBgU=; b=VUfuwb/vC3Zhf1E+xUQFwB6Ay41oZk1N78zHTQXphGS+aAyhSn5weGWru+2N8mfXvtQjX43Lxxui+PIs2LdzCCC2Q+OcnW1jznxwC8cD9tZUWc2VJL5HVLss+k+jrzhFyIDKwsvCrKcIS26k8AaUPUJ1rjcP08w9udHptIMHMuYCactsMLNsKUiF2VDoV1qJKa0k4mGIZJ/xWQwtH+AVknKpEoDSVFcYWbL44dIZ75q8LX1FDpAxyHbhrDASYX9rvGbmnI+lhqwUDsH7k0n9MU4a/9lzjm+Pyn8RM+Krsq2g3Y0AbfGeGX9KfiImSZchlHdNm1JmDQgdyxJrGd27Mg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2Bo9iEvdcJyRIqYGwp8RBTHrb5Fr2GYVPb3TIiWEBgU=; b=hSXrPzSyJkhLnmhOJh5i/xov7UBFc9/qHOiY+JEySyT+NTUVlE9iN637XiNhkQ+TcasEQSfc4XheBPKnD+WxXj2ynIMOTqdzcL1Rsn/JeCglmybCvz3+0zXCSbnkeJBOIdxxsKOFWrIKY9q+TKVq4NxXjDMjTjswmfh+Wd6WShc= Authentication-Results: wdc.com; dkim=none (message not signed) header.d=none;wdc.com; dmarc=none action=none header.from=wdc.com; Received: from DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) by DM5PR04MB1148.namprd04.prod.outlook.com (2603:10b6:3:a7::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17; Wed, 3 Mar 2021 11:56:36 +0000 Received: from DM6PR04MB6201.namprd04.prod.outlook.com ([fe80::38c0:cc46:192b:1868]) by DM6PR04MB6201.namprd04.prod.outlook.com ([fe80::38c0:cc46:192b:1868%7]) with mapi id 15.20.3912.018; Wed, 3 Mar 2021 11:56:36 +0000 From: Anup Patel To: Atish Patra , Alistair Francis Cc: Anup Patel , opensbi@lists.infradead.org, Anup Patel Subject: [PATCH v3 07/11] lib: sbi: Add sbi_hart_reinit() function Date: Wed, 3 Mar 2021 17:25:08 +0530 Message-Id: <20210303115512.470786-8-anup.patel@wdc.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210303115512.470786-1-anup.patel@wdc.com> References: <20210303115512.470786-1-anup.patel@wdc.com> X-Originating-IP: [122.171.215.70] X-ClientProxiedBy: MAXPR0101CA0040.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:d::26) To DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from wdc.com (122.171.215.70) by MAXPR0101CA0040.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:d::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Wed, 3 Mar 2021 11:56:33 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: ac5f0144-4d21-4886-eb48-08d8de3b652f X-MS-TrafficTypeDiagnostic: DM5PR04MB1148: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: WDCIPOUTBOUND: EOP-TRUE X-MS-Oob-TLC-OOBClassifiers: OLM:1728; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: h0gz++GxknmkriDHBRThkGKR9TKtH8GQsO0V0JqSTKsOCgGjYtRYWozjO9tF69vNT7LVKzGZJuqz7tQzoZqQQutExt+SHTVdjMA3f6D7bgAbQKTy3tWDoLs6u9ac50tbiPlNk0wGcIxvpJG9pN31rF4g6txtoc3ONT5yo7QqWEMhLpNEVP+2Om/tBNl9GQTCSJiQCb0pxvhdYyBXAIOIwyInji4T29yUCOQNor5YZYT+u5GIUiQGn4+jQ7OQqpnUZJraK8csDV21q0ohEmraiQFNZkT8w5MFPIsPr4NjAcdnHBAXI5YDKFuY6EtSmSNVhgiq0dbpOeg7ZjG5YS2pb+n4TzQSjRCAPscyELKHPY6PJKdmkWVAv2IQC2N3m8eZZJi63zg5xObf+90dHgHkU8WOjyPnrO+TC33CaSQvjaO0DwCGVi4Z4DnQfFomipfxHHUrzkwceW6nxQCldt/9Mf9lEcEwln+5096K0f5wfFcR/wRGy5h6qj4VZTk4qz6NbiUNbhwavA2ARSPdWKjAfQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR04MB6201.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(366004)(396003)(376002)(346002)(136003)(7696005)(8676002)(8936002)(1076003)(86362001)(316002)(478600001)(55016002)(52116002)(26005)(54906003)(36756003)(6666004)(8886007)(110136005)(83380400001)(66476007)(66556008)(66946007)(5660300002)(2906002)(16526019)(186003)(956004)(4326008)(2616005)(6636002)(44832011); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: tuFIEhaSyw9mVlT1mJlioTu7bugde/POgMm6vdCkEGwVJajCDtz9wu5UdM1tu1J20OZoH3bnSEis1W9ma0xpLguLFp7ru1PAJos9JJzeWHx3v6ZsIKSqeVQ2mAl1FEDuqIgFhUOYIRMdKTo3+syzomzlAPF8L2MzyXkXael8m8I0mj9ir/2I7UTXWpz1N8/Fc4v4HdTpjyPWNgvsLNWUtVJbKErxNIJrnJ/tr44KK+/jcemIt5l3I/en6xviAd7fU79EKJCTMqGrgzxBLEmUamYm7GO5ZgZg0Cz0OTUlJzGONBLRdMvqPKEf+D48AkMAHAsrYRfxXuKyNAiwhIjQjhmmaq9d/TyvVTc32YyKog2mOpiQs9egL/9Gtl6qhOjj8cN43nAprd42vucVPaiBupqsCKo/0O6EgApl3pyLwXXskA0Bjb+ZJ2U+WDbUQn9Qef5zCTm1ZpOFK50NRaWCBV0sRiFKNdEciZ5AkDGaTnsymtSexfzserzsFORv5bx4TTZGtYMBhh1if7x+wdYE0p1NfWwfJkgKRh0fFuL3nD2KDjh+0syyVlwHa3hvAUkS+7TgR8QB1LduAuUFEFmiGcIE260sp+wHI0rwt4dQGP+vj/BmacAsCB7uVHNIUeSi6WRn7BZYFisyujQ7rs/qDSQ/7hFQm7PDYGDLxhbfRGuSh+cIoByah0TAUIovJcTTTSIbRqxJZrGUtM76+7V1qqkSHhoRfxxqYyYwli9NycQYo3h5Ef00RCoW3xaxdv63a75RkZazI65rq2PjxuerfB8M3IIlf/2EyRAgpyc7zhLqHs5GnaU4C8y4efq3QqKR0TA18Gg8vS4TMWHRoeymcjLZdyvbU1+Q5SPpgIsJi/Dgxu34VCu61udhs7bQXYS80icFsSTGqD1jf8M5gp/wPB2b5Dg230KXJTQxyX3M+/SlweTZfbiSUP2bpeo/SGsRcneQ3bNHR5tL2W5A0tXT8zU6N9X6/ffc84tshGthu9OgzuxtNb6rwVrpg0693+p9QsXepMHx03e137NFk8WY/U9wxuiCz+hqy42X2NB0PpiSrphdxB0TXaO5pbydQOfqtMrhMbSwTKB0QPF742pzKHUEzo/TYQXqY90dl2dxXTR3T5kLohcvNrjNv057Z1cQSNz0rt3lnErrQJOduVAF6PwwxFTm69iK5dzu1aORim3UZvjq+zQB9yq55BCVD4RYxVpzPfKE46hkK1uCUHEaOUlCk3RUQQxy/mA35Fjm5qjvSDoVB/TgiR3wjKbt2Vx/NT0HcO4wYlqNSW0f/cxMU0NdKG99PykWkInQFYNa54kgqY5HSxVg9BTR05zPlNss X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: ac5f0144-4d21-4886-eb48-08d8de3b652f X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6201.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2021 11:56:35.8958 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xHRKNkPOZqnOuzu6q5HsGCcqNi5aEVwjW0BNzL59SLQeE8uFFBgmo36szHCSxaaIi7nZt9/35So6djv+cKN8wg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR04MB1148 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210303_115652_263361_3A32A7BF X-CRM114-Status: GOOD ( 14.87 ) X-Spam-Note: SpamAssassin invocation failed X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org We add sbi_hart_reinit() function which will re-initialize HART CSRs assuming HART features are already detected. This new function will be useful in re-initializing HART after it resumes from HSM SUSPENDED state. Signed-off-by: Anup Patel Reviewed-by: Atish Patra --- include/sbi/sbi_hart.h | 1 + lib/sbi/sbi_hart.c | 29 +++++++++++++++++------------ 2 files changed, 18 insertions(+), 12 deletions(-) diff --git a/include/sbi/sbi_hart.h b/include/sbi/sbi_hart.h index ec9e30f..031c7b0 100644 --- a/include/sbi/sbi_hart.h +++ b/include/sbi/sbi_hart.h @@ -27,6 +27,7 @@ enum sbi_hart_features { struct sbi_scratch; +int sbi_hart_reinit(struct sbi_scratch *scratch); int sbi_hart_init(struct sbi_scratch *scratch, bool cold_boot); extern void (*sbi_hart_expected_trap)(void); diff --git a/lib/sbi/sbi_hart.c b/lib/sbi/sbi_hart.c index fc86e9f..d91b08c 100644 --- a/lib/sbi/sbi_hart.c +++ b/lib/sbi/sbi_hart.c @@ -430,10 +430,25 @@ __mhpm_skip: hfeatures->features |= SBI_HART_HAS_TIME; } -int sbi_hart_init(struct sbi_scratch *scratch, bool cold_boot) +int sbi_hart_reinit(struct sbi_scratch *scratch) { int rc; + mstatus_init(scratch); + + rc = fp_init(scratch); + if (rc) + return rc; + + rc = delegate_traps(scratch); + if (rc) + return rc; + + return 0; +} + +int sbi_hart_init(struct sbi_scratch *scratch, bool cold_boot) +{ if (cold_boot) { if (misa_extension('H')) sbi_hart_expected_trap = &__sbi_expected_trap_hext; @@ -447,17 +462,7 @@ int sbi_hart_init(struct sbi_scratch *scratch, bool cold_boot) hart_detect_features(scratch); - mstatus_init(scratch); - - rc = fp_init(scratch); - if (rc) - return rc; - - rc = delegate_traps(scratch); - if (rc) - return rc; - - return 0; + return sbi_hart_reinit(scratch); } void __attribute__((noreturn)) sbi_hart_hang(void) From patchwork Wed Mar 3 11:55:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 1446843 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2001:8b0:10b:1:d65d:64ff:fe57:4e05; helo=desiato.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=oMBtDBlH; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=RxKiaCTQ; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.a=rsa-sha256 header.s=dkim.wdc.com header.b=YCQDNBMv; dkim=neutral header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-sharedspace-onmicrosoft-com header.b=oT5qICIJ; dkim-atps=neutral Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DrQkz6syTz9sR4 for ; Thu, 4 Mar 2021 07:36:27 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=I8VdyUG1gxOx6yjQkdl9t97Vjg7eQAuUBVgv0wpawMw=; b=oMBtDBlHS/6ZfT33GaMSPJbSE O1EfwEeM8HsJZJrVbYwb2kdlNlKifZHOfNqKFChfdwCd/IfcqTpKHekwytY+KWN4KhD2AO7gNQsfs wSrQUKA2U0EVUIZZrHeoH5krxQR9tVg8CTi5ytp7CXo5zKyyOCOQuh5sBIkJ7BXJA2w/VBvobE9pz QodLQnl1xGmvbxbcE1dtN7aTuRwMaq/6L4OIhDbtDgpzW6JuO13ca1p+2nD8kmIdpWQx3iTDBs1+j VLGjqZykuD50rGoW/H1PvGDX/IovDAgf58CILVNTFipD9rIHi2u2wDvKVXRDmgnAXrP2EOUDvCXg+ NiMx6S5Dg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lHYDv-006RgT-5Q; Wed, 03 Mar 2021 20:35:59 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHT6S-005J3e-Cw for opensbi@desiato.infradead.org; Wed, 03 Mar 2021 15:07:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=MV0KBd95TdvUFFXIa8qN9/v/+Zwhq7HZDQI99HKMecc=; b=RxKiaCTQifGwt7KwHg615xvXZN k1JA4FSmYbbKM1+D6iQ3+uP0ja/OT1BbXVk11hBHLjanhxIPpXyDgak+/poz/VXZfAodytlKxRAUF BDiL6ParPiWxkyTrH/Q8iJLp6L+Cw5DqgXzGZ7RvqmA4ejNyWXEQwTpXV6D00AXsX5j2E6989K0s4 zvSXA0X9cA6U1zmYobEz5yFRG/725gKmtCt7ORwyd4pQtdXZje6YSS0j16qm6V1DwkjT+8cuu7jmt b2GnRckJBZ26y914t/d/dDw6ASXP8WAbb9fvGCpPTnzyRy5v7+BcCmkzocCVvtN4P2p31juHJKPQs Z1Qn53hw==; Received: from esa5.hgst.iphmx.com ([216.71.153.144]) by casper.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHQ7c-002RaZ-5z for opensbi@lists.infradead.org; Wed, 03 Mar 2021 11:56:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1614772616; x=1646308616; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=JY9hL7yxSv+lWQKmPRw2kEIZ635FUP1JauCp+dh8Iuc=; b=YCQDNBMva7Kym91o+U4ycmuLNEH0VrX3Z1q/3ysDDBKWBvuAiUCSQbgb a7rKU4avSr8488ZELOu5fgMmQOQ1UcnA+dPZLiNocDtOYTmugH5bDK3f1 /0C9G2nFq4EmHdTrz3vG+/+AT913UgrWRUY+YPR3OYrVERzrqr/yHF0Cm +uepJ0lR27PVlG2T7+Y4ohsF3p5QYuJlBBArmeNMBWKoyTINDfooDSsZY bzg+uW0OG5tcWKKWAq3v1XdQxDrYQcVlRH34gK5qYdEo5q+jKM5smYnrn q0FdaXWOpsD2iGUGFvbNKZsOx8HhbqWnwyNHw0Smm24NymvvW26xpTTO2 g==; IronPort-SDR: plZwsoDFpcjfN3VtS8SZgjpmD29NquXpjaKF3AQm7LyZjcFTceozvLFGV1J0S0ZR3tvt5+eo/9 7xXyTpdwAhx9eVOCIDKBpB+CFTkc2bkg/k1bxCiJsyKUZjA8le3xpwR31eZtY4VIqiPyr4FYJE L22cCqHz61MU37C4urXuU43aq91NW9ttKvoBCQwKjdjLTKv/yJHHx6h2ZZVbinWFa9hIiSMwPI 8R4wro3kvygl7vYEWrYV/8MLOrVF977poi8aPdT4ijGzaNyQmqHi95GZeIfuVOowL3zTe13BUO hq8= X-IronPort-AV: E=Sophos;i="5.81,219,1610380800"; d="scan'208";a="161265022" Received: from mail-mw2nam10lp2104.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.104]) by ob1.hgst.iphmx.com with ESMTP; 03 Mar 2021 19:56:39 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CdmHWXDMxKT28GggxXBqQoniMOh5Zsd/JlZWwGjFS2LKvH8qrg9L/o4ry1CYg8Wij+1KsVg4Pk+g/vEzlEKj9HvoR2B03BdoROGt6cmbmA1bz9dAP5vYMLJtp1LMVDj/ANO+u6B9plfKzqE4+6JnYArl6a+my8HBWXubDcEp9LvTUP9Y1JE8/LSNPVf/9ZQ3R+flVrt3DXlgVi7PBqjoEGyRWg/ccDbnbPcnpffNWPFQ6Ha2PRUXgs2zPcKbFjZQZs2jsrPln8XnA+8prsOSJmk9wgfjhlBSxOYcdXIzBJOVKibPXMM/M577wJappOdIFT3iAt2ARsisHUZ6KVWyiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MV0KBd95TdvUFFXIa8qN9/v/+Zwhq7HZDQI99HKMecc=; b=YL6S/axxz72k2+klz1DSlA7UEqcuNHR3a+6zgIaDrWjuF3SntbSYU4jIkO2HeCX6mg5cBQ3PlKyfl1jGmRY/FZVjj/Go/QBJL9LDS3/LXdCXDJQfquPqNKslibN62J3PclpIGglXtXwWkkuB65Ntb799+rIUmROo98rLepNBJGroFBl/eGxY270zBF1O2fbXZwb4SvkUFqq/vJUnE7Ai5rwdmJeJ8EbztERrquom4DfxoJ1cLeGK7SiYl7sAhDdBLBuvSWrR2fs4+d10EVLxcU8t1z1EzT+hF6aiUOl3vtxdv1N2fLemHFAnxoE1jPY9bdNAylXGjHhQf7EuOwva3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MV0KBd95TdvUFFXIa8qN9/v/+Zwhq7HZDQI99HKMecc=; b=oT5qICIJmR4wsoK7oKLzsT8cDKe5GNjL7y1O7pxEs0BE8kGhMGZYDVLcT5mOiVFYRq0ZXiCR3hSzgTX7guVhDFaN/iRSRF+NfJ+4LalJzwpr6WwJ3eMALMeInYotYYEiDd5DgsyyvouA8fkJzmXaO1G9RxZCRn6/31em4bgWKh4= Authentication-Results: wdc.com; dkim=none (message not signed) header.d=none;wdc.com; dmarc=none action=none header.from=wdc.com; Received: from DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) by DM6PR04MB6204.namprd04.prod.outlook.com (2603:10b6:5:122::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17; Wed, 3 Mar 2021 11:56:38 +0000 Received: from DM6PR04MB6201.namprd04.prod.outlook.com ([fe80::38c0:cc46:192b:1868]) by DM6PR04MB6201.namprd04.prod.outlook.com ([fe80::38c0:cc46:192b:1868%7]) with mapi id 15.20.3912.018; Wed, 3 Mar 2021 11:56:38 +0000 From: Anup Patel To: Atish Patra , Alistair Francis Cc: Anup Patel , opensbi@lists.infradead.org, Anup Patel Subject: [PATCH v3 08/11] include: sbi: Add hart_suspend() platform callback Date: Wed, 3 Mar 2021 17:25:09 +0530 Message-Id: <20210303115512.470786-9-anup.patel@wdc.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210303115512.470786-1-anup.patel@wdc.com> References: <20210303115512.470786-1-anup.patel@wdc.com> X-Originating-IP: [122.171.215.70] X-ClientProxiedBy: MAXPR0101CA0040.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:d::26) To DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from wdc.com (122.171.215.70) by MAXPR0101CA0040.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:d::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Wed, 3 Mar 2021 11:56:36 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 909dc66f-0a5d-4e22-7b22-08d8de3b66b2 X-MS-TrafficTypeDiagnostic: DM6PR04MB6204: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: WDCIPOUTBOUND: EOP-TRUE X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CGmQYYBL4G5mWI25NNrKyC5jkdMCrgHxG220UFlpGf0y19N5NDnCfXgaZjeYO5X34QqsHyuU7e+3pc9W/yxlhIAW42ajmpxR9CbO+ekvYQo5xM2giWkkty42M1yNrvCJ8P3fhxAW8jfj1G8DgA/CY+7lBIbVehSheqvNveebrdmbOHiDBsHmd87yjYviDMdRh7WBpD0oIAMxLX4K9kEJBBPg2QOc/cD074IxhPEnzGPEDmDWuAl5epbnNgjMHcMy5jqP1KmCsiVrtDwgI91nzHnHl7I5F2MjRGz/EQ7CnpGbHKeuaMAImYlhaKzX7AyJx2nUP2ewacG58Cl0c/7WEiPR2mA/kI2pecbZ9QVcYtIkTp4iTfS9hQYGP1Eke2xeCxaNiKiv1Ui1Mzg0ygkI2vYTtcwc3sUX+1+QWhjm0SjgzJSqSwe+pbzSglPo2XMZaXuC4SvDbCeS2onRzMLMnFh2/JVN7X/tbbm82gZ9b8PSOGbjbUVWu6ewITQIPyIqPMZNnVJ6t3QZSYh6mcMJ1W0vOkhyGAr4/wtbOUCw5uRdI9nVKll21xZU3bss36QQBW/3BS4ovJgc1dnljHecAg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR04MB6201.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(136003)(396003)(366004)(346002)(376002)(316002)(4326008)(52116002)(16526019)(186003)(66946007)(5660300002)(8936002)(7696005)(36756003)(478600001)(66556008)(2906002)(2616005)(956004)(83380400001)(66476007)(8676002)(1076003)(8886007)(6666004)(55016002)(6636002)(44832011)(86362001)(110136005)(54906003)(26005)(357404004); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: oFxE+YhgqaGs2f5DuTX9i7Mz2I2y8o87a14ZonCdhUtx7ihxZk8pdAiEqjB/ttz7OMjjo+6B3Q+oT/PwWNDs8QWcEaL/O6jcJ/cGUVz9unv+Ngc4hiPF83nNrZXOQUobPoE0u9mOmS2xRqIp35sGIt4W5QUeEFsL/PljC/taONpi7lcd4aWwIPO/wj0n8Q9nr3kUXaECo5U6XHtZzYo/1hpw3TnEzTQAuCmLxS+vU+8mXTTUUdBpcVn4ZXtvqfQ6jiGBTcZGI15OKnHJVnfFATSDKxzPhiFgijtIoBJp5fYNLpVlav8mxkhGu3PU0I9+rPLh+osDNpiRa51D35MWdQ8Eo0v5BN5yehUwu2jUI1w+4sAeTc7CUJTkqwXdxyOiylSzzbeIjP1mxSjStmuErjfm66vLtDBZAVqeddNaLWH4GqV+VFHxKX5edy9W0nOn11rTgCTBxiHkNt3AI2DaoCX+XWCWlngrZBCUDj965TC5duPreMX/hod8htPznbB1g8Ewqb0HcccHUQHBOLq0cC6mkxgxfCKw8AUzkPEJs5G5bvBPOQqe0nGXnwK4zWRjaMW84v3hU4M6YRkBlumWY28+l5JnRuXrM/ZesdEYkMk1l3ClEWgOhjVupSTw2jGcE64U/n/x0a/Mi7xx9fVwSefmsQ++gcTm1f31a8o22DofVykvQnzOJznwMQWvf994oYXFDZ8oUIfg9DXjK/PwiYlf4OCJKKetMcBvdf5v2TTXo7wL2UEY3m1T2SBq/vDPXzljIUtbnQ1b1+LQjWoMacc1H51tO+d98VTolmqM+VLaerXk97Zs/cji64f6pDl1651MNvXuL3ugZECcbo67cIKlvp6QGWgIhDQhQdnMHXf+R1b2IEdZji7MkkrQhn4e0PPiF1YhAmeFXIBJb7XJH8Wbep27+tHLe4ct5eLZfYcT90jMUDozMfB+Hny23Gr5BnzNFzQZd/zqDNB8O4dQE9LLWIbm0KpIIVon0N/3imKpJVIM4gFKLfWF17Hd1P5TdDwEyouUa/YEFMPJ4CQb2xA3uk/ZO34fZ3DYo/cmCrX0Q+294n1pPVCocgcXarfjpg6Axru4dDIrZJE/i9+cv17fdB28VJekBOgvzs/355dTl1bz6lEwQU/r2iwCpsv8g191uvgrEObLGN26Q1GHVsZ8TxtVt80buUDbACJub1bloEPZoigHftWUfw79ZyHg0KO3drizKwJLXlOS4LGRRJIJnnmaAU4eoYRPkSJbuFnicrhR235c//7kaqVVOkWWaJKSFyS/2KPnRKWGVF6QZYNtaSyguiZ9B/oYCjkjsyqvQAkOl5nTxYUzBYldJgwK X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 909dc66f-0a5d-4e22-7b22-08d8de3b66b2 X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6201.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2021 11:56:38.4352 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: c1+6zBhTeqQMXdHlljNIL87BQgLkJUJrObCwQp9vk0cSmEANBjZhwAWzp5H7IMAfvWKp9fQXKq0KBUEqm3KNug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB6204 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210303_115657_352950_CCC7F0E4 X-CRM114-Status: GOOD ( 14.43 ) X-Spam-Note: SpamAssassin invocation failed X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org We add hart_suspend() callback in platform operations which will be used by HSM implementation to enter retentive or non-retentive suspend state. Signed-off-by: Anup Patel Reviewed-by: Atish Patra --- include/sbi/sbi_platform.h | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/include/sbi/sbi_platform.h b/include/sbi/sbi_platform.h index cc7e3ff..dadbc1e 100644 --- a/include/sbi/sbi_platform.h +++ b/include/sbi/sbi_platform.h @@ -139,6 +139,11 @@ struct sbi_platform_operations { * return if success. */ int (*hart_stop)(void); + /** + * Put the current hart in platform specific suspend (or low-power) + * state. + */ + int (*hart_suspend)(u32 suspend_type, ulong raddr); /* Check whether reset type and reason supported by the platform */ int (*system_reset_check)(u32 reset_type, u32 reset_reason); @@ -370,6 +375,31 @@ static inline int sbi_platform_hart_stop(const struct sbi_platform *plat) return SBI_ENOTSUPP; } +/** + * Put the current hart in platform specific suspend (or low-power) state. + * + * For successful retentive suspend, the call will return 0 when the hart + * resumes normal execution. + * + * For successful non-retentive suspend, the hart will resume from specified + * resume address + * + * @param plat pointer to struct sbi_platform + * @param suspend_type the type of suspend + * @param raddr physical address where the hart can resume in M-mode after + * non-retantive suspend + * + * @return 0 if successful and negative error code on failure + */ +static inline int sbi_platform_hart_suspend(const struct sbi_platform *plat, + u32 suspend_type, ulong raddr) +{ + if (plat && sbi_platform_ops(plat)->hart_suspend) + return sbi_platform_ops(plat)->hart_suspend(suspend_type, + raddr); + return SBI_ENOTSUPP; +} + /** * Early initialization for current HART * From patchwork Wed Mar 3 11:55:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 1446734 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2001:8b0:10b:1:d65d:64ff:fe57:4e05; helo=desiato.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=BlWzwhfc; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=OB0ydBiv; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.a=rsa-sha256 header.s=dkim.wdc.com header.b=inVTOYjg; dkim=neutral header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-sharedspace-onmicrosoft-com header.b=dEI3RZaB; dkim-atps=neutral Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DrL2Q13NKz9sSC for ; Thu, 4 Mar 2021 04:04:30 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nimG9w8zmeW/RMJPle5cffPmFTlG6se+/n8RrxmaBPY=; b=BlWzwhfcRcUTYLev0XwVd9VbL trBZFXFQiHPO4aGJQ5nos7xrQLliAJtvXbOma877JXBUDgqo4K8es4OQIFZAYF6ri3kLMcugjJdkV 0vmNs1VSyD8T5b67+olERgLhwwSyWbyfUplMq/6IG7sjCUXHIeWN2D3t+BfLNAJKwYrCmfdLKNKZl dWWBvBagkeXI1SWia4pbL38QNQg1tk8TQWJYzNHaTpODLvqRYKULbp/LvU/OHt7WWfKvKX0lrLBLG crhxT63xRY06CVrxlcOv6p+fN1fClMCXdeSMYhtdqlParD2mCXkeD4aR260EXjcnUgmqsrlGtoYbP yejXujKhA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lHUv6-005iiw-SK; Wed, 03 Mar 2021 17:04:20 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHSsW-005EmU-0w for opensbi@desiato.infradead.org; Wed, 03 Mar 2021 14:53:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=ULIv6Su2/fMq3ZhrzBigkZ3rbunDgBB7q9YJN+rDQdg=; b=OB0ydBivOVwnBh0qWMolbqdnGt z+ymKGp24qQzPJlJ2w76RI5jcO3xWqZEvHmCDqbvmAfA5jLZa0mAIlDvjayiBynI6wFhCbJNpNXHE Es16r0TNEb9F3o373DW19D9XHSELlKLHWVkZKF7ia2DlMGR3rheAdM+tY5VkyKEKSA4pjuBtzt04g 2jtji9824q/KZ1ZTqdnfev82RrK7OumNgT5zLfPN+cAWFbOE39tyIk1p88bZtDGKRH8ilOKbj67Hu daax9tbYUyAzo49mybdwSPeDaZwg8pLEpIIzAi+R2/3zAxmwEjtFgPaf9vB1hSMrIrPwWtewWY/Ey PQFg+Fvw==; Received: from esa3.hgst.iphmx.com ([216.71.153.141]) by casper.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHQ7b-002RbK-Tu for opensbi@lists.infradead.org; Wed, 03 Mar 2021 11:56:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1614772615; x=1646308615; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=3Bp2H4Eq2IaNmmsIi3azQojsibtMG8i5H45mUyVoGno=; b=inVTOYjgbuPYsGX5SzpDJHCDiULIjQVUn3t+xIjkkXDtt72VWNptz3zK ndkkHu8xg8Bc+4/hQI2ESbsJGDrKku5RpCVvKEfj40xgqwXkbMf5+sIEQ 1UpF7znWAt38H4hpS8qIGhu7/XxFEQREiOhYR5C4WrijAbSjRkYsbYgbb Ce79Oe8+NOzykLx0BgvC5W4jw045nkVgI0M7VqhwuUFpByI1tGEio3ABn FGdGNGIk2KdOKNha05JRUvn9wZHL9TMb0uFEAWit3kcmHW/lo7jIjFMJD VScLA36Aba3UtW7FRWWdnyvxMWroLfdxl6te0ZWabtKSHvbRcb3gptW9W A==; IronPort-SDR: cTt/JJXN1CW/3c7G15fBeUZM1ZjyQrQKc3XGYsKv6SIy6GLc6UeIPOHpKEkOOdsmyg+zbxR5Bm I/JhyHahqauv8bEuYdUTaP6MXeP/qR4JQqAeeCG5x+ef83WBkFum3ubwVOI+U5VIyL+gSJHjFF uz/TdlCxgIcp5bWw97BDYDlIBl9ugDCHVwRR+1S8hMulK1/LhSZWe0pjYn+gskQ7TfAtaLIArP nysfR0DjS+sOI0AdXpbzD0oLUXydgEoBNcPKl/fGkznOxWbVVVDuKwnDxy1ENCwR4iOgvbJutH m1c= X-IronPort-AV: E=Sophos;i="5.81,219,1610380800"; d="scan'208";a="165729511" Received: from mail-bn8nam11lp2170.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.170]) by ob1.hgst.iphmx.com with ESMTP; 03 Mar 2021 19:56:42 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O0fU9/mw9ZYMt77/SLkd8hPmSLXDrEgY50Fw/noYhJw2WZYWRD17mYf/SixDa3oES2QuMKeyVuMYXORzS6QSa2zW2TDlXZ8L19DRQgjdg0+XPMOWGy/ktIIYP+FJC7mKJ0SFqc0NnZgs3oAjlK9yXmwXdZvAX6mHe7tDrCe5V7Wi1W11zk/FhL/XtUiwhRbJWSc+HfclXs1Z9DONzwCjFIbVxKAw5Re5OzMvMb8z7FsLdZyHDREKHkK74hsvILlsXqyH/tKkQDKjE4Na9bYF9506xCawcmZfr8olMoTbRuAW1qPGacW6SvaYhLetKCHW/NwNdS31YXnr4fAHoF+n2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ULIv6Su2/fMq3ZhrzBigkZ3rbunDgBB7q9YJN+rDQdg=; b=Fw7BiZAli6elOna8L1aYUiYDQHmmaze+I3s+3G1Ny4orD8xvIyt2YYlK+uUUR2G+D90ev6g8AcECSZOfIBJy1MgOtniQQ0/BCfUb5bKYsSqZ0cn2xGAKtgqUHwqlnhAkCoZyYKdpBpEP52v2JAnWiajEgk5jPMLpJMopNjN0AuB5QaS0+47eYESD0vvdbcTv0UQhDR/zZqA2E0qxNa98i+cbS71Bmsg6iEcyQanJWoYFpyS0ZYY4r69PWGPkXvSWC/5nKkOUzB3aV2VQPK+WO7BTZdF/YHSGYOKwEHPmRplXi1UDUfxxPEaHRZxwnjZ8dwW5YpFKF3Se+FMkP3mmMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ULIv6Su2/fMq3ZhrzBigkZ3rbunDgBB7q9YJN+rDQdg=; b=dEI3RZaBIB0EFi+q/AZvLEmjHtUTaF9gkP9OBA5S0168uYBBl9BpM4Zq6xQh1OIr0x25M3jeDDFZrxh8jekF1dFrYd2I0bQwoiUm/MAEXp7Azy0j9wVcZANrxYcAiaNjHQnhA9AHhIB233jA+TN/wF/I285D9NnUQKMrBhroetc= Authentication-Results: wdc.com; dkim=none (message not signed) header.d=none;wdc.com; dmarc=none action=none header.from=wdc.com; Received: from DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) by DM5PR04MB1148.namprd04.prod.outlook.com (2603:10b6:3:a7::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17; Wed, 3 Mar 2021 11:56:41 +0000 Received: from DM6PR04MB6201.namprd04.prod.outlook.com ([fe80::38c0:cc46:192b:1868]) by DM6PR04MB6201.namprd04.prod.outlook.com ([fe80::38c0:cc46:192b:1868%7]) with mapi id 15.20.3912.018; Wed, 3 Mar 2021 11:56:41 +0000 From: Anup Patel To: Atish Patra , Alistair Francis Cc: Anup Patel , opensbi@lists.infradead.org, Anup Patel Subject: [PATCH v3 09/11] lib: sbi: Implement SBI HSM suspend function Date: Wed, 3 Mar 2021 17:25:10 +0530 Message-Id: <20210303115512.470786-10-anup.patel@wdc.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210303115512.470786-1-anup.patel@wdc.com> References: <20210303115512.470786-1-anup.patel@wdc.com> X-Originating-IP: [122.171.215.70] X-ClientProxiedBy: MAXPR0101CA0040.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:d::26) To DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from wdc.com (122.171.215.70) by MAXPR0101CA0040.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:d::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Wed, 3 Mar 2021 11:56:38 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 034d6551-c0e4-428e-68be-08d8de3b6848 X-MS-TrafficTypeDiagnostic: DM5PR04MB1148: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: WDCIPOUTBOUND: EOP-TRUE X-MS-Oob-TLC-OOBClassifiers: OLM:669; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qIgErCSarPVN6wD/cZIFEyUH5G8qZ3kDy9wJwpppo22+ntnorNLHM4bGusGAc14inWAHEMNuwW1yw1BslpoL+NpGfZ9pvFKsoes5aOZ82riqM6C61gVhHgGYd/F0IrDTKF0VnRhBSmvQKeAQQHn9O8PReIJuQevAS/rH6u29pQTIo23XjSVj70t4xIQWS1ABp45U9KTAaWOiYck6GU2TDGJhtjx8V/uvacO4pcB42fVlg8jw4g31IMCMq7dSD4v7gXQA0KTpWS0KavgjY9BcVCQDqBXxM9gPGSdiikeQycAuL+N50oFKMiRT/RcJC6dzS6tCsKI6GGvMPxzjecB8zbjdF9mFl4KQ3BFN64+azrvFAWdj/Jcx/1p2H3XcH2mScCn0jbpN1OfJgaoDqUjX26+20ZqzAuINYmzRNCvfktzX89UZioX5jCdEwukzbaL2XunK+bmvhVTtE6Pm8NVhmE7mGhYEw8EsKwN6lp1G6/beKWp7NyIstuaqyw89z0IK0oeV7p2Pgbco+etL+5hcBg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR04MB6201.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(366004)(396003)(376002)(346002)(136003)(7696005)(8676002)(8936002)(1076003)(86362001)(316002)(478600001)(55016002)(52116002)(26005)(54906003)(36756003)(6666004)(8886007)(110136005)(83380400001)(15650500001)(66476007)(66556008)(66946007)(30864003)(5660300002)(2906002)(16526019)(186003)(956004)(4326008)(2616005)(6636002)(44832011); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: hHHqXdstxRr0Z0ektaeFHp4+X2Kk5iS4UaVwyel194ZJwHpUZYqR6Vu0aaxUa/zfWb0G96JI2dBdQw/uvSooSVu35SjYsy+ScMVj5kfKZd5RhKFy4CB+XyvkRKc8NFxvDSs84g5Jr71Un824FcIhTub5XD72Evtt26peCch9GQt4jia0+z06pqkNQICRJ9Hg/iJpesywJShbpjOt3rjaJ8SIeReRTEmYFSbE4wTRmarjFq0bTqkLRuVYZoXdXsIBwmx5xWpW4kFOeBQ0ZOf39ip2hFcT69HnsNo4AMsMECnovdoQ+JTzwjfvJJ9pnlfnt5H+51ERAfAOvLE+nwHg0bsmvfegly7E8tjmM43dHHzncLed7M0ajdjg0SGDHOeb3rm1U8tULKeLR/m76bqPiU/3tSejUU4bzANsTUqrVovXjhMN2K1Wr1Cz4wphWVAi2lh2XRcn0+kOtxv1kCVyUkFzCAT7ZadJsRwASQlrTlRm2SgPesSLNgo2Xbs22GwEVUflAikCEZmbWz4aVDqXwMg8+w5iYd5C4Q3o5b3OXdqAiNoyazTrA9cEhPEKmfVO+qdowAONqw29GuModusI9XacXbeE+h3KUJCpbxudM8K218yWLpp58dM4T2vQFIuzsg4Er99sSE1GgB2/kG8pm7cXpHC+NdwHvNARY1p3NIk1Xsx6Dr5zY6Jzdal1fdbgm8bNBXoVfJ/dDURLfgiVxU1QEgHyhFZTV3e4QNoLjSHC9WrgRXQheXing+RneMMn5AmHWVG2HOyF81uj76V3W/jkIeNbM4ECLB6q3X1MfMCSjk98wzVSCkmj7S7n7onOdii79TsoMRH0SYkIF+Wq5Zbt+QzsF5Qt5cQjQJjrK/mKo9WrqaO0/CX3NtUD+bGyyJ6bduzU4+56ZsGzofiTj2NvgkzhUvcOm1STnGK0aHKyLZagCxggye+jVJdb/2aUQ42tGyKUzvxmqa97kqWVNwbv3jtTZMU4dM966D0PtKQ8BI+kMARtZQkxQM+jR6b84cA/Qu8t/OcCcJrNXeEzcrzywwC8KqXGqoDnlMifv/pVrWaylyrmTefKDAl1fJhGlN3Bteb0QH7mr0Hz6ZpJE5hoBKy2InQCNpvUK6pLR/t9Wt7mdbO+23oZqpDIBUHCowGlDIxkXdsBbNumZV/RYjJK98ax652RlDbMH69YbsxbGSwZP6pDX91+nmLqPlG4IpQLzWD6wqAYMcNQX8+A/MtXXT6lTjptZ6+8UQZruCd9szBIV/RvFUVR1wKtvFaavH8GAn/meHO4vgwR8z3bFlB4Eyh3cChR9uos17testrnkRhG8Popg/H0zvl5G2SU X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 034d6551-c0e4-428e-68be-08d8de3b6848 X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6201.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2021 11:56:41.0695 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TsjcGas1/gUlYLQrmpGlaDO2M9TROLY2o5wpLlPVI/cTt9thhNkYFoW6INaH7EdRy5fL0LIlAd8ZBL2FW0WyFA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR04MB1148 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210303_115657_448079_8BD020E2 X-CRM114-Status: GOOD ( 22.34 ) X-Spam-Note: SpamAssassin invocation failed X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org This patch implements the SBI HSM suspend function. Using this new SBI call, the S-mode software can put calling HART in platform specific suspend (i.e. low-power) state. For a successful retentive suspend, the SBI call will return without errors upon resuming whereas for a successful non-retentive suspend, the SBI call will resume from a user provided resume address. Signed-off-by: Anup Patel Reviewed-by: Atish Patra --- include/sbi/sbi_hsm.h | 4 + lib/sbi/sbi_ecall_hsm.c | 9 +- lib/sbi/sbi_hsm.c | 193 +++++++++++++++++++++++++++++++++++++++- lib/sbi/sbi_init.c | 38 +++++++- 4 files changed, 235 insertions(+), 9 deletions(-) diff --git a/include/sbi/sbi_hsm.h b/include/sbi/sbi_hsm.h index 4250515..bf0c1a5 100644 --- a/include/sbi/sbi_hsm.h +++ b/include/sbi/sbi_hsm.h @@ -22,6 +22,10 @@ int sbi_hsm_hart_start(struct sbi_scratch *scratch, const struct sbi_domain *dom, u32 hartid, ulong saddr, ulong smode, ulong priv); int sbi_hsm_hart_stop(struct sbi_scratch *scratch, bool exitnow); +void sbi_hsm_hart_resume_start(struct sbi_scratch *scratch); +void sbi_hsm_hart_resume_finish(struct sbi_scratch *scratch); +int sbi_hsm_hart_suspend(struct sbi_scratch *scratch, u32 suspend_type, + ulong raddr, ulong rmode, ulong priv); int sbi_hsm_hart_get_state(const struct sbi_domain *dom, u32 hartid); int sbi_hsm_hart_interruptible_mask(const struct sbi_domain *dom, ulong hbase, ulong *out_hmask); diff --git a/lib/sbi/sbi_ecall_hsm.c b/lib/sbi/sbi_ecall_hsm.c index 79a9f21..a339abf 100644 --- a/lib/sbi/sbi_ecall_hsm.c +++ b/lib/sbi/sbi_ecall_hsm.c @@ -22,14 +22,13 @@ static int sbi_ecall_hsm_handler(unsigned long extid, unsigned long funcid, unsigned long *out_val, struct sbi_trap_info *out_trap) { - ulong smode; int ret = 0; struct sbi_scratch *scratch = sbi_scratch_thishart_ptr(); + ulong smode = (csr_read(CSR_MSTATUS) & MSTATUS_MPP) >> + MSTATUS_MPP_SHIFT; switch (funcid) { case SBI_EXT_HSM_HART_START: - smode = csr_read(CSR_MSTATUS); - smode = (smode & MSTATUS_MPP) >> MSTATUS_MPP_SHIFT; ret = sbi_hsm_hart_start(scratch, sbi_domain_thishart_ptr(), regs->a0, regs->a1, smode, regs->a2); break; @@ -40,6 +39,10 @@ static int sbi_ecall_hsm_handler(unsigned long extid, unsigned long funcid, ret = sbi_hsm_hart_get_state(sbi_domain_thishart_ptr(), regs->a0); break; + case SBI_EXT_HSM_HART_SUSPEND: + ret = sbi_hsm_hart_suspend(scratch, regs->a0, regs->a1, + smode, regs->a2); + break; default: ret = SBI_ENOTSUPP; }; diff --git a/lib/sbi/sbi_hsm.c b/lib/sbi/sbi_hsm.c index 63fa8c2..ace6a9d 100644 --- a/lib/sbi/sbi_hsm.c +++ b/lib/sbi/sbi_hsm.c @@ -31,6 +31,9 @@ static unsigned long hart_data_offset; /** Per hart specific data to manage state transition **/ struct sbi_hsm_data { atomic_t state; + unsigned long suspend_type; + unsigned long saved_mie; + unsigned long saved_mip; }; static inline int __sbi_hsm_hart_get_state(u32 hartid) @@ -65,6 +68,7 @@ int sbi_hsm_hart_get_state(const struct sbi_domain *dom, u32 hartid) int sbi_hsm_hart_interruptible_mask(const struct sbi_domain *dom, ulong hbase, ulong *out_hmask) { + int hstate; ulong i, hmask, dmask; ulong hend = sbi_scratch_last_hartid() + 1; @@ -77,9 +81,12 @@ int sbi_hsm_hart_interruptible_mask(const struct sbi_domain *dom, dmask = sbi_domain_get_assigned_hartmask(dom, hbase); for (i = hbase; i < hend; i++) { hmask = 1UL << (i - hbase); - if ((dmask & hmask) && - (__sbi_hsm_hart_get_state(i) == SBI_HSM_STATE_STARTED)) - *out_hmask |= hmask; + if (dmask & hmask) { + hstate = __sbi_hsm_hart_get_state(i); + if (hstate == SBI_HSM_STATE_STARTED || + hstate == SBI_HSM_STATE_SUSPENDED) + *out_hmask |= hmask; + } } return 0; @@ -259,3 +266,183 @@ int sbi_hsm_hart_stop(struct sbi_scratch *scratch, bool exitnow) return 0; } + +static int __sbi_hsm_suspend_ret_default(struct sbi_scratch *scratch) +{ + /* Wait for interrupt */ + wfi(); + + return 0; +} + +static void __sbi_hsm_suspend_non_ret_save(struct sbi_scratch *scratch) +{ + struct sbi_hsm_data *hdata = sbi_scratch_offset_ptr(scratch, + hart_data_offset); + + /* + * We will be resuming in warm-boot path so the MIE and MIP CSRs + * will be back to initial state. It is possible that HART has + * configured timer event before going to suspend state so we + * should save MIE and MIP CSRs and restore it after resuming. + * + * Further, the M-mode bits in MIP CSR are read-only and set by + * external devices (such as interrupt controller) whereas all + * VS-mode bits in MIP are read-only alias of bits in HVIP CSR. + * + * This means we should only save/restore S-mode bits of MIP CSR + * such as MIP.SSIP and MIP.STIP. + */ + + hdata->saved_mie = csr_read(CSR_MIE); + hdata->saved_mip = csr_read(CSR_MIP) & (MIP_SSIP | MIP_STIP); +} + +static void __sbi_hsm_suspend_non_ret_restore(struct sbi_scratch *scratch) +{ + struct sbi_hsm_data *hdata = sbi_scratch_offset_ptr(scratch, + hart_data_offset); + + csr_write(CSR_MIE, hdata->saved_mie); + csr_write(CSR_MIP, (hdata->saved_mip & (MIP_SSIP | MIP_STIP))); +} + +static int __sbi_hsm_suspend_non_ret_default(struct sbi_scratch *scratch, + ulong raddr) +{ + void (*jump_warmboot)(void) = (void (*)(void))scratch->warmboot_addr; + + /* + * Save some of the M-mode CSRs which should be restored after + * resuming from suspend state + */ + __sbi_hsm_suspend_non_ret_save(scratch); + + /* Wait for interrupt */ + wfi(); + + /* + * Directly jump to warm reboot to simulate resume from a + * non-retentive suspend. + */ + jump_warmboot(); + + return 0; +} + +void sbi_hsm_hart_resume_start(struct sbi_scratch *scratch) +{ + int oldstate; + struct sbi_hsm_data *hdata = sbi_scratch_offset_ptr(scratch, + hart_data_offset); + + /* If current HART was SUSPENDED then set RESUME_PENDING state */ + oldstate = atomic_cmpxchg(&hdata->state, SBI_HSM_STATE_SUSPENDED, + SBI_HSM_STATE_RESUME_PENDING); + if (oldstate != SBI_HSM_STATE_SUSPENDED) { + sbi_printf("%s: ERR: The hart is in invalid state [%u]\n", + __func__, oldstate); + sbi_hart_hang(); + } +} + +void sbi_hsm_hart_resume_finish(struct sbi_scratch *scratch) +{ + u32 oldstate; + struct sbi_hsm_data *hdata = sbi_scratch_offset_ptr(scratch, + hart_data_offset); + + /* If current HART was RESUME_PENDING then set STARTED state */ + oldstate = atomic_cmpxchg(&hdata->state, SBI_HSM_STATE_RESUME_PENDING, + SBI_HSM_STATE_STARTED); + if (oldstate != SBI_HSM_STATE_RESUME_PENDING) { + sbi_printf("%s: ERR: The hart is in invalid state [%u]\n", + __func__, oldstate); + sbi_hart_hang(); + } + + /* + * Restore some of the M-mode CSRs which we are re-configured by + * the warm-boot sequence. + */ + __sbi_hsm_suspend_non_ret_restore(scratch); +} + +int sbi_hsm_hart_suspend(struct sbi_scratch *scratch, u32 suspend_type, + ulong raddr, ulong rmode, ulong priv) +{ + int oldstate, ret; + const struct sbi_domain *dom = sbi_domain_thishart_ptr(); + const struct sbi_platform *plat = sbi_platform_ptr(scratch); + struct sbi_hsm_data *hdata = sbi_scratch_offset_ptr(scratch, + hart_data_offset); + + /* For now, we only allow suspend from S-mode or U-mode. */ + + /* Sanity check on domain assigned to current HART */ + if (!dom) + return SBI_EINVAL; + + /* Sanity check on suspend type */ + if (SBI_HSM_SUSPEND_RET_DEFAULT < suspend_type && + suspend_type < SBI_HSM_SUSPEND_RET_PLATFORM) + return SBI_EINVAL; + if (SBI_HSM_SUSPEND_NON_RET_DEFAULT < suspend_type && + suspend_type < SBI_HSM_SUSPEND_NON_RET_PLATFORM) + return SBI_EINVAL; + + /* Additional sanity check for non-retentive suspend */ + if (suspend_type & SBI_HSM_SUSP_NON_RET_BIT) { + if (rmode != PRV_S && rmode != PRV_U) + return SBI_EINVAL; + if (dom && !sbi_domain_check_addr(dom, raddr, rmode, + SBI_DOMAIN_EXECUTE)) + return SBI_EINVALID_ADDR; + } + + /* Save the resume address and resume mode */ + scratch->next_arg1 = priv; + scratch->next_addr = raddr; + scratch->next_mode = rmode; + + /* Directly move from STARTED to SUSPENDED state */ + oldstate = atomic_cmpxchg(&hdata->state, SBI_HSM_STATE_STARTED, + SBI_HSM_STATE_SUSPENDED); + if (oldstate != SBI_HSM_STATE_STARTED) { + sbi_printf("%s: ERR: The hart is in invalid state [%u]\n", + __func__, oldstate); + ret = SBI_EDENIED; + goto fail_restore_state; + } + + /* Save the suspend type */ + hdata->suspend_type = suspend_type; + + /* Try platform specific suspend */ + ret = sbi_platform_hart_suspend(plat, suspend_type, + scratch->warmboot_addr); + if (ret == SBI_ENOTSUPP) { + /* Try generic implementation of default suspend types */ + if (suspend_type == SBI_HSM_SUSPEND_RET_DEFAULT) { + ret = __sbi_hsm_suspend_ret_default(scratch); + } else if (suspend_type == SBI_HSM_SUSPEND_NON_RET_DEFAULT) { + ret = __sbi_hsm_suspend_non_ret_default(scratch, + scratch->warmboot_addr); + } + } + +fail_restore_state: + /* + * We might have successfully resumed from retentive suspend + * or suspend failed. In both cases, we restore state of hart. + */ + oldstate = atomic_cmpxchg(&hdata->state, SBI_HSM_STATE_SUSPENDED, + SBI_HSM_STATE_STARTED); + if (oldstate != SBI_HSM_STATE_SUSPENDED) { + sbi_printf("%s: ERR: The hart is in invalid state [%u]\n", + __func__, oldstate); + sbi_hart_hang(); + } + + return ret; +} diff --git a/lib/sbi/sbi_init.c b/lib/sbi/sbi_init.c index 0e82458..1d4a838 100644 --- a/lib/sbi/sbi_init.c +++ b/lib/sbi/sbi_init.c @@ -311,14 +311,12 @@ static void __noreturn init_coldboot(struct sbi_scratch *scratch, u32 hartid) scratch->next_mode, FALSE); } -static void __noreturn init_warmboot(struct sbi_scratch *scratch, u32 hartid) +static void init_warm_startup(struct sbi_scratch *scratch, u32 hartid) { int rc; unsigned long *init_count; const struct sbi_platform *plat = sbi_platform_ptr(scratch); - wait_for_coldboot(scratch, hartid); - if (!init_count_offset) sbi_hart_hang(); @@ -362,6 +360,40 @@ static void __noreturn init_warmboot(struct sbi_scratch *scratch, u32 hartid) (*init_count)++; sbi_hsm_prepare_next_jump(scratch, hartid); +} + +static void init_warm_resume(struct sbi_scratch *scratch) +{ + int rc; + + sbi_hsm_hart_resume_start(scratch); + + rc = sbi_hart_reinit(scratch); + if (rc) + sbi_hart_hang(); + + rc = sbi_hart_pmp_configure(scratch); + if (rc) + sbi_hart_hang(); + + sbi_hsm_hart_resume_finish(scratch); +} + +static void __noreturn init_warmboot(struct sbi_scratch *scratch, u32 hartid) +{ + int hstate; + + wait_for_coldboot(scratch, hartid); + + hstate = sbi_hsm_hart_get_state(sbi_domain_thishart_ptr(), hartid); + if (hstate < 0) + sbi_hart_hang(); + + if (hstate == SBI_HSM_STATE_SUSPENDED) + init_warm_resume(scratch); + else + init_warm_startup(scratch, hartid); + sbi_hart_switch_mode(hartid, scratch->next_arg1, scratch->next_addr, scratch->next_mode, FALSE); From patchwork Wed Mar 3 11:55:11 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 1446739 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2001:8b0:10b:1:d65d:64ff:fe57:4e05; helo=desiato.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=BC17zPgy; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=jHwz6k+1; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.a=rsa-sha256 header.s=dkim.wdc.com header.b=NITVRGKj; dkim=neutral header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-sharedspace-onmicrosoft-com header.b=ryCzC+Zr; dkim-atps=neutral Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DrLTM6zS8z9sRR for ; Thu, 4 Mar 2021 04:24:23 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fRQ8KAlpl+FK1g5XAKbCcuPHc73ZWQSfbqYUKqN47l8=; b=BC17zPgy7H5xe9f6kk4VkZZKZ TSMQDpbWr6+TqqUNY/bqOvjBK+tpwRv3+i5d2Er1ghpusEl04hMXhvB4kM9bOMfn0zvdmE5hD7aBg IE88s/F/v69pcMvLJ70BJy76NqfIoQRbCWosIUJ7zlFjABD9EKx/BDbZcjHzzkPacPn1QgUqDQpYf a/w/Yhqsd05wQT0TaQwln+jEMP6+763TobCGTJqEaqdiS3Sq010rB73FCtCvyE0XvDQgiF6fP4yFj 1Y7/MooRrVRAFLdYRTP+XGfh1LaaLJ76EJsB3g6ubRxeJs5zz4N9Rq7TdaId8KCpyzGSsN6Kht9hY 6J3ShnwgQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lHVEN-005mzy-Mz; Wed, 03 Mar 2021 17:24:15 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHSuf-005FLp-MX for opensbi@desiato.infradead.org; Wed, 03 Mar 2021 14:55:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=EFneqew2qpcrXcd4kgo63XTBH1gwi789WNntmZnIFgs=; b=jHwz6k+1ScP+CffQ2pxy+31chc ebPS479y75EP0aq9rSWjio24aQ3M0BJnKvlrfyixzdVFesltqoCFebnP4ShPMhSYxg4QaOdG1XOrP Y4NxSxhF3aN4H2b2MO11cAPXg2FSh6S91SP8inYPIIHfwXcrbH1gUmJ1Roxv7izF6CC7yNsyLK/fO zYYgbYEdmDK9G7ePG+ICk1tYI7XpTLyKxilT/On7x49KX2WkYqe3u5jnLbCZizqStq1vQcIwa3R1X xYGeBlZxdgOPTqstMu+mtSq+hIfwgU57qRkmJQnV2f6n1ivXjGvjAaSP2d/dvN5JjelrsXspXqEav Io9lh2kw==; Received: from esa3.hgst.iphmx.com ([216.71.153.141]) by casper.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHQ7b-002Rah-Tv for opensbi@lists.infradead.org; Wed, 03 Mar 2021 11:56:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1614772615; x=1646308615; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=12U9PavAe0IGee/esoiENB2drZIvPBo9V6qmCoccff0=; b=NITVRGKj/DRHLORvXUOzL6WH3n06KeVC9V9k5998WYYDBVGZxZ6kN9DN hP7IH/t/CZsrL8kVTCEUSsQ+Iy0lYjiZFvww7yT8dZuqCfH2/7JJ8JX2b lPfoWOenoaOI670sZdOgVm19qn1tnAZUT8ALb1j6kOGjFVSXYh13eN80H jyAyakqC0+954THefO8Hjft5CX7tTQCkqeEQ02hqrz0UT7WogVYBcKWcL 4vB3GjcXhK2cCE++YJiWGzL5szysKfwRRBiM5gVFp8bas8IH9aAVpOK1i KzVcnC5VftBMo1JZow6Ln8TNHHAI39fcJyfNrF2G2JDq8z75L+cPymV6q g==; IronPort-SDR: Q0nzR0ymbv/f74HDg6c4AtF8mVB1OCbMxmyHT2cvy5ElFkCTum5ynrWZnzXL/pcxvV/T3T62g+ ceE2FnpzVDN0iOJvK0gxnuDdAywprNTqzNuxK+gkr9jGgkAlPNM3Wb3VP+iBmCta1kWoTpj/9m nLMFK8prXyPBcmjyXwc2c6Z+vBijFvTZfmANdPMLeF6YgCHKCrJ56E9vNsdN5LB8y9+TxdL3CB 8HOYJhY5SL7//T0XCLcZqpWfBRw6GqwBGXxRHeoMSN8oFQz4ZdXft9TmGttXcHoc5IIHxlCWKx LjQ= X-IronPort-AV: E=Sophos;i="5.81,219,1610380800"; d="scan'208";a="165729515" Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169]) by ob1.hgst.iphmx.com with ESMTP; 03 Mar 2021 19:56:44 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A+c5S1SCXj7iBd4u/8ExpYdusWpwFh815sy1Xb45RbYp01KeplJBQkWBmN3ZaUTuirhZYu/a++NKyyOWDYKFamsuDWdu1TLgfzNtrIAv1Tj4Ar66xt5718R9miUNSA/eNwFiyaQbqREcbYMQZgSDbTGXwI4tL0X4r5ho0e6goO01jw5sC7gmfDHr8Qwir/9L4q5exzxyf52Q7Sr2v1LtECkqXYzXnYu7C8VBtdBdwHb0YA/5b+8EPomwpYhhjlnxGdMa88KMI/ypp4RAm4azeQkwDSB45WtFcs1AVGe9tvaFNmIsQyue9qDd+ejFUL07khdMsu2K72uWfLQ1clQYpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EFneqew2qpcrXcd4kgo63XTBH1gwi789WNntmZnIFgs=; b=VdQinBq1GbXWxKVcXSyFxjTEh35fat5uRq9mbJY24kSlPJ8SGBU/BzjKlePjhXWbQ5oiQj7Z8DLsAbRIqzb4+trXZIi9eY3hVM0AY1iXT2orkMTTL/W7Yh7id95DU1oqideCuh58+f2h3KTQ02otno/7o1OJWxnn1OoJCQf4F9xtgZH2VRMf9Ikid7Vb+dI/vDB85Ia+qv7Z95FsyveegGiZbu4Z1ud+uz01qaF9X/mPdhGze7nzo34qPcHU8NnJPJmcVctK5mnkT2ni39Ce6sceAuH+NOYZ86sjrQiYj23qFpwc0vMArbiJ7bi/bJTI1JPCrEmuzHuBbsCJBgBnAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EFneqew2qpcrXcd4kgo63XTBH1gwi789WNntmZnIFgs=; b=ryCzC+Zr7fhC+TEmD116LHOrzQc/uxayFPMn99kghHGs9u4c0kAcsX3Zj6g0IrdNDkEGXALFJhjEjr2+z545plbMfpQ/RqbhawA3wFxiM2NKSO3PnljrsyAYnbn1SRhxZ7CRxc4LgnX5UHGcs+jvaNSnjBDCyhC8qnKhoSm1Rxw= Authentication-Results: wdc.com; dkim=none (message not signed) header.d=none;wdc.com; dmarc=none action=none header.from=wdc.com; Received: from DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) by DM5PR04MB1148.namprd04.prod.outlook.com (2603:10b6:3:a7::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17; Wed, 3 Mar 2021 11:56:43 +0000 Received: from DM6PR04MB6201.namprd04.prod.outlook.com ([fe80::38c0:cc46:192b:1868]) by DM6PR04MB6201.namprd04.prod.outlook.com ([fe80::38c0:cc46:192b:1868%7]) with mapi id 15.20.3912.018; Wed, 3 Mar 2021 11:56:43 +0000 From: Anup Patel To: Atish Patra , Alistair Francis Cc: Anup Patel , opensbi@lists.infradead.org, Anup Patel Subject: [PATCH v3 10/11] include: sbi: Upgrade SBI implementation version to v0.3 Date: Wed, 3 Mar 2021 17:25:11 +0530 Message-Id: <20210303115512.470786-11-anup.patel@wdc.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210303115512.470786-1-anup.patel@wdc.com> References: <20210303115512.470786-1-anup.patel@wdc.com> X-Originating-IP: [122.171.215.70] X-ClientProxiedBy: MAXPR0101CA0040.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:d::26) To DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from wdc.com (122.171.215.70) by MAXPR0101CA0040.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:d::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Wed, 3 Mar 2021 11:56:41 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 7ae132d3-3cba-44af-2297-08d8de3b69db X-MS-TrafficTypeDiagnostic: DM5PR04MB1148: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: WDCIPOUTBOUND: EOP-TRUE X-MS-Oob-TLC-OOBClassifiers: OLM:1107; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: R6pKSHLADjj4SVwuyPz7HckMbG9lZs/r/V6ZDy2L1HsrsblUtmHRxFlmQelfZPoC5CtinE9/Y8HDRFJhupyQPTiEBQ0neZZipJGabuNpf98+1RjOW+v9orzifNSR/bbLopbQhCx623qI4lV3DpRjWXBVWxDeuxfDy/IVEob0rwDcUffuVFv0Jr+D3roC+0PbIXebO4e9TDberDeJqYf3c2LKINnFmA3AHfTjw72DfpJSTghRPB82+7X+1LLxgtLZmEft3kvI1pFfnAovXk2V0A/FL6Q2YriLosobJRGfaiTbIjyG66KEO/ljE5/SwmpGJfjXb8KJnqvR9pasw2Jd9QSsyTKEMBi7RWnKh0vdh02w/AduAAI6ZoD/rB+yKSWncfWQexsVRTbwhVXoPbZ+cpSrnQASRNRcbhzTPfunsWSdFE6Iz0ecgziY7YXRmdWf2D7MQsI6nhy/WkkZSQ4Tkc0bUtHGSWZqfC1CZFSU9Uz1KBAQPMcPfBRoXcqO8fPL6QIPCcycs0+gR9Ob0pDivQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR04MB6201.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(366004)(396003)(376002)(346002)(136003)(7696005)(8676002)(8936002)(1076003)(86362001)(316002)(478600001)(55016002)(52116002)(26005)(54906003)(36756003)(6666004)(8886007)(110136005)(83380400001)(4744005)(66476007)(66556008)(66946007)(5660300002)(2906002)(16526019)(186003)(956004)(4326008)(2616005)(6636002)(44832011); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: L3mI9xIexz95CLOozh9rZZ4q8eAQE9JigLzffAbQxfoZxO8oDRlXlCRELdZj1EoIttoWj6iFePCg1A0QnwEzGAtuPQSCCKBmM9TyDx7THkSmnA0etcScp6T7wlMuOBg/OdrBCj/9b12id5m1zo6X1e7pb3/rV8STIFkjV7XdGyb/0coNT05EzMeHE5Ch7FB1GJ3PB7+tH8jsNNVzYDDx1G3C5sdvhOCFxBLDWSYsuxWwF0ef0omxk2DkJiiK2Yh8iRfXDAoSOdbAsEEsD0KAOfr3wj6VE4o5Ncw/WntajGIXdJx2WiksEK60eGeKEp25VGM/5XBdlRyIABSMv3j5+W/HKpoEJPhSrp3rTf1OazOK1sENRzonQ/jU11rHYFGG+kH4XPC2/1KntBx4980mjM0FLeND3BalGaoCz5/bxNi/V8se3Hqwwl+2bn01pXGijDOjWoGN/oBnOW9Wkr9JwLPk4XsSYuN5R7hsl215pXtLiWMxg/IJ3V/qcpr3gxi/pHnkMbZglp/sHtZZMSLsVXSIfKXbqrGVbg01Y3zAhCWwoCgrLNv6HsVe777FJP/RPMLJj5Cs6rwwCKIptXtJ968Na8ZtmajnbF0E4WGBXjLDFyLbr8+vEhoVksAu6JzzHHmogsXwv8cV0dhiT+xrXpnjxEbI6zuoxfTF9Y8OnSLLxaZ+7uqClvnKLEl+hzpXdvpO4TnQpQYuMeLW3wGLbe85OcjMFdtTWWa+jPle5PExWstsb8nOy138pKfysg/hX4uFcvN/LPz0g62zV0kC5vSHEs69oJ9bOY/z8wCXLnAUaRq0i6UsxiFcYuNCfC99c3UXwfxVq3d0KWaROEz+Jy/oj7Qtj4KNTRovaj0fpsMRYayvByXONtZ1zy05c+eWRWSmF/yPKOM9fEeEOMmhDBiB3y50Hq4B9hoGabcNRDWpRjJugBaE5WOS/bJSmXzgFu+jhiX059OuJ4ZAiDa4owQVC0GTc5u5SWWoW75C2/SM98jPAIpegvghwIxENy/54DGzhIAxOVANeKxtF1B/07lBQqdr6+I203BM7z9dXHzq97PEWD3DGkxPqX7cNleEFl/X/cUbnr0VJgX2V4h80PWWlTo6NullDns0sR0/RU7QC8lOGZRkv+uHhMAvD6yiJiB7wvOrGRoDI/6m62TV9hxUFJKSGK+u3e/LB+Euo0uKvlFvIIK87WBP4lwlftNNloSddvIzh1IMBfBaB1GtnZbP1Y/dIWZ/rkane3HufsMczdUDypaJQiy7Ag8wX+j5dPv4lv1TFPM74cipOkhnbdS6cG8S/JHxDJPCKTKRt5Sv9AVRsJfNyrJTmgMy/54J X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7ae132d3-3cba-44af-2297-08d8de3b69db X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6201.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2021 11:56:43.7328 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BQuBAbWU2eREPozGivGLVMw+pWC8Hs3iBjrC+AXSuoGaKWMHVXZ8G/yAoC/PzmUSLxw1GRqwCHSKG79X6QNRvw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR04MB1148 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210303_115657_382327_0EAFA25B X-CRM114-Status: GOOD ( 13.79 ) X-Spam-Note: SpamAssassin invocation failed X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The OpenSBI SBI implementation is now compliant with latest draft SBI v0.3 specification so let's upgrade SBI implementation version. This will also help HSM suspend function detection in S-mode because HSM suspend function is only present when HSM extension is present and SBI implementation version is 0.3 (or higher). Signed-off-by: Anup Patel Reviewed-by: Atish Patra --- include/sbi/sbi_ecall.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/sbi/sbi_ecall.h b/include/sbi/sbi_ecall.h index d357085..63ef866 100644 --- a/include/sbi/sbi_ecall.h +++ b/include/sbi/sbi_ecall.h @@ -14,7 +14,7 @@ #include #define SBI_ECALL_VERSION_MAJOR 0 -#define SBI_ECALL_VERSION_MINOR 2 +#define SBI_ECALL_VERSION_MINOR 3 #define SBI_OPENSBI_IMPID 1 struct sbi_trap_regs; From patchwork Wed Mar 3 11:55:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 1446794 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2001:8b0:10b:1:d65d:64ff:fe57:4e05; helo=desiato.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=SHT+ut6n; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=pEzZg2mv; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.a=rsa-sha256 header.s=dkim.wdc.com header.b=YSYtBSso; dkim=neutral header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-sharedspace-onmicrosoft-com header.b=mMe3j4Rp; dkim-atps=neutral Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DrN3W0m3Sz9sCD for ; Thu, 4 Mar 2021 05:35:35 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kfsvQHSQGmyL5oGluxoY8QYGzdkHdidR3+XHcJHhNT0=; b=SHT+ut6nNolLo3JXtSZK1izzc uWzxRwTF+a8767z6PVHsgBEwCLshjukJLRI68hxPSBIxBpeUuGeE6FuHXknkHZ/E/1H/Xx6T7G6N3 U6Zu5YnFZJobh/Wpby97i2lczIs/APojWWTn1kbi7n4eXQrhq8uAhZpXRqk/GX0mazjHDsNqMrA+/ MBNj1vDs2Avf85hepqhR712LqgHoxCmM8MwmCx/VmSyXhVPVpKYbH8oYLG8YzWdwj/X8POiJzwcdX ZMLEFylvNz1u2i/+CdU5CWvW4p7Ua5aP3y4B3fPHha52rINhmZBHW8eljce0zxQ8v/L9Jz9cL96vQ xk5uIfxyQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lHWLG-0062WW-Fo; Wed, 03 Mar 2021 18:35:26 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHT0p-005H8B-Lm for opensbi@desiato.infradead.org; Wed, 03 Mar 2021 15:02:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=4kzp+yQl7FMyXz7KWG55V0BeMULdaijDioumDameak4=; b=pEzZg2mv0slxxSf+2uHAoIXVyh m79KdiwxSMjqxrgdLYcgoRxa2R+kiRMV0+0u+dNEVwm+dR73+tF5AKgfS7P7HUdiMLQJZKBkFud/Y MezFPG80MsKqUDRURpftmmWCB83jaTMDk4jadgEdChn0YQL9TN+uZf934Zbldu0rjO//4BWFUchSq M5Wybrwz7QzlLL+AI9aswR+roaLqTWRw9V3lgELXk16jOaeFgYW1NcHk5wBfERA8yzFFpWeqnL6sN 05sKlOL0Pp9sRiDOdfcd22WSY8n/+HHP5vOHykTkWQgFHb7dD/R/B6i8yh5XSTm6URD+gnYNGRpSn wCkoLPBA==; Received: from esa4.hgst.iphmx.com ([216.71.154.42]) by casper.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHQ8R-002Rgx-FV for opensbi@lists.infradead.org; Wed, 03 Mar 2021 11:57:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1614772667; x=1646308667; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=ZJPyKesIonvsQGwkw7HwrlBTwhjt6pgwnq26KVaANxo=; b=YSYtBSsomvPJ24P0nN3t8+qKNDDSfcn6JslDsFrq1ZBQTzgG4SQZe4FY zSayb4OxE4jlbnWpAUdOHVHxReFBbY+fV+MLuelNITHvxsPFLwPnq9p27 4jR4IOkI3jwC7a++zEg7Bdbc2GiF2GO8XZaQvQTChERbladtrHXwSEgoT SS/QgQOCvG1qoT9fwsfOfOQb6I355jaajAmO5YqnzuFwzGHvNG2T1IdAH 452DoywiTVPn+ZBV2SkocPrWj5sAbTOmiaAURCjDBNipy1Bh2QZDJY0GQ BTNG6mvVqbGUCZGe3GBSnoBHLKNhTvvAzgNBjxY2TJB1HqhVuF06mz/aE g==; IronPort-SDR: f4I/pdVQUaS9DPyQLt+y26WBUo51MXiDxlX25xJ+8GKywcPMXOZ6ptZk/NOe4dtyXoLxBWW2I4 N2oyHWVtKxQaTdNXHd+9Gp/HBD0woQnU6uXB90pisa1cl90FbvAeWk1a295dUS0GRhrqCefeJL cfc271Kqpomy74QcXgyyPHU1MWtcsJoptD0yxREfcJPsyvh4j4ODDzOh5YcOSXezoVdbcWHWZx Ti1zfQAypNilvP9C8zvdOL3rUTx8ijnFYm/GtAICRL188SkVNn7KA6hu0OFdUtM+jF9SIhi0n8 /Ok= X-IronPort-AV: E=Sophos;i="5.81,219,1610380800"; d="scan'208";a="161237795" Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169]) by ob1.hgst.iphmx.com with ESMTP; 03 Mar 2021 19:56:47 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C2G8i8kNZtH6CodytFNI5mYPbo8nqcIhmQFmWzRBf2cY9+IQxLHXN0FSICC4/qOrQjQIqgwOJ/+dIQ5eSLy+k5yoMRx3bLEaByRar+iacKLQhn6S9wyUz/Pe+9F/1pIL59fW4AoWSLOoSRK0GDQj1wZewjHJca26lmizeBOEPnGLWXXBD3fRvHFu7+/ne/cF2Oh5sUQ+q5R0lnEh4AkbC/SuTMNSR5g6GdgllXRKxb5ge2NwNgYRUnSplkUVf+GaFDxcHNPb6WSdssIDGI5C6JbPU6OpQlUm8ELB3R5A9kPsq76vRXeL+BAzLXLSQ6x6MZ1mjFMQ47ULxqfA3IpXlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4kzp+yQl7FMyXz7KWG55V0BeMULdaijDioumDameak4=; b=a2rrJ+aknBNdhBjsciaCGyD7LkrCfRDK0pdJGlYp3Tg0XG4Jc/1B29IdWEaXpJcyQ4tLy7RmxoQPwNo4RqBXPQ9GEXWs+icSQ4no4wD8p4nJoLjjUjsZw8TcmQPWRh3FBcZgwgdrCrXPT3BD6WpsLFeBoGMnj5TIWs9aVoawyQ2oYFj6/tMF3+zwU+2tnSkYZ3yszrB9A3kdFWkhMm3PB96WbdrtZpOQrYnpnu6eUMrDVftqINKueKpItFlH1DHZaC/cJcb+8M58ONrTsxx4c8ukct7X9WFuWknXAbl/CkviTvjTJBtLdZlbFOpJNIVlaDBqaYBKKLgjdWs2BgN3RA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4kzp+yQl7FMyXz7KWG55V0BeMULdaijDioumDameak4=; b=mMe3j4RpNDlZOvpIe0NOb1tUSj+7WYh+0KolPagLT9bUbGk9Y8BvuxMcJtBbkXelfnLLzNnAPX7W7noPD1wmAL/dpyy3bvOS0lM7H3SCN5KBzfYTh5Um3QuJLvhG+9He3XHCwNXpp/QX6BOwISFrBkfysRxJ8SIwhE8IgNBta3k= Authentication-Results: wdc.com; dkim=none (message not signed) header.d=none;wdc.com; dmarc=none action=none header.from=wdc.com; Received: from DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) by DM5PR04MB1148.namprd04.prod.outlook.com (2603:10b6:3:a7::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17; Wed, 3 Mar 2021 11:56:46 +0000 Received: from DM6PR04MB6201.namprd04.prod.outlook.com ([fe80::38c0:cc46:192b:1868]) by DM6PR04MB6201.namprd04.prod.outlook.com ([fe80::38c0:cc46:192b:1868%7]) with mapi id 15.20.3912.018; Wed, 3 Mar 2021 11:56:46 +0000 From: Anup Patel To: Atish Patra , Alistair Francis Cc: Anup Patel , opensbi@lists.infradead.org, Anup Patel Subject: [PATCH v3 11/11] lib: Remove redundant sbi_platform_ipi_clear() calls Date: Wed, 3 Mar 2021 17:25:12 +0530 Message-Id: <20210303115512.470786-12-anup.patel@wdc.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210303115512.470786-1-anup.patel@wdc.com> References: <20210303115512.470786-1-anup.patel@wdc.com> X-Originating-IP: [122.171.215.70] X-ClientProxiedBy: MAXPR0101CA0040.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:d::26) To DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from wdc.com (122.171.215.70) by MAXPR0101CA0040.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:d::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Wed, 3 Mar 2021 11:56:44 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: d89d5eda-67d3-4e01-adea-08d8de3b6b5f X-MS-TrafficTypeDiagnostic: DM5PR04MB1148: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: WDCIPOUTBOUND: EOP-TRUE X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1XQxRFLoOYBn5mNs3lLnGbcWxcb41sFHPalLVlcesaVVCfvw81QgpQXOfwc6FuBuwvsC18Ukj4A7V7FgZjFB9ktUu4rQadSrsDcF451Dfa5Pw2XlQt2BpFSrlUI2RRio7HwI5v2MWBAZKuFIe4otHgVsOlxhlyXYM0IOMkfIyeM7NZ2ddAUWE5VJZzj+hdkGVHq7gizJdZ5zHMq8Ab6WTlmJzIYeOS4tMu5HlGf/2j9BEpGp8zJEbsrADSR2kU9zX4aPfyukWI6YuWMCHo15QjgukuPnZCzvPq+Rl3XkRs1NW79axoN4Spa3EEx4pHHZqPLat4sRuRT78bkCG+zS9lRcuZqPx4jd6bQAWAfe1Ix4UPTyOPKONMfeZbwdxCDYrfr/ur8MO25MdVXF0bdeBC+MpCIavTgyprgPN2mY7eHKOlnTQzBmD3jtHDhJhSWS3Vuh7TM3/kKoqYnw1L/dHQEsyXrc9/SbxMz7GyC3Z2TpH4ImV9XOaHmjshCWkHfDPLlDdR3QLtvA6xz1ccvTbQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR04MB6201.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(366004)(396003)(376002)(346002)(136003)(7696005)(8676002)(8936002)(1076003)(86362001)(316002)(478600001)(55016002)(52116002)(26005)(54906003)(36756003)(6666004)(8886007)(110136005)(83380400001)(66476007)(66556008)(66946007)(5660300002)(2906002)(16526019)(186003)(956004)(4326008)(2616005)(6636002)(44832011); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: k3HM6QApUMFQ2F/oIewQqhnOHMK7tTh0t44FO5pIcLTzZlx0aKw4iC05LEQTqyj7Jm96w5761WF31oXY9Ndb4tRXUmxSvYVtGaE24xZpXi06QTSWR3vLjrzErheeciLSeqI1t7vLACeyqb6+xrCqZ2HFp2sOu6VWLGUNrK42VywJhsO4X89cXLmlbBIgExR/QZ3VVFO9i0V4nf9r0dZC+Z7VaPL/NPBMu0jJr7joZOUPIxZ2s1HNhc6RSm5z5BF53QRMcXPcQcOnb0rUrUsO33QevLA/Ts59AUjH2cUww2zWajKywsJ1W8D1dHN6UP33xc9009ibXkMt1RL5DmB+tg334d/Ben/wIpgOtUhkg1a2K7KIw0IE7ikW7IGM2mtLfg0i+yjkWugJKBrUcKzcsfdNPWYwf8/0SzHFJKacLeENuCrvdMuaD12EuEdAuUEDHXL2ifvaD8/5gjZTX35oBYEq7CqCYkFzPVMfP2KR/IM+QUSdzvdHlcV77phpFaA8yPLG1GQrnF99U8dq0GbpWNze+aLX4A/jU58ItgOTlLOfixlTpOX7kaSQ9JwxMX+UvLy+eY2qhMOS3Sg02+lP8KD9aFLDvZ2s8OVj4FOzb0iFlDok1zWWqBXGWAseT++auuoUd+bH2NiPFxdlbfrxEJ+c8YTu/Uegqx3Se0+FVpgC3gxs0r20lMQH+yDNn6llE1N6wglUVIVwZTyxRmJAY964Vv0P2u/Ww/MBPtWRWVlygU52SCPUPxE2VWHp1T7N2qKaQ7xU5B3A70o6z8zAF6ReoCESIqekQpSlLy6TLMFpvHfUs+JKidgCiqqfaAmGD2tq5DfS4wBEbZLGWsO2+/r6OT+U4hIEh8UD9BmlXc0Zlbb+tcxDYbvReS1Wv80JteQnQ5F0G5H9sHNRswIRChUPSO2fHPtLMaJxNys2Qv+Qhef8M9dYThwDyojV7XIW45o5kSvruWuPWcTdmEIHXJ7auX3OKRAYd711ShbILw41tg21Aq1efwWS07bD2AMc8ROv02IwUqz4ZKtVTXzOebMcQOrLVDJg7eiF336oE5ynOat68V3dhBmawzXd3SX5/fn9O98uyH15kTunz8HMDgatlDX+KMqnRwoXhgbBvsdEwCpvg9zJIXkQ0EpftLmtmGcmV0lX0wyM/DX8TvD8mtskHG3VFz/th9FQXW6bK6PPIa6JzjO0JaWeR3RoXL37O6ZHDrOV6ITK0B8XpJkbp0jOb503xaRqgX+7MQNSAjR/4uZEeWqF4wMpQIFZjkre47mxK3IwLdXgMrN5pR7chE0OCPDibA1vFMrDasBiWdWebiFX2ld6asLRB2XX6No5 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: d89d5eda-67d3-4e01-adea-08d8de3b6b5f X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6201.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2021 11:56:46.2901 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KzIS3uQbzsbZnPqu0O3FnIIukcJBylARM1/+4Or3VEuDgdV8glIpQ+GTxCV0PmYQiZMXJej9tOQfBJOknNer1A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR04MB1148 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210303_115749_970897_45D552B5 X-CRM114-Status: GOOD ( 13.88 ) X-Spam-Note: SpamAssassin invocation failed X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The sbi_platform_ipi_clear() called from wait_for_coldboot() and sbi_hsm_hart_wait() is redundant because IPI will be automatically cleared by sbi_platform_ipi_init() called from sbi_ipi_init(). Further, wait_for_coldboot() is common for warm startup and warm resume path so the sbi_platform_ipi_clear() called in warm resume path cause resuming HART to miss an IPI injected other HART to wakeup the HART. Signed-off-by: Anup Patel Reviewed-by: Atish Patra --- lib/sbi/sbi_hsm.c | 7 ++++--- lib/sbi/sbi_init.c | 11 ++++++++--- lib/sbi/sbi_ipi.c | 5 ++++- 3 files changed, 16 insertions(+), 7 deletions(-) diff --git a/lib/sbi/sbi_hsm.c b/lib/sbi/sbi_hsm.c index ace6a9d..bbc4ce9 100644 --- a/lib/sbi/sbi_hsm.c +++ b/lib/sbi/sbi_hsm.c @@ -107,7 +107,6 @@ void sbi_hsm_prepare_next_jump(struct sbi_scratch *scratch, u32 hartid) static void sbi_hsm_hart_wait(struct sbi_scratch *scratch, u32 hartid) { unsigned long saved_mie; - const struct sbi_platform *plat = sbi_platform_ptr(scratch); struct sbi_hsm_data *hdata = sbi_scratch_offset_ptr(scratch, hart_data_offset); /* Save MIE CSR */ @@ -124,8 +123,10 @@ static void sbi_hsm_hart_wait(struct sbi_scratch *scratch, u32 hartid) /* Restore MIE CSR */ csr_write(CSR_MIE, saved_mie); - /* Clear current HART IPI */ - sbi_platform_ipi_clear(plat, hartid); + /* + * No need to clear IPI here because the sbi_ipi_init() will + * clear it for current HART via sbi_platform_ipi_init(). + */ } int sbi_hsm_init(struct sbi_scratch *scratch, u32 hartid, bool cold_boot) diff --git a/lib/sbi/sbi_init.c b/lib/sbi/sbi_init.c index 1d4a838..4de2dfa 100644 --- a/lib/sbi/sbi_init.c +++ b/lib/sbi/sbi_init.c @@ -130,7 +130,6 @@ static unsigned long coldboot_done; static void wait_for_coldboot(struct sbi_scratch *scratch, u32 hartid) { unsigned long saved_mie, cmip; - const struct sbi_platform *plat = sbi_platform_ptr(scratch); /* Save MIE CSR */ saved_mie = csr_read(CSR_MIE); @@ -167,8 +166,14 @@ static void wait_for_coldboot(struct sbi_scratch *scratch, u32 hartid) /* Restore MIE CSR */ csr_write(CSR_MIE, saved_mie); - /* Clear current HART IPI */ - sbi_platform_ipi_clear(plat, hartid); + /* + * The wait for coldboot is common for both warm startup and + * warm resume path so clearing IPI here would result in losing + * an IPI in warm resume path. + * + * Also, the sbi_platform_ipi_init() called from sbi_ipi_init() + * will automatically clear IPI for current HART. + */ } static void wake_coldboot_harts(struct sbi_scratch *scratch, u32 hartid) diff --git a/lib/sbi/sbi_ipi.c b/lib/sbi/sbi_ipi.c index a3a6ce6..b50735e 100644 --- a/lib/sbi/sbi_ipi.c +++ b/lib/sbi/sbi_ipi.c @@ -230,7 +230,10 @@ int sbi_ipi_init(struct sbi_scratch *scratch, bool cold_boot) ipi_data = sbi_scratch_offset_ptr(scratch, ipi_data_off); ipi_data->ipi_type = 0x00; - /* Platform init */ + /* + * Initialize platform IPI support. This will also clear any + * pending IPIs for current/calling HART. + */ ret = sbi_platform_ipi_init(sbi_platform_ptr(scratch), cold_boot); if (ret) return ret;