From patchwork Sat Jan 13 09:15:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: yuan linyu X-Patchwork-Id: 860306 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=163.com header.i=@163.com header.b="ez8z4Ed+"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zJYsb53hpz9s7n for ; Sat, 13 Jan 2018 20:17:07 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965450AbeAMJRD (ORCPT ); Sat, 13 Jan 2018 04:17:03 -0500 Received: from m12-14.163.com ([220.181.12.14]:33242 "EHLO m12-14.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754593AbeAMJRC (ORCPT ); Sat, 13 Jan 2018 04:17:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=R7BxZ bv3bth89n6PEVHuLbm5xVKE07uKkH+pz5iuGGU=; b=ez8z4Ed+oOBElSyciVNRQ Y6PNzVxDKjEbc/naXzNSICHdUiHR2eQTYlUa3K4w7XJVd36lnS+5FsHO4YgTBbDe FBMBx5vO2BtIu9V8yhe3mOwyL44egdip4Z1ZWP3Jnj3/UV69p+WF7hweAyX6adNS cl5EB0TtSLM92YwvBTrV+E= Received: from localhost.localdomain (unknown [122.224.55.50]) by smtp10 (Coremail) with SMTP id DsCowADXYyR3zllaA8SiCQ--.14342S2; Sat, 13 Jan 2018 17:16:42 +0800 (CST) From: yuan linyu To: netdev@vger.kernel.org Cc: "David S . Miller" , yuan linyu Subject: [PATCH net-next] net: dpaa: change while() to if() in dpaa_fq_setup() Date: Sat, 13 Jan 2018 17:15:54 +0800 Message-Id: <1515834954-32145-1-git-send-email-cugyly@163.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-CM-TRANSID: DsCowADXYyR3zllaA8SiCQ--.14342S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrKry7ZrW3ArW5AF1rGF1Dtrb_yoWfZFX_Wr y2qF10kr4UKFyIya1Yyr43Z34S9w1DZr4FvFZ3tFZ8G3sxCFyDJr109rn5Gw15u3y09F97 WwnxX3yfC34jqjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUY1OJUUUUUU== X-Originating-IP: [122.224.55.50] X-CM-SenderInfo: pfxj5zr16rljoofrz/xtbB0xrM41XlcZAuDAAAsV Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: yuan linyu while loop is not needed, because list_for_each_entry() already check all fq. Signed-off-by: yuan linyu --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c index 7caa8da..fd0e411 100644 --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c @@ -931,7 +931,7 @@ static void dpaa_fq_setup(struct dpaa_priv *priv, } /* Make sure all CPUs receive a corresponding Tx queue. */ - while (egress_cnt < DPAA_ETH_TXQ_NUM) { + if (egress_cnt < DPAA_ETH_TXQ_NUM) { list_for_each_entry(fq, &priv->dpaa_fq_list, list) { if (fq->fq_type != FQ_TYPE_TX) continue;