From patchwork Fri Jan 12 20:07:36 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ido Schimmel X-Patchwork-Id: 860180 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=Mellanox.com header.i=@Mellanox.com header.b="x8Wuc6C9"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zJDN469hHz9s81 for ; Sat, 13 Jan 2018 07:08:52 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965148AbeALUIt (ORCPT ); Fri, 12 Jan 2018 15:08:49 -0500 Received: from mail-ve1eur01on0069.outbound.protection.outlook.com ([104.47.1.69]:10496 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965081AbeALUIr (ORCPT ); Fri, 12 Jan 2018 15:08:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=lTKPkjG8UIFBBktQPxuoTkno/NNM8NVTvX0MhKk5J5Q=; b=x8Wuc6C9wfAZ2uouVwzFsJK2PuZllXB7dl5WPHpCcp/jJgnaM7iHYm2HNVDn5pDbzPQ9YMzQbCItBh23IwqvZDmuOe9m4e47PNIDGYhkojU5IKvysQ8Tb7kHXfodPekzlX0gBqJbJduPWERqZw8twxTHBNcTBFMzKUjGYgcLoX0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=idosch@mellanox.com; Received: from localhost.localdomain (109.67.160.95) by DB6PR0501MB2006.eurprd05.prod.outlook.com (2603:10a6:4:6::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.407.7; Fri, 12 Jan 2018 20:08:39 +0000 From: Ido Schimmel To: netdev@vger.kernel.org Cc: davem@davemloft.net, dsahern@gmail.com, emils.tantilov@gmail.com, mlxsw@mellanox.com, Ido Schimmel Subject: [PATCH net-next] ipv6: Fix build with gcc-4.4.5 Date: Fri, 12 Jan 2018 22:07:36 +0200 Message-Id: <20180112200736.24786-1-idosch@mellanox.com> X-Mailer: git-send-email 2.14.3 MIME-Version: 1.0 X-Originating-IP: [109.67.160.95] X-ClientProxiedBy: HE1P191CA0024.EURP191.PROD.OUTLOOK.COM (2603:10a6:3:cf::34) To DB6PR0501MB2006.eurprd05.prod.outlook.com (2603:10a6:4:6::12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 08426d31-1ec0-46da-d7fe-08d559f84673 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020086)(4652020)(5600026)(4604075)(48565401081)(2017052603307)(7153060)(7193020); SRVR:DB6PR0501MB2006; X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2006; 3:Z3X4mE7pt3i+LWmI4o286+HJqUX5AYBcr/1+sQ4IkQuGxzIHhmDgbGwfjzwc4DIfI92Zn2LvJ2cSR6IydQs9vJ2G1TCFK7k94cXyqkVmJAQplimQxJyG+azXXsixga4nxurHnRvHVG5wJauunCr/+mK79gniorch4M5mxuMuPcVd25YgkW9dA+VhvPepVCoenTfX0hgZlSAb5LRM7tqMwoh6gogGngh3QJoo2QyjmyFbRQ77QA8O67yTx6I92N/z; 25:teLEU4j4bc7mQoCExViSI67kXAjWKu9kab/hO3Qee5iMNDV+/6z4N1C0UxYPV2ykibO+MRepNIxCq8ePXZEkKwSeOj/tlyw6QSXTPf+2t/av7G/cb6AU5VaeKMy09bHCifdryVClScqVLgE2vHpsat6ZknsBAFoDcIJWkGi4rNEmapIioq1+OLwPu8RWVoV2SaLsuod00bZmRuO7zv6ABAFP4NmAudh/rdJ95S+M8ZWfJ/azam2mOqrEW+ZxMTfFnNL8p0ciuRGa30Vjt6YHjwDPmm5cpIroXy4KBw+MPM7ora75o6nuTw66ETTNgVnJB81XGju/mjcOsRVyJh3yAQ==; 31:pjL/doR5fr3Deircbzfe4GMoVXfG+BjOjXUhd02YyMvKIZQ+3DfjQslXsafp4tVnzYda6ahk9dkYl1AQ4j8BhmDGhy0E0i+WeyQ8Wh4tp6SGbR5UnL1INUzyrNxbwJ984z1HFvlopVHU36fliyg0h4BosqKQnJK2zQ894OR5QlVy8pt+W7rHCse28XCSCpCmOmsck2kSZ/0qI9+MJrLG+6zHkvBb7iqycYVmJILwL1s= X-MS-TrafficTypeDiagnostic: DB6PR0501MB2006: X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2006; 20:st/TfO/kxf7ZN24A3mqIag7eEpiwoVon2ZNpB/V4MrVh18aKJrIVXpo9Q15nB629EMjz2fR9pPYcq0rFeBEQx4rN8C1HrT7oxPjz3TQDyugJdiq5FlAoa8a+Bk3cZxtWkiYzJEZ63J5hP2vP2o2FTPcy3LiOP29NGtbkzjDyPAFkqKpNrmGP68GfFaP2HiIjEfxu4DMtExl8w3KYBSttBpzICM6n//ntZ/37XnJn6miGlA4Qt4OFDYUwXpTBmRAccg1cM51oaoKz2Vo2nE9XU0LU5X4gPyzOCEjdcjaMxEVDR/v16EvFGviQG3iTbDm+jGrrhHTBB/EeZOnpqtu66Vs+8to/h3sTYULdK2taV3BaPR4F5pPK+lPDP1U3JQELtEo98gbUXwpXw8XVORlunfXWd71YG3Cgy7U3eYzkQe+fvbpQvncruMGFudq9bBlCoygMdlcS5jfxZvql3QHEOj5Fz/TfLbVg3mfPuEiNON9FX+WXVNLFaKOJBMkvitGf; 4:C7Yaaykk0guaHRJMCcCbnacQrLFg8rBYMfPct8/d2euYRtQVEkogo0eneVt3ZKRvfHE0baTbwrszL60LoxJaU69cLrfExxvAErLpqtDJKknnOqkvO++EEFRT7kwaLAEv0+ukBBLi7LDc/gh5Q+Dj78e24s7b3Y/feq+UoxsSeZPWsTC97Igc3Mpm7WlA69Wfp83Wc7UTCS22VO8ajeBCfPVxyjL9X2aQbbMBPDjAOl3VNBijXhPBsxk0U5+uACUJh0Hdi9oPbIQPMTsBbh4qYdLjGIk7H+R4IawwNG8+iYp/XS4h1C4U2gULb2X5MKSL X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(85827821059158); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3231023)(944501147)(3002001)(6055026)(6041268)(20161123560045)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(6072148)(201708071742011); SRVR:DB6PR0501MB2006; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:DB6PR0501MB2006; X-Forefront-PRVS: 0550778858 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6069001)(366004)(39860400002)(39380400002)(346002)(376002)(396003)(199004)(189003)(6916009)(6666003)(386003)(5660300001)(305945005)(7736002)(50226002)(106356001)(2361001)(105586002)(2351001)(16586007)(50466002)(8936002)(6506007)(48376002)(25786009)(59450400001)(6486002)(316002)(478600001)(3846002)(1076002)(39060400002)(6116002)(2906002)(97736004)(107886003)(6512007)(53936002)(4326008)(81166006)(86362001)(51416003)(66066001)(52116002)(8676002)(81156014)(16526018)(575784001)(68736007)(36756003)(47776003); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0501MB2006; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2006; 23:4ElsNQdhXUgi1bzfRwPYtO9tMQl7ko2NqQgf1rieTl5iDjaYqK6yOW41gxBkHj8vR1qy6XNEmRb6qvW6o09mF0D/z9+oS3f7oGM6AhRbtqLi0AHMxkwi9vsR7BPSaTB6eRG0Xo0b7Jse6egj3HCjI/quGVc5Kic3Ml2LjY9ArHhIeKFuar4n+7trYlmgrb8HaR+U19yv64UhDRnTgpmw7bqgUaBtV8c6y0A8+Z5+Fi+J3Hg4XKAHx34sf+QuiU0akWyJrRe+mKQANspagsnj+IDgAHzmyqt5FKG1TULwOl2P5qBt3i7MGn/KsExP2+mdPXtFZjcRdaNh02B0KvQOEFQDtEg9U7iCWB/15r0wB3Wy3fic9+GeIJP1sJhUmDCgkgCVqDmRSV5ZMl3Z6e+J/uZLw43bmtYjwtYT8MRJ+F9IjMYUGbumxBvjgU7YWQDe3yMPzNiEAcdAYbJSEW3Kv9i1dwxtFtUxoxVLN/sjXUFy6T0JzWEyhky7iCp54M+xfWdEa5wgIgA2qYDmd6/Z2ych1u3BDY4trR5tqj4rzrXxa8Qr60T2gi9saOKfS7ujSV70OFvYBvuIE66SHxEEwy9VfNaJTEtvpkFFDFN0jVum0wBo0cPZvP0952A5DPam88hrbpbChjhJCzgtCnPHAAlLIntRjLQk9hF/5Hg0Q8ZZESwx4E6EIoGPiH2aJU/uR1l9F3ZgHGceavIiDtTyTdiwP8df5Fb+A2Vpp6n5iY2HTX5FCSOhEmS7Ud/wN1V4Eol12/o9DgT4ZelhD4EzGqaxb0uswC/nwqS0S91hsLt7TKu3Q1HdqIRtDQirI1wqff2iXj5lGwq/SnteqKAmWBsCIR7Co6juRjDZZHr1iz5BGfPH1o3L/4639FSgExwv+7D+JoDM6oXO21qcx2v870ywW8B2stAThq04sCm0S5EJxdimIqA5//FXacrDOEyadZ6q4n1CkRb1NjOf3roV8AO4KM5m2IvveI/VHVjKQX0RDGPYNgEdD6P3SfWB/99qU6J1VwFM1SXp4ESAIBWDNUzmYGZSg61agjdt+ucLaPnhIpAKLoiRCn9yLafifbZysgCfUKjJF+0bGtZIq8Breqt5pQmBJdsXOX8gWm8BXzxwd3RNMsGWjl9qH6qTdEaGTAnsh4Oqpg1DKewxQoASMNfAMuJ+2bLDPM76BwXYhpR7icqQeCHYKzmANMUlXfpw X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2006; 6:xhaKlA6kOpwPtedxIsYc8l8wkXRKmCR0usKVhoC61frPYPfTZ6Pd9gK5ltCsmm/S4dRAq5QBPDT7FBQoXYqlOS6eUWd8yK3CbodjLZK7QfBKX/X4I994pUf6AmfUJIG4wBzxjy0B8w/mv4Fs6yA0X1fPX6pIhqxCgt4/bjiiIlVEzr5sG5XcZIocX9732dO8exG0+9GImHrWsniRO5sZ9lSwq384pfbvdpywwhjF8wLSOKHdnGZmKkHRqhg/S3GFFpg7bZwNdAoCMjEmVbpY+FKHRLeVjdEl/Yjy4P0R1N8UEIvOtwYspHyCiE7tkAUJLdbLWTHa1nfg1H3bsEHCu1rw8IkCUlnTdfyZ/0aCwGA=; 5:HFiqGcSIOBRNc274KbQwIB+8tzazaVMpjOLgnWdu6YE6GksR+1jHsqNPmf2DpE3nfXLuhcvploFhMMl3GsRT7TYy5d3DcfedKbwtr6AhrNtg6U/CyyOgDczgeEnR4KNEJu6qpNXyc7UaApNVnuA6uF1/VWGALYf8voUKhngWkGc=; 24:1SI3D6G1CS/rmhbaRwjKT59MJ4suLv6SmoYhgab79fvniYSZAByducpPy/XhjnvEsbMIZbFb7j0k5nshLMVW8KhkraBedskpBp74iG31yH0=; 7:/T+lMheJghSMHpn7Se1Op/7aKxCCBiWIGeTo+HK9OHhPcIhF01BGDLEqqco5h3+ES4JbVn5n95mmvTH2tgTBt4eRBEAi2q7fgXi6ygQvR5EN1xnd7deNgs421VRxXpMBCApaUl1Of38zKAcubvaqoOx0P8FkBdihIiwVhFiStGJb3I7fPTHhVB1WiPF3IcXaAytkFmgi/P0MkO5DFnXaxHoJ34qBgkjsRtONEdLRN+Afk8NtyAk7GTL4dB/x6Web SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2018 20:08:39.6082 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 08426d31-1ec0-46da-d7fe-08d559f84673 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0501MB2006 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Emil reported the following compiler errors: net/ipv6/route.c: In function `rt6_sync_up`: net/ipv6/route.c:3586: error: unknown field `nh_flags` specified in initializer net/ipv6/route.c:3586: warning: missing braces around initializer net/ipv6/route.c:3586: warning: (near initialization for `arg.`) net/ipv6/route.c: In function `rt6_sync_down_dev`: net/ipv6/route.c:3695: error: unknown field `event` specified in initializer net/ipv6/route.c:3695: warning: missing braces around initializer net/ipv6/route.c:3695: warning: (near initialization for `arg.`) Problem is with the named initializers for the anonymous union members. Fix this by adding curly braces around the initialization. Fixes: 4c981e28d373 ("ipv6: Prepare to handle multiple netdev events") Signed-off-by: Ido Schimmel Reported-by: Emil S Tantilov Tested-by: Emil S Tantilov --- net/ipv6/route.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 1076ae0ea9d5..c37bd9569172 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -3583,7 +3583,9 @@ void rt6_sync_up(struct net_device *dev, unsigned int nh_flags) { struct arg_netdev_event arg = { .dev = dev, - .nh_flags = nh_flags, + { + .nh_flags = nh_flags, + }, }; if (nh_flags & RTNH_F_DEAD && netif_carrier_ok(dev)) @@ -3692,7 +3694,9 @@ void rt6_sync_down_dev(struct net_device *dev, unsigned long event) { struct arg_netdev_event arg = { .dev = dev, - .event = event, + { + .event = event, + }, }; fib6_clean_all(dev_net(dev), fib6_ifdown, &arg);