From patchwork Mon Feb 22 00:24:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= X-Patchwork-Id: 1442910 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-pci-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DkNJ72q9Hz9sBy for ; Mon, 22 Feb 2021 11:25:43 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230019AbhBVAZ0 (ORCPT ); Sun, 21 Feb 2021 19:25:26 -0500 Received: from mail-lj1-f172.google.com ([209.85.208.172]:38568 "EHLO mail-lj1-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229998AbhBVAZY (ORCPT ); Sun, 21 Feb 2021 19:25:24 -0500 Received: by mail-lj1-f172.google.com with SMTP id e8so14365799ljj.5 for ; Sun, 21 Feb 2021 16:25:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=9/W5vqXLuXygQbp7Hfjhi2yf9xNJ/W2qyUcwlafWXcg=; b=LE0etKqsnGKU+PxdKMM3MephYv1jOepnhZMDU1S08E8RuT1bu7XPyGYGLiP2k0xlAp Nw3qRMJraNiPl7qGxKmV2SzUwidWT0b+0zI4rb8a/cnrUTCismRpUf+l93GRgUbYBXva nxHwIRJPiRMvgTeds28iIofy/lo+vqUte8FWb98qVoOCX8Vl8SJqX1qruXDZuVp2A7ap dawsQ0WYXORSC6h4SDeKmdHk14owkG3u335JAXEdnMaBHmsRq+CEazzdIz6L8LSIjMyB ZUnAWTFHFq5zMaqNYc6G8ymxxhfCuYM0gq0ohidogx9EqJ8vk3GZIQoDBvqZwVSzK2PG oE1Q== X-Gm-Message-State: AOAM532s8HIbo/MCMw6v35/zFFtVV1+bY/ckOmfwZJufchN6WWESsy8M CeLX1J3OC6WPMiWFJXUFpw4J4FvBKp3WPw== X-Google-Smtp-Source: ABdhPJxus68CwgPG4T6MWq54NBDNsO7K2R0UMnvzfGqH9se8c/2+oskit5dGN+QT57NT9f2knHRX/g== X-Received: by 2002:a2e:b012:: with SMTP id y18mr5144563ljk.466.1613953479946; Sun, 21 Feb 2021 16:24:39 -0800 (PST) Received: from workstation.lan ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id 194sm1710400lfo.263.2021.02.21.16.24.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Feb 2021 16:24:39 -0800 (PST) From: =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= To: Bjorn Helgaas Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "Oliver O'Halloran" , Russell Currey , Borislav Petkov , Kai-Heng Feng , Colin Ian King , Myron Stowe , x86@kernel.org, linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Bjorn Helgaas Subject: [PATCH v2] PCI: Convert enum pci_bus_flags to bit fields in struct pci_bus Date: Mon, 22 Feb 2021 00:24:38 +0000 Message-Id: <20210222002438.2209091-1-kw@linux.com> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org All the flags defined in the enum pci_bus_flags are used to determine whether a particular feature of a PCI bus is available or not - features are also often disabled via architecture or device-specific quirk. These flags are tightly coupled with a PCI buses and PCI bridges and primarily used in simple binary on/off manner to check whether something is enabled or disabled, and have almost no other users (with an exception of the x86 architecture-specific quirk) outside of the PCI device drivers space. Therefore, convert enum pci_bus_flags into a set of bit fields in the struct pci_bus, and then drop said enum and the typedef pci_bus_flags_t. This will keep PCI device-specific features as part of the struct pci_dev and make the code that used to use flags simpler. Suggested-by: Bjorn Helgaas Signed-off-by: Krzysztof Wilczyński --- Changes in v2: Rebased against kernel 5.11. arch/x86/pci/fixup.c | 6 +++--- drivers/pci/msi.c | 8 ++++---- drivers/pci/pci-sysfs.c | 14 ++++++-------- drivers/pci/pci.c | 2 +- drivers/pci/pcie/aer.c | 5 ++--- drivers/pci/probe.c | 13 +++++++++---- drivers/pci/quirks.c | 16 ++++++++-------- include/linux/pci.h | 20 ++++++++++---------- 8 files changed, 43 insertions(+), 41 deletions(-) diff --git a/arch/x86/pci/fixup.c b/arch/x86/pci/fixup.c index 0a0e168be1cb..a43316ced8ab 100644 --- a/arch/x86/pci/fixup.c +++ b/arch/x86/pci/fixup.c @@ -641,14 +641,14 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x8c10, quirk_apple_mbp_poweroff); * ID, the AER driver should traverse the child device tree, reading * AER registers to find the faulting device. */ -static void quirk_no_aersid(struct pci_dev *pdev) +static void quirk_no_aer_sid(struct pci_dev *pdev) { /* VMD Domain */ if (is_vmd(pdev->bus) && pci_is_root_bus(pdev->bus)) - pdev->bus->bus_flags |= PCI_BUS_FLAGS_NO_AERSID; + pdev->bus->no_aer_sid = 1; } DECLARE_PCI_FIXUP_CLASS_EARLY(PCI_VENDOR_ID_INTEL, PCI_ANY_ID, - PCI_CLASS_BRIDGE_PCI, 8, quirk_no_aersid); + PCI_CLASS_BRIDGE_PCI, 8, quirk_no_aer_sid); static void quirk_intel_th_dnv(struct pci_dev *dev) { diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c index 3162f88fe940..134ddf20bde8 100644 --- a/drivers/pci/msi.c +++ b/drivers/pci/msi.c @@ -899,13 +899,13 @@ static int pci_msi_supported(struct pci_dev *dev, int nvec) /* * Any bridge which does NOT route MSI transactions from its - * secondary bus to its primary bus must set NO_MSI flag on - * the secondary pci_bus. + * secondary bus to its primary bus must enable "no_msi" on + * the secondary bus (pci_bus). * We expect only arch-specific PCI host bus controller driver - * or quirks for specific PCI bridges to be setting NO_MSI. + * or quirks for specific PCI bridges to enable "no_msi". */ for (bus = dev->bus; bus; bus = bus->parent) - if (bus->bus_flags & PCI_BUS_FLAGS_NO_MSI) + if (bus->no_msi) return 0; return 1; diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c index fb072f4b3176..414727551660 100644 --- a/drivers/pci/pci-sysfs.c +++ b/drivers/pci/pci-sysfs.c @@ -366,9 +366,7 @@ static ssize_t msi_bus_show(struct device *dev, struct device_attribute *attr, struct pci_dev *pdev = to_pci_dev(dev); struct pci_bus *subordinate = pdev->subordinate; - return sprintf(buf, "%u\n", subordinate ? - !(subordinate->bus_flags & PCI_BUS_FLAGS_NO_MSI) - : !pdev->no_msi); + return sprintf(buf, "%u\n", subordinate ? !subordinate->no_msi : !pdev->no_msi); } static ssize_t msi_bus_store(struct device *dev, struct device_attribute *attr, @@ -385,9 +383,9 @@ static ssize_t msi_bus_store(struct device *dev, struct device_attribute *attr, return -EPERM; /* - * "no_msi" and "bus_flags" only affect what happens when a driver - * requests MSI or MSI-X. They don't affect any drivers that have - * already requested MSI or MSI-X. + * "no_msi" enabled for device and bus only affect what happens + * when a driver requests MSI or MSI-X. They don't affect any + * drivers that have already requested MSI or MSI-X. */ if (!subordinate) { pdev->no_msi = !val; @@ -397,9 +395,9 @@ static ssize_t msi_bus_store(struct device *dev, struct device_attribute *attr, } if (val) - subordinate->bus_flags &= ~PCI_BUS_FLAGS_NO_MSI; + subordinate->no_msi = 0; else - subordinate->bus_flags |= PCI_BUS_FLAGS_NO_MSI; + subordinate->no_msi = 1; dev_info(&subordinate->dev, "MSI/MSI-X %s for future drivers of devices on this bus\n", val ? "allowed" : "disallowed"); diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 790393d1e318..803c2c7b0808 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -5694,7 +5694,7 @@ int pcix_set_mmrbc(struct pci_dev *dev, int mmrbc) o = (cmd & PCI_X_CMD_MAX_READ) >> 2; if (o != v) { - if (v > o && (dev->bus->bus_flags & PCI_BUS_FLAGS_NO_MMRBC)) + if (v > o && dev->bus->no_mmrbc) return -EIO; cmd &= ~PCI_X_CMD_MAX_READ; diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c index 77b0f2c45bc0..b164d6df720f 100644 --- a/drivers/pci/pcie/aer.c +++ b/drivers/pci/pcie/aer.c @@ -829,8 +829,7 @@ static bool is_error_source(struct pci_dev *dev, struct aer_err_info *e_info) * When bus id is equal to 0, it might be a bad id * reported by root port. */ - if ((PCI_BUS_NUM(e_info->id) != 0) && - !(dev->bus->bus_flags & PCI_BUS_FLAGS_NO_AERSID)) { + if (PCI_BUS_NUM(e_info->id) != 0 && !dev->bus->no_aer_sid) { /* Device ID match? */ if (e_info->id == ((dev->bus->number << 8) | dev->devfn)) return true; @@ -844,7 +843,7 @@ static bool is_error_source(struct pci_dev *dev, struct aer_err_info *e_info) * When either * 1) bus id is equal to 0. Some ports might lose the bus * id of error source id; - * 2) bus flag PCI_BUS_FLAGS_NO_AERSID is set + * 2) bus has "no_aer_sid" enabled * 3) There are multiple errors and prior ID comparing fails; * We check AER status registers to find possible reporter. */ diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index 953f15abc850..081e130d1cbd 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -1009,7 +1009,7 @@ static bool pci_bridge_child_ext_cfg_accessible(struct pci_dev *bridge) * If extended config space isn't accessible on a bridge's primary * bus, we certainly can't access it on the secondary bus. */ - if (bridge->bus->bus_flags & PCI_BUS_FLAGS_NO_EXTCFG) + if (bridge->bus->no_ext_cfg) return false; /* @@ -1055,7 +1055,12 @@ static struct pci_bus *pci_alloc_child_bus(struct pci_bus *parent, child->parent = parent; child->msi = parent->msi; child->sysdata = parent->sysdata; - child->bus_flags = parent->bus_flags; + + /* PCI bus flags */ + child->no_msi = parent->no_msi; + child->no_mmrbc = parent->no_mmrbc; + child->no_aer_sid = parent->no_aer_sid; + child->no_ext_cfg = parent->no_ext_cfg; host = pci_find_host_bridge(parent); if (host->child_ops) @@ -1092,7 +1097,7 @@ static struct pci_bus *pci_alloc_child_bus(struct pci_bus *parent, * the root bus. */ if (!pci_bridge_child_ext_cfg_accessible(bridge)) { - child->bus_flags |= PCI_BUS_FLAGS_NO_EXTCFG; + child->no_ext_cfg = 1; pci_info(child, "extended config space not accessible\n"); } @@ -1657,7 +1662,7 @@ int pci_cfg_space_size(struct pci_dev *dev) return PCI_CFG_SPACE_EXP_SIZE; #endif - if (dev->bus->bus_flags & PCI_BUS_FLAGS_NO_EXTCFG) + if (dev->bus->no_ext_cfg) return PCI_CFG_SPACE_SIZE; class = dev->class >> 8; diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index 653660e3ba9e..134ca3bca916 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c @@ -1052,7 +1052,7 @@ static void quirk_amd_8131_mmrbc(struct pci_dev *dev) if (dev->subordinate && dev->revision <= 0x12) { pci_info(dev, "AMD8131 rev %x detected; disabling PCI-X MMRBC\n", dev->revision); - dev->subordinate->bus_flags |= PCI_BUS_FLAGS_NO_MMRBC; + dev->subordinate->no_mmrbc = 1; } } DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_8131_BRIDGE, quirk_amd_8131_mmrbc); @@ -2503,10 +2503,10 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82875_HB, #ifdef CONFIG_PCI_MSI /* - * Some chipsets do not support MSI. We cannot easily rely on setting - * PCI_BUS_FLAGS_NO_MSI in its bus flags because there are actually some - * other buses controlled by the chipset even if Linux is not aware of it. - * Instead of setting the flag on all buses in the machine, simply disable + * Some chipsets do not support MSI. We cannot easily rely on enabling + * "no_msi" for its bus because there are actually some other buses + * controlled by the chipset even if Linux is not aware of it. Instead + * of enabling "no_msi" on all buses in the machine, simply disable * MSI globally. */ static void quirk_disable_all_msi(struct pci_dev *dev) @@ -2529,7 +2529,7 @@ static void quirk_disable_msi(struct pci_dev *dev) { if (dev->subordinate) { pci_warn(dev, "MSI quirk detected; subordinate MSI disabled\n"); - dev->subordinate->bus_flags |= PCI_BUS_FLAGS_NO_MSI; + dev->subordinate->no_msi = 1; } } DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_8131_BRIDGE, quirk_disable_msi); @@ -2587,7 +2587,7 @@ static void quirk_msi_ht_cap(struct pci_dev *dev) { if (dev->subordinate && !msi_ht_cap_enabled(dev)) { pci_warn(dev, "MSI quirk detected; subordinate MSI disabled\n"); - dev->subordinate->bus_flags |= PCI_BUS_FLAGS_NO_MSI; + dev->subordinate->no_msi = 1; } } DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_SERVERWORKS, PCI_DEVICE_ID_SERVERWORKS_HT2000_PCIE, @@ -2613,7 +2613,7 @@ static void quirk_nvidia_ck804_msi_ht_cap(struct pci_dev *dev) return; if (!msi_ht_cap_enabled(dev) && !msi_ht_cap_enabled(pdev)) { pci_warn(dev, "MSI quirk detected; subordinate MSI disabled\n"); - dev->subordinate->bus_flags |= PCI_BUS_FLAGS_NO_MSI; + dev->subordinate->no_msi = 1; } pci_dev_put(pdev); } diff --git a/include/linux/pci.h b/include/linux/pci.h index b32126d26997..f4c6cb618c0a 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -234,14 +234,6 @@ enum pci_irq_reroute_variant { MAX_IRQ_REROUTE_VARIANTS = 3 }; -typedef unsigned short __bitwise pci_bus_flags_t; -enum pci_bus_flags { - PCI_BUS_FLAGS_NO_MSI = (__force pci_bus_flags_t) 1, - PCI_BUS_FLAGS_NO_MMRBC = (__force pci_bus_flags_t) 2, - PCI_BUS_FLAGS_NO_AERSID = (__force pci_bus_flags_t) 4, - PCI_BUS_FLAGS_NO_EXTCFG = (__force pci_bus_flags_t) 8, -}; - /* Values from Link Status register, PCIe r3.1, sec 7.8.8 */ enum pcie_link_width { PCIE_LNK_WIDTH_RESRV = 0x00, @@ -636,12 +628,20 @@ struct pci_bus { char name[48]; unsigned short bridge_ctl; /* Manage NO_ISA/FBB/et al behaviors */ - pci_bus_flags_t bus_flags; /* Inherited by child buses */ struct device *bridge; struct device dev; struct bin_attribute *legacy_io; /* Legacy I/O for this bus */ struct bin_attribute *legacy_mem; /* Legacy mem */ - unsigned int is_added:1; + unsigned int is_added:1; /* This bus has already been registered */ + + /* PCI bus flags are inherited by child buses */ + unsigned int no_msi:1; /* Don't use MSI/MSI-X for devices behind a bridge that does not route + MSI transactions from its secondary bus to its primary bus */ + unsigned int no_mmrbc:1; /* Disallow setting PCI-X Maximum Memory Read Byte Count on this bus */ + unsigned int no_aer_sid:1; /* Allow Root Port buses to skip the AER source ID matching when finding + the faulting device */ + unsigned int no_ext_cfg:1; /* Don't use PCIe/PCI-X Mode 2 Extended Configuration Space + when it isn't available on bridge's primary bus */ }; #define to_pci_bus(n) container_of(n, struct pci_bus, dev)