From patchwork Fri Jan 12 11:38:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 859786 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pwm-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zJ12k3ylxz9t3B for ; Fri, 12 Jan 2018 22:38:06 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754514AbeALLiF (ORCPT ); Fri, 12 Jan 2018 06:38:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54348 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754403AbeALLiE (ORCPT ); Fri, 12 Jan 2018 06:38:04 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1617FDF3E; Fri, 12 Jan 2018 11:38:04 +0000 (UTC) Received: from shalem.localdomain.com (ovpn-116-201.ams2.redhat.com [10.36.116.201]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1C3D2600C8; Fri, 12 Jan 2018 11:38:02 +0000 (UTC) From: Hans de Goede To: Thierry Reding , Andy Shevchenko Cc: Hans de Goede , linux-pwm@vger.kernel.org Subject: [PATCH] pwm: lpss-platform: Cleanly exit probe on boards without resources Date: Fri, 12 Jan 2018 12:38:02 +0100 Message-Id: <20180112113802.3888-1-hdegoede@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 12 Jan 2018 11:38:04 +0000 (UTC) Sender: linux-pwm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org Some boards which do not use the pwm-controller have an empty or invalid resource-table in ACPI the for pwm-controller. Currently this causes these error messages to get logged: [ 3.281966] pwm-lpss 80862288:00: invalid resource [ 3.287098] pwm-lpss: probe of 80862288:00 failed with error -22 This commit silences these error messages on these boards by cleanly exiting pwm_lpss_probe_platform() if there is no memory resource. Signed-off-by: Hans de Goede --- drivers/pwm/pwm-lpss-platform.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/pwm/pwm-lpss-platform.c b/drivers/pwm/pwm-lpss-platform.c index 5d6ed1507d29..5e5f4d018178 100644 --- a/drivers/pwm/pwm-lpss-platform.c +++ b/drivers/pwm/pwm-lpss-platform.c @@ -52,7 +52,14 @@ static int pwm_lpss_probe_platform(struct platform_device *pdev) return -ENODEV; info = (const struct pwm_lpss_boardinfo *)id->driver_data; + + /* + * Some boards which don't use the pwm controller have an empty + * resources table, so if we cannot get the resource, return -ENODEV. + */ r = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!r) + return -ENODEV; lpwm = pwm_lpss_probe(&pdev->dev, r, info); if (IS_ERR(lpwm))