From patchwork Sun Feb 7 15:07:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pedro Guimaraes X-Patchwork-Id: 1439381 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.136; helo=smtp3.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DbsTG3Z2Nz9sS8 for ; Thu, 11 Feb 2021 20:55:59 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 157D66F530 for ; Thu, 11 Feb 2021 09:55:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LsRbiC_HIh64 for ; Thu, 11 Feb 2021 09:55:57 +0000 (UTC) Received: by smtp3.osuosl.org (Postfix, from userid 1001) id 5928D6F532; Thu, 11 Feb 2021 09:55:56 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTP id 3CDCB6F49E; Thu, 11 Feb 2021 09:55:47 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 0F9EBC0174; Thu, 11 Feb 2021 09:55:47 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 879ABC013A for ; Thu, 11 Feb 2021 09:55:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 6DFBF87364 for ; Thu, 11 Feb 2021 09:55:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dsCbKX2DxTqg for ; Thu, 11 Feb 2021 09:55:45 +0000 (UTC) X-Greylist: delayed 00:06:05 by SQLgrey-1.7.6 Received: from ti0189a330-0925.bb.online.no (ti0189a330-0925.bb.online.no [88.88.218.161]) by whitealder.osuosl.org (Postfix) with ESMTP id 84A3B8732E for ; Thu, 11 Feb 2021 09:55:28 +0000 (UTC) X-Mailbox-Line: From f061946677e5ffbcae3ffc82a019e53e8e69e8ea Mon Sep 17 00:00:00 2001 From: Pedro Guimaraes To: dev@openvswitch.org Date: Sun, 7 Feb 2021 16:07:08 +0100 Message-Id: <20210211095546.6DFBF87364@whitealder.osuosl.org> Subject: [ovs-dev] [PATCH ovn] Add IGMP_Group to ovn-controller RBAC X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" If RBAC and IGMP snooping are enabled, ovn-controllers need to be able to register new entries to table IGMP_Group as requests are detected. For that, ovn-controllers need to have read/write access to IGMP_Group table. Signed-off-by: Pedro Guimaraes Reported-at: https://github.com/ovn-org/ovn/issues/77 Acked-by: Frode Nordahl --- northd/ovn-northd.c | 12 ++++++++++++ ovn-architecture.7.xml | 16 ++++++++++++++++ 2 files changed, 28 insertions(+) diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c index b2b5f6a1b..39d798782 100644 --- a/northd/ovn-northd.c +++ b/northd/ovn-northd.c @@ -13009,6 +13009,10 @@ static const char *rbac_svc_monitor_auth[] = {""}; static const char *rbac_svc_monitor_auth_update[] = {"status"}; +static const char *rbac_igmp_group_auth[] = + {""}; +static const char *rbac_igmp_group_update[] = + {"address", "chassis", "datapath", "ports"}; static struct rbac_perm_cfg { const char *table; @@ -13067,6 +13071,14 @@ static struct rbac_perm_cfg { .update = rbac_svc_monitor_auth_update, .n_update = ARRAY_SIZE(rbac_svc_monitor_auth_update), .row = NULL + },{ + .table = "IGMP_Group", + .auth = rbac_igmp_group_auth, + .n_auth = ARRAY_SIZE(rbac_igmp_group_auth), + .insdel = true, + .update = rbac_igmp_group_update, + .n_update = ARRAY_SIZE(rbac_igmp_group_update), + .row = NULL },{ .table = NULL, .auth = NULL, diff --git a/ovn-architecture.7.xml b/ovn-architecture.7.xml index e5c9f9549..0eef9b739 100644 --- a/ovn-architecture.7.xml +++ b/ovn-architecture.7.xml @@ -2597,6 +2597,22 @@ modified by ovn-controller.

+ +
IGMP_Group
+
+

+ Authorization: disabled (all clients are considered + to be authorized). +

+

+ Insert/Delete: row insertion/deletion are permitted. +

+

+ Update: The columns address, + chassis, datapath, and + ports may be modified by ovn-controller. +

+