From patchwork Fri Feb 5 04:26:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?Z21pbmdjaGVuKOmZiOS+m+aYjik=?= X-Patchwork-Id: 1436803 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.138; helo=whitealder.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=tencent.com header.i=@tencent.com header.a=rsa-sha256 header.s=s202002 header.b=epiQYMyM; dkim-atps=neutral Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DXNbt4Fqnz9rx6 for ; Sat, 6 Feb 2021 05:04:41 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 7E4B9872F8; Fri, 5 Feb 2021 18:04:39 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TaVopmZcFwSe; Fri, 5 Feb 2021 18:04:35 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id B97DE872DE; Fri, 5 Feb 2021 18:04:35 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 9EE6AC08A1; Fri, 5 Feb 2021 18:04:35 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 24AB0C0174 for ; Fri, 5 Feb 2021 04:46:11 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 17384872DB for ; Fri, 5 Feb 2021 04:46:11 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5s4CFgPnNbkF for ; Fri, 5 Feb 2021 04:46:01 +0000 (UTC) X-Greylist: delayed 00:09:58 by SQLgrey-1.7.6 Received: from mail6.tencent.com (mail6.tencent.com [220.249.245.26]) by hemlock.osuosl.org (Postfix) with ESMTPS id 388DF872D6 for ; Fri, 5 Feb 2021 04:46:00 +0000 (UTC) Received: from EX-SZ020.tencent.com (unknown [10.28.6.40]) by mail6.tencent.com (Postfix) with ESMTP id 65D33CEB11 for ; Fri, 5 Feb 2021 12:26:50 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tencent.com; s=s202002; t=1612499210; bh=pAmUfaTPXfe4YhvYuB2BPcVfc+27xZF43A3WIv6CWDk=; h=From:To:Subject:Date; b=epiQYMyMKYyxe1AwpvQyGhgo+8g9bUheD8RaonpVCIAGdrTRt97IcEB0vrR3hhSLD ik1+YZH9/FRzOr7xlk3vwvY2e7i9rcHMZaJxTmW3ToceC1GN4UvLjaOP+YkLVScP7w fUdRO3acflQjW78PvTl514xa9B/Lp6Xy0zmsopi0= Received: from EX-SZ006.tencent.com (10.28.6.30) by EX-SZ020.tencent.com (10.28.6.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Fri, 5 Feb 2021 12:26:50 +0800 Received: from EX-SZ004.tencent.com (10.28.6.25) by EX-SZ006.tencent.com (10.28.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Fri, 5 Feb 2021 12:26:50 +0800 Received: from EX-SZ004.tencent.com ([fe80::5deb:928d:fe5e:850d]) by EX-SZ004.tencent.com ([fe80::5deb:928d:fe5e:850d%8]) with mapi id 15.01.2106.002; Fri, 5 Feb 2021 12:26:50 +0800 From: =?utf-8?b?Z21pbmdjaGVuKOmZiOS+m+aYjik=?= To: "ovs-dev@openvswitch.org" Thread-Topic: [ovs-dev] [PATCH ovn] tests: Fix Port_Binding up test. Thread-Index: AQHW+3cf0SZAlzWlAk+RY6HiJbF01g== Date: Fri, 5 Feb 2021 04:26:49 +0000 Message-ID: <25EABDC7-0F9B-46CD-90B0-BF72EF7EA2B0@tencent.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.99.16.17] MIME-Version: 1.0 X-Mailman-Approved-At: Fri, 05 Feb 2021 18:04:34 +0000 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: [ovs-dev] [PATCH ovn] tests: Fix Port_Binding up test. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" After setting the iface-id, immediately check the up status of the port binding, it will occasionally fail, especially when the port binding status is reported later. When it fails, the following will be output: Checking values in sb Port_Binding with logical_port=lsp1 against false... found false ovs-vsctl add-port br-int lsp1 -- set Interface lsp1 external-ids:iface-id=lsp1 ./ovn-macros.at:307: "$@" Checking values in sb Port_Binding with logical_port=lsp1 against true... found false _uuid : 15ebabb6-3dbb-4806-aa85-d1c03e3b39f6 logical_port : lsp1 up : true ./ovn-macros.at:393: hard failure Fixes: 4d3cb42b076b("binding: Set Logical_Switch_Port.up when all OVS flows are installed") Signed-off-by: Gongming Chen --- tests/ovn.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dev mailing list dev@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev diff --git a/tests/ovn.at b/tests/ovn.at index 80c9fe138..43dc16dd8 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -23885,7 +23885,7 @@ check ovn-nbctl --wait=hv sync check_column "false" Port_Binding up logical_port=lsp1 check ovs-vsctl add-port br-int lsp1 -- set Interface lsp1 external-ids:iface-id=lsp1 -check_column "true" Port_Binding up logical_port=lsp1 +wait_column "true" Port_Binding up logical_port=lsp1 wait_column "true" nb:Logical_Switch_Port up name=lsp1 OVS_WAIT_UNTIL([test `ovs-vsctl get Interface lsp1 external_ids:ovn-installed` = '"true"']) _______________________________________________