From patchwork Thu Jan 11 18:00:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 859222 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zHYcd5V6hz9ryQ for ; Fri, 12 Jan 2018 05:02:25 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3zHYcd46B5zF0gF for ; Fri, 12 Jan 2018 05:02:25 +1100 (AEDT) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=users.sourceforge.net (client-ip=212.227.15.3; helo=mout.web.de; envelope-from=elfring@users.sourceforge.net; receiver=) Received: from mout.web.de (mout.web.de [212.227.15.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3zHYZs5gQ1zF0dJ for ; Fri, 12 Jan 2018 05:00:53 +1100 (AEDT) Received: from [192.168.1.3] ([92.227.255.105]) by smtp.web.de (mrweb004 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MHdwC-1eancN0jca-003MPq; Thu, 11 Jan 2018 19:00:35 +0100 Subject: [PATCH 1/5] powerpc/4xx: Combine four seq_printf() calls into two in ocm_debugfs_show() From: SF Markus Elfring To: linuxppc-dev@lists.ozlabs.org, Benjamin Herrenschmidt , Michael Ellerman , Paul Mackerras , Rob Herring , Tyrel Datwyler References: <2b9b4285-f1c0-5dc7-35c6-df901c9ca0eb@users.sourceforge.net> Message-ID: <90e9f81b-25ad-cf02-663c-50a9997d9d53@users.sourceforge.net> Date: Thu, 11 Jan 2018 19:00:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <2b9b4285-f1c0-5dc7-35c6-df901c9ca0eb@users.sourceforge.net> Content-Language: en-GB X-Provags-ID: V03:K0:+kYZSVXMk1tj7XCllKmTfnWwx9D91EaB4oeOxD+O7lUDhutADC0 1FAxVlW8F2yHPe6QICguq8XdH9PMvniRejFVSWsJWmv0lT4+tibzXR0yaWJzPnRMJJNBcwV igBygQoOrDacNhkBa6uEKFpbFn8b8MFL0LZ/AGMIr5eEPqzhZNioEAN56KUC9k4O2iKKq3+ 3FH2O4ayb/WIOkw4RGJoQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:Jrkm8Q/qUwo=:IFdDljf/O7oCzZsPZzFWbt OuMcZtgFQ8fx6tqidjuYDX3bvYZO/5w5JyXxPsMUjPbTZB1cuFC27r9x2YGt6oj3dNJL5RwXP 4MdT5qbM4Qcb9No0SfbiROZLJhQxUQ+6GosVNdRDbqnYQ8m/UV2H7BQgSi/wyth+69JVynb/C o8JK3k6/6SCWJbLpKFJZUTvV2OxzHqgkSLFBBzRMECUA2IaC6cd6YRRnPsrY6moG5gE912uXv rA9B6GlIzVl8e/aTYBHNx6vj7lgmQj9wrWmPmNTUdj9arRdL3Ke6OL6a9nn1BACyNpjL8upmN 0bmhYJNPjN8FSC5zP7nTgc5iD7HaFquZxUg1N40dCETV5mgYsvjDtihIvVqIpGJtrpzu2u2et BUjRa7hiv8f7oWtYys6Kf7nv9zSzsFqwraabuk9HCJPMcps9+2xo/Tnsm2PQuagQXm7sXVOrS q4HT2AS9NiCL0fRNSqm96NR5ehFBUuEKTZgprMauCJ64pwp9R+flFIS3JvHhQWEt45Oiob98l JEvduOjPNPvc2uKDZ4DDS/vsokJ7EHVLkWSs0nZNQ502yPjRQy5UuGIxRtfMIG4eiv1zGdlUF bw2nWZF6hAOx+pMiR2wgb7ZyKk+j4AdjeoRTkENNpNqEGUsyl8vwKBRtEG8P4LQhdRPeiFd/n uqy2Y9lhmYGP53Qtm4A6PEWvtFB1RPyfxu3RMONtuGI3ZrfAUw5/hOWJm9kZaZpWU6UgX2pYE gbONoEpCoM8ict1dVI+v6kNDHdaW6mIbb2Ami+M5dFD56rgQg7UoBhx/bgHzvCgxtUAO1pL2J bhb9Ppy9wkAXtzBCatKqLSJl3Nau0bb3QyJuNnYdttFmy0cL+4= X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, LKML Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Markus Elfring Date: Thu, 11 Jan 2018 18:08:08 +0100 Some data were printed into a sequence by four separate function calls. Print the same data by two single function calls instead. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- arch/powerpc/platforms/4xx/ocm.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/arch/powerpc/platforms/4xx/ocm.c b/arch/powerpc/platforms/4xx/ocm.c index 85d9e37f5ccb..5bc1baf809d1 100644 --- a/arch/powerpc/platforms/4xx/ocm.c +++ b/arch/powerpc/platforms/4xx/ocm.c @@ -245,9 +245,7 @@ static int ocm_debugfs_show(struct seq_file *m, void *v) seq_printf(m, "PhysAddr : 0x%llx\n", ocm->phys); seq_printf(m, "MemTotal : %d Bytes\n", ocm->memtotal); seq_printf(m, "MemTotal(NC) : %d Bytes\n", ocm->nc.memtotal); - seq_printf(m, "MemTotal(C) : %d Bytes\n", ocm->c.memtotal); - - seq_printf(m, "\n"); + seq_printf(m, "MemTotal(C) : %d Bytes\n\n", ocm->c.memtotal); seq_printf(m, "NC.PhysAddr : 0x%llx\n", ocm->nc.phys); seq_printf(m, "NC.VirtAddr : 0x%p\n", ocm->nc.virt); @@ -259,9 +257,7 @@ static int ocm_debugfs_show(struct seq_file *m, void *v) blk->size, blk->owner); } - seq_printf(m, "\n"); - - seq_printf(m, "C.PhysAddr : 0x%llx\n", ocm->c.phys); + seq_printf(m, "\nC.PhysAddr : 0x%llx\n", ocm->c.phys); seq_printf(m, "C.VirtAddr : 0x%p\n", ocm->c.virt); seq_printf(m, "C.MemTotal : %d Bytes\n", ocm->c.memtotal); seq_printf(m, "C.MemFree : %d Bytes\n", ocm->c.memfree); From patchwork Thu Jan 11 18:01:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 859223 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zHYfs54pSz9ryQ for ; Fri, 12 Jan 2018 05:04:21 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3zHYfs3MjTzF0Xb for ; Fri, 12 Jan 2018 05:04:21 +1100 (AEDT) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=users.sourceforge.net (client-ip=212.227.15.14; helo=mout.web.de; envelope-from=elfring@users.sourceforge.net; receiver=) Received: from mout.web.de (mout.web.de [212.227.15.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3zHYc22LP0zF0fb for ; Fri, 12 Jan 2018 05:01:53 +1100 (AEDT) Received: from [192.168.1.3] ([92.227.255.105]) by smtp.web.de (mrweb003 [213.165.67.108]) with ESMTPSA (Nemesis) id 0LkhAC-1f7eTT2RD2-00aYHN; Thu, 11 Jan 2018 19:01:35 +0100 Subject: [PATCH 2/5] powerpc/4xx: Use seq_putc() in ocm_debugfs_show() From: SF Markus Elfring To: linuxppc-dev@lists.ozlabs.org, Benjamin Herrenschmidt , Michael Ellerman , Paul Mackerras , Rob Herring , Tyrel Datwyler References: <2b9b4285-f1c0-5dc7-35c6-df901c9ca0eb@users.sourceforge.net> Message-ID: <400b7f67-bd62-9f5f-228b-9633c23671d7@users.sourceforge.net> Date: Thu, 11 Jan 2018 19:01:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <2b9b4285-f1c0-5dc7-35c6-df901c9ca0eb@users.sourceforge.net> Content-Language: en-GB X-Provags-ID: V03:K0:Kfe/2L0SlUKuJAagEdjPSGiwokhHA3ZbAXLLu3lFY8RdYBYtRRb Y+/+hcAA11RO++DzGAAZ6Rb0Ui5UE+Zh/c7J8yUFZhS8n6khIwFoxyTJhQusGQUXibIQoPu nQJqsgxwidgLZeHaQoSy5KtVK7le7ES9OIHnxxWytVPNW5FEeaJqSjiaNo2WAb1CHO+jFHv RY7I0kgNojljbM5sdE8Uw== X-UI-Out-Filterresults: notjunk:1; V01:K0:IBc2hkEz3uw=:DYKjR8URC2ey+VbGoOtu0a LGlGm6QpGfEJt9imnga43j2Yk2GpSj8o/aHebfiuVxkAczHGsgVuaaVZpbHW2tPqPav1LMRp1 Z7BhD7V2jKazqL+JSsTa+8ySURrRiVbyU4y2we6DD46WTOhFIhjnRehqVUOCt8PUiwgiYRtL2 VLhKSTvQ3/6IVpkVSFyv9ovlMxQQfIAXIRbrHgB+wRUsHJz7HGSkll0cxMHDe80jRx7xju4Yc grZo4gdYDomel+jDC+m0/vp0Gh04vKvKKpHymcD5MEFW8VhLrTyINpW3caSzdgWyNgmk6pqF+ wPy6jPP2Nk8cHKv8GBwZM2QS2VXtIAs3iwm2qcGviIGptqvdkCIxrINbex+J5P0ParChsKxTG 1PLA47Fj5ikWaoFJt1BNia3BG/NVYJXbH+GJvAuMLttXMY5o10t1LSeKOFG7ltj9SvWCjN37F OXCNx65059zgtee5VGSnMoLqaBNEguJ2xkppcYk64qD6ZrUZD4hs0Tv0ODEVplCNmRj15gCCX V8EhEAttOZ/9+BlHGgtQaCGoYqK56YK3+4xCqqcZqFEiiNo0Ai2OBISenWm8Sb/81FV8v/7fC e3qIelCOtstTznsxDgJycsdg7KOTNHjUg3yUbi0EoeDauTzY1tX6NnMRJ+kRSqbqL19XH+RCL XrLDagvYmQW8jWVRiZsLCD9zmoX2b9Jd0CwgG9FpZL6nr48B+GAszDj95OAW0gisRhxuMklM2 j5Ch/WQ6C2zMfn/jMlMCKOEH2lqf1o4lTxng1HMgRQQjqrto8JaTjzAlgQJNeAObOkUIPSnsl LmZrsw3EDrKgOQ3+cY8pI0gp1kPCr83Js0VqAxcivPTUQWjI2U= X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, LKML Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Markus Elfring Date: Thu, 11 Jan 2018 18:10:02 +0100 A single character (line break) should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- arch/powerpc/platforms/4xx/ocm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/platforms/4xx/ocm.c b/arch/powerpc/platforms/4xx/ocm.c index 5bc1baf809d1..8cb601e8bed7 100644 --- a/arch/powerpc/platforms/4xx/ocm.c +++ b/arch/powerpc/platforms/4xx/ocm.c @@ -267,7 +267,7 @@ static int ocm_debugfs_show(struct seq_file *m, void *v) blk->size, blk->owner); } - seq_printf(m, "\n"); + seq_putc(m, '\n'); } return 0; From patchwork Thu Jan 11 18:02:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 859224 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zHYjH3bnxz9ryQ for ; Fri, 12 Jan 2018 05:06:27 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3zHYjH2Zw6zF0WC for ; Fri, 12 Jan 2018 05:06:27 +1100 (AEDT) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=users.sourceforge.net (client-ip=212.227.15.14; helo=mout.web.de; envelope-from=elfring@users.sourceforge.net; receiver=) Received: from mout.web.de (mout.web.de [212.227.15.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3zHYdP3wwVzF0h7 for ; Fri, 12 Jan 2018 05:03:04 +1100 (AEDT) Received: from [192.168.1.3] ([92.227.255.105]) by smtp.web.de (mrweb001 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MXHt7-1eLAaR1XCH-00WIL8; Thu, 11 Jan 2018 19:02:46 +0100 Subject: [PATCH 3/5] powerpc/4xx: Delete an error message for a failed memory allocation in three functions From: SF Markus Elfring To: linuxppc-dev@lists.ozlabs.org, Benjamin Herrenschmidt , Michael Ellerman , Paul Mackerras , Rob Herring , Tyrel Datwyler References: <2b9b4285-f1c0-5dc7-35c6-df901c9ca0eb@users.sourceforge.net> Message-ID: <92f46132-b654-cc73-a589-4abf8ab3122a@users.sourceforge.net> Date: Thu, 11 Jan 2018 19:02:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <2b9b4285-f1c0-5dc7-35c6-df901c9ca0eb@users.sourceforge.net> Content-Language: en-GB X-Provags-ID: V03:K0:Z+iETydpHlZ79or2o7fPTG5QJ97DQJjVkkdrwbCuZxW1m7k2KcO DGHm6I0NQ3FYXXER7gqXSx5HwXkV610NtK6wcZW0OUeFLng8+xolg+BMUdG3KlEwBEKSX+i WHYG8F8Ch+9uXdEr9srqL1WwmPQW5N/jOWpYCbdvtC7C/Fmm7CD+ZTYVYy6rRBnR7WMX5qf snRUz+9UituvHDtU6jzPg== X-UI-Out-Filterresults: notjunk:1; V01:K0:xnis+3JOaL4=:5ZRT0cvPmlK8wZHZ+SlY76 uaO6qhQM7jvaEO0wEmRNbaukziAkpgUafyYXG/x8MbZ/XcvT3NoPfMwA92y30Ve/Ii72tl0dM /Ej6YPWii2HSX6akygcdwemXACZMg9kPydKs0MFPNIybflo6oY6eMEkgMO3DEMIFBqewcI6cV BmPhnTwZ52r8cxgsjauaUk0YZMnx59CdV90NJY/QbaD/HzikJDECTxH9Ry4Rh2WGqsqD/8BvZ 1dOmq/ApAn5GlQJp6ERozCeyF1YdKZrwu+5/ehXH/TQ6VXr12L+M4bkCFwAQ0FwIC+ZrR+vi4 vPIIsfdHb1JzHvMOOVD5HZ9kgntDjopTNYrJXF/ZuIB+khYuRQK84b+nS8uPHQG2HiddqBxF1 VvPLtgEQ+T8QTinBXaV9doL+t2/cM00yM4TMntFnvh5VyiL7QsIuePY6C7W/iRuAqvISHN5tN A0gXbQ8J6c6AzMkNC46NUXPk5xb3QTJAvMzxGxBgI0bseXd4rp0yY2UNmm885qgDBBRm5B3I0 TZl55i6Ab/jiRvdlAaeb7oJneD7d/S+CYeQlyHmXt7BIGyUBUffZzz+f0G9BL5SVrs0UauYN1 eDnOjGEAs8U5Yj5XUYXDxC2AWUppv+sloFzydHR/lfZu26cHAhkZJZ/WEmf9WqdvNZUiJpDDY xfcmowUxbJq9NNt5B1tw2wRZqiOmQ3caxjZ/rudquMSTPL/Qe4qru2epkD8aUKfPnwNGSG0TI P2qgjdrcFhZ1HZyZk3lfgJTF5j+kksWNzLcvu8ylp8LIeDhRE2msC+nbdly/RQ/6UqJc9KswO VVZS2MoHlULnIMW2OulUAXZ15iVTKPaFxp1JjRjJzxpczQ5tMA= X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, LKML Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Markus Elfring Date: Thu, 11 Jan 2018 18:28:54 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- arch/powerpc/platforms/4xx/msi.c | 5 ++--- arch/powerpc/platforms/4xx/ocm.c | 5 +---- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/arch/powerpc/platforms/4xx/msi.c b/arch/powerpc/platforms/4xx/msi.c index d50417e23add..d16b81303cb0 100644 --- a/arch/powerpc/platforms/4xx/msi.c +++ b/arch/powerpc/platforms/4xx/msi.c @@ -224,10 +224,9 @@ static int ppc4xx_msi_probe(struct platform_device *dev) dev_dbg(&dev->dev, "PCIE-MSI: Setting up MSI support...\n"); msi = kzalloc(sizeof(struct ppc4xx_msi), GFP_KERNEL); - if (!msi) { - dev_err(&dev->dev, "No memory for MSI structure\n"); + if (!msi) return -ENOMEM; - } + dev->dev.platform_data = msi; /* Get MSI ranges */ diff --git a/arch/powerpc/platforms/4xx/ocm.c b/arch/powerpc/platforms/4xx/ocm.c index 8cb601e8bed7..5a750d0ad446 100644 --- a/arch/powerpc/platforms/4xx/ocm.c +++ b/arch/powerpc/platforms/4xx/ocm.c @@ -337,7 +337,6 @@ void *ppc4xx_ocm_alloc(phys_addr_t *phys, int size, int align, ocm_blk = kzalloc(sizeof(struct ocm_block), GFP_KERNEL); if (!ocm_blk) { - printk(KERN_ERR "PPC4XX OCM: could not allocate ocm block"); rh_free(ocm_reg->rh, offset); break; } @@ -391,10 +390,8 @@ static int __init ppc4xx_ocm_init(void) return 0; ocm_nodes = kzalloc((count * sizeof(struct ocm_info)), GFP_KERNEL); - if (!ocm_nodes) { - printk(KERN_ERR "PPC4XX OCM: failed to allocate OCM nodes!\n"); + if (!ocm_nodes) return -ENOMEM; - } ocm_count = count; count = 0; From patchwork Thu Jan 11 18:03:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 859227 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zHYpP1j9Pz9s4s for ; Fri, 12 Jan 2018 05:10:53 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3zHYpP0X8CzF0Vj for ; Fri, 12 Jan 2018 05:10:53 +1100 (AEDT) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=users.sourceforge.net (client-ip=212.227.15.4; helo=mout.web.de; envelope-from=elfring@users.sourceforge.net; receiver=) Received: from mout.web.de (mout.web.de [212.227.15.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3zHYmZ36n7zDqhB for ; Fri, 12 Jan 2018 05:09:18 +1100 (AEDT) Received: from [192.168.1.3] ([92.227.255.105]) by smtp.web.de (mrweb002 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MUnuu-1eNeXm3qNo-00Y9jb; Thu, 11 Jan 2018 19:03:55 +0100 Subject: [PATCH 4/5] powerpc/4xx: Improve a size determination in two functions From: SF Markus Elfring To: linuxppc-dev@lists.ozlabs.org, Benjamin Herrenschmidt , Michael Ellerman , Paul Mackerras , Rob Herring , Tyrel Datwyler References: <2b9b4285-f1c0-5dc7-35c6-df901c9ca0eb@users.sourceforge.net> Message-ID: <8ac91d54-bd2b-42cb-f890-e3007489b758@users.sourceforge.net> Date: Thu, 11 Jan 2018 19:03:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <2b9b4285-f1c0-5dc7-35c6-df901c9ca0eb@users.sourceforge.net> Content-Language: en-GB X-Provags-ID: V03:K0:J06GW6e8QqapTFFgkB2OMVFIoniUItxvJKLjpQVFy4qmFQFzZCn 9mlrEcSxJMvHoc4M8K5uaYVhxxdmaaShbb8/iRGqR7NUwRa09FLvhfdo5kLHuPAhJh2wByC /t8fhvXArEeEi0VzOo+z1z/608eD/y6dbkSGQT3Hh4Vvcuen1s4l5v6AgR/G1svQwcgW1Rp 0xPrI2Lm4fI2nV6iI/Hjg== X-UI-Out-Filterresults: notjunk:1; V01:K0:mVzTKRjpiyQ=:kG6aUg1xP1fnM54gSjmo7h Aub3ii+sq1vJZQ+UIdeTTApp4kiavRIyg8hY3Anl1mPH7/g3ia4xXDinLWnl6z4jdvLrtMuNX hlHWebBiY+cUFFWksolN3JtmEJLtCJaW5lBnsxbvTU/5CXaJbc4cuvSybpoGDeYs8rZYCp0sZ tIHHK/Qt6C0MYrgBVnlk9RA5jaBrit7ZHbSNb7z62MErwG2IDqyVasI4UXnBw9srRiDR5gByg yr4vp5miCD83Iw8SAt3SjF6k+WRKq54R4SBCuphGDwSNKOpRwmufUnjeTRqi5NSEMu1sILx0O e0ZfGSv9Qvz4ibOKb+6e+Hchu0S3DjGN+y2CCGnEhcVWyo1z9GK2l86MbrUGJ18jyYvEpqMb/ TDoz/asBLgLfkdrA309suSsfExWs7z6Xv1a2bPfu7HHNzrIh/8XW7cisN1/X6xrOjvSnlNxXU 895wtVNX+t7slDnGDCg+YWDdDyM8mYlyNU/uwgE2VotdUXMNzYnZsODNKc3KQStPhMOb2xsxo fKs2S5u7DP/h5jYrHdikkueuhx2lmId6UapqbS22T0xow2aE5CzMJRrfLVKK4c6ghQZO7k+Ht Gz7isjkpUzwg3ERRgMJl6+AlSp2Z15xG7DxDHYdsErb8/saCV21hf7h0Q7wjkLJUGqTsG45r1 qSOMKFtJSd7rQYwdduuxTa8Iya9K0wzPaZi6lAGhYbxoi26JmytKd/0WKRBt7TYc1o9wMkwiT cFblTId9NQvXgR4y9vBREV2imdmZ/URM52x9K9esXKgTnRTveckdv5BP70vFWU2BAzA46C3Cy eF1HNv8jFWB1WPdQS6bMb1+DIUG3lam9yLTRZ9L7j6xJ9NJZJg= X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, LKML Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Markus Elfring Date: Thu, 11 Jan 2018 18:32:33 +0100 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- arch/powerpc/platforms/4xx/msi.c | 2 +- arch/powerpc/platforms/4xx/ocm.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/platforms/4xx/msi.c b/arch/powerpc/platforms/4xx/msi.c index d16b81303cb0..f693cab07752 100644 --- a/arch/powerpc/platforms/4xx/msi.c +++ b/arch/powerpc/platforms/4xx/msi.c @@ -223,7 +223,7 @@ static int ppc4xx_msi_probe(struct platform_device *dev) dev_dbg(&dev->dev, "PCIE-MSI: Setting up MSI support...\n"); - msi = kzalloc(sizeof(struct ppc4xx_msi), GFP_KERNEL); + msi = kzalloc(sizeof(*msi), GFP_KERNEL); if (!msi) return -ENOMEM; diff --git a/arch/powerpc/platforms/4xx/ocm.c b/arch/powerpc/platforms/4xx/ocm.c index 5a750d0ad446..11418f090bf4 100644 --- a/arch/powerpc/platforms/4xx/ocm.c +++ b/arch/powerpc/platforms/4xx/ocm.c @@ -335,7 +335,7 @@ void *ppc4xx_ocm_alloc(phys_addr_t *phys, int size, int align, if (IS_ERR_VALUE(offset)) continue; - ocm_blk = kzalloc(sizeof(struct ocm_block), GFP_KERNEL); + ocm_blk = kzalloc(sizeof(*ocm_blk), GFP_KERNEL); if (!ocm_blk) { rh_free(ocm_reg->rh, offset); break; From patchwork Thu Jan 11 18:04:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 859226 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zHYlP4Fxcz9ryQ for ; Fri, 12 Jan 2018 05:08:17 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3zHYlP2zF3zF0Xb for ; Fri, 12 Jan 2018 05:08:17 +1100 (AEDT) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=users.sourceforge.net (client-ip=212.227.15.14; helo=mout.web.de; envelope-from=elfring@users.sourceforge.net; receiver=) Received: from mout.web.de (mout.web.de [212.227.15.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3zHYgx5t2SzF0VJ for ; Fri, 12 Jan 2018 05:05:16 +1100 (AEDT) Received: from [192.168.1.3] ([92.227.255.105]) by smtp.web.de (mrweb004 [213.165.67.108]) with ESMTPSA (Nemesis) id 0Lh90R-1fBCuO46Rr-00oSme; Thu, 11 Jan 2018 19:04:56 +0100 Subject: [PATCH 5/5] powerpc/4xx: Delete an unnecessary return statement in two functions From: SF Markus Elfring To: linuxppc-dev@lists.ozlabs.org, Benjamin Herrenschmidt , Michael Ellerman , Paul Mackerras , Rob Herring , Tyrel Datwyler References: <2b9b4285-f1c0-5dc7-35c6-df901c9ca0eb@users.sourceforge.net> Message-ID: Date: Thu, 11 Jan 2018 19:04:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <2b9b4285-f1c0-5dc7-35c6-df901c9ca0eb@users.sourceforge.net> Content-Language: en-GB X-Provags-ID: V03:K0:lNXJ74kw1BkEjTiXE965Bfkd+cDHLuS+q7cNdcRYs4gDtFzwk86 ORmyOAYpB5A4hstLX06Ai4LJ/VWW0uQODI7ctBIq2buanVYd+uviG11fcIjCXKIIkgfrzN4 +UzQBmlQ6UcjVsvs3sdjUinBJtkfiAdV2TNvbsDjev+bfkqsqdFD6QAI0oc0l4JTpKGIDGy +PvHvR6sz3phbmIw0IFSQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:IZ60/4G6OCI=:63BmRDMHMNtjor9NUIt6pR GDN1TSZJkS7bGNf9dKk3LVmP4uPSVaib/Zp7adUwXIm+p+AaXCwBq3Q0O9kV7FuuEpgv0G7It zAajZLOUL1Om6Hb7n2MxdpAHQG/uCFnRQrB0XN4xO95iGqzH66xswfndP6YgeLJuHsTSRWB93 /M8YjJl3O+JyitjI7VWHiuTUkncKslTLH20o5wIcmlES5flnDiUadDD7XyJ2BzTizp/xAncHx JraF6QOoTpnGTAK7k3JSuEKDu+LFCKAVzVqfNkkeTOdA5Rzd6ENF+5aviz1jiAFE92KngsMeO a+7AZQ5NnlU5F56uqjDXMbAyPSjnOrh71lTXq1LqHqtEHxuF5OOPywJmjO0bF3gkZj4A2OKFL pmBHDcWsszvMsFAjd9YU9VBUnvi26KgcIYX8mkYUGK3++/15Dv0hyvRnPynWJ7luHdZvX9DNs ZB5RQyiM1eAgon/a/NW0cMYAG4ZZZhHmny7rZfCGrQM/rVXcclk9SgVUJg7GEGqH2WwKKxHDN zD8HMDO/7XL2KXGmVi2hjN5ae9zgkdWK8LB58AcClHB/nVDogS1uDxKfGd2/7fDB/E77+PsuO 82sarO0PzfWoUOQU0IF35MRPSii+zoJwG6BHdm6pR2PMTVz6Yk3pvX9djVuLinhZKb+L/1EcN rsx/Zso2IWWHfr2RQhIpPXE8y62MHJr4ueGmg1IpWVIygOGRdNEuSEU7187pvmdlMjLWRFbqz rDOhCiOq7HktNNc06dM0DW+bcO0lXnKYLmhK9OPtjaYTW/YLY31TQLW8tQFfLaHuxnLJj9JA8 9u3Uj6NEKlLTyXCiIi31iAtHTtuoRbuxJigW299EiWlbdEsiIE= X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, LKML Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Markus Elfring Date: Thu, 11 Jan 2018 18:40:23 +0100 The script "checkpatch.pl" pointed information out like the following. WARNING: void function return statements are not generally useful Thus remove such a statement in the affected functions. Signed-off-by: Markus Elfring --- arch/powerpc/platforms/4xx/ocm.c | 2 -- arch/powerpc/platforms/4xx/pci.c | 1 - 2 files changed, 3 deletions(-) diff --git a/arch/powerpc/platforms/4xx/ocm.c b/arch/powerpc/platforms/4xx/ocm.c index 11418f090bf4..aee5f041ff14 100644 --- a/arch/powerpc/platforms/4xx/ocm.c +++ b/arch/powerpc/platforms/4xx/ocm.c @@ -226,8 +226,6 @@ static void __init ocm_init_node(int count, struct device_node *node) INIT_LIST_HEAD(&ocm->c.list); ocm->ready = 1; - - return; } static int ocm_debugfs_show(struct seq_file *m, void *v) diff --git a/arch/powerpc/platforms/4xx/pci.c b/arch/powerpc/platforms/4xx/pci.c index 73e6b36bcd51..b73ea8f4be1f 100644 --- a/arch/powerpc/platforms/4xx/pci.c +++ b/arch/powerpc/platforms/4xx/pci.c @@ -1399,7 +1399,6 @@ static void __init ppc_476fpe_pciex_check_link(struct ppc4xx_pciex_port *port) printk(KERN_WARNING "PCIE%d: Link up failed\n", port->index); iounmap(mbase); - return; } static struct ppc4xx_pciex_hwops ppc_476fpe_pcie_hwops __initdata =